[Buildroot] [PATCH] package/trinity: New package

[Buildroot] [PATCH] package/trinity: New package

[Vicente Olivert Riera]

Adding the Trinity Linux System call fuzz tester.

Signed-off-by: Vicente Olivert Riera <Vincent.Riera@imgtec.com>
---
 package/Config.in          |    1 +
 package/trinity/Config.in  |    6 ++++++
 package/trinity/trinity.mk |   31 +++++++++++++++++++++++++++++++
 3 files changed, 38 insertions(+), 0 deletions(-)
 create mode 100644 package/trinity/Config.in
 create mode 100644 package/trinity/trinity.mk

diff --git a/package/Config.in b/package/Config.in
index 1021d4c..45ff5f6 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -88,6 +88,7 @@ endif
 	source "package/sysprof/Config.in"
 	source "package/tinymembench/Config.in"
 	source "package/trace-cmd/Config.in"
+	source "package/trinity/Config.in"
 	source "package/valgrind/Config.in"
 	source "package/whetstone/Config.in"
 endmenu
diff --git a/package/trinity/Config.in b/package/trinity/Config.in
new file mode 100644
index 0000000..de9c467
--- /dev/null
+++ b/package/trinity/Config.in
@@ -0,0 +1,6 @@
+config BR2_PACKAGE_TRINITY
+	bool "trinity"
+	help
+	  A Linux System call fuzz tester
+
+	  http://codemonkey.org.uk/projects/trinity/
diff --git a/package/trinity/trinity.mk b/package/trinity/trinity.mk
new file mode 100644
index 0000000..1e6c54a
--- /dev/null
+++ b/package/trinity/trinity.mk
@@ -0,0 +1,31 @@
+################################################################################
+#
+# trinity
+#
+################################################################################
+
+TRINITY_VERSION = c02034ec08d951cde3429905e64afe450cbc47db
+TRINITY_SITE = $(call github,kernelslacker,trinity,$(TRINITY_VERSION))
+TRINITY_LICENSE = GPLv2
+TRINITY_LICENSE_FILES = COPYING
+
+define TRINITY_CONFIGURE_CMDS
+	(cd $(@D); $(TARGET_CONFIGURE_OPTS) ./configure.sh)
+endef
+
+define TRINITY_BUILD_CMDS
+	$(TARGET_CONFIGURE_OPTS) $(MAKE) -C $(@D)
+endef
+
+define TRINITY_INSTALL_TARGET_CMDS
+	$(TARGET_CONFIGURE_OPTS) $(MAKE) -C $(@D) DESTDIR=$(TARGET_DIR)/usr install
+endef
+
+# Install helper scripts
+define TRINITY_INSTALL_HELPER_SCRIPTS
+	mkdir -p $(TARGET_DIR)/usr/libexec/trinity
+	cp -p $(@D)/scripts/* $(TARGET_DIR)/usr/libexec/trinity/
+endef
+TRINITY_POST_INSTALL_TARGET_HOOKS += TRINITY_INSTALL_HELPER_SCRIPTS
+
+$(eval $(generic-package))
-- 
1.7.1

[Buildroot] [PATCH] package/trinity: New package

[Peter Korsgaard]

>>>>> "Vicente" == Vicente Olivert Riera <Vincent.Riera@imgtec.com> writes:

 > Adding the Trinity Linux System call fuzz tester.
 > Signed-off-by: Vicente Olivert Riera <Vincent.Riera@imgtec.com>

Thanks, but a quick test build with uClibc fails:

make[1]: Entering directory '/home/peko/source/buildroot/output/build/trinity-c02034ec08d951cde3429905e64afe450cbc47db'
  CC    arg-decoder.o
  CC    blockdevs.o
  CC    child.o
  CC    debug.o
  CC    devices.o
debug.c:5:22: fatal error: execinfo.h: No such file or directory
compilation terminated.
Makefile:96: recipe for target 'debug.o' failed
make[1]: *** [debug.o] Error 1
make[1]: *** Waiting for unfinished jobs....
make[1]: Leaving directory '/home/peko/source/buildroot/output/build/trinity-c02034ec08d951cde3429905e64afe450cbc47db'

execinfo.h is only available if uClibc is built with
UCLIBC_HAS_BACKTRACE=y (which it isn't by default).

Perhaps the backtrace() stuff can get #ifdef'ed out if not available?

-- 
Bye, Peter Korsgaard

[Buildroot] [PATCH] package/trinity: New package

[Vicente Olivert Riera]

Dear Peter Korsgaard,

On 10/07/2014 11:11 PM, Peter Korsgaard wrote:
>>>>>> "Vicente" == Vicente Olivert Riera <Vincent.Riera@imgtec.com> writes:
>
>   > Adding the Trinity Linux System call fuzz tester.
>   > Signed-off-by: Vicente Olivert Riera <Vincent.Riera@imgtec.com>
>
> Thanks, but a quick test build with uClibc fails:
>
> make[1]: Entering directory '/home/peko/source/buildroot/output/build/trinity-c02034ec08d951cde3429905e64afe450cbc47db'
>    CC    arg-decoder.o
>    CC    blockdevs.o
>    CC    child.o
>    CC    debug.o
>    CC    devices.o
> debug.c:5:22: fatal error: execinfo.h: No such file or directory
> compilation terminated.
> Makefile:96: recipe for target 'debug.o' failed
> make[1]: *** [debug.o] Error 1
> make[1]: *** Waiting for unfinished jobs....
> make[1]: Leaving directory '/home/peko/source/buildroot/output/build/trinity-c02034ec08d951cde3429905e64afe450cbc47db'
>
> execinfo.h is only available if uClibc is built with
> UCLIBC_HAS_BACKTRACE=y (which it isn't by default).
>
> Perhaps the backtrace() stuff can get #ifdef'ed out if not available?

It looks like a change to be made upstream. Maybe it needs to include a 
header check in the configure.sh script, then defining a macro if the 
header is present, and then modify the source code to take that macro 
into account to do things like "#ifdef USE_EXECINFO"...

So, what do you propose by now for the Buildroot package? Disabling it 
for uClibc until upstream fixes that?

-- 
Vincent

[Buildroot] [PATCH] package/trinity: New package

[Peter Korsgaard]

>>>>> "Vicente" == Vicente Olivert Riera <Vincent.Riera@imgtec.com> writes:

Hi,

 >> execinfo.h is only available if uClibc is built with
 >> UCLIBC_HAS_BACKTRACE=y (which it isn't by default).
 >> 
 >> Perhaps the backtrace() stuff can get #ifdef'ed out if not available?

 > It looks like a change to be made upstream. Maybe it needs to include
 > a header check in the configure.sh script, then defining a macro if
 > the header is present, and then modify the source code to take that
 > macro into account to do things like "#ifdef USE_EXECINFO"...

 > So, what do you propose by now for the Buildroot package? Disabling it
 > for uClibc until upstream fixes that?

Either that or submit a patch upstream.

-- 
Bye, Peter Korsgaard

[Buildroot] [PATCH] package/trinity: New package

[Vicente Olivert Riera]

Dear Peter Korsgaard,

On 10/08/2014 10:58 AM, Peter Korsgaard wrote:
>>>>>> "Vicente" == Vicente Olivert Riera <Vincent.Riera@imgtec.com> writes:
>
> Hi,
>
>   >> execinfo.h is only available if uClibc is built with
>   >> UCLIBC_HAS_BACKTRACE=y (which it isn't by default).
>   >>
>   >> Perhaps the backtrace() stuff can get #ifdef'ed out if not available?
>
>   > It looks like a change to be made upstream. Maybe it needs to include
>   > a header check in the configure.sh script, then defining a macro if
>   > the header is present, and then modify the source code to take that
>   > macro into account to do things like "#ifdef USE_EXECINFO"...
>
>   > So, what do you propose by now for the Buildroot package? Disabling it
>   > for uClibc until upstream fixes that?
>
> Either that or submit a patch upstream.

Let's disable it by now. I don't have enough understanding of the inners 
of that package to be able to do that patch right now, so I will just 
send an email upstream requesting that fix.

I will send the new patch in a while.

Thanks.

-- 
Vincent