Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH 1/1] package/upmpdcli: fix missing dependency of libcurl
@ 2014-10-12 18:55 Jörg Krause
  2014-10-12 19:37 ` Thomas Petazzoni
  0 siblings, 1 reply; 4+ messages in thread
From: Jörg Krause @ 2014-10-12 18:55 UTC (permalink / raw)
  To: buildroot

Signed-off-by: J?rg Krause <jkrause@posteo.de>
---
 package/upmpdcli/Config.in   | 1 +
 package/upmpdcli/upmpdcli.mk | 2 +-
 2 files changed, 2 insertions(+), 1 deletion(-)

diff --git a/package/upmpdcli/Config.in b/package/upmpdcli/Config.in
index dbbc9b5..f28c775 100644
--- a/package/upmpdcli/Config.in
+++ b/package/upmpdcli/Config.in
@@ -1,6 +1,7 @@
 config BR2_PACKAGE_UPMPDCLI
 	bool "upmpdcli"
 	select BR2_PACKAGE_EXPAT
+	select BR2_PACKAGE_LIBCURL
 	select BR2_PACKAGE_LIBUPNP
 	select BR2_PACKAGE_LIBMPDCLIENT
 	depends on BR2_INSTALL_LIBSTDCPP
diff --git a/package/upmpdcli/upmpdcli.mk b/package/upmpdcli/upmpdcli.mk
index 88a5a16..547752a 100644
--- a/package/upmpdcli/upmpdcli.mk
+++ b/package/upmpdcli/upmpdcli.mk
@@ -8,7 +8,7 @@ UPMPDCLI_VERSION = 0.8.3
 UPMPDCLI_SITE = http://www.lesbonscomptes.com/upmpdcli/downloads
 UPMPDCLI_LICENSE = GPLv2+
 UPMPDCLI_LICENSE_FILES = COPYING
-UPMPDCLI_DEPENDENCIES = expat libupnp libmpdclient
+UPMPDCLI_DEPENDENCIES = expat libcurl libupnp libmpdclient
 
 # Upmpdcli only runs if user upmpdcli exists
 define UPMPDCLI_USERS
-- 
2.1.2

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [Buildroot] [PATCH 1/1] package/upmpdcli: fix missing dependency of libcurl
  2014-10-12 18:55 [Buildroot] [PATCH 1/1] package/upmpdcli: fix missing dependency of libcurl Jörg Krause
@ 2014-10-12 19:37 ` Thomas Petazzoni
  2014-10-13  7:30   ` Jörg Krause
  0 siblings, 1 reply; 4+ messages in thread
From: Thomas Petazzoni @ 2014-10-12 19:37 UTC (permalink / raw)
  To: buildroot

Dear J?rg Krause,

If this is fixing an autobuilder issues, please include the autobuilder
result URL in the commit log.

Thanks,

Thomas

On Sun, 12 Oct 2014 20:55:10 +0200, J?rg Krause wrote:
> Signed-off-by: J?rg Krause <jkrause@posteo.de>
> ---
>  package/upmpdcli/Config.in   | 1 +
>  package/upmpdcli/upmpdcli.mk | 2 +-
>  2 files changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/package/upmpdcli/Config.in b/package/upmpdcli/Config.in
> index dbbc9b5..f28c775 100644
> --- a/package/upmpdcli/Config.in
> +++ b/package/upmpdcli/Config.in
> @@ -1,6 +1,7 @@
>  config BR2_PACKAGE_UPMPDCLI
>  	bool "upmpdcli"
>  	select BR2_PACKAGE_EXPAT
> +	select BR2_PACKAGE_LIBCURL
>  	select BR2_PACKAGE_LIBUPNP
>  	select BR2_PACKAGE_LIBMPDCLIENT
>  	depends on BR2_INSTALL_LIBSTDCPP
> diff --git a/package/upmpdcli/upmpdcli.mk b/package/upmpdcli/upmpdcli.mk
> index 88a5a16..547752a 100644
> --- a/package/upmpdcli/upmpdcli.mk
> +++ b/package/upmpdcli/upmpdcli.mk
> @@ -8,7 +8,7 @@ UPMPDCLI_VERSION = 0.8.3
>  UPMPDCLI_SITE = http://www.lesbonscomptes.com/upmpdcli/downloads
>  UPMPDCLI_LICENSE = GPLv2+
>  UPMPDCLI_LICENSE_FILES = COPYING
> -UPMPDCLI_DEPENDENCIES = expat libupnp libmpdclient
> +UPMPDCLI_DEPENDENCIES = expat libcurl libupnp libmpdclient
>  
>  # Upmpdcli only runs if user upmpdcli exists
>  define UPMPDCLI_USERS



-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [Buildroot] [PATCH 1/1] package/upmpdcli: fix missing dependency of libcurl
  2014-10-12 19:37 ` Thomas Petazzoni
@ 2014-10-13  7:30   ` Jörg Krause
  2014-10-14  7:53     ` Peter Korsgaard
  0 siblings, 1 reply; 4+ messages in thread
From: Jörg Krause @ 2014-10-13  7:30 UTC (permalink / raw)
  To: buildroot

Dear Thomas Petazzoni,

On 10/12/2014 09:37 PM, Thomas Petazzoni wrote:
> Dear J?rg Krause,
>
> If this is fixing an autobuilder issues, please include the autobuilder
> result URL in the commit log.

Sorry, I forgot. Patch is already committed now. Should I leave it as it 
is or?
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20141013/9dd470fd/attachment.html>

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [Buildroot] [PATCH 1/1] package/upmpdcli: fix missing dependency of libcurl
  2014-10-13  7:30   ` Jörg Krause
@ 2014-10-14  7:53     ` Peter Korsgaard
  0 siblings, 0 replies; 4+ messages in thread
From: Peter Korsgaard @ 2014-10-14  7:53 UTC (permalink / raw)
  To: buildroot

>>>>> "J?rg" == J?rg Krause <jkrause@posteo.de> writes:

 > Dear Thomas Petazzoni,
 > On 10/12/2014 09:37 PM, Thomas Petazzoni wrote:

 >     Dear J?rg Krause,

 >     If this is fixing an autobuilder issues, please include the autobuilder
 >     result URL in the commit log.


 > Sorry, I forgot. Patch is already committed now. Should I leave it as it is or?

Yes, now it is too late (I forgot and didn't notice Thomas' mail). Just
something to keep in mind for future patches.

-- 
Bye, Peter Korsgaard

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2014-10-14  7:53 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-10-12 18:55 [Buildroot] [PATCH 1/1] package/upmpdcli: fix missing dependency of libcurl Jörg Krause
2014-10-12 19:37 ` Thomas Petazzoni
2014-10-13  7:30   ` Jörg Krause
2014-10-14  7:53     ` Peter Korsgaard

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox