* [Buildroot] [PATCH v2] cppunit: Added package @ 2014-10-14 20:09 Sebastien Bourdelin 2014-10-15 15:27 ` Arnout Vandecappelle 0 siblings, 1 reply; 3+ messages in thread From: Sebastien Bourdelin @ 2014-10-14 20:09 UTC (permalink / raw) To: buildroot CppUnit is the C++ port of the famous JUnit framework for unit testing. Test output is in XML or text format for automatic testing and GUI based for supervised tests. http://www.freedesktop.org/wiki/Software/cppunit/ Signed-off-by: Sebastien Bourdelin <sebastien.bourdelin@savoirfairelinux.com> --- Changes v1 -> v2: - used AUTORECONF option (suggested by romain.naour at openwide.fr) - removed useless CONFIGURE_CMDS (suggested by romain.naour at openwide.fr) --- package/Config.in | 1 + package/cppunit/Config.in | 12 ++++++++++++ package/cppunit/cppunit.mk | 14 ++++++++++++++ 3 files changed, 27 insertions(+) create mode 100644 package/cppunit/Config.in create mode 100644 package/cppunit/cppunit.mk diff --git a/package/Config.in b/package/Config.in index 19bb9bf..407f24f 100644 --- a/package/Config.in +++ b/package/Config.in @@ -838,6 +838,7 @@ menu "Other" source "package/clapack/Config.in" source "package/classpath/Config.in" source "package/cppcms/Config.in" + source "package/cppunit/Config.in" source "package/eigen/Config.in" source "package/elfutils/Config.in" source "package/fftw/Config.in" diff --git a/package/cppunit/Config.in b/package/cppunit/Config.in new file mode 100644 index 0000000..91700b8 --- /dev/null +++ b/package/cppunit/Config.in @@ -0,0 +1,12 @@ +config BR2_PACKAGE_CPPUNIT + bool "cppunit" + depends on BR2_INSTALL_LIBSTDCPP + help + CppUnit is the C++ port of the famous JUnit framework for unit testing. + Test output is in XML or text format for automatic testing and GUI + based for supervised tests. + + http://www.freedesktop.org/wiki/Software/cppunit/ + +comment "cppunit needs a toolchain w/ C++" + depends on !BR2_INSTALL_LIBSTDCPP diff --git a/package/cppunit/cppunit.mk b/package/cppunit/cppunit.mk new file mode 100644 index 0000000..4447537 --- /dev/null +++ b/package/cppunit/cppunit.mk @@ -0,0 +1,14 @@ +################################################################################ +# +# cppunit +# +################################################################################ + +CPPUNIT_VERSION = cppunit-1.13.2 +CPPUNIT_SITE = git://anongit.freedesktop.org/git/libreoffice/cppunit/ +CPPUNIT_INSTALL_STAGING = YES +CPPUNIT_LICENSE = GPLv2 +CPPUNIT_LICENSE_FILES = COPYING +CPPUNIT_AUTORECONF = YES + +$(eval $(autotools-package)) -- 1.8.3.4 ^ permalink raw reply related [flat|nested] 3+ messages in thread
* [Buildroot] [PATCH v2] cppunit: Added package 2014-10-14 20:09 [Buildroot] [PATCH v2] cppunit: Added package Sebastien Bourdelin @ 2014-10-15 15:27 ` Arnout Vandecappelle 2014-10-15 20:14 ` Sebastien Bourdelin 0 siblings, 1 reply; 3+ messages in thread From: Arnout Vandecappelle @ 2014-10-15 15:27 UTC (permalink / raw) To: buildroot Hi Sebastien, Thank you for your contribution. I still have a few more comments. On 14/10/14 22:09, Sebastien Bourdelin wrote: > CppUnit is the C++ port of the famous JUnit framework for unit testing. > Test output is in XML or text format for automatic testing and GUI > based for supervised tests. > > http://www.freedesktop.org/wiki/Software/cppunit/ > Signed-off-by: Sebastien Bourdelin <sebastien.bourdelin@savoirfairelinux.com> We normally leave an empty line between the commit message itself and the SOB. > --- > Changes v1 -> v2: > - used AUTORECONF option (suggested by romain.naour at openwide.fr) > - removed useless CONFIGURE_CMDS (suggested by romain.naour at openwide.fr) > --- > package/Config.in | 1 + > package/cppunit/Config.in | 12 ++++++++++++ > package/cppunit/cppunit.mk | 14 ++++++++++++++ > 3 files changed, 27 insertions(+) > create mode 100644 package/cppunit/Config.in > create mode 100644 package/cppunit/cppunit.mk > > diff --git a/package/Config.in b/package/Config.in > index 19bb9bf..407f24f 100644 > --- a/package/Config.in > +++ b/package/Config.in > @@ -838,6 +838,7 @@ menu "Other" > source "package/clapack/Config.in" > source "package/classpath/Config.in" > source "package/cppcms/Config.in" > + source "package/cppunit/Config.in" > source "package/eigen/Config.in" > source "package/elfutils/Config.in" > source "package/fftw/Config.in" > diff --git a/package/cppunit/Config.in b/package/cppunit/Config.in > new file mode 100644 > index 0000000..91700b8 > --- /dev/null > +++ b/package/cppunit/Config.in > @@ -0,0 +1,12 @@ > +config BR2_PACKAGE_CPPUNIT > + bool "cppunit" > + depends on BR2_INSTALL_LIBSTDCPP > + help > + CppUnit is the C++ port of the famous JUnit framework for unit testing. > + Test output is in XML or text format for automatic testing and GUI > + based for supervised tests. > + > + http://www.freedesktop.org/wiki/Software/cppunit/ > + > +comment "cppunit needs a toolchain w/ C++" > + depends on !BR2_INSTALL_LIBSTDCPP > diff --git a/package/cppunit/cppunit.mk b/package/cppunit/cppunit.mk > new file mode 100644 > index 0000000..4447537 > --- /dev/null > +++ b/package/cppunit/cppunit.mk > @@ -0,0 +1,14 @@ > +################################################################################ > +# > +# cppunit > +# > +################################################################################ > + > +CPPUNIT_VERSION = cppunit-1.13.2 > +CPPUNIT_SITE = git://anongit.freedesktop.org/git/libreoffice/cppunit/ We prefer to use the release tarball: CPPUNIT_VERSION = 1.13.2 CPPUNIT_SITE = http://dev-www.libreoffice.org/src If that doesn't work for some reason, please add a comment why not. Also, it would be nice if you could add a hash file with the upstream md5 and with a locally calculated sha256 or sha512. The hash file is optional, but if upstream provides an md5 it's nice to have it. > +CPPUNIT_INSTALL_STAGING = YES I'm writing this mail while offline so I can't check myself, but IIRC cppunit only installs a static library (.a). Therefore, there is nothing to install in the target directory so you could add # Static library only CPPUNIT_INSTALL_TARGET = NO Note that this is completely optional, though, because we anyway remove all .a files in the finalize step. > +CPPUNIT_LICENSE = GPLv2 Is it really v2 only and not v2+? To check that, look at the source files, in the header they usually have something like "blah blah version 2 (or later)". > +CPPUNIT_LICENSE_FILES = COPYING > +CPPUNIT_AUTORECONF = YES With the release tarball, you probably don't need that. Regards, Arnout > + > +$(eval $(autotools-package)) > -- Arnout Vandecappelle arnout at mind be Senior Embedded Software Architect +32-16-286500 Essensium/Mind http://www.mind.be G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle GPG fingerprint: 7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F ^ permalink raw reply [flat|nested] 3+ messages in thread
* [Buildroot] [PATCH v2] cppunit: Added package 2014-10-15 15:27 ` Arnout Vandecappelle @ 2014-10-15 20:14 ` Sebastien Bourdelin 0 siblings, 0 replies; 3+ messages in thread From: Sebastien Bourdelin @ 2014-10-15 20:14 UTC (permalink / raw) To: buildroot Hi Arnout, Thank you for your review. On 10/15/2014 11:27 AM, Arnout Vandecappelle wrote: > Hi Sebastien, > > Thank you for your contribution. I still have a few more comments. > > On 14/10/14 22:09, Sebastien Bourdelin wrote: >> CppUnit is the C++ port of the famous JUnit framework for unit testing. >> Test output is in XML or text format for automatic testing and GUI >> based for supervised tests. >> >> http://www.freedesktop.org/wiki/Software/cppunit/ >> Signed-off-by: Sebastien Bourdelin <sebastien.bourdelin@savoirfairelinux.com> > We normally leave an empty line between the commit message itself and the SOB. My bad. > >> --- >> Changes v1 -> v2: >> - used AUTORECONF option (suggested by romain.naour at openwide.fr) >> - removed useless CONFIGURE_CMDS (suggested by romain.naour at openwide.fr) >> --- >> package/Config.in | 1 + >> package/cppunit/Config.in | 12 ++++++++++++ >> package/cppunit/cppunit.mk | 14 ++++++++++++++ >> 3 files changed, 27 insertions(+) >> create mode 100644 package/cppunit/Config.in >> create mode 100644 package/cppunit/cppunit.mk >> >> diff --git a/package/Config.in b/package/Config.in >> index 19bb9bf..407f24f 100644 >> --- a/package/Config.in >> +++ b/package/Config.in >> @@ -838,6 +838,7 @@ menu "Other" >> source "package/clapack/Config.in" >> source "package/classpath/Config.in" >> source "package/cppcms/Config.in" >> + source "package/cppunit/Config.in" >> source "package/eigen/Config.in" >> source "package/elfutils/Config.in" >> source "package/fftw/Config.in" >> diff --git a/package/cppunit/Config.in b/package/cppunit/Config.in >> new file mode 100644 >> index 0000000..91700b8 >> --- /dev/null >> +++ b/package/cppunit/Config.in >> @@ -0,0 +1,12 @@ >> +config BR2_PACKAGE_CPPUNIT >> + bool "cppunit" >> + depends on BR2_INSTALL_LIBSTDCPP >> + help >> + CppUnit is the C++ port of the famous JUnit framework for unit testing. >> + Test output is in XML or text format for automatic testing and GUI >> + based for supervised tests. >> + >> + http://www.freedesktop.org/wiki/Software/cppunit/ >> + >> +comment "cppunit needs a toolchain w/ C++" >> + depends on !BR2_INSTALL_LIBSTDCPP >> diff --git a/package/cppunit/cppunit.mk b/package/cppunit/cppunit.mk >> new file mode 100644 >> index 0000000..4447537 >> --- /dev/null >> +++ b/package/cppunit/cppunit.mk >> @@ -0,0 +1,14 @@ >> +################################################################################ >> +# >> +# cppunit >> +# >> +################################################################################ >> + >> +CPPUNIT_VERSION = cppunit-1.13.2 >> +CPPUNIT_SITE = git://anongit.freedesktop.org/git/libreoffice/cppunit/ > We prefer to use the release tarball: > > CPPUNIT_VERSION = 1.13.2 > CPPUNIT_SITE = http://dev-www.libreoffice.org/src > > If that doesn't work for some reason, please add a comment why not. > > Also, it would be nice if you could add a hash file with the upstream md5 and > with a locally calculated sha256 or sha512. The hash file is optional, but if > upstream provides an md5 it's nice to have it. Ok, i will do that. > >> +CPPUNIT_INSTALL_STAGING = YES > I'm writing this mail while offline so I can't check myself, but IIRC cppunit > only installs a static library (.a). Therefore, there is nothing to install in > the target directory so you could add > > # Static library only > CPPUNIT_INSTALL_TARGET = NO > > Note that this is completely optional, though, because we anyway remove all .a > files in the finalize step. cppunit also install shared library (.so) > >> +CPPUNIT_LICENSE = GPLv2 > Is it really v2 only and not v2+? To check that, look at the source files, in > the header they usually have something like "blah blah version 2 (or later)". You are right, the correct licence is LGPLv2.1+ >> +CPPUNIT_LICENSE_FILES = COPYING >> +CPPUNIT_AUTORECONF = YES > With the release tarball, you probably don't need that. Right. > > Regards, > Arnout > Thanks Arnout, i will send a v3. Regards. Sebastien Bourdelin. >> + >> +$(eval $(autotools-package)) >> > ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-10-15 20:14 UTC | newest] Thread overview: 3+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2014-10-14 20:09 [Buildroot] [PATCH v2] cppunit: Added package Sebastien Bourdelin 2014-10-15 15:27 ` Arnout Vandecappelle 2014-10-15 20:14 ` Sebastien Bourdelin
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox