From: Arnout Vandecappelle <arnout@mind.be>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v2] libevent: Use github call & fix patch
Date: Sun, 19 Oct 2014 22:43:28 +0200 [thread overview]
Message-ID: <54442270.6020109@mind.be> (raw)
In-Reply-To: <20141019085013.GD4072@free.fr>
On 19/10/14 10:50, Yann E. MORIN wrote:
> Maxime, All,
>
> On 2014-10-12 19:32 +0200, Maxime Hadjinlian spake thusly:
[snip]
>> LIBEVENT_VERSION = 2.0.21
>> -LIBEVENT_SOURCE = libevent-$(LIBEVENT_VERSION)-stable.tar.gz
>> -LIBEVENT_SITE = https://github.com/downloads/libevent/libevent
>> +LIBEVENT_SITE = $(call github,libevent,libevent,release-$(LIBEVENT_VERSION)-stable)
>
> This should be:
>
> LIBEVENT_VERSION = release-2.0.21-stable
> LIBEVENT_SITE = $(call github,libevent,libevent,$(LIBEVENT_VERSION))
>
> I think we already talked about this in the past few days (for another
> such change), where we said that the version should be the tag used by
> upstream.
Perhaps we should remove the third argument of the github helper and instead
use $($(PKG)_VERSION) instead, to avoid this kind of confusion...
Regards,
Arnout
--
Arnout Vandecappelle arnout at mind be
Senior Embedded Software Architect +32-16-286500
Essensium/Mind http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint: 7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F
next prev parent reply other threads:[~2014-10-19 20:43 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-12 17:32 [Buildroot] [PATCH v2] libevent: Use github call & fix patch Maxime Hadjinlian
2014-10-19 8:50 ` Yann E. MORIN
2014-10-19 20:43 ` Arnout Vandecappelle [this message]
2014-10-19 20:47 ` Maxime Hadjinlian
2014-10-19 20:48 ` Arnout Vandecappelle
2014-10-19 20:49 ` Maxime Hadjinlian
2014-10-19 20:53 ` Arnout Vandecappelle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54442270.6020109@mind.be \
--to=arnout@mind.be \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox