From: Arnout Vandecappelle <arnout@mind.be>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v2] libevent: Use github call & fix patch
Date: Sun, 19 Oct 2014 22:48:01 +0200 [thread overview]
Message-ID: <54442381.3070502@mind.be> (raw)
In-Reply-To: <1413135162-16654-1-git-send-email-maxime.hadjinlian@gmail.com>
On 12/10/14 19:32, Maxime Hadjinlian wrote:
> We want to uses the github helper since we download a generated tarball
> from the tag anyway.
>
> We also need to uses AUTORECONF as theses releases don't contains
> 'configure' and such.
>
> The patchs that was already present is updated to apply against
> Makefile.am instead of Makefile.in
>
> The seconds patchs is backported from upstream to remove the usage of
> $(top_src_dirs) which makes current autotools error.
>
> Signed-off-by: Maxime Hadjinlian <maxime.hadjinlian@gmail.com>
> ---
> v1 -> v2:
> - Fix the added patches so they have correct SoB (Thomas Petazzoni)
> - Add SoB (Thomas Petazzoni)
> - Add comment for autoreconf (Yann E. Morin)
[snip]
> LIBEVENT_VERSION = 2.0.21
> -LIBEVENT_SOURCE = libevent-$(LIBEVENT_VERSION)-stable.tar.gz
> -LIBEVENT_SITE = https://github.com/downloads/libevent/libevent
> +LIBEVENT_SITE = $(call github,libevent,libevent,release-$(LIBEVENT_VERSION)-stable)
Like the addition to the manual that you created a few days ago points out:
this is wrong, because you're replacing a release tarball with a git tag...
> LIBEVENT_INSTALL_STAGING = YES
> LIBEVENT_LICENSE = BSD-3c, OpenBSD
> LIBEVENT_LICENSE_FILES = LICENSE
> +# Straight from the repository, need to generate autotools files
> +LIBEVENT_AUTORECONF = YES
... which would also make this redundant. And probably the patch changes as
well. So perhaps this one should be rejected.
Regards,
Arnout
>
> define LIBEVENT_REMOVE_PYSCRIPT
> rm $(TARGET_DIR)/usr/bin/event_rpcgen.py
>
--
Arnout Vandecappelle arnout at mind be
Senior Embedded Software Architect +32-16-286500
Essensium/Mind http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint: 7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F
next prev parent reply other threads:[~2014-10-19 20:48 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-12 17:32 [Buildroot] [PATCH v2] libevent: Use github call & fix patch Maxime Hadjinlian
2014-10-19 8:50 ` Yann E. MORIN
2014-10-19 20:43 ` Arnout Vandecappelle
2014-10-19 20:47 ` Maxime Hadjinlian
2014-10-19 20:48 ` Arnout Vandecappelle [this message]
2014-10-19 20:49 ` Maxime Hadjinlian
2014-10-19 20:53 ` Arnout Vandecappelle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54442381.3070502@mind.be \
--to=arnout@mind.be \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox