[Buildroot] [PATCH] pakage/erlang: fix host build without termcap (curses) library

[Buildroot] [PATCH] pakage/erlang: fix host build without termcap (curses) library

[Yann E. MORIN]

We do not need termcap (curses) support in the host variant of erlang.

Fixes a bunch of autobuild failures;
    http://autobuild.buildroot.net/results/4be/4bef658b6815929058c769037211f7e0fc8d1f9c/
    http://autobuild.buildroot.net/results/726/72619ed15590a3a5a41b7c398d973766ecab0a2e/
    http://autobuild.buildroot.net/results/366/366439438549d5f7656be72f71dae3bb5f99c6b2/
    ...

Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
Cc: Nathaniel Roach <nroach44@gmail.com>
Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>

---
Cc-ing Nathaniel, as all failures happen on his build server. Thomas and
Nathaniel, could you please review the setting of that autobuild server?
And the others as well?

It seems legit ncurses is missing on a build server, but we did not notice,
because we do require it for menuconfig and nconfig, so virtually everyone
has it, and it is most probably installed on other autobuild servers
because owners want to be able to run menuconfig on them to debug stuff.

Care to have a look, please?

Regards,
Yann E. MORIN.
---
 package/erlang/erlang.mk | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/package/erlang/erlang.mk b/package/erlang/erlang.mk
index e6899de..ef0e0a2 100644
--- a/package/erlang/erlang.mk
+++ b/package/erlang/erlang.mk
@@ -27,6 +27,8 @@ ERLANG_CONF_OPTS = --without-javac
 HOST_ERLANG_DEPENDENCIES = host-openssl
 HOST_ERLANG_CONF_OPTS = --without-javac --with-ssl=$(HOST_DIR)/usr
 
+HOST_ERLANG_CONF_OPTS += --without-termcap
+
 ifeq ($(BR2_PACKAGE_NCURSES),y)
 ERLANG_CONF_OPTS += --with-termcap
 ERLANG_DEPENDENCIES += ncurses
-- 
1.9.1

[Buildroot] [PATCH] pakage/erlang: fix host build without termcap (curses) library

[Nathaniel Roach]

On 18/11/14 06:33, Yann E. MORIN wrote:
> Cc-ing Nathaniel, as all failures happen on his build server. Thomas and
> Nathaniel, could you please review the setting of that autobuild server?
> And the others as well?
>
> It seems legit ncurses is missing on a build server, but we did not
notice,
> because we do require it for menuconfig and nconfig, so virtually everyone
> has it, and it is most probably installed on other autobuild servers
> because owners want to be able to run menuconfig on them to debug stuff.
>
> Care to have a look, please?
>
> Regards,
> Yann E. MORIN.

I haven't installed libncurses-dev per the discussion we had a few
weeks/months back. (Basically only use the system's ncurses for 'make
*config', and in all other cases build it)

I haven't heard otherwise, and this is also causing failures in
host-mysql (IIRC).

If you both believe that I should install it, I will, but I still
believe it is better to build host-ncurses.

Thanks, Nathaniel.

[Buildroot] [PATCH] pakage/erlang: fix host build without termcap (curses) library

[Yann E. MORIN]

Nathaniel, All,

On 2014-11-18 15:59 +0800, Nathaniel Roach spake thusly:
> On 18/11/14 06:33, Yann E. MORIN wrote:
> > Cc-ing Nathaniel, as all failures happen on his build server. Thomas and
> > Nathaniel, could you please review the setting of that autobuild server?
> > And the others as well?
> >
> > It seems legit ncurses is missing on a build server, but we did not
> notice,
> > because we do require it for menuconfig and nconfig, so virtually everyone
> > has it, and it is most probably installed on other autobuild servers
> > because owners want to be able to run menuconfig on them to debug stuff.
> >
> > Care to have a look, please?
> >
> > Regards,
> > Yann E. MORIN.
> 
> I haven't installed libncurses-dev per the discussion we had a few
> weeks/months back. (Basically only use the system's ncurses for 'make
> *config', and in all other cases build it)

Ah, OK. I've overlooked that discussion, then. Thanks!

> I haven't heard otherwise, and this is also causing failures in
> host-mysql (IIRC).
> 
> If you both believe that I should install it, I will, but I still
> believe it is better to build host-ncurses.

Yes, I fully agree with this. No need to fix your autobuild instance.

Thank you!

Regards,
Yann E. MORIN.


-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

[Buildroot] [PATCH] pakage/erlang: fix host build without termcap (curses) library

[Thomas Petazzoni]

Dear Yann E. MORIN,

On Mon, 17 Nov 2014 23:33:16 +0100, Yann E. MORIN wrote:

> Cc-ing Nathaniel, as all failures happen on his build server. Thomas and
> Nathaniel, could you please review the setting of that autobuild server?
> And the others as well?

We already discussed this on the mailing list some time ago.
Nathaniel's build server is the only one where libncurses-dev is not
installed in the system. And since libncurses-dev is not part of our
mandatory dependencies (someone could very well use gconfig or xconfig
only, for example), we thought that keeping Nathaniel's configuration
as is was a good way of catching the cases where we have a missing
dependency on host-ncurses.

I remember we even had a discussion to decide whether we should build
host-ncurses in such cases, or whether we should make libncurses-dev a
hard dependency of Buildroot, and Peter decided that building
host-ncurses was the right solution.

Best regards,

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

[Buildroot] [PATCH] pakage/erlang: fix host build without termcap (curses) library

[Yann E. MORIN]

Thomas, All,

On 2014-11-18 09:31 +0100, Thomas Petazzoni spake thusly:
> On Mon, 17 Nov 2014 23:33:16 +0100, Yann E. MORIN wrote:
> > Cc-ing Nathaniel, as all failures happen on his build server. Thomas and
> > Nathaniel, could you please review the setting of that autobuild server?
> > And the others as well?
> 
> We already discussed this on the mailing list some time ago.
> Nathaniel's build server is the only one where libncurses-dev is not
> installed in the system. And since libncurses-dev is not part of our
> mandatory dependencies (someone could very well use gconfig or xconfig
> only, for example), we thought that keeping Nathaniel's configuration
> as is was a good way of catching the cases where we have a missing
> dependency on host-ncurses.
> 
> I remember we even had a discussion to decide whether we should build
> host-ncurses in such cases, or whether we should make libncurses-dev a
> hard dependency of Buildroot, and Peter decided that building
> host-ncurses was the right solution.

I fully back this resolution. It is very often that a build server
(whether it is for us to do autobuilds, or a production build server)
lacks such libraries.

So, we have to fix such build failures by either:
  - adding a dependency on host-ncurses, or
  - disabling ncurses/termcap support for the host tools if it makes
    sense and it is possible, otherwise revert to depending on
    host-ncurses.

Thank you!

Regards,
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

[Buildroot] [PATCH] pakage/erlang: fix host build without termcap (curses) library

[Peter Korsgaard]

>>>>> "Yann" == Yann E MORIN <yann.morin.1998@free.fr> writes:

 > We do not need termcap (curses) support in the host variant of erlang.
 > Fixes a bunch of autobuild failures;
 >     http://autobuild.buildroot.net/results/4be/4bef658b6815929058c769037211f7e0fc8d1f9c/
 >     http://autobuild.buildroot.net/results/726/72619ed15590a3a5a41b7c398d973766ecab0a2e/
 >     http://autobuild.buildroot.net/results/366/366439438549d5f7656be72f71dae3bb5f99c6b2/
 >     ...

 > Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
 > Cc: Nathaniel Roach <nroach44@gmail.com>
 > Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>

Committed, thanks.

-- 
Bye, Peter Korsgaard