[Buildroot] [PATCH] bluez5_utils: bumped version number to 5.25

[Buildroot] [PATCH] bluez5_utils: bumped version number to 5.25

[Jaap Crezee]

---
 package/bluez5_utils/bluez5_utils.hash | 3 +++
 package/bluez5_utils/bluez5_utils.mk   | 2 +-
 2 files changed, 4 insertions(+), 1 deletion(-)
 create mode 100644 package/bluez5_utils/bluez5_utils.hash

diff --git a/package/bluez5_utils/bluez5_utils.hash b/package/bluez5_utils/bluez5_utils.hash
new file mode 100644
index 0000000..9166f7e
--- /dev/null
+++ b/package/bluez5_utils/bluez5_utils.hash
@@ -0,0 +1,3 @@
+# No upstream hashes for the following:
+sha1    8f65a7076d83116cfacbb84374b99269cd15f1d6                            bluez-5.25.tar.xz
+sha256  5ca62f3f45e2638a0f7a81658d6c8813ee01487436ae8e53e9fe395e23d1fd30    bluez-5.25.tar.xz
diff --git a/package/bluez5_utils/bluez5_utils.mk b/package/bluez5_utils/bluez5_utils.mk
index f34513c..21f792c 100644
--- a/package/bluez5_utils/bluez5_utils.mk
+++ b/package/bluez5_utils/bluez5_utils.mk
@@ -4,7 +4,7 @@
 #
 ################################################################################
 
-BLUEZ5_UTILS_VERSION = 5.21
+BLUEZ5_UTILS_VERSION = 5.25
 BLUEZ5_UTILS_SOURCE = bluez-$(BLUEZ5_UTILS_VERSION).tar.xz
 BLUEZ5_UTILS_SITE = $(BR2_KERNEL_MIRROR)/linux/bluetooth
 BLUEZ5_UTILS_INSTALL_STAGING = YES
-- 
2.1.3

[Buildroot] [PATCH] bluez5_utils: bumped version number to 5.25

[Vicente Olivert Riera]

Dear Jaap Crezee,

On 11/21/2014 04:36 PM, Jaap Crezee wrote:
> ---
>  package/bluez5_utils/bluez5_utils.hash | 3 +++
>  package/bluez5_utils/bluez5_utils.mk   | 2 +-
>  2 files changed, 4 insertions(+), 1 deletion(-)
>  create mode 100644 package/bluez5_utils/bluez5_utils.hash
> 
> diff --git a/package/bluez5_utils/bluez5_utils.hash b/package/bluez5_utils/bluez5_utils.hash
> new file mode 100644
> index 0000000..9166f7e
> --- /dev/null
> +++ b/package/bluez5_utils/bluez5_utils.hash
> @@ -0,0 +1,3 @@
> +# No upstream hashes for the following:
> +sha1    8f65a7076d83116cfacbb84374b99269cd15f1d6                            bluez-5.25.tar.xz
> +sha256  5ca62f3f45e2638a0f7a81658d6c8813ee01487436ae8e53e9fe395e23d1fd30    bluez-5.25.tar.xz
> diff --git a/package/bluez5_utils/bluez5_utils.mk b/package/bluez5_utils/bluez5_utils.mk
> index f34513c..21f792c 100644
> --- a/package/bluez5_utils/bluez5_utils.mk
> +++ b/package/bluez5_utils/bluez5_utils.mk
> @@ -4,7 +4,7 @@
>  #
>  ################################################################################
>  
> -BLUEZ5_UTILS_VERSION = 5.21
> +BLUEZ5_UTILS_VERSION = 5.25
>  BLUEZ5_UTILS_SOURCE = bluez-$(BLUEZ5_UTILS_VERSION).tar.xz
>  BLUEZ5_UTILS_SITE = $(BR2_KERNEL_MIRROR)/linux/bluetooth
>  BLUEZ5_UTILS_INSTALL_STAGING = YES
> 

thanks for sending an improved version of your patch. Is much better now :)

Here you have my:

Reviewed-by: Vicente Olivert Riera <Vincent.Riera@imgtec.com>
Tested-by: Vicente Olivert Riera <Vincent.Riera@imgtec.com>

Just a few more things for the next time you send patches to Buildroot.
After sending a new version of a patch, we usually mark the former patch
as "superseded" in patchwork. To be able to do that, you need to be
logged in in patchwork. If you don't have an account, you can create one
here:

http://patchwork.ozlabs.org/register/

Another one. When you create the patch using "git format-patch", before
sending it, please edit the patch using your favourite text editor and
add the version number in the "Subject" line. Here is an example using
your own patch:

Subject: [PATCH v2] bluez5_utils: bumped version number to 5.25

Also, is useful if you explain the differences between the patch
versions. You can add that information just below the "---" line of you
patch. Here is an example using your own patch:

# [snip] #
Subject: [PATCH] bluez5_utils: bumped version number to 5.25

---
Changes v1 -> v2:
- Improved subject
- Add a hash file

 package/bluez5_utils/bluez5_utils.hash |    3 +++
# [snip] #

And the last thing. Having only the sha256 hash is enough. And, if there
are no upstream hashes we can use, then we usually say "Locally
calculated" as a comment, instead of saying that there are no upstream
hashes, as you did.

I hope my comments help you in the future.

Cheers,
-- 
Vicente Olivert Riera
Graduate Software Engineer, MIPS Processor IP
Imagination Technologies Limited
t: +44 (0)113 2429814
www.imgtec.com

[Buildroot] [PATCH] bluez5_utils: bumped version number to 5.25

[Thomas Petazzoni]

Dear Vicente Olivert Riera,

On Fri, 21 Nov 2014 17:00:59 +0000, Vicente Olivert Riera wrote:

> Another one. When you create the patch using "git format-patch", before
> sending it, please edit the patch using your favourite text editor and
> add the version number in the "Subject" line. Here is an example using
> your own patch:
> 
> Subject: [PATCH v2] bluez5_utils: bumped version number to 5.25

Just a quick comment: there's no need to fire up a text editor to do
this. Just do:

	git format-patch --subject-prefix="PATCHv2"

Best regards,

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

[Buildroot] [PATCH] bluez5_utils: bumped version number to 5.25

[Baruch Siach]

Hi Thomas, Vicente,

On Sat, Nov 22, 2014 at 05:16:15PM +0100, Thomas Petazzoni wrote:
> Dear Vicente Olivert Riera,
> 
> On Fri, 21 Nov 2014 17:00:59 +0000, Vicente Olivert Riera wrote:
> 
> > Another one. When you create the patch using "git format-patch", before
> > sending it, please edit the patch using your favourite text editor and
> > add the version number in the "Subject" line. Here is an example using
> > your own patch:
> > 
> > Subject: [PATCH v2] bluez5_utils: bumped version number to 5.25
> 
> Just a quick comment: there's no need to fire up a text editor to do
> this. Just do:
> 
> 	git format-patch --subject-prefix="PATCHv2"

Since you mentioned it I'll add that with a recent enough version of git you 
can shorten it to

	git format-patch -v 2

baruch

-- 
     http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -

[Buildroot] [PATCH] bluez5_utils: bumped version number to 5.25

[Vicente Olivert Riera]

Dear Thomas Petazzoni,

On 11/22/2014 04:16 PM, Thomas Petazzoni wrote:
> Dear Vicente Olivert Riera,
> 
> On Fri, 21 Nov 2014 17:00:59 +0000, Vicente Olivert Riera wrote:
> 
>> Another one. When you create the patch using "git format-patch", before
>> sending it, please edit the patch using your favourite text editor and
>> add the version number in the "Subject" line. Here is an example using
>> your own patch:
>>
>> Subject: [PATCH v2] bluez5_utils: bumped version number to 5.25
> 
> Just a quick comment: there's no need to fire up a text editor to do
> this. Just do:
> 
> 	git format-patch --subject-prefix="PATCHv2"
> 
> Best regards,
> 
> Thomas
> 

I didn't know that. Thanks for the info :-)

Cheers,
-- 
Vicente Olivert Riera
Graduate Software Engineer, MIPS Processor IP
Imagination Technologies Limited
t: +44 (0)113 2429814
www.imgtec.com

[Buildroot] [PATCH] bluez5_utils: bumped version number to 5.25

[Thomas Petazzoni]

Dear Jaap Crezee,

On Fri, 21 Nov 2014 17:36:31 +0100, Jaap Crezee wrote:
> ---
>  package/bluez5_utils/bluez5_utils.hash | 3 +++
>  package/bluez5_utils/bluez5_utils.mk   | 2 +-
>  2 files changed, 4 insertions(+), 1 deletion(-)
>  create mode 100644 package/bluez5_utils/bluez5_utils.hash

Your Signed-off-by line is missing in the patch.

Can you resend after adding your SoB line?

Thanks,

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

[Buildroot] [PATCH] bluez5_utils: bumped version number to 5.25

[Thomas Petazzoni]

Hello,

On Sat, 22 Nov 2014 19:00:28 +0100, Thomas Petazzoni wrote:
> Dear Jaap Crezee,
> 
> On Fri, 21 Nov 2014 17:36:31 +0100, Jaap Crezee wrote:
> > ---
> >  package/bluez5_utils/bluez5_utils.hash | 3 +++
> >  package/bluez5_utils/bluez5_utils.mk   | 2 +-
> >  2 files changed, 4 insertions(+), 1 deletion(-)
> >  create mode 100644 package/bluez5_utils/bluez5_utils.hash
> 
> Your Signed-off-by line is missing in the patch.
> 
> Can you resend after adding your SoB line?

Ping? Could you resend with your SoB line added? Without this, I cannot
commit your patch.

Thanks,

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

[Buildroot] [PATCH] bluez5_utils: bumped version number to 5.25

[Peter Seiderer]

Hello Vicente, Jaap,

On Fri, Nov 21, 2014 at 05:00:59PM +0000, Vicente Olivert Riera wrote:
> Dear Jaap Crezee,
 
[...]

> Just a few more things for the next time you send patches to Buildroot.
> After sending a new version of a patch, we usually mark the former patch
> as "superseded" in patchwork. To be able to do that, you need to be
> logged in in patchwork. If you don't have an account, you can create one
> here:
> 
> http://patchwork.ozlabs.org/register/
> 

Would be a nice patchwork feature to mark 'legacy' patches automatically
as superseded in case a newer patch (with same subject, new version number,
from same submitter) is detected on the mailing list?

> Another one. When you create the patch using "git format-patch", before
> sending it, please edit the patch using your favourite text editor and
> add the version number in the "Subject" line. Here is an example using
> your own patch:
> 
> Subject: [PATCH v2] bluez5_utils: bumped version number to 5.25
> 

Or use 'git format-patch --subject-prefix "PATCH v2" ...'

Regards,
Peter

[Buildroot] [PATCH] bluez5_utils: bumped version number to 5.25

[Thomas Petazzoni]

Dear Peter Seiderer,

On Sun, 23 Nov 2014 01:12:39 +0100, Peter Seiderer wrote:

> > Just a few more things for the next time you send patches to Buildroot.
> > After sending a new version of a patch, we usually mark the former patch
> > as "superseded" in patchwork. To be able to do that, you need to be
> > logged in in patchwork. If you don't have an account, you can create one
> > here:
> > 
> > http://patchwork.ozlabs.org/register/
> > 
> 
> Would be a nice patchwork feature to mark 'legacy' patches automatically
> as superseded in case a newer patch (with same subject, new version number,
> from same submitter) is detected on the mailing list?

There is a such a feature, but only if the new version of the patch
series is sent as a reply to the previous one. And of course, it only
works if each patch in the new version have exactly the same subject as
in the previous version. That's why we never use it.

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

[Buildroot] [PATCH] bluez5_utils: bumped version number to 5.25

[Jaap Crezee]

Signed-off-by: Jaap Crezee <jaap@jcz.nl>
---
 package/bluez5_utils/bluez5_utils.hash | 2 ++
 package/bluez5_utils/bluez5_utils.mk   | 2 +-
 2 files changed, 3 insertions(+), 1 deletion(-)
 create mode 100644 package/bluez5_utils/bluez5_utils.hash

diff --git a/package/bluez5_utils/bluez5_utils.hash b/package/bluez5_utils/bluez5_utils.hash
new file mode 100644
index 0000000..c8295f9
--- /dev/null
+++ b/package/bluez5_utils/bluez5_utils.hash
@@ -0,0 +1,2 @@
+# Locally calculated:
+sha256  5ca62f3f45e2638a0f7a81658d6c8813ee01487436ae8e53e9fe395e23d1fd30    bluez-5.25.tar.xz
diff --git a/package/bluez5_utils/bluez5_utils.mk b/package/bluez5_utils/bluez5_utils.mk
index f34513c..21f792c 100644
--- a/package/bluez5_utils/bluez5_utils.mk
+++ b/package/bluez5_utils/bluez5_utils.mk
@@ -4,7 +4,7 @@
 #
 ################################################################################
 
-BLUEZ5_UTILS_VERSION = 5.21
+BLUEZ5_UTILS_VERSION = 5.25
 BLUEZ5_UTILS_SOURCE = bluez-$(BLUEZ5_UTILS_VERSION).tar.xz
 BLUEZ5_UTILS_SITE = $(BR2_KERNEL_MIRROR)/linux/bluetooth
 BLUEZ5_UTILS_INSTALL_STAGING = YES
-- 
2.1.3

[Buildroot] [PATCH] bluez5_utils: bumped version number to 5.25

[Baruch Siach]

Hi Jaap,

On Sun, Nov 30, 2014 at 03:37:36PM +0100, Jaap Crezee wrote:
> Signed-off-by: Jaap Crezee <jaap@jcz.nl>
> ---
>  package/bluez5_utils/bluez5_utils.hash | 2 ++
>  package/bluez5_utils/bluez5_utils.mk   | 2 +-
>  2 files changed, 3 insertions(+), 1 deletion(-)
>  create mode 100644 package/bluez5_utils/bluez5_utils.hash
> 
> diff --git a/package/bluez5_utils/bluez5_utils.hash b/package/bluez5_utils/bluez5_utils.hash
> new file mode 100644
> index 0000000..c8295f9
> --- /dev/null
> +++ b/package/bluez5_utils/bluez5_utils.hash
> @@ -0,0 +1,2 @@
> +# Locally calculated:
> +sha256  5ca62f3f45e2638a0f7a81658d6c8813ee01487436ae8e53e9fe395e23d1fd30    bluez-5.25.tar.xz

Should be: "From https://www.kernel.org/pub/linux/bluetooth/sha256sums.asc".

baruch


-- 
     http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -

[Buildroot] [PATCH] bluez5_utils: bumped version number to 5.25

[Jaap Crezee]

On 11/30/14 15:40, Baruch Siach wrote:
> From https://www.kernel.org/pub/linux/bluetooth/sha256sums.asc

Like this?

Regards,

Jaap Crezee
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-bluez5_utils-bumped-version-number-to-5.25.patch
Type: text/x-patch
Size: 1357 bytes
Desc: not available
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20141130/087ef7f2/attachment.bin>

[Buildroot] [PATCH] bluez5_utils: bumped version number to 5.25

[Baruch Siach]

Hi Jaap,

On Sun, Nov 30, 2014 at 03:43:27PM +0100, Jaap Crezee wrote:
> On 11/30/14 15:40, Baruch Siach wrote:
> > From https://www.kernel.org/pub/linux/bluetooth/sha256sums.asc
> 
> Like this?

Yes. This is better. But please send the patch inline like you did with the 
previous one. When doing so please add '-v 2' to your 'git format-patch' or 
'git send-email' command to have 'v2' appended to the [PATCH] subject prefix.

Thanks,
baruch

> From 50a00f68bbd0bc18217c8e9883c4a20a598ea0b9 Mon Sep 17 00:00:00 2001
> From: Jaap Crezee <jaap@jcz.nl>
> Date: Sun, 30 Nov 2014 15:35:31 +0100
> Subject: [PATCH] bluez5_utils: bumped version number to 5.25
> 
> Signed-off-by: Jaap Crezee <jaap@jcz.nl>
> ---
>  package/bluez5_utils/bluez5_utils.hash | 2 ++
>  package/bluez5_utils/bluez5_utils.mk   | 2 +-
>  2 files changed, 3 insertions(+), 1 deletion(-)
>  create mode 100644 package/bluez5_utils/bluez5_utils.hash
> 
> diff --git a/package/bluez5_utils/bluez5_utils.hash b/package/bluez5_utils/bluez5_utils.hash
> new file mode 100644
> index 0000000..c8295f9
> --- /dev/null
> +++ b/package/bluez5_utils/bluez5_utils.hash
> @@ -0,0 +1,2 @@
> +# From https://www.kernel.org/pub/linux/bluetooth/sha256sums.asc:
> +sha256  5ca62f3f45e2638a0f7a81658d6c8813ee01487436ae8e53e9fe395e23d1fd30    bluez-5.25.tar.xz
> diff --git a/package/bluez5_utils/bluez5_utils.mk b/package/bluez5_utils/bluez5_utils.mk
> index f34513c..21f792c 100644
> --- a/package/bluez5_utils/bluez5_utils.mk
> +++ b/package/bluez5_utils/bluez5_utils.mk
> @@ -4,7 +4,7 @@
>  #
>  ################################################################################
>  
> -BLUEZ5_UTILS_VERSION = 5.21
> +BLUEZ5_UTILS_VERSION = 5.25
>  BLUEZ5_UTILS_SOURCE = bluez-$(BLUEZ5_UTILS_VERSION).tar.xz
>  BLUEZ5_UTILS_SITE = $(BR2_KERNEL_MIRROR)/linux/bluetooth
>  BLUEZ5_UTILS_INSTALL_STAGING = YES

-- 
     http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -

[Buildroot] [PATCH] bluez5_utils: bumped version number to 5.25

[Jaap Crezee]

Hello all,

On 11/30/14 15:59, Baruch Siach wrote:
> Yes. This is better. But please send the patch inline like you did with the 
> previous one. When doing so please add '-v 2' to your 'git format-patch' or 
> 'git send-email' command to have 'v2' appended to the [PATCH] subject prefix.

I took a look at patchwork and the new patch seems to be there.
Is everything okay now for inclusion? Somebody will eventually commit this?
Or do I need to make more changes?

Please advise,

Jaap Crezee

[Buildroot] [PATCH] bluez5_utils: bumped version number to 5.25

[Thomas Petazzoni]

Dear Jaap Crezee,

Patch applied. But please send the patch with 'git send-email' next
time, and use a different version number. See
http://buildroot.org/downloads/manual/manual.html#submitting-patches
for details.

Thanks for your contribution!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com