* [Buildroot] [PATCH v2] openocd 0.8.0
@ 2014-11-30 20:35 Claudio Laurita
2014-12-03 17:20 ` Vicente Olivert Riera
2014-12-09 21:20 ` Ezequiel Garcia
0 siblings, 2 replies; 5+ messages in thread
From: Claudio Laurita @ 2014-11-30 20:35 UTC (permalink / raw)
To: buildroot
Signed-off-by: Claudio Laurita <claudio.laurita@integrazionetotale.it>
---
Changes v1 -> v2
- Added less laconical patch description
- Added signature to the (sub)patches of the packege itself
- HOST_OPENOCD_CONF_OPTS no longer related to OPENOCD_CONF_OPTS
- Re-introduced the patch to avoid jimctl shared lib building
package/openocd/Config.in | 191 +++++++++++++++++++--
...mpilation-error-in-src-flash-nor-mini51.c.patch | 30 ++++
...s-compilation-host-libsub-was-used-before.patch | 33 ----
...auto-configuration-to-force-static-librar.patch | 35 ++++
...002-fix-xscale-uninitialise-breakpoint_pc.patch | 20 ---
package/openocd/openocd-0003-force-gnu99.patch | 19 --
.../openocd/openocd-0004-force_jimtcl_static.patch | 25 ---
.../openocd/openocd-0005-dont-force-ldflags.patch | 37 ----
package/openocd/openocd-0006-automake-compat.patch | 40 -----
package/openocd/openocd.mk | 175 +++++++++++++++++--
10 files changed, 407 insertions(+), 198 deletions(-)
create mode 100644 package/openocd/openocd-0001-Fix-compilation-error-in-src-flash-nor-mini51.c.patch
delete mode 100644 package/openocd/openocd-0001-fix-cross-compilation-host-libsub-was-used-before.patch
create mode 100644 package/openocd/openocd-0002-Fix-jimtcl-auto-configuration-to-force-static-librar.patch
delete mode 100644 package/openocd/openocd-0002-fix-xscale-uninitialise-breakpoint_pc.patch
delete mode 100644 package/openocd/openocd-0003-force-gnu99.patch
delete mode 100644 package/openocd/openocd-0004-force_jimtcl_static.patch
delete mode 100644 package/openocd/openocd-0005-dont-force-ldflags.patch
delete mode 100644 package/openocd/openocd-0006-automake-compat.patch
diff --git a/package/openocd/Config.in b/package/openocd/Config.in
index 9440c65..0c4b47a 100644
--- a/package/openocd/Config.in
+++ b/package/openocd/Config.in
@@ -1,8 +1,6 @@
config BR2_PACKAGE_OPENOCD
bool "openocd"
depends on BR2_TOOLCHAIN_HAS_THREADS # libusb
- select BR2_PACKAGE_LIBUSB
- select BR2_PACKAGE_LIBUSB_COMPAT
help
OpenOCD - Open On-Chip Debugger
@@ -12,22 +10,195 @@ if BR2_PACKAGE_OPENOCD
comment "Adapters"
-config BR2_PACKAGE_OPENOCD_FT2XXX
- bool "FT2xxx/FT4xxx Based JTAG Programmer"
- depends on BR2_ARCH_HAS_ATOMICS # libftdi
- select BR2_PACKAGE_LIBFTDI
+config BR2_PACKAGE_OPENOCD_FTDI
+ bool "MPSSE mode of FTDI based devices"
+ select BR2_PACKAGE_LIBUSB
help
- Enable building support for FT2232 based devices
- using the libftdi driver, opensource alternate of FTD2XX
-
+ Enable building support for the MPSSE mode of FTDI
+ (FT2xxx/FT4xxx) based devices (default is auto)
+
+config BR2_PACKAGE_OPENOCD_STLINK
+ bool "ST-Link JTAG Programmer"
+ select BR2_PACKAGE_LIBUSB
+ help
+ Enable building support for the ST-Link JTAG
+ Programmer (default is auto)
+
+config BR2_PACKAGE_OPENOCD_TI_ICDI
+ bool "TI ICDI JTAG Programmer"
+ select BR2_PACKAGE_LIBUSB
+ help
+ Enable building support for the TI ICDI JTAG
+ Programmer (default is auto)
+
+config BR2_PACKAGE_OPENOCD_ULINK
+ bool "Keil ULINK JTAG Programmer"
+ select BR2_PACKAGE_LIBUSB
+ help
+ Enable building support for the Keil ULINK JTAG
+ Programmer (default is auto)
+
+config BR2_PACKAGE_OPENOCD_UBLASTER2
+ bool "Altera USB-Blaster II Compatible"
+ select BR2_PACKAGE_LIBUSB
+ help
+ Enable building support for the Altera USB-Blaster
+ II Compatible (default is auto)
+
config BR2_PACKAGE_OPENOCD_JLINK
bool "Segger J-Link JTAG Programmer"
+ select BR2_PACKAGE_LIBUSB
help
Segger J-Link JTAG Programmer and clone such as Atmel SAM-ICE
+config BR2_PACKAGE_OPENOCD_OSDBM
+ bool "OSDBM JTAG (only) Programmer"
+ select BR2_PACKAGE_LIBUSB
+ help
+ Enable building support for the OSBDM (JTAG only)
+ Programmer (default is auto)
+
+config BR2_PACKAGE_OPENOCD_OPENDOUS
+ bool "eStick/opendous JTAG Programmer"
+ select BR2_PACKAGE_LIBUSB
+ help
+ Enable building support for the eStick/opendous JTAG
+ Programmer (default is auto)
+
+config BR2_PACKAGE_OPENOCD_AICE
+ bool "Andes JTAG Programmer"
+ select BR2_PACKAGE_LIBUSB
+ help
+ Enable building support for the Andes JTAG
+ Programmer (default is auto)
+
config BR2_PACKAGE_OPENOCD_VSLLINK
- bool "Versaloon-Link JTAG Programmr"
+ bool "Versaloon-Link JTAG Programmer"
+ select BR2_PACKAGE_LIBUSB_COMPAT
+ help
+ Enable building support for the Versaloon-Link JTAG
+ Programmer (default is auto)
+
+config BR2_PACKAGE_OPENOCD_USBPROG
+ bool "USBProg JTAG Programmer"
+ select BR2_PACKAGE_LIBUSB_COMPAT
+ help
+ Enable building support for the USBProg JTAG
+ Programmer (default is auto)
+
+config BR2_PACKAGE_OPENOCD_RLINK
+ bool "Raisonance RLink JTAG Programmer"
+ select BR2_PACKAGE_LIBUSB_COMPAT
+ help
+ Enable building support for the Raisonance RLink
+ JTAG Programmer (default is auto)
+
+config BR2_PACKAGE_OPENOCD_ARMEW
+ bool "Olimex ARM-JTAG-EW Programmer"
+ select BR2_PACKAGE_LIBUSB_COMPAT
+ help
+ Enable building support for the Olimex ARM-JTAG-EW
+ Programmer (default is auto)
+
+config BR2_PACKAGE_OPENOCD_CMSIS_DAP
+ bool "CMSIS-DAP Compliant Debugger"
+ select BR2_PACKAGE_LIBUSB
+ select BR2_PACKAGE_LIBHID
+ help
+ Enable building support for the CMSIS-DAP Compliant
+ Debugger (default is auto)
+
+config BR2_PACKAGE_OPENOCD_PARPORT
+ bool "pc parallel port driver"
+ help
+ Enable building the pc parallel port driver
+
+config BR2_PACKAGE_OPENOCD_FT2XXX
+ bool "FT2232 based devices (DEPRECATED)"
+ select BR2_PACKAGE_LIBFTDI
+ help
+ (DEPRECATED) Enable building support for FT2232
+ based devices using the libftdi library
+
+config BR2_PACKAGE_OPENOCD_VPI
+ bool "JTAG VPI"
+ help
+ Enable building support for JTAG VPI
+
+config BR2_PACKAGE_OPENOCD_UBLASTER
+ bool "Altera USB-Blaster"
+ select BR2_PACKAGE_LIBFTDI
+ help
+ Enable building support for the Altera USB-Blaster
+ using the libftdi driver, opensource alternate of
+ FTD2XX
+
+config BR2_PACKAGE_OPENOCD_AMTJT
+ bool "Amontec JTAG-Accelerator"
+ help
+ Enable building the Amontec JTAG-Accelerator driver
+
+config BR2_PACKAGE_OPENOCD_ZY1000_MASTER
+ bool "ZY1000 JTAG master"
+ help
+ Use ZY1000 JTAG master registers
+
+config BR2_PACKAGE_OPENOCD_ZY1000
+ bool "ZY1000 interface"
+ help
+ Enable ZY1000 interface
+
+if BR2_arm
+config BR2_PACKAGE_OPENOCD_EP93XX
+ bool "EP93xx based SBCs"
+ help
+ Enable building support for EP93xx based SBCs
+
+config BR2_PACKAGE_OPENOCD_AT91RM
+ bool "AT91RM9200 based SBCs"
+ help
+ Enable building support for AT91RM9200 based SBCs
+
+config BR2_PACKAGE_OPENOCD_BCM2835
+ bool "bitbanging on BCM2835"
+ help
+ Enable building support for bitbanging on BCM2835
+ (as found in Raspberry Pi)
+
+endif # BR2_arm
+
+config BR2_PACKAGE_OPENOCD_GW16012
+ bool "Gateworks GW16012 JTAG Programmer"
+ help
+ Enable building support for the Gateworks GW16012
+ JTAG Programmer
+
+config BR2_PACKAGE_OPENOCD_PRESTO
+ bool "ASIX Presto Programmer"
+ select BR2_PACKAGE_LIBFTDI
+ help
+ Enable building support for ASIX Presto Programmer
+ using the libftdi driver
+
+config BR2_PACKAGE_OPENOCD_OPENJTAG
+ bool "OpenJTAG Programmer"
+ select BR2_PACKAGE_LIBFTDI
+ help
+ Enable building support for the OpenJTAG Programmer
+ with ftdi driver
+
+config BR2_PACKAGE_OPENOCD_BUSPIRATE
+ bool "Buspirate"
+ help
+ Enable building support for the Buspirate
+
+config BR2_PACKAGE_OPENOCD_SYSFS
+ bool "programming via sysfs gpios"
+ help
+ Enable building support for programming driven via
+ sysfs gpios.
+
endif # BR2_PACKAGE_OPENOCD
comment "openocd needs a toolchain w/ threads"
diff --git a/package/openocd/openocd-0001-Fix-compilation-error-in-src-flash-nor-mini51.c.patch b/package/openocd/openocd-0001-Fix-compilation-error-in-src-flash-nor-mini51.c.patch
new file mode 100644
index 0000000..6eb7f9d
--- /dev/null
+++ b/package/openocd/openocd-0001-Fix-compilation-error-in-src-flash-nor-mini51.c.patch
@@ -0,0 +1,30 @@
+From 893330638a26ea2868c6e7606047acf9b6fe31ea Mon Sep 17 00:00:00 2001
+From: Claudio Laurita <claudio.laurita@integrazionetotale.it>
+Date: Sun, 30 Nov 2014 17:30:36 +0100
+Subject: [PATCH 1/1] Fix compilation error in src/flash/nor/mini51.c
+
+0001-Fix-compilation-error-in-src-flash-nor-mini51.c.patch
+gcc complains about missing initialization of
+local variable flash_size and compilation aborts
+
+Signed-off-by: Claudio Laurita <claudio.laurita@integrazionetotale.it>
+---
+ src/flash/nor/mini51.c | 2 +-
+ 1 file changed, 1 insertion(+), 1 deletion(-)
+
+diff --git a/src/flash/nor/mini51.c b/src/flash/nor/mini51.c
+index 61aee5d..c7ba13a 100644
+--- a/src/flash/nor/mini51.c
++++ b/src/flash/nor/mini51.c
+@@ -397,7 +397,7 @@ static int mini51_write(struct flash_bank *bank, const uint8_t *buffer, uint32_t
+
+ static int mini51_probe(struct flash_bank *bank)
+ {
+- uint32_t flash_size;
++ uint32_t flash_size = 0;
+ int retval;
+ int num_pages;
+ uint32_t offset = 0;
+--
+2.1.3
+
diff --git a/package/openocd/openocd-0001-fix-cross-compilation-host-libsub-was-used-before.patch b/package/openocd/openocd-0001-fix-cross-compilation-host-libsub-was-used-before.patch
deleted file mode 100644
index caf1a8b..0000000
--- a/package/openocd/openocd-0001-fix-cross-compilation-host-libsub-was-used-before.patch
+++ /dev/null
@@ -1,33 +0,0 @@
-From 3728c4af7f6303ccedab56ec220797f8f290580e Mon Sep 17 00:00:00 2001
-From: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
-Date: Wed, 10 Aug 2011 00:17:29 +0800
-Subject: [PATCH] fix cross compilation: host libsub was used before
-
-tested in buildroot
-
-Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
----
- configure.in | 7 +++++--
- 1 files changed, 5 insertions(+), 2 deletions(-)
-
-diff --git a/configure.in b/configure.in
-index dfa1e8f..cfe2218 100644
---- a/configure.in
-+++ b/configure.in
-@@ -1046,8 +1046,11 @@ build_usb=no
- if test $build_jlink = yes -o $build_vsllink = yes -o $build_usbprog = yes -o \
- $build_rlink = yes -o $build_ulink = yes -o $build_armjtagew = yes
- then
-- AC_CHECK_HEADERS([usb.h],[],
-- [AC_MSG_ERROR([usb.h is required to build some OpenOCD driver(s)])])
-+ dnl check for libusb
-+ PKG_CHECK_MODULES(LIBUSB, libusb >= 0.1.11)
-+ CFLAGS="$CFLAGS $LIBUSB_CFLAGS"
-+ LDFLAGS="$LDFLAGS $LIBUSB_LDFLAGS"
-+ LIBS="$LIBS $LIBUSB_LIBS"
- build_usb=yes
- fi
-
---
-1.7.5.4
-
diff --git a/package/openocd/openocd-0002-Fix-jimtcl-auto-configuration-to-force-static-librar.patch b/package/openocd/openocd-0002-Fix-jimtcl-auto-configuration-to-force-static-librar.patch
new file mode 100644
index 0000000..5ec0552
--- /dev/null
+++ b/package/openocd/openocd-0002-Fix-jimtcl-auto-configuration-to-force-static-librar.patch
@@ -0,0 +1,35 @@
+From 3bef159779c8fd39a070ec5c8191e18ba2efa79d Mon Sep 17 00:00:00 2001
+From: Claudio Laurita <claudio.laurita@integrazionetotale.it>
+Date: Sun, 30 Nov 2014 18:21:58 +0100
+Subject: [PATCH 2/2] Fix jimtcl auto configuration to force static library
+ only. jimtcl ignores a --disable-shared option if a previous --enable-shared
+ option was given. This breaks openocd compilation if shared was the preferred
+ option in buildroot project.
+
+Signed-off-by: Claudio Laurita <claudio.laurita@integrazionetotale.it>
+---
+ jimtcl/auto.def | 8 ++------
+ 1 file changed, 2 insertions(+), 6 deletions(-)
+
+diff --git a/jimtcl/auto.def b/jimtcl/auto.def
+index ddb0c1e..929ade0 100644
+--- a/jimtcl/auto.def
++++ b/jimtcl/auto.def
+@@ -181,12 +181,8 @@ if {[opt-bool references]} {
+ msg-result "Enabling references"
+ define JIM_REFERENCES
+ }
+-if {[opt-bool shared with-jim-shared]} {
+- msg-result "Building shared library"
+-} else {
+- msg-result "Building static library"
+- define JIM_STATICLIB
+-}
++msg-result "Building static library"
++define JIM_STATICLIB
+ define JIM_INSTALL [opt-bool install-jim]
+
+ # Attributes of the extensions
+--
+2.1.3
+
diff --git a/package/openocd/openocd-0002-fix-xscale-uninitialise-breakpoint_pc.patch b/package/openocd/openocd-0002-fix-xscale-uninitialise-breakpoint_pc.patch
deleted file mode 100644
index 328241e..0000000
--- a/package/openocd/openocd-0002-fix-xscale-uninitialise-breakpoint_pc.patch
+++ /dev/null
@@ -1,20 +0,0 @@
-xscale: fix uninitialise breakpoint_pc
-
-Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
----
- src/target/xscale.c | 2 +-
- 1 file changed, 1 insertion(+), 1 deletion(-)
-
-Index: b/src/target/xscale.c
-===================================================================
---- a/src/target/xscale.c
-+++ b/src/target/xscale.c
-@@ -2811,7 +2811,7 @@ static int xscale_analyze_trace(struct t
- struct xscale_common *xscale = target_to_xscale(target);
- struct xscale_trace_data *trace_data = xscale->trace.data;
- int i, retval;
-- uint32_t breakpoint_pc;
-+ uint32_t breakpoint_pc = 0;
- struct arm_instruction instruction;
- uint32_t current_pc = 0; /* initialized when address determined */
-
diff --git a/package/openocd/openocd-0003-force-gnu99.patch b/package/openocd/openocd-0003-force-gnu99.patch
deleted file mode 100644
index 106d112..0000000
--- a/package/openocd/openocd-0003-force-gnu99.patch
+++ /dev/null
@@ -1,19 +0,0 @@
-force gnu99
-
-Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
----
- configure.in | 1 +
- 1 file changed, 1 insertion(+)
-
-Index: b/configure.in
-===================================================================
---- a/configure.in
-+++ b/configure.in
-@@ -28,6 +28,7 @@ AC_DISABLE_SHARED
- AC_PROG_LIBTOOL
- AC_SUBST(LIBTOOL_DEPS)
-
-+CFLAGS="$CFLAGS -std=gnu99"
-
- dnl configure checks required for Jim files (these are obsolete w/ C99)
- AC_C_CONST
diff --git a/package/openocd/openocd-0004-force_jimtcl_static.patch b/package/openocd/openocd-0004-force_jimtcl_static.patch
deleted file mode 100644
index 7118b57..0000000
--- a/package/openocd/openocd-0004-force_jimtcl_static.patch
+++ /dev/null
@@ -1,25 +0,0 @@
-force jimtcl to build static
-
-Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
----
- jimtcl/auto.def | 5 -----
- 1 file changed, 5 deletions(-)
-
-Index: b/jimtcl/auto.def
-===================================================================
---- a/jimtcl/auto.def
-+++ b/jimtcl/auto.def
-@@ -148,13 +148,8 @@ if {[opt-bool references]} {
- msg-result "Enabling references"
- define JIM_REFERENCES
- }
--if {[opt-bool shared with-jim-shared]} {
-- msg-result "Building shared library"
-- define JIM_LIBTYPE shared
--} else {
- msg-result "Building static library"
- define JIM_LIBTYPE static
--}
- if {[opt-bool install-jim]} {
- define install_jim 1
- } else {
diff --git a/package/openocd/openocd-0005-dont-force-ldflags.patch b/package/openocd/openocd-0005-dont-force-ldflags.patch
deleted file mode 100644
index 1880e00..0000000
--- a/package/openocd/openocd-0005-dont-force-ldflags.patch
+++ /dev/null
@@ -1,37 +0,0 @@
-[PATCH] don't force library search path / rpath settings
-
-openocd adds -L$exec_prefix/lib -Wl,rpath,$exec_prefix/lib to the compile
-LDFLAGS if it isn't installed into /usr/local, which breaks cross compilation
-as the compiler ends up using host libraries.
----
- configure.in | 17 -----------------
- 1 file changed, 17 deletions(-)
-
-Index: openocd-0.5.0/configure.in
-===================================================================
---- openocd-0.5.0.orig/configure.in
-+++ openocd-0.5.0/configure.in
-@@ -174,23 +174,6 @@
- # Let make expand exec_prefix.
- test x"$OCDxprefix" = xNONE && OCDxprefix="$OCDprefix"
-
--# what matters is the "exec-prefix"
--if test "$OCDxprefix" != "$ac_default_prefix"
--then
-- # We are installing in a non-standard place
-- # Nonstandard --prefix and/or --exec-prefix
-- # We have an override of some sort.
-- # use build specific install library dir
--
-- LDFLAGS="$LDFLAGS -L$OCDxprefix/lib"
-- # RPATH becomes an issue on Linux only
-- if test $host_os = linux-gnu || test $host_os = linux ; then
-- LDFLAGS="$LDFLAGS -Wl,-rpath,$OCDxprefix/lib"
-- fi
-- # The "INCDIR" is also usable
-- CFLAGS="$CFLAGS -I$includedir"
--fi
--
- AC_ARG_WITH(ftd2xx,
- AS_HELP_STRING([--with-ftd2xx=<PATH>],[This option has been removed.]),
- [
diff --git a/package/openocd/openocd-0006-automake-compat.patch b/package/openocd/openocd-0006-automake-compat.patch
deleted file mode 100644
index cdc6c92..0000000
--- a/package/openocd/openocd-0006-automake-compat.patch
+++ /dev/null
@@ -1,40 +0,0 @@
-Backport from openocd commit 737a52d7b22b1774acc5d20f9bd25000a70ac116
-Fix for automake 1.11.2+
-
-Signed-off-by: Gustavo Zacarias <gustavo@zacarias.com.ar>
-
-diff -Nura openocd-0.5.0/src/jtag/drivers/Makefile.am openocd-0.5.0.automake/src/jtag/drivers/Makefile.am
---- openocd-0.5.0/src/jtag/drivers/Makefile.am 2011-08-09 02:34:19.000000000 -0300
-+++ openocd-0.5.0.automake/src/jtag/drivers/Makefile.am 2012-05-01 13:57:01.007561480 -0300
-@@ -5,7 +5,8 @@
- libocdjtagdrivers_la_SOURCES = \
- $(DRIVERFILES)
-
--nobase_dist_pkglib_DATA =
-+ocddatadir = $(pkglibdir)
-+nobase_dist_ocddata_DATA =
-
- ULINK_FIRMWARE = $(srcdir)/OpenULINK
-
-@@ -64,7 +65,7 @@
- endif
- if ULINK
- DRIVERFILES += ulink.c
--nobase_dist_pkglib_DATA += $(ULINK_FIRMWARE)/ulink_firmware.hex
-+nobase_dist_ocddata_DATA += $(ULINK_FIRMWARE)/ulink_firmware.hex
- endif
- if VSLLINK
- DRIVERFILES += vsllink.c
-diff -Nura openocd-0.5.0/src/target/Makefile.am openocd-0.5.0.automake/src/target/Makefile.am
---- openocd-0.5.0/src/target/Makefile.am 2011-08-09 02:34:19.000000000 -0300
-+++ openocd-0.5.0.automake/src/target/Makefile.am 2012-05-01 13:57:01.934567076 -0300
-@@ -165,7 +165,7 @@
- avr32_mem.h \
- avr32_regs.h
-
--nobase_dist_pkglib_DATA =
--nobase_dist_pkglib_DATA += ecos/at91eb40a.elf
-+ocddatadir = $(pkglibdir)
-+nobase_dist_ocddata_DATA = ecos/at91eb40a.elf
-
- MAINTAINERCLEANFILES = $(srcdir)/Makefile.in
diff --git a/package/openocd/openocd.mk b/package/openocd/openocd.mk
index 07366af..3855156 100644
--- a/package/openocd/openocd.mk
+++ b/package/openocd/openocd.mk
@@ -4,43 +4,190 @@
#
################################################################################
-OPENOCD_VERSION = 0.5.0
+OPENOCD_VERSION = 0.8.0
OPENOCD_SOURCE = openocd-$(OPENOCD_VERSION).tar.bz2
OPENOCD_SITE = http://downloads.sourceforge.net/project/openocd/openocd/$(OPENOCD_VERSION)
-OPENOCD_LICENSE = GPLv2+
-OPENOCD_LICENSE_FILES = COPYING
OPENOCD_AUTORECONF = YES
OPENOCD_CONF_OPTS = \
--oldincludedir=$(STAGING_DIR)/usr/include \
--includedir=$(STAGING_DIR)/usr/include \
--disable-doxygen-html \
+ --with-jim-shared=no \
+ --disable-shared \
--enable-dummy
-OPENOCD_DEPENDENCIES = libusb-compat
+OPENOCD_DEPENDENCIES =
+HOST_OPENOCD_DEPENDENCIES =
-# Adapters
-ifeq ($(BR2_PACKAGE_OPENOCD_FT2XXX),y)
-OPENOCD_CONF_OPTS += --enable-ft2232_libftdi
+ifeq ($(BR2_PACKAGE_LIBFTDI),y)
OPENOCD_DEPENDENCIES += libftdi
+HOST_OPENOCD_DEPENDENCIES += host-libftdi
+endif
+
+ifeq ($(BR2_PACKAGE_LIBUSB),y)
+OPENOCD_DEPENDENCIES += libusb
+HOST_OPENOCD_DEPENDENCIES += host-libusb
+endif
+
+ifeq ($(BR2_PACKAGE_LIBUSB_COMPAT),y)
+OPENOCD_DEPENDENCIES += libusb-compat
+HOST_OPENOCD_DEPENDENCIES += host-libusb-compat
+endif
+
+ifeq ($(BR2_PACKAGE_LIBHID),y)
+OPENOCD_DEPENDENCIES += libhid
+HOST_OPENOCD_DEPENDENCIES += host-libhid
endif
+# Adapters
+
+ifeq ($(BR2_PACKAGE_OPENOCD_FTDI),y)
+OPENOCD_CONF_OPTS += --enable-ftdi
+endif
+
+ifeq ($(BR2_PACKAGE_OPENOCD_STLINK),y)
+OPENOCD_CONF_OPTS += --enable-stlink
+endif
+
+ifeq ($(BR2_PACKAGE_OPENOCD_TI_ICDI),y)
+OPENOCD_CONF_OPTS += --enable-ti-icdi
+endif
+
+ifeq ($(BR2_PACKAGE_OPENOCD_ULINK),y)
+OPENOCD_CONF_OPTS += --enable-ulink
+endif
+
+ifeq ($(BR2_PACKAGE_OPENOCD_UBLASTER2),y)
+OPENOCD_CONF_OPTS += --enable-usb-blaster-2
+endif
+
ifeq ($(BR2_PACKAGE_OPENOCD_JLINK),y)
OPENOCD_CONF_OPTS += --enable-jlink
endif
+ifeq ($(BR2_PACKAGE_OPENOCD_OSDBM),y)
+OPENOCD_CONF_OPTS += --enable-osbdm
+endif
+
+ifeq ($(BR2_PACKAGE_OPENOCD_OPENDOUS),y)
+OPENOCD_CONF_OPTS += --enable-opendous
+endif
+
+ifeq ($(BR2_PACKAGE_OPENOCD_AICE),y)
+OPENOCD_CONF_OPTS += --enable-aice
+endif
+
ifeq ($(BR2_PACKAGE_OPENOCD_VSLLINK),y)
OPENOCD_CONF_OPTS += --enable-vsllink
endif
+
+ifeq ($(BR2_PACKAGE_OPENOCD_USBPROG),y)
+OPENOCD_CONF_OPTS += --enable-usbprog
+endif
+
+ifeq ($(BR2_PACKAGE_OPENOCD_RLINK),y)
+OPENOCD_CONF_OPTS += --enable-rlink
+endif
+
+ifeq ($(BR2_PACKAGE_OPENOCD_ARMEW),y)
+OPENOCD_CONF_OPTS += --enable-armjtagew
+endif
+
+ifeq ($(BR2_PACKAGE_OPENOCD_CMSIS_DAP),y)
+OPENOCD_CONF_OPTS += --enable-cmsis-dap
+endif
+
+ifeq ($(BR2_PACKAGE_OPENOCD_PARPORT),y)
+OPENOCD_CONF_OPTS += --enable-parport
+endif
-HOST_OPENOCD_DEPENDENCIES = host-libusb-compat host-libftdi
+ifeq ($(BR2_PACKAGE_OPENOCD_FT2XXX),y)
+OPENOCD_CONF_OPTS += --enable-legacy-ft2232_libftdi
+endif
+
+ifeq ($(BR2_PACKAGE_OPENOCD_VPI),y)
+OPENOCD_CONF_OPTS += --enable-jtag_vpi
+endif
+
+ifeq ($(BR2_PACKAGE_OPENOCD_UBLASTER),y)
+OPENOCD_CONF_OPTS += --enable-usb_blaster_libftdi
+endif
+
+ifeq ($(BR2_PACKAGE_OPENOCD_AMTJT),y)
+OPENOCD_CONF_OPTS += --enable-amtjtagaccel
+endif
+
+ifeq ($(BR2_PACKAGE_OPENOCD_ZY1000_MASTER),y)
+OPENOCD_CONF_OPTS += --enable-zy1000-master
+endif
+
+ifeq ($(BR2_PACKAGE_OPENOCD_ZY1000),y)
+OPENOCD_CONF_OPTS += --enable-zy1000
+endif
+
+ifeq ($(BR2_PACKAGE_OPENOCD_EP93XX),y)
+OPENOCD_CONF_OPTS += --enable-ep93xx
+endif
+
+ifeq ($(BR2_PACKAGE_OPENOCD_AT91RM),y)
+OPENOCD_CONF_OPTS += --enable-at91rm9200
+endif
+
+ifeq ($(BR2_PACKAGE_OPENOCD_BCM2835),y)
+OPENOCD_CONF_OPTS += --enable-bcm2835gpio
+endif
+
+ifeq ($(BR2_PACKAGE_OPENOCD_GW16012),y)
+OPENOCD_CONF_OPTS += --enable-gw16012
+endif
+
+ifeq ($(BR2_PACKAGE_OPENOCD_PRESTO),y)
+OPENOCD_CONF_OPTS += --enable-presto_libftdi
+endif
+
+ifeq ($(BR2_PACKAGE_OPENOCD_OPENJTAG),y)
+OPENOCD_CONF_OPTS += --enable-openjtag_ftdi
+endif
+
+ifeq ($(BR2_PACKAGE_OPENOCD_BUSPIRATE),y)
+OPENOCD_CONF_OPTS += --enable-buspirate
+endif
+
+ifeq ($(BR2_PACKAGE_OPENOCD_SYSFS),y)
+OPENOCD_CONF_OPTS += --enable-sysfsgpio
+endif
-HOST_OPENOCD_CONF_OPTS = \
- --disable-doxygen-html \
- --enable-dummy \
- --enable-ft2232_libftdi \
- --enable-jlink \
- --enable-vsllink
+# enable all configuration options for host build to avoid duplicating
+# the very long selection logic made for target
+# we suppose that host compilation time and disk space is not a problem
+# (suggestion by Thomas Petazzoni)
+HOST_OPENOCD_CONF_OPTS = \
+ --enable-ftdi \
+ --enable-stlink \
+ --enable-ti-icdi \
+ --enable-ulink \
+ --enable-usb-blaster-2 \
+ --enable-jlink \
+ --enable-osbdm \
+ --enable-opendous \
+ --enable-aice \
+ --enable-vsllink \
+ --enable-usbprog \
+ --enable-rlink \
+ --enable-armjtagew \
+ --enable-cmsis-dap \
+ --enable-parport \
+ --enable-jtag_vpi \
+ --enable-usb_blaster_libftdi \
+ --enable-amtjtagaccel \
+ --enable-zy1000-master \
+ --enable-zy1000 \
+ --enable-gw16012 \
+ --enable-presto_libftdi \
+ --enable-openjtag_ftdi \
+ --enable-buspirate \
+ --enable-sysfsgpio
$(eval $(autotools-package))
$(eval $(host-autotools-package))
--
2.1.3
^ permalink raw reply related [flat|nested] 5+ messages in thread* [Buildroot] [PATCH v2] openocd 0.8.0
2014-11-30 20:35 [Buildroot] [PATCH v2] openocd 0.8.0 Claudio Laurita
@ 2014-12-03 17:20 ` Vicente Olivert Riera
2014-12-09 21:20 ` Ezequiel Garcia
1 sibling, 0 replies; 5+ messages in thread
From: Vicente Olivert Riera @ 2014-12-03 17:20 UTC (permalink / raw)
To: buildroot
Dear Claudio Laurita,
I think your patch does too many changes to have an empty git log.
Also, could you state in the title that you are bumping the version?
Something like "openocd: bump version to 0.8.0" for instance.
Best regards,
--
Vicente Olivert Riera
Graduate Software Engineer, MIPS Platforms
Imagination Technologies Limited
t: +44 (0)113 2429814
www.imgtec.com
^ permalink raw reply [flat|nested] 5+ messages in thread
* [Buildroot] [PATCH v2] openocd 0.8.0
2014-11-30 20:35 [Buildroot] [PATCH v2] openocd 0.8.0 Claudio Laurita
2014-12-03 17:20 ` Vicente Olivert Riera
@ 2014-12-09 21:20 ` Ezequiel Garcia
2014-12-10 19:08 ` Claudio Laurita
1 sibling, 1 reply; 5+ messages in thread
From: Ezequiel Garcia @ 2014-12-09 21:20 UTC (permalink / raw)
To: buildroot
Hi Claudio,
Shouldn't this patch have a proper commit log?
I have a question, see below.
On 11/30/2014 05:35 PM, Claudio Laurita wrote:
[..]
> -# Adapters
> -ifeq ($(BR2_PACKAGE_OPENOCD_FT2XXX),y)
> -OPENOCD_CONF_OPTS += --enable-ft2232_libftdi
> +ifeq ($(BR2_PACKAGE_LIBFTDI),y)
> OPENOCD_DEPENDENCIES += libftdi
> +HOST_OPENOCD_DEPENDENCIES += host-libftdi
> +endif
> +
Are you sure it's correct to tie a host dependency
to a target option?
A target symbol such as BR2_PACKAGE_LIBFTDI may not
be even selectable on a given target, so it would
affect the host option.
Also, even if BR2_PACKAGE_LIBFTDI can be selected,
it would mean I'm adding a library that I don't
really need to my target.
On the other side, the commit fails to build here:
(cd /home/zeta/buildroot/ciaa/output/build/host-openocd-0.8.0/ && rm -rf config.cache; PATH="/home/zeta/buildroot/ciaa/output/host/bin:/home/zeta/buildroot/ciaa/output/host/sbin:/home/zeta/buildroot/ciaa/output/host/usr/bin:/home/zeta/buildroot/ciaa/output/host/usr/sbin:/home/zeta/fast/depot_tools:/home/zeta/bin:/home/zeta/fast/depot_tools:/home/zeta/bin:/usr/local/sbin:/usr/local/bin:/usr/bin:/usr/bin/vendor_perl:/usr/bin/core_perl" AR="/usr/bin/ar" AS="/usr/bin/as" LD="/usr/bin/ld" NM="/usr/bin/nm" CC="/usr/bin/gcc" GCC="/usr/bin/gcc" CXX="/usr/bin/g++" CPP="/usr/bin/cpp" OBJCOPY="/usr/bin/objcopy" RANLIB="/usr/bin/ranlib" CPPFLAGS="-I/home/zeta/buildroot/ciaa/output/host/usr/include" CFLAGS="-O2 -I/home/zeta/buildroot/ciaa/output/host/usr/include" CXXFLAGS="-O2 -I/home/zeta/buildroot/ciaa/output/host/usr/include" LDFLAGS="-L/home/zeta/buildroot/ciaa/output/host/lib -L/home/zeta/buildroot/ciaa/output/host/usr/lib -Wl,-rpath,/home/zeta/buildroot/ciaa/output/host/usr/lib" PKG
_CONFIG_A
LLOW_SYSTEM_CFLAGS=1 PKG_CONFIG_ALLOW_SYSTEM_LIBS=1 PKG_CONFIG="/home/zeta/buildroot/ciaa/output/host/usr/bin/pkg-config" PKG_CONFIG_SYSROOT_DIR="/" PKG_CONFIG_LIBDIR="/home/zeta/buildroot/ciaa/output/host/usr/lib/pkgconfig:/home/zeta/buildroot/ciaa/output/host/usr/share/pkgconfig" LD_LIBRARY_PATH="/home/zeta/buildroot/ciaa/output/host/usr/lib:" CFLAGS="-O2 -I/home/zeta/buildroot/ciaa/output/host/usr/include" LDFLAGS="-L/home/zeta/buildroot/ciaa/output/host/lib -L/home/zeta/buildroot/ciaa/output/host/usr/lib -Wl,-rpath,/home/zeta/buildroot/ciaa/output/host/usr/lib" CONFIG_SITE=/dev/null ./configure --prefix="/home/zeta/buildroot/ciaa/output/host/usr" --sysconfdir="/home/zeta/buildroot/ciaa/output/host/etc" --localstatedir="/home/zeta/buildroot/ciaa/output/host/var" --enable-shared --disable-static --disable-gtk-doc --disable-doc --disable-docs --disable-documentation --disable-debug --with-xmlto=no --with-fop=no --disable-dependency-tracking --enable-ftdi --enable-stlink --
enable-ti
-icdi --enable-ulink --enable-usb-blaster-2 --enable-jlink --enable-osbdm --enable-opendous --enable-aice --enable-vsllink --enable-usbprog --enable-rlink --enable-armjtagew --enable-cmsis-dap --enable-parport --enable-jtag_vpi --enable-usb_blaster_libftdi --enable-amtjtagaccel --enable-zy1000-master --enable-zy1000 --enable-gw16012 --enable-presto_libftdi --enable-openjtag_ftdi --enable-buspirate --enable-sysfsgpio )
checking for a BSD-compatible install... /usr/bin/install -c
checking whether build environment is sane... yes
checking for a thread-safe mkdir -p... /usr/bin/mkdir -p
checking for gawk... gawk
checking whether make sets $(MAKE)... yes
checking whether make supports nested variables... yes
checking for gcc... /usr/bin/gcc
checking whether the C compiler works... yes
checking for C compiler default output file name... a.out
checking for suffix of executables...
checking whether we are cross compiling... no
checking for suffix of object files... o
checking whether we are using the GNU C compiler... yes
checking whether /usr/bin/gcc accepts -g... yes
checking for /usr/bin/gcc option to accept ISO C89... none needed
checking whether /usr/bin/gcc understands -c and -o together... yes
checking for style of include used by make... GNU
checking dependency style of /usr/bin/gcc... none
checking for /usr/bin/gcc option to accept ISO C99... -std=gnu99
checking for ranlib... /usr/bin/ranlib
checking pkg-config is at least version 0.23... yes
checking build system type... x86_64-unknown-linux-gnu
checking host system type... x86_64-unknown-linux-gnu
checking how to print strings... printf
checking for a sed that does not truncate output... /usr/bin/sed
checking for grep that handles long lines and -e... /usr/bin/grep
checking for egrep... /usr/bin/grep -E
checking for fgrep... /usr/bin/grep -F
checking for ld used by /usr/bin/gcc -std=gnu99... /usr/bin/ld
checking if the linker (/usr/bin/ld) is GNU ld... yes
checking for BSD- or MS-compatible name lister (nm)... /usr/bin/nm
checking the name lister (/usr/bin/nm) interface... BSD nm
checking whether ln -s works... yes
checking the maximum length of command line arguments... 1572864
checking whether the shell understands some XSI constructs... yes
checking whether the shell understands "+="... yes
checking how to convert x86_64-unknown-linux-gnu file names to x86_64-unknown-linux-gnu format... func_convert_file_noop
checking how to convert x86_64-unknown-linux-gnu file names to toolchain format... func_convert_file_noop
checking for /usr/bin/ld option to reload object files... -r
checking for objdump... objdump
checking how to recognize dependent libraries... pass_all
checking for dlltool... no
checking how to associate runtime and link libraries... printf %s\n
checking for archiver @FILE support... @
checking for strip... strip
checking for ranlib... (cached) /usr/bin/ranlib
checking command to parse /usr/bin/nm output from /usr/bin/gcc -std=gnu99 object... ok
checking for sysroot... no
checking for mt... no
checking if : is a manifest tool... no
checking how to run the C preprocessor... /usr/bin/cpp
checking for ANSI C header files... yes
checking for sys/types.h... yes
checking for sys/stat.h... yes
checking for stdlib.h... yes
checking for string.h... yes
checking for memory.h... yes
checking for strings.h... yes
checking for inttypes.h... yes
checking for stdint.h... yes
checking for unistd.h... yes
checking for dlfcn.h... yes
checking for objdir... .libs
checking if /usr/bin/gcc -std=gnu99 supports -fno-rtti -fno-exceptions... no
checking for /usr/bin/gcc -std=gnu99 option to produce PIC... -fPIC -DPIC
checking if /usr/bin/gcc -std=gnu99 PIC flag -fPIC -DPIC works... yes
checking if /usr/bin/gcc -std=gnu99 static flag -static works... yes
checking if /usr/bin/gcc -std=gnu99 supports -c -o file.o... yes
checking if /usr/bin/gcc -std=gnu99 supports -c -o file.o... (cached) yes
checking whether the /usr/bin/gcc -std=gnu99 linker (/usr/bin/ld -m elf_x86_64) supports shared libraries... yes
checking whether -lc should be explicitly linked in... no
checking dynamic linker characteristics... GNU/Linux ld.so
checking how to hardcode library paths into programs... immediate
checking whether stripping libraries is possible... yes
checking if libtool supports shared libraries... yes
checking whether to build shared libraries... yes
checking whether to build static libraries... no
checking for an ANSI C-conforming const... yes
checking for unsigned long long int... yes
checking for long long int... yes
checking for library containing ioperm... none required
checking for library containing dlopen... -ldl
checking sys/socket.h usability... yes
checking sys/socket.h presence... yes
checking for sys/socket.h... yes
checking for arpa/inet.h... yes
checking elf.h usability... yes
checking elf.h presence... yes
checking for elf.h... yes
checking dirent.h usability... yes
checking dirent.h presence... yes
checking for dirent.h... yes
checking fcntl.h usability... yes
checking fcntl.h presence... yes
checking for fcntl.h... yes
checking for ifaddrs.h... yes
checking malloc.h usability... yes
checking malloc.h presence... yes
checking for malloc.h... yes
checking netdb.h usability... yes
checking netdb.h presence... yes
checking for netdb.h... yes
checking for netinet/in.h... yes
checking for netinet/tcp.h... yes
checking pthread.h usability... yes
checking pthread.h presence... yes
checking for pthread.h... yes
checking for strings.h... (cached) yes
checking sys/ioctl.h usability... yes
checking sys/ioctl.h presence... yes
checking for sys/ioctl.h... yes
checking sys/param.h usability... yes
checking sys/param.h presence... yes
checking for sys/param.h... yes
checking sys/poll.h usability... yes
checking sys/poll.h presence... yes
checking for sys/poll.h... yes
checking sys/select.h usability... yes
checking sys/select.h presence... yes
checking for sys/select.h... yes
checking for sys/stat.h... (cached) yes
checking sys/time.h usability... yes
checking sys/time.h presence... yes
checking for sys/time.h... yes
checking for sys/types.h... (cached) yes
checking for unistd.h... (cached) yes
checking for net/if.h... yes
checking whether to enable assertions... yes
checking for stdbool.h that conforms to C99... yes
checking for _Bool... yes
checking whether time.h and sys/time.h may both be included... yes
checking whether byte ordering is bigendian... no
checking for strndup... yes
checking for strnlen... yes
checking for gettimeofday... yes
checking for usleep... yes
checking for vasprintf... yes
checking whether to build a release... yes
checking whether to build Doxygen as HTML... yes
checking whether to build Doxygen as PDF... no
checking whether to enable verbose JTAG I/O messages... no
checking whether to enable verbose USB I/O messages... no
checking whether to enable verbose USB communication messages... no
checking whether to enable malloc free space logging... no
checking whether to enable ZY1000 minidriver... yes
checking whether to enable dummy minidriver... no
checking whether standard drivers can be built... no
configure: WARNING: Using the minidriver disables all other drivers.
checking for LIBFTDI... no
checking for LIBFTDI... yes
checking Build & Link with libftdi...... Success
checking for libftdi highspeed device support... yes
checking for libftdi FT232H device support... no
configure: WARNING: You need a newer libftdi version (0.20 or later).
checking for LIBUSB1... yes
configure: libusb-1.0 header bug workaround: LIBUSB1_CFLAGS changed to "-isystem /home/zeta/buildroot/ciaa/output/host/usr/include/libusb-1.0"
checking for LIBUSB0... yes
checking for HIDAPI... no
checking for HIDAPI... no
checking for HIDAPI... no
configure: error: hidapi is required for the CMSIS-DAP Compliant Debugger
package/pkg-generic.mk:167: recipe for target '/home/zeta/buildroot/ciaa/output/build/host-openocd-0.8.0/.stamp_configured' failed
make: *** [/home/zeta/buildroot/ciaa/output/build/host-openocd-0.8.0/.stamp_configured] Error 1
$ cat defconfig
BR2_arm=y
BR2_arm920t=y
BR2_TOOLCHAIN_EXTERNAL=y
# BR2_USE_MMU is not set
BR2_PACKAGE_OPENOCD=y
BR2_PACKAGE_LIBFTDI=y
BR2_PACKAGE_ZLOG=y
# BR2_TARGET_ROOTFS_TAR is not set
BR2_PACKAGE_HOST_OPENOCD=y
Any chance we bump openocd with a less invasive patch?
--
Ezequiel Garcia, VanguardiaSur
www.vanguardiasur.com.ar
^ permalink raw reply [flat|nested] 5+ messages in thread
* [Buildroot] [PATCH v2] openocd 0.8.0
2014-12-09 21:20 ` Ezequiel Garcia
@ 2014-12-10 19:08 ` Claudio Laurita
2014-12-10 20:15 ` Ezequiel Garcia
0 siblings, 1 reply; 5+ messages in thread
From: Claudio Laurita @ 2014-12-10 19:08 UTC (permalink / raw)
To: buildroot
Il 09/12/2014 22:20, Ezequiel Garcia ha scritto:
> Hi Claudio,
>
> Shouldn't this patch have a proper commit log?
Hi Ezequiel
thank you for your comments.
This is my first "official" proposal, so, please, guide me through the
right "formal" steps.
I simply followed the instructions found in the manual. Anything missing
is something I didn't understand (or I forgot).
I have a folder with the master git clone, put my new files there,
commit them (locally) and format a patch.
Maybe this is not the right way to go, so, any suggestion to fill the
missing pieces is welcome.
>
> I have a question, see below.
>
> On 11/30/2014 05:35 PM, Claudio Laurita wrote:
> [..]
>> -# Adapters
>> -ifeq ($(BR2_PACKAGE_OPENOCD_FT2XXX),y)
>> -OPENOCD_CONF_OPTS += --enable-ft2232_libftdi
>> +ifeq ($(BR2_PACKAGE_LIBFTDI),y)
>> OPENOCD_DEPENDENCIES += libftdi
>> +HOST_OPENOCD_DEPENDENCIES += host-libftdi
>> +endif
>> +
> Are you sure it's correct to tie a host dependency
> to a target option?
Absolutely not.
It's a mistake that I only partially corrected from the first version of
the patch.
Originally I assumed that the host part was to be built with the same
options of the target part.
Thomas Petazzoni pointed out this bad mistake, but I forgot to correct
this part. Sorry.
> On the other side, the commit fails to build here:
>
> configure: error: hidapi is required for the CMSIS-DAP Compliant Debugger
> package/pkg-generic.mk:167: recipe for target '/home/zeta/buildroot/ciaa/output/build/host-openocd-0.8.0/.stamp_configured' failed
> make: *** [/home/zeta/buildroot/ciaa/output/build/host-openocd-0.8.0/.stamp_configured] Error 1
I really apologize for that. The host part is a disaster.
I was totally concentrated on the target part. Shame on me.
> Any chance we bump openocd with a less invasive patch?
I really didn't want to be invasive, trust me.
But the actual package recipe manages only a minimal part of the options
offered, even at the time of version 5.
I simply tried to make a full recipe to exploit all the actual potential
of the package, as I needed it for my project.
Maybe it's not a good idea. Let's talk about that and find the right way
to go.
But note that the deleted package patches are simply useless with the
actual code, so they are to be deleted anyway. And this is a very big
part of the patch.
I will try to clean all the mistakes in the host part and submit a third
version of the patch in a couple of days.
Claudio
^ permalink raw reply [flat|nested] 5+ messages in thread
* [Buildroot] [PATCH v2] openocd 0.8.0
2014-12-10 19:08 ` Claudio Laurita
@ 2014-12-10 20:15 ` Ezequiel Garcia
0 siblings, 0 replies; 5+ messages in thread
From: Ezequiel Garcia @ 2014-12-10 20:15 UTC (permalink / raw)
To: buildroot
On 12/10/2014 04:08 PM, Claudio Laurita wrote:
> Il 09/12/2014 22:20, Ezequiel Garcia ha scritto:
>> Hi Claudio,
>>
>> Shouldn't this patch have a proper commit log?
> Hi Ezequiel
> thank you for your comments.
> This is my first "official" proposal, so, please, guide me through the
> right "formal" steps.
As far as I can see, the patch was more or less OK.
You only needed a nice commit log. Maybe you can take a look at other
patches being sent to the mailing list and see how that's done.
[..]
>> Are you sure it's correct to tie a host dependency
>> to a target option?
> Absolutely not.
> It's a mistake that I only partially corrected from the first version of
> the patch.
> Originally I assumed that the host part was to be built with the same
> options of the target part.
> Thomas Petazzoni pointed out this bad mistake, but I forgot to correct
> this part. Sorry.
Sure, no problem. It's normal to make mistakes, don't be so hard on yourself.
>> On the other side, the commit fails to build here:
>>
>> configure: error: hidapi is required for the CMSIS-DAP Compliant Debugger
>> package/pkg-generic.mk:167: recipe for target
>> '/home/zeta/buildroot/ciaa/output/build/host-openocd-0.8.0/.stamp_configured'
>> failed
>> make: ***
>> [/home/zeta/buildroot/ciaa/output/build/host-openocd-0.8.0/.stamp_configured]
>> Error 1
> I really apologize for that. The host part is a disaster.
> I was totally concentrated on the target part. Shame on me.
>
No problem.
>> Any chance we bump openocd with a less invasive patch?
> I really didn't want to be invasive, trust me.
> But the actual package recipe manages only a minimal part of the options
> offered, even at the time of version 5.
> I simply tried to make a full recipe to exploit all the actual potential
> of the package, as I needed it for my project.
> Maybe it's not a good idea. Let's talk about that and find the right way
> to go.
> But note that the deleted package patches are simply useless with the
> actual code, so they are to be deleted anyway. And this is a very big
> part of the patch.
>
> I will try to clean all the mistakes in the host part and submit a third
> version of the patch in a couple of days.
That sounds great. Maybe you can begin with a simpler patch and work
from there.
If you Cc me, I can give you a hand testing your work.
--
Ezequiel Garcia, VanguardiaSur
www.vanguardiasur.com.ar
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2014-12-10 20:15 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-11-30 20:35 [Buildroot] [PATCH v2] openocd 0.8.0 Claudio Laurita
2014-12-03 17:20 ` Vicente Olivert Riera
2014-12-09 21:20 ` Ezequiel Garcia
2014-12-10 19:08 ` Claudio Laurita
2014-12-10 20:15 ` Ezequiel Garcia
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox