* [Buildroot] [PATCH 1/1] util-linux: rename patches to follow the new name convention
@ 2014-12-10 13:14 Karoly Kasza
2014-12-10 15:11 ` Vicente Olivert Riera
2014-12-10 20:23 ` Thomas Petazzoni
0 siblings, 2 replies; 6+ messages in thread
From: Karoly Kasza @ 2014-12-10 13:14 UTC (permalink / raw)
To: buildroot
Signed-off-by: Karoly Kasza <kaszak@gmail.com>
---
...{util-linux-001-sscanf-no-ms-as.patch => 001-sscanf-no-ms-as.patch} | 0
...cation-short-name.patch => 002-program-invocation-short-name.patch} | 0
...patch => 003-c.h-define-mkostemp-for-older-version-of-uClibc.patch} | 0
3 files changed, 0 insertions(+), 0 deletions(-)
rename package/util-linux/{util-linux-001-sscanf-no-ms-as.patch => 001-sscanf-no-ms-as.patch} (100%)
rename package/util-linux/{util-linux-002-program-invocation-short-name.patch => 002-program-invocation-short-name.patch} (100%)
rename package/util-linux/{util-linux-003-c.h-define-mkostemp-for-older-version-of-uClibc.patch => 003-c.h-define-mkostemp-for-older-version-of-uClibc.patch} (100%)
diff --git a/package/util-linux/util-linux-001-sscanf-no-ms-as.patch b/package/util-linux/001-sscanf-no-ms-as.patch
similarity index 100%
rename from package/util-linux/util-linux-001-sscanf-no-ms-as.patch
rename to package/util-linux/001-sscanf-no-ms-as.patch
diff --git a/package/util-linux/util-linux-002-program-invocation-short-name.patch b/package/util-linux/002-program-invocation-short-name.patch
similarity index 100%
rename from package/util-linux/util-linux-002-program-invocation-short-name.patch
rename to package/util-linux/002-program-invocation-short-name.patch
diff --git a/package/util-linux/util-linux-003-c.h-define-mkostemp-for-older-version-of-uClibc.patch b/package/util-linux/003-c.h-define-mkostemp-for-older-version-of-uClibc.patch
similarity index 100%
rename from package/util-linux/util-linux-003-c.h-define-mkostemp-for-older-version-of-uClibc.patch
rename to package/util-linux/003-c.h-define-mkostemp-for-older-version-of-uClibc.patch
--
1.7.10.4
^ permalink raw reply [flat|nested] 6+ messages in thread* [Buildroot] [PATCH 1/1] util-linux: rename patches to follow the new name convention
2014-12-10 13:14 [Buildroot] [PATCH 1/1] util-linux: rename patches to follow the new name convention Karoly Kasza
@ 2014-12-10 15:11 ` Vicente Olivert Riera
2014-12-10 15:21 ` Károly Kasza
2014-12-10 20:23 ` Thomas Petazzoni
1 sibling, 1 reply; 6+ messages in thread
From: Vicente Olivert Riera @ 2014-12-10 15:11 UTC (permalink / raw)
To: buildroot
Dear Karoly Kasza,
the new name convention says the patches should be prefixes with a
4-digit number. So, 0001 instead of 001, etc.
Could you please fix that and resend your patch? Thanks.
Best regards,
--
Vicente Olivert Riera
Graduate Software Engineer, MIPS Platforms
Imagination Technologies Limited
t: +44 (0)113 2429814
www.imgtec.com
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH 1/1] util-linux: rename patches to follow the new name convention
2014-12-10 15:11 ` Vicente Olivert Riera
@ 2014-12-10 15:21 ` Károly Kasza
2014-12-10 15:26 ` Vicente Olivert Riera
0 siblings, 1 reply; 6+ messages in thread
From: Károly Kasza @ 2014-12-10 15:21 UTC (permalink / raw)
To: buildroot
Hi,
Sorry, I missed it.
Wouldn't be better to do all packages in one run of "git mv"-s? I recall
seeing some patch (possibly from Peter) doing that on the near past?
On Wed, Dec 10, 2014 at 4:11 PM, Vicente Olivert Riera <
Vincent.Riera@imgtec.com> wrote:
> Dear Karoly Kasza,
>
> the new name convention says the patches should be prefixes with a
> 4-digit number. So, 0001 instead of 001, etc.
>
> Could you please fix that and resend your patch? Thanks.
>
> Best regards,
> --
> Vicente Olivert Riera
> Graduate Software Engineer, MIPS Platforms
> Imagination Technologies Limited
> t: +44 (0)113 2429814
> www.imgtec.com
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
>
--
?dv,
KK
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20141210/05333d41/attachment.html>
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH 1/1] util-linux: rename patches to follow the new name convention
2014-12-10 15:21 ` Károly Kasza
@ 2014-12-10 15:26 ` Vicente Olivert Riera
2014-12-10 22:22 ` Yann E. MORIN
0 siblings, 1 reply; 6+ messages in thread
From: Vicente Olivert Riera @ 2014-12-10 15:26 UTC (permalink / raw)
To: buildroot
Dear K?roly Kasza,
On 12/10/2014 03:21 PM, K?roly Kasza wrote:
> Wouldn't be better to do all packages in one run of "git mv"-s?
I'm not sure, because there are lots of patches in the patchwork queue
which may be touch some package-patches, so if you send a patch to
rename all package-patches for all buildroot packages, there could be
lots of patches that couldn't be applied as they are. I think it's
better to fix one package at a time, but that's only my opinion, I could
be wrong.
Best regards,
--
Vicente Olivert Riera
Graduate Software Engineer, MIPS Platforms
Imagination Technologies Limited
t: +44 (0)113 2429814
www.imgtec.com
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH 1/1] util-linux: rename patches to follow the new name convention
2014-12-10 15:26 ` Vicente Olivert Riera
@ 2014-12-10 22:22 ` Yann E. MORIN
0 siblings, 0 replies; 6+ messages in thread
From: Yann E. MORIN @ 2014-12-10 22:22 UTC (permalink / raw)
To: buildroot
Vicente, All,
On 2014-12-10 15:26 +0000, Vicente Olivert Riera spake thusly:
> On 12/10/2014 03:21 PM, K?roly Kasza wrote:
> > Wouldn't be better to do all packages in one run of "git mv"-s?
Yes, there's a patch from Samuel doing that with a (Python!) script.
> I'm not sure, because there are lots of patches in the patchwork queue
> which may be touch some package-patches, so if you send a patch to
> rename all package-patches for all buildroot packages, there could be
> lots of patches that couldn't be applied as they are. I think it's
> better to fix one package at a time, but that's only my opinion, I could
> be wrong.
Well, except if one really want to bust his number of commits, there is
no reason to do so.
Yesterday during the Patchwork cleanup session, Peter agreed on using
Samuel's script to rename all patches in one go.
Regards,
Yann E. MORIN.
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH 1/1] util-linux: rename patches to follow the new name convention
2014-12-10 13:14 [Buildroot] [PATCH 1/1] util-linux: rename patches to follow the new name convention Karoly Kasza
2014-12-10 15:11 ` Vicente Olivert Riera
@ 2014-12-10 20:23 ` Thomas Petazzoni
1 sibling, 0 replies; 6+ messages in thread
From: Thomas Petazzoni @ 2014-12-10 20:23 UTC (permalink / raw)
To: buildroot
Dear Karoly Kasza,
On Wed, 10 Dec 2014 14:14:09 +0100, Karoly Kasza wrote:
>
> Signed-off-by: Karoly Kasza <kaszak@gmail.com>
> ---
> ...{util-linux-001-sscanf-no-ms-as.patch => 001-sscanf-no-ms-as.patch} | 0
> ...cation-short-name.patch => 002-program-invocation-short-name.patch} | 0
> ...patch => 003-c.h-define-mkostemp-for-older-version-of-uClibc.patch} | 0
> 3 files changed, 0 insertions(+), 0 deletions(-)
Thanks, but Gustavo also sent another similar patch, which included a
fix for a CVE security issue, so I took Gustavo's patch instead.
Thanks!
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2014-12-10 22:22 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-12-10 13:14 [Buildroot] [PATCH 1/1] util-linux: rename patches to follow the new name convention Karoly Kasza
2014-12-10 15:11 ` Vicente Olivert Riera
2014-12-10 15:21 ` Károly Kasza
2014-12-10 15:26 ` Vicente Olivert Riera
2014-12-10 22:22 ` Yann E. MORIN
2014-12-10 20:23 ` Thomas Petazzoni
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox