[Buildroot] [PATCH V2] dvd+rw-tools: new package

[Buildroot] [PATCH V2] dvd+rw-tools: new package

[Steve Kenton]

The dvd+rw-tools are used to master Blu-ray Disc
and DVD Disc media, both +RW/+R and -RW/-R. The
+RW in the name is a historical artifact. This
package contains the widely used growisofs program.
	
http://fy.chalmers.se/~appro/linux/DVD+RW/tools

Signed-off-by Stephen M. Kenton <skenton@ou.edu>
---
V2 - added the licensing information
Build tested with both uClibc and glibc against last nights snapshot

uClibc make savedefconfig
BR2_PACKAGE_DVDRW_TOOLS=y

glibc make savedefconfig
BR2_TOOLCHAIN_BUILDROOT_GLIBC=y
BR2_PACKAGE_DVDRW_TOOLS=y

diff -pruN buildroot.ori/package/Config.in buildroot/package/Config.in
--- buildroot.ori/package/Config.in	2015-01-15 02:41:42.000000000 -0600
+++ buildroot/package/Config.in	2015-01-16 19:05:22.878144144 -0600
@@ -7,6 +7,7 @@ menu "Audio and video applications"
 	source "package/aumix/Config.in"
 	source "package/bellagio/Config.in"
 	source "package/dvdauthor/Config.in"
+	source "package/dvdrw-tools/Config.in"
 	source "package/espeak/Config.in"
 	source "package/faad2/Config.in"
 	source "package/ffmpeg/Config.in"
diff -pruN buildroot.ori/package/dvdrw-tools/0001-limits.h.patch buildroot/package/dvdrw-tools/0001-limits.h.patch
--- buildroot.ori/package/dvdrw-tools/0001-limits.h.patch	1969-12-31 18:00:00.000000000 -0600
+++ buildroot/package/dvdrw-tools/0001-limits.h.patch	2015-01-16 19:04:53.170143574 -0600
@@ -0,0 +1,12 @@
+diff -ru dvd+rw-tools-7.1.clean/transport.hxx dvd+rw-tools-7.1.modified/transport.hxx
+--- dvd+rw-tools-7.1.clean/transport.hxx	2008-03-01 04:34:43.000000000 -0600
++++ dvd+rw-tools-7.1.modified/transport.hxx	2014-12-16 16:34:04.208459745 -0600
+@@ -9,6 +9,7 @@
+ #if defined(__unix) || defined(__unix__)
+ #include <stdio.h>
+ #include <stdlib.h>
++#include <limits.h>
+ #include <unistd.h>
+ #include <string.h>
+ #include <sys/types.h>
+
diff -pruN buildroot.ori/package/dvdrw-tools/Config.in buildroot/package/dvdrw-tools/Config.in
--- buildroot.ori/package/dvdrw-tools/Config.in	1969-12-31 18:00:00.000000000 -0600
+++ buildroot/package/dvdrw-tools/Config.in	2015-01-16 19:04:53.170143574 -0600
@@ -0,0 +1,9 @@
+config BR2_PACKAGE_DVDRW_TOOLS
+	bool "dvdrw-tools"
+	help
+	  The dvd+rw-tools are used to master Blu-ray Disc
+	  and DVD Disc media, both +RW/+R and -RW/-R. The
+	  +RW in the name is a historical artifact. This
+	  package contains the widely used growisofs program.
+	
+	  http://fy.chalmers.se/~appro/linux/DVD+RW/tools
diff -pruN buildroot.ori/package/dvdrw-tools/dvdrw-tools.mk buildroot/package/dvdrw-tools/dvdrw-tools.mk
--- buildroot.ori/package/dvdrw-tools/dvdrw-tools.mk	1969-12-31 18:00:00.000000000 -0600
+++ buildroot/package/dvdrw-tools/dvdrw-tools.mk	2015-01-16 19:04:53.170143574 -0600
@@ -0,0 +1,24 @@
+#############################################################
+#
+# dvdrw-tools
+#
+#############################################################
+DVDRW_TOOLS_VERSION = 7.1
+DVDRW_TOOLS_SOURCE = dvd+rw-tools-$(DVDRW_TOOLS_VERSION).tar.gz
+DVDRW_TOOLS_SITE = http://fy.chalmers.se/~appro/linux/DVD+RW/tools
+DVDRW_TOOLS_LICENSE = GPLv2
+DVDRW_TOOLS_LICENSE_FILES = LICENSE
+
+define DVDRW_TOOLS_BUILD_CMDS
+	$(MAKE) -C $(@D)
+endef
+
+define DVDRW_TOOLS_INSTALL_TARGET_CMDS
+	$(INSTALL) -m 0755 -D $(@D)/dvd-ram-control $(TARGET_DIR)/usr/bin/dvd-ram-control
+	$(INSTALL) -m 0755 -D $(@D)/dvd+rw-booktype $(TARGET_DIR)/usr/bin/dvd+rw-booktype
+	$(INSTALL) -m 0755 -D $(@D)/dvd+rw-format $(TARGET_DIR)/usr/bin/dvd+rw-format
+	$(INSTALL) -m 0755 -D $(@D)/dvd+rw-mediainfo $(TARGET_DIR)/usr/bin/dvd+rw-mediainfo
+	$(INSTALL) -m 0755 -D $(@D)/growisofs $(TARGET_DIR)/usr/bin/growisofs
+endef
+
+$(eval $(generic-package))

[Buildroot] [PATCH V2] dvd+rw-tools: new package

[Bernd Kuhls]

[posted and mailed]

Steve Kenton <skenton@ou.edu> wrote in 
news:54B9B774.9030204 at ou.edu:

> +     $(INSTALL) -m 0755 -D $(@D)/growisofs $(TARGET_DIR)/usr/bin/growisofs
> +endef

Hi,

according to Beyond Linux From Scratch you need libisoburn or a similar 
package which provides xorrisofs, otherwise "the growisofs command will not 
function properly"
http://www.linuxfromscratch.org/blfs/view/svn/multimedia/dvd-rw-tools.html

Did your package work without xorrisofs during your tests?

Regards, Bernd

[Buildroot] [PATCH V2] dvd+rw-tools: new package

[Steve Kenton]

On 01/17/2015 12:22 PM, Bernd Kuhls wrote:
> according to Beyond Linux From Scratch you need libisoburn or a similar 
> package which provides xorrisofs, otherwise "the growisofs command will not 
> function properly"
> http://www.linuxfromscratch.org/blfs/view/svn/multimedia/dvd-rw-tools.html
> 
> Did your package work without xorrisofs during your tests?
> 
> Regards, Bernd
I was working on xorriso, dvdauthor, dvd+rw-tools and mjpegtools simultaneously
for my embedded project. Once they all worked I cleaned them up for submission.
GNU Xorriso includes all the libburnia libraries as well as the xorriso burner program.
FYI - Xorriso and dvdauthor were just committed. I did not think to check for hidden runtime
dependencies when I was working up the submission for those four packages individually. I just
worked on getting each of them to build in a clean buildroot snapshot for both uClibc and glibc.

If it was not a feature that I needed for my project right then it probably did not get
run time tested. So I can well believe there may be other dependencies that I did not discover.
Thanks for the tip, I'll try it out stand-alone and see what I find.

Steve

[Buildroot] [PATCH V2] dvd+rw-tools: new package

[Steve Kenton]

> 
> according to Beyond Linux From Scratch you need libisoburn or a similar 
> package which provides xorrisofs, otherwise "the growisofs command will not 
> function properly"
> http://www.linuxfromscratch.org/blfs/view/svn/multimedia/dvd-rw-tools.html

I look at the LFS information again and it brings up another points. Linux From
Scratch patches dvd+rw-tools to replace mkisofs from the cdrtools package
with xorrisofs from GNU xorriso.

I have also been experimenting with the cdrtools 3.01 pre-release package.
The controversy about whether the CDDL license is GPL compatible is beyond
me. Would the buildroot project be likely to accept a cdrtools submission
or should I also patch dvd+rw-tools to to use the xorriso equivalents to the
cdrtools programs? I missed that and need to do one or the other I guess.

FYI xorriso does not do UDF and cdrtools apparently does.

Steve

[Buildroot] [PATCH V2] dvd+rw-tools: new package

[Yann E. MORIN]

Steve, All,

On 2015-01-17 22:23 -0600, Steve Kenton spake thusly:
> > according to Beyond Linux From Scratch you need libisoburn or a similar 
> > package which provides xorrisofs, otherwise "the growisofs command will not 
> > function properly"
> > http://www.linuxfromscratch.org/blfs/view/svn/multimedia/dvd-rw-tools.html
> 
> I look at the LFS information again and it brings up another points. Linux From
> Scratch patches dvd+rw-tools to replace mkisofs from the cdrtools package
> with xorrisofs from GNU xorriso.
> 
> I have also been experimenting with the cdrtools 3.01 pre-release package.
> The controversy about whether the CDDL license is GPL compatible is beyond
> me. Would the buildroot project be likely to accept a cdrtools submission
> or should I also patch dvd+rw-tools to to use the xorriso equivalents to the
> cdrtools programs? I missed that and need to do one or the other I guess.

Well, we do not try to resolve license dependencies and/or incompatibilities.
We are not lawyers, so we lack the knowledge to do so.

Instead, we just list the licenses, and leave out to the user (or their
legal team) to sort out such incompatibilities, should they believe
there are.

So, my suggestion would be to just list the licenses as exhaustively as
possible, and be done with that.

So yes, we'd accept such a package. ;-)

Regards,
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'