Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Romain Naour <romain.naour@openwide.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] infozip: fix compilation with LARGE_FILE_SUPPORT
Date: Fri, 23 Jan 2015 00:43:25 +0100	[thread overview]
Message-ID: <54C18B1D.6030206@openwide.fr> (raw)
In-Reply-To: <20150120174108.5a6ecd37@free-electrons.com>

Richard, Thomas,

Le 20/01/2015 17:41, Thomas Petazzoni a ?crit :
> Dear Richard Genoud,
> 
> On Tue, 20 Jan 2015 11:16:02 +0100, Richard Genoud wrote:
> 
>> +INFOZIP_CFLAGS = -I. -DUNIX
>> +
>> +ifeq ($(BR2_LARGEFILE),y)
>> +INFOZIP_CFLAGS += -DLARGE_FILE_SUPPORT
>> +endif
> 
> Things are not really clear: the INSTALL file from infozip says:
> 
>     This flag should be set automatically on Unix, Win32, and some
>     other ports.  Setting NO_LARGE_FILE_SUPPORT turns this flag off.
> 
> So according to this, it should not be necessary to set this flag
> explicitly. However, after a quick look at the unix/configure script, I
> haven't seen any logic doing this. Can you confirm?
> 
> Thanks,
> 
> Thomas
> 

Sorry, I made a mistake in commit cc4dedd9...

This week I updated from 2013.08 to 2014.11 and I had a runtime error with zip:
"zip warning : Not supported (uzoff_t not same size as zoff_t)"

I'm sending a series to fit this.

Best regards,
Romain Naour

      reply	other threads:[~2015-01-22 23:43 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-20 10:16 [Buildroot] [PATCH] infozip: fix compilation with LARGE_FILE_SUPPORT Richard Genoud
2015-01-20 16:41 ` Thomas Petazzoni
2015-01-22 23:43   ` Romain Naour [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54C18B1D.6030206@openwide.fr \
    --to=romain.naour@openwide.fr \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox