Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] infozip: fix compilation with LARGE_FILE_SUPPORT
Date: Tue, 20 Jan 2015 17:41:08 +0100	[thread overview]
Message-ID: <20150120174108.5a6ecd37@free-electrons.com> (raw)
In-Reply-To: <1421748962-838-1-git-send-email-richard.genoud@gmail.com>

Dear Richard Genoud,

On Tue, 20 Jan 2015 11:16:02 +0100, Richard Genoud wrote:

> +INFOZIP_CFLAGS = -I. -DUNIX
> +
> +ifeq ($(BR2_LARGEFILE),y)
> +INFOZIP_CFLAGS += -DLARGE_FILE_SUPPORT
> +endif

Things are not really clear: the INSTALL file from infozip says:

    This flag should be set automatically on Unix, Win32, and some
    other ports.  Setting NO_LARGE_FILE_SUPPORT turns this flag off.

So according to this, it should not be necessary to set this flag
explicitly. However, after a quick look at the unix/configure script, I
haven't seen any logic doing this. Can you confirm?

Thanks,

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

  reply	other threads:[~2015-01-20 16:41 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-20 10:16 [Buildroot] [PATCH] infozip: fix compilation with LARGE_FILE_SUPPORT Richard Genoud
2015-01-20 16:41 ` Thomas Petazzoni [this message]
2015-01-22 23:43   ` Romain Naour

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150120174108.5a6ecd37@free-electrons.com \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox