[Buildroot] [PATCH] infozip: fix compilation with LARGE_FILE_SUPPORT

[Buildroot] [PATCH] infozip: fix compilation with LARGE_FILE_SUPPORT

[Richard Genoud]

Signed-off-by: Richard Genoud <richard.genoud@gmail.com>
---
 package/infozip/infozip.mk | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/package/infozip/infozip.mk b/package/infozip/infozip.mk
index 229299c52f11..d857df6dd3e9 100644
--- a/package/infozip/infozip.mk
+++ b/package/infozip/infozip.mk
@@ -14,9 +14,15 @@ ifeq ($(BR2_PACKAGE_BZIP2),y)
 INFOZIP_DEPENDENCIES += bzip2
 endif
 
+INFOZIP_CFLAGS = -I. -DUNIX
+
+ifeq ($(BR2_LARGEFILE),y)
+INFOZIP_CFLAGS += -DLARGE_FILE_SUPPORT
+endif
+
 define INFOZIP_BUILD_CMDS
 	$(MAKE) $(TARGET_CONFIGURE_OPTS) -C $(@D) \
-		CFLAGS="$(TARGET_CFLAGS) -I. -DUNIX" \
+		CFLAGS="$(TARGET_CFLAGS) $(INFOZIP_CFLAGS)" \
 		AS="$(TARGET_CC) -c" \
 		-f unix/Makefile generic
 endef
-- 
2.0.0

[Buildroot] [PATCH] infozip: fix compilation with LARGE_FILE_SUPPORT

[Thomas Petazzoni]

Dear Richard Genoud,

On Tue, 20 Jan 2015 11:16:02 +0100, Richard Genoud wrote:

> +INFOZIP_CFLAGS = -I. -DUNIX
> +
> +ifeq ($(BR2_LARGEFILE),y)
> +INFOZIP_CFLAGS += -DLARGE_FILE_SUPPORT
> +endif

Things are not really clear: the INSTALL file from infozip says:

    This flag should be set automatically on Unix, Win32, and some
    other ports.  Setting NO_LARGE_FILE_SUPPORT turns this flag off.

So according to this, it should not be necessary to set this flag
explicitly. However, after a quick look at the unix/configure script, I
haven't seen any logic doing this. Can you confirm?

Thanks,

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

[Buildroot] [PATCH] infozip: fix compilation with LARGE_FILE_SUPPORT

[Romain Naour]

Richard, Thomas,

Le 20/01/2015 17:41, Thomas Petazzoni a ?crit :
> Dear Richard Genoud,
> 
> On Tue, 20 Jan 2015 11:16:02 +0100, Richard Genoud wrote:
> 
>> +INFOZIP_CFLAGS = -I. -DUNIX
>> +
>> +ifeq ($(BR2_LARGEFILE),y)
>> +INFOZIP_CFLAGS += -DLARGE_FILE_SUPPORT
>> +endif
> 
> Things are not really clear: the INSTALL file from infozip says:
> 
>     This flag should be set automatically on Unix, Win32, and some
>     other ports.  Setting NO_LARGE_FILE_SUPPORT turns this flag off.
> 
> So according to this, it should not be necessary to set this flag
> explicitly. However, after a quick look at the unix/configure script, I
> haven't seen any logic doing this. Can you confirm?
> 
> Thanks,
> 
> Thomas
> 

Sorry, I made a mistake in commit cc4dedd9...

This week I updated from 2013.08 to 2014.11 and I had a runtime error with zip:
"zip warning : Not supported (uzoff_t not same size as zoff_t)"

I'm sending a series to fit this.

Best regards,
Romain Naour