* [Buildroot] [PATCH] busybox: S01logging: implement restart
@ 2015-01-20 11:38 Richard Genoud
2015-02-01 9:08 ` Luca Ceresoli
2015-02-01 22:19 ` Thomas Petazzoni
0 siblings, 2 replies; 3+ messages in thread
From: Richard Genoud @ 2015-01-20 11:38 UTC (permalink / raw)
To: buildroot
restart wasn't doing anything, and the expected behaviour is stop/start.
Signed-off-by: Richard Genoud <richard.genoud@gmail.com>
---
package/busybox/S01logging | 18 ++++++++++++++----
1 file changed, 14 insertions(+), 4 deletions(-)
diff --git a/package/busybox/S01logging b/package/busybox/S01logging
index b7af2a7d5dbc..29093707888e 100644
--- a/package/busybox/S01logging
+++ b/package/busybox/S01logging
@@ -3,20 +3,30 @@
# Start logging
#
-case "$1" in
- start)
+start() {
echo -n "Starting logging: "
start-stop-daemon -b -S -q -m -p /var/run/syslogd.pid --exec /sbin/syslogd -- -n
start-stop-daemon -b -S -q -m -p /var/run/klogd.pid --exec /sbin/klogd -- -n
echo "OK"
- ;;
- stop)
+}
+
+stop() {
echo -n "Stopping logging: "
start-stop-daemon -K -q -p /var/run/syslogd.pid
start-stop-daemon -K -q -p /var/run/klogd.pid
echo "OK"
+}
+
+case "$1" in
+ start)
+ start
+ ;;
+ stop)
+ stop
;;
restart|reload)
+ stop
+ start
;;
*)
echo "Usage: $0 {start|stop|restart}"
--
2.0.0
^ permalink raw reply related [flat|nested] 3+ messages in thread* [Buildroot] [PATCH] busybox: S01logging: implement restart
2015-01-20 11:38 [Buildroot] [PATCH] busybox: S01logging: implement restart Richard Genoud
@ 2015-02-01 9:08 ` Luca Ceresoli
2015-02-01 22:19 ` Thomas Petazzoni
1 sibling, 0 replies; 3+ messages in thread
From: Luca Ceresoli @ 2015-02-01 9:08 UTC (permalink / raw)
To: buildroot
Dear Richard,
Richard Genoud wrote:
> restart wasn't doing anything, and the expected behaviour is stop/start.
>
> Signed-off-by: Richard Genoud <richard.genoud@gmail.com>
Acked-by: Luca Ceresoli <luca@lucaceresoli.net>
--
Luca
^ permalink raw reply [flat|nested] 3+ messages in thread
* [Buildroot] [PATCH] busybox: S01logging: implement restart
2015-01-20 11:38 [Buildroot] [PATCH] busybox: S01logging: implement restart Richard Genoud
2015-02-01 9:08 ` Luca Ceresoli
@ 2015-02-01 22:19 ` Thomas Petazzoni
1 sibling, 0 replies; 3+ messages in thread
From: Thomas Petazzoni @ 2015-02-01 22:19 UTC (permalink / raw)
To: buildroot
Dear Richard Genoud,
On Tue, 20 Jan 2015 12:38:35 +0100, Richard Genoud wrote:
> restart wasn't doing anything, and the expected behaviour is stop/start.
>
> Signed-off-by: Richard Genoud <richard.genoud@gmail.com>
> ---
> package/busybox/S01logging | 18 ++++++++++++++----
> 1 file changed, 14 insertions(+), 4 deletions(-)
Applied, thanks!
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-02-01 22:19 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-01-20 11:38 [Buildroot] [PATCH] busybox: S01logging: implement restart Richard Genoud
2015-02-01 9:08 ` Luca Ceresoli
2015-02-01 22:19 ` Thomas Petazzoni
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox