[Buildroot] [PATCH] boot/at91bootstrap3: Add the option to download via git

[Buildroot] [PATCH] boot/at91bootstrap3: Add the option to download via git

[Giuseppe Marocchio]

Hello all,

Tested-by: Giuseppe Marrocchio  giuseppe at marocchio.com

Works fine,
gm

2015-02-16 10:12 GMT+01:00 Angelo Compagnucci <angelo.compagnucci@gmail.com  <http://lists.busybox.net/mailman/listinfo/buildroot>>:
>/  Hello All,
/>/
/>/  Any news on this one?
/>/
/>/  Staiyng to this comment on at91bootstrap git tree [1] there is no
/>/  infrastructure in place to add third parties boards.
/>/
/>/  Personally, I need this option cause I'm in the process to prepare a
/>/  comprehensive board support for Acmesystems' products and ask for
/>/  inclusion in the near future.
/>/
/>/  Thanks!
/>/
/>/  Sincerely, Angelo
/>/
/>/  [1]https://github.com/linux4sam/at91bootstrap/pull/2#issuecomment-27954225
/>/
/>/  2015-01-30 17:52 GMT+01:00 Angelo Compagnucci <angelo.compagnucci@gmail.com  <http://lists.busybox.net/mailman/listinfo/buildroot>>:
/>>/  Adding support for git downloading of a custom repository.
/>>/
/>>/  Signed-off-by: Angelo Compagnucci <angelo.compagnucci@gmail.com  <http://lists.busybox.net/mailman/listinfo/buildroot>>
/>>/  ---
/>>/   boot/at91bootstrap3/Config.in         | 35 +++++++++++++++++++++++++++++++++++
/>>/   boot/at91bootstrap3/at91bootstrap3.mk |  8 +++++++-
/>>/   2 files changed, 42 insertions(+), 1 deletion(-)
/>>/
/>>/  diff --git a/boot/at91bootstrap3/Config.in b/boot/at91bootstrap3/Config.in
/>>/  index 8ac40ed..6f2f7db 100644
/>>/  --- a/boot/at91bootstrap3/Config.in
/>>/  +++ b/boot/at91bootstrap3/Config.in
/>>/  @@ -8,8 +8,43 @@ config BR2_TARGET_AT91BOOTSTRAP3
/>>/            - Peripheral drivers such as PIO, PMC or SDRAMC...
/>>/            - Physical media algorithm such as DataFlash, NandFlash, NOR Flash...
/>>/
/>>/  +
/>>/   if BR2_TARGET_AT91BOOTSTRAP3
/>>/
/>>/  +choice
/>>/  +
/>>/  +       prompt "AT91 Bootstrap 3 version"
/>>/  +
/>>/  +config BR2_TARGET_AT91BOOTSTRAP3_LATEST_VERSION
/>>/  +       bool "3.7.1"
/>>/  +
/>>/  +config BR2_TARGET_AT91BOOTSTRAP3_CUSTOM_GIT
/>>/  +       bool "Custom Git repository"
/>>/  +       help
/>>/  +         This option allows Buildroot to get the AT91 Bootstrap 3 source
/>>/  +         code from a Git repository.
/>>/  +
/>>/  +endchoice
/>>/  +
/>>/  +if BR2_TARGET_AT91BOOTSTRAP3_CUSTOM_GIT
/>>/  +
/>>/  +config BR2_TARGET_AT91BOOTSTRAP3_CUSTOM_REPO_URL
/>>/  +       string "URL of custom repository"
/>>/  +
/>>/  +config BR2_TARGET_AT91BOOTSTRAP3_CUSTOM_REPO_VERSION
/>>/  +       string "Custom repository version"
/>>/  +       help
/>>/  +         Revision to use in the typical format used by Git
/>>/  +         E.G. a sha id, a tag, branch, ..
/>>/  +
/>>/  +endif
/>>/  +
/>>/  +config BR2_TARGET_AT91BOOTSTRAP3_VERSION
/>>/  +       string
/>>/  +       default "v3.7.1" if BR2_TARGET_AT91BOOTSTRAP3_LATEST_VERSION
/>>/  +       default BR2_TARGET_AT91BOOTSTRAP3_CUSTOM_REPO_VERSION \
/>>/  +               if BR2_TARGET_AT91BOOTSTRAP3_CUSTOM_GIT
/>>/  +
/>>/   config BR2_TARGET_AT91BOOTSTRAP3_CUSTOM_PATCH_DIR
/>>/          string "custom patch dir"
/>>/          help
/>>/  diff --git a/boot/at91bootstrap3/at91bootstrap3.mk b/boot/at91bootstrap3/at91bootstrap3.mk
/>>/  index 098e7bf..39f2365 100644
/>>/  --- a/boot/at91bootstrap3/at91bootstrap3.mk
/>>/  +++ b/boot/at91bootstrap3/at91bootstrap3.mk
/>>/  @@ -4,8 +4,14 @@
/>>/   #
/>>/   ################################################################################
/>>/
/>>/  -AT91BOOTSTRAP3_VERSION = v3.7.1
/>>/  +AT91BOOTSTRAP3_VERSION = $(call qstrip,$(BR2_TARGET_AT91BOOTSTRAP3_VERSION))
/>>/  +
/>>/  +ifeq ($(BR2_TARGET_AT91BOOTSTRAP3_CUSTOM_GIT),y)
/>>/  +AT91BOOTSTRAP3_SITE = $(call qstrip,$(BR2_TARGET_AT91BOOTSTRAP3_CUSTOM_REPO_URL))
/>>/  +AT91BOOTSTRAP3_SITE_METHOD = git
/>>/  +else
/>>/   AT91BOOTSTRAP3_SITE = $(call github,linux4sam,at91bootstrap,$(AT91BOOTSTRAP3_VERSION))
/>>/  +endif
/>>/
/>>/   AT91BOOTSTRAP3_INSTALL_IMAGES = YES
/>>/   AT91BOOTSTRAP3_INSTALL_TARGET = NO
/>>/  --
/>>/  1.9.1
/>>/
/>/
/>/
/>/
/>/  --
/>/  Profile:http://it.linkedin.com/in/compagnucciangelo/

-- 
Giuseppe Marocchio
Tel: +39.3477365087
Tel: +39.0458538888
skype: giuseppe.marocchio

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20150306/916426ff/attachment.html>

[Buildroot] [PATCH] boot/at91bootstrap3: Add the option to download via git

[Angelo Compagnucci]

Adding support for git downloading of a custom repository.

Signed-off-by: Angelo Compagnucci <angelo.compagnucci@gmail.com>
---
 boot/at91bootstrap3/Config.in         | 35 +++++++++++++++++++++++++++++++++++
 boot/at91bootstrap3/at91bootstrap3.mk |  8 +++++++-
 2 files changed, 42 insertions(+), 1 deletion(-)

diff --git a/boot/at91bootstrap3/Config.in b/boot/at91bootstrap3/Config.in
index 8ac40ed..6f2f7db 100644
--- a/boot/at91bootstrap3/Config.in
+++ b/boot/at91bootstrap3/Config.in
@@ -8,8 +8,43 @@ config BR2_TARGET_AT91BOOTSTRAP3
 	  - Peripheral drivers such as PIO, PMC or SDRAMC...
 	  - Physical media algorithm such as DataFlash, NandFlash, NOR Flash...
 
+
 if BR2_TARGET_AT91BOOTSTRAP3
 
+choice
+
+	prompt "AT91 Bootstrap 3 version"
+
+config BR2_TARGET_AT91BOOTSTRAP3_LATEST_VERSION
+	bool "3.7.1"
+
+config BR2_TARGET_AT91BOOTSTRAP3_CUSTOM_GIT
+	bool "Custom Git repository"
+	help
+	  This option allows Buildroot to get the AT91 Bootstrap 3 source
+	  code from a Git repository.
+
+endchoice
+
+if BR2_TARGET_AT91BOOTSTRAP3_CUSTOM_GIT
+
+config BR2_TARGET_AT91BOOTSTRAP3_CUSTOM_REPO_URL
+	string "URL of custom repository"
+
+config BR2_TARGET_AT91BOOTSTRAP3_CUSTOM_REPO_VERSION
+	string "Custom repository version"
+	help
+	  Revision to use in the typical format used by Git
+	  E.G. a sha id, a tag, branch, ..
+
+endif
+
+config BR2_TARGET_AT91BOOTSTRAP3_VERSION
+	string
+	default "v3.7.1" if BR2_TARGET_AT91BOOTSTRAP3_LATEST_VERSION
+	default BR2_TARGET_AT91BOOTSTRAP3_CUSTOM_REPO_VERSION \
+		if BR2_TARGET_AT91BOOTSTRAP3_CUSTOM_GIT
+
 config BR2_TARGET_AT91BOOTSTRAP3_CUSTOM_PATCH_DIR
 	string "custom patch dir"
 	help
diff --git a/boot/at91bootstrap3/at91bootstrap3.mk b/boot/at91bootstrap3/at91bootstrap3.mk
index 098e7bf..39f2365 100644
--- a/boot/at91bootstrap3/at91bootstrap3.mk
+++ b/boot/at91bootstrap3/at91bootstrap3.mk
@@ -4,8 +4,14 @@
 #
 ################################################################################
 
-AT91BOOTSTRAP3_VERSION = v3.7.1
+AT91BOOTSTRAP3_VERSION = $(call qstrip,$(BR2_TARGET_AT91BOOTSTRAP3_VERSION))
+
+ifeq ($(BR2_TARGET_AT91BOOTSTRAP3_CUSTOM_GIT),y)
+AT91BOOTSTRAP3_SITE = $(call qstrip,$(BR2_TARGET_AT91BOOTSTRAP3_CUSTOM_REPO_URL))
+AT91BOOTSTRAP3_SITE_METHOD = git
+else
 AT91BOOTSTRAP3_SITE = $(call github,linux4sam,at91bootstrap,$(AT91BOOTSTRAP3_VERSION))
+endif
 
 AT91BOOTSTRAP3_INSTALL_IMAGES = YES
 AT91BOOTSTRAP3_INSTALL_TARGET = NO
-- 
1.9.1

[Buildroot] [PATCH] boot/at91bootstrap3: Add the option to download via git

[Angelo Compagnucci]

Hello All,

Any news on this one?

Staiyng to this comment on at91bootstrap git tree [1] there is no
infrastructure in place to add third parties boards.

Personally, I need this option cause I'm in the process to prepare a
comprehensive board support for Acmesystems' products and ask for
inclusion in the near future.

Thanks!

Sincerely, Angelo

[1] https://github.com/linux4sam/at91bootstrap/pull/2#issuecomment-27954225

2015-01-30 17:52 GMT+01:00 Angelo Compagnucci <angelo.compagnucci@gmail.com>:
> Adding support for git downloading of a custom repository.
>
> Signed-off-by: Angelo Compagnucci <angelo.compagnucci@gmail.com>
> ---
>  boot/at91bootstrap3/Config.in         | 35 +++++++++++++++++++++++++++++++++++
>  boot/at91bootstrap3/at91bootstrap3.mk |  8 +++++++-
>  2 files changed, 42 insertions(+), 1 deletion(-)
>
> diff --git a/boot/at91bootstrap3/Config.in b/boot/at91bootstrap3/Config.in
> index 8ac40ed..6f2f7db 100644
> --- a/boot/at91bootstrap3/Config.in
> +++ b/boot/at91bootstrap3/Config.in
> @@ -8,8 +8,43 @@ config BR2_TARGET_AT91BOOTSTRAP3
>           - Peripheral drivers such as PIO, PMC or SDRAMC...
>           - Physical media algorithm such as DataFlash, NandFlash, NOR Flash...
>
> +
>  if BR2_TARGET_AT91BOOTSTRAP3
>
> +choice
> +
> +       prompt "AT91 Bootstrap 3 version"
> +
> +config BR2_TARGET_AT91BOOTSTRAP3_LATEST_VERSION
> +       bool "3.7.1"
> +
> +config BR2_TARGET_AT91BOOTSTRAP3_CUSTOM_GIT
> +       bool "Custom Git repository"
> +       help
> +         This option allows Buildroot to get the AT91 Bootstrap 3 source
> +         code from a Git repository.
> +
> +endchoice
> +
> +if BR2_TARGET_AT91BOOTSTRAP3_CUSTOM_GIT
> +
> +config BR2_TARGET_AT91BOOTSTRAP3_CUSTOM_REPO_URL
> +       string "URL of custom repository"
> +
> +config BR2_TARGET_AT91BOOTSTRAP3_CUSTOM_REPO_VERSION
> +       string "Custom repository version"
> +       help
> +         Revision to use in the typical format used by Git
> +         E.G. a sha id, a tag, branch, ..
> +
> +endif
> +
> +config BR2_TARGET_AT91BOOTSTRAP3_VERSION
> +       string
> +       default "v3.7.1" if BR2_TARGET_AT91BOOTSTRAP3_LATEST_VERSION
> +       default BR2_TARGET_AT91BOOTSTRAP3_CUSTOM_REPO_VERSION \
> +               if BR2_TARGET_AT91BOOTSTRAP3_CUSTOM_GIT
> +
>  config BR2_TARGET_AT91BOOTSTRAP3_CUSTOM_PATCH_DIR
>         string "custom patch dir"
>         help
> diff --git a/boot/at91bootstrap3/at91bootstrap3.mk b/boot/at91bootstrap3/at91bootstrap3.mk
> index 098e7bf..39f2365 100644
> --- a/boot/at91bootstrap3/at91bootstrap3.mk
> +++ b/boot/at91bootstrap3/at91bootstrap3.mk
> @@ -4,8 +4,14 @@
>  #
>  ################################################################################
>
> -AT91BOOTSTRAP3_VERSION = v3.7.1
> +AT91BOOTSTRAP3_VERSION = $(call qstrip,$(BR2_TARGET_AT91BOOTSTRAP3_VERSION))
> +
> +ifeq ($(BR2_TARGET_AT91BOOTSTRAP3_CUSTOM_GIT),y)
> +AT91BOOTSTRAP3_SITE = $(call qstrip,$(BR2_TARGET_AT91BOOTSTRAP3_CUSTOM_REPO_URL))
> +AT91BOOTSTRAP3_SITE_METHOD = git
> +else
>  AT91BOOTSTRAP3_SITE = $(call github,linux4sam,at91bootstrap,$(AT91BOOTSTRAP3_VERSION))
> +endif
>
>  AT91BOOTSTRAP3_INSTALL_IMAGES = YES
>  AT91BOOTSTRAP3_INSTALL_TARGET = NO
> --
> 1.9.1
>



-- 
Profile: http://it.linkedin.com/in/compagnucciangelo

[Buildroot] [PATCH] boot/at91bootstrap3: Add the option to download via git

[Angelo Compagnucci]

Hello List,


2015-02-16 10:12 GMT+01:00 Angelo Compagnucci <angelo.compagnucci@gmail.com>:
> Hello All,
>
> Any news on this one?
>
> Staiyng to this comment on at91bootstrap git tree [1] there is no
> infrastructure in place to add third parties boards.
>
> Personally, I need this option cause I'm in the process to prepare a
> comprehensive board support for Acmesystems' products and ask for
> inclusion in the near future.
>
> Thanks!
>
> Sincerely, Angelo
>
> [1] https://github.com/linux4sam/at91bootstrap/pull/2#issuecomment-27954225
>
> 2015-01-30 17:52 GMT+01:00 Angelo Compagnucci <angelo.compagnucci@gmail.com>:
>> Adding support for git downloading of a custom repository.
>>
>> Signed-off-by: Angelo Compagnucci <angelo.compagnucci@gmail.com>
>> ---
>>  boot/at91bootstrap3/Config.in         | 35 +++++++++++++++++++++++++++++++++++
>>  boot/at91bootstrap3/at91bootstrap3.mk |  8 +++++++-
>>  2 files changed, 42 insertions(+), 1 deletion(-)
>>
>> diff --git a/boot/at91bootstrap3/Config.in b/boot/at91bootstrap3/Config.in
>> index 8ac40ed..6f2f7db 100644
>> --- a/boot/at91bootstrap3/Config.in
>> +++ b/boot/at91bootstrap3/Config.in
>> @@ -8,8 +8,43 @@ config BR2_TARGET_AT91BOOTSTRAP3
>>           - Peripheral drivers such as PIO, PMC or SDRAMC...
>>           - Physical media algorithm such as DataFlash, NandFlash, NOR Flash...
>>
>> +
>>  if BR2_TARGET_AT91BOOTSTRAP3
>>
>> +choice
>> +
>> +       prompt "AT91 Bootstrap 3 version"
>> +
>> +config BR2_TARGET_AT91BOOTSTRAP3_LATEST_VERSION
>> +       bool "3.7.1"
>> +
>> +config BR2_TARGET_AT91BOOTSTRAP3_CUSTOM_GIT
>> +       bool "Custom Git repository"
>> +       help
>> +         This option allows Buildroot to get the AT91 Bootstrap 3 source
>> +         code from a Git repository.
>> +
>> +endchoice
>> +
>> +if BR2_TARGET_AT91BOOTSTRAP3_CUSTOM_GIT
>> +
>> +config BR2_TARGET_AT91BOOTSTRAP3_CUSTOM_REPO_URL
>> +       string "URL of custom repository"
>> +
>> +config BR2_TARGET_AT91BOOTSTRAP3_CUSTOM_REPO_VERSION
>> +       string "Custom repository version"
>> +       help
>> +         Revision to use in the typical format used by Git
>> +         E.G. a sha id, a tag, branch, ..
>> +
>> +endif
>> +
>> +config BR2_TARGET_AT91BOOTSTRAP3_VERSION
>> +       string
>> +       default "v3.7.1" if BR2_TARGET_AT91BOOTSTRAP3_LATEST_VERSION
>> +       default BR2_TARGET_AT91BOOTSTRAP3_CUSTOM_REPO_VERSION \
>> +               if BR2_TARGET_AT91BOOTSTRAP3_CUSTOM_GIT
>> +
>>  config BR2_TARGET_AT91BOOTSTRAP3_CUSTOM_PATCH_DIR
>>         string "custom patch dir"
>>         help
>> diff --git a/boot/at91bootstrap3/at91bootstrap3.mk b/boot/at91bootstrap3/at91bootstrap3.mk
>> index 098e7bf..39f2365 100644
>> --- a/boot/at91bootstrap3/at91bootstrap3.mk
>> +++ b/boot/at91bootstrap3/at91bootstrap3.mk
>> @@ -4,8 +4,14 @@
>>  #
>>  ################################################################################
>>
>> -AT91BOOTSTRAP3_VERSION = v3.7.1
>> +AT91BOOTSTRAP3_VERSION = $(call qstrip,$(BR2_TARGET_AT91BOOTSTRAP3_VERSION))
>> +
>> +ifeq ($(BR2_TARGET_AT91BOOTSTRAP3_CUSTOM_GIT),y)
>> +AT91BOOTSTRAP3_SITE = $(call qstrip,$(BR2_TARGET_AT91BOOTSTRAP3_CUSTOM_REPO_URL))
>> +AT91BOOTSTRAP3_SITE_METHOD = git
>> +else
>>  AT91BOOTSTRAP3_SITE = $(call github,linux4sam,at91bootstrap,$(AT91BOOTSTRAP3_VERSION))
>> +endif
>>
>>  AT91BOOTSTRAP3_INSTALL_IMAGES = YES
>>  AT91BOOTSTRAP3_INSTALL_TARGET = NO
>> --
>> 1.9.1
>>
>
>
>
> --
> Profile: http://it.linkedin.com/in/compagnucciangelo

Any news on this?

Thank you!

-- 
Profile: http://it.linkedin.com/in/compagnucciangelo

[Buildroot] [PATCH] boot/at91bootstrap3: Add the option to download via git

[Yann E. MORIN]

Angelo, All,

On 2015-03-04 15:55 +0100, Angelo Compagnucci spake thusly:
> >> Adding support for git downloading of a custom repository.
[--SNIP--]
> Any news on this?

Sorry it takes so long, but we are just getting out of a release cycle
(i.e. the last month was a feature-freeze), and we're trying to catch up
with the currently 363-or-so patches pending in our patch-tracker:
    http://patchwork.ozlabs.org/project/buildroot/list/

One reason that it takes so much time is that there are very
reviewers/testers that give feedback on patches (I have been myself not
very active in that activity recently), and Peter and Thomas have to do
the grunt work of the triaging, reviewing, testing and applying almost
all on their own...

A little bit of help in reviewing those patches, testing them, triaging
the duplicates and so on... is very welcome.

Regards,
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

[Buildroot] [PATCH] boot/at91bootstrap3: Add the option to download via git

[Angelo Compagnucci]

Dear Yann E. MORIN,

2015-03-06 23:53 GMT+01:00 Yann E. MORIN <yann.morin.1998@free.fr>:
> Angelo, All,
>
> On 2015-03-04 15:55 +0100, Angelo Compagnucci spake thusly:
>> >> Adding support for git downloading of a custom repository.
> [--SNIP--]
>> Any news on this?
>
> Sorry it takes so long, but we are just getting out of a release cycle
> (i.e. the last month was a feature-freeze), and we're trying to catch up
> with the currently 363-or-so patches pending in our patch-tracker:
>     http://patchwork.ozlabs.org/project/buildroot/list/
>
> One reason that it takes so much time is that there are very
> reviewers/testers that give feedback on patches (I have been myself not
> very active in that activity recently), and Peter and Thomas have to do
> the grunt work of the triaging, reviewing, testing and applying almost
> all on their own...
>
> A little bit of help in reviewing those patches, testing them, triaging
> the duplicates and so on... is very welcome.

I usually contribute to several Open Source software and I usually
tend to lend a hand because it's fun!
Unfortunately I'm still grasping the internal of Buildroot and I've
not the necessary knowledge to help reviewing patches.
I'm monitorin the mailing list everyday and in case I find something
to work on, you can count on me!

I'm open to some sort of mentorship if someone wants to help me became
proficient and helpful!

Sincerely, Angelo.

>
> Regards,
> Yann E. MORIN.
>
> --
> .-----------------.--------------------.------------------.--------------------.
> |  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
> | +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
> | +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
> | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
> '------------------------------^-------^------------------^--------------------'



-- 
Profile: http://it.linkedin.com/in/compagnucciangelo

[Buildroot] [PATCH] boot/at91bootstrap3: Add the option to download via git

[Yann E. MORIN]

Angelo, All,

On 2015-03-07 10:08 +0100, Angelo Compagnucci spake thusly:
> 2015-03-06 23:53 GMT+01:00 Yann E. MORIN <yann.morin.1998@free.fr>:
> > Angelo, All,
> >
> > On 2015-03-04 15:55 +0100, Angelo Compagnucci spake thusly:
> >> >> Adding support for git downloading of a custom repository.
> > [--SNIP--]
> >> Any news on this?
> >
> > Sorry it takes so long, but we are just getting out of a release cycle
> > (i.e. the last month was a feature-freeze), and we're trying to catch up
> > with the currently 363-or-so patches pending in our patch-tracker:
> >     http://patchwork.ozlabs.org/project/buildroot/list/
> >
> > One reason that it takes so much time is that there are very
> > reviewers/testers that give feedback on patches (I have been myself not
> > very active in that activity recently), and Peter and Thomas have to do
> > the grunt work of the triaging, reviewing, testing and applying almost
> > all on their own...
> >
> > A little bit of help in reviewing those patches, testing them, triaging
> > the duplicates and so on... is very welcome.
> 
> I usually contribute to several Open Source software and I usually
> tend to lend a hand because it's fun!
> Unfortunately I'm still grasping the internal of Buildroot and I've
> not the necessary knowledge to help reviewing patches.
> I'm monitorin the mailing list everyday and in case I find something
> to work on, you can count on me!

That's great, and it is appreciated! :-)

> I'm open to some sort of mentorship if someone wants to help me became
> proficient and helpful!

Yes, sure. First, don't be afraid! Even a review that just looks at
typoes is much welcome. Start with simple changes, such as a version
bump and build-test it, in various configurations (mips, arm, ppc...
with uclibc or glibc, with or without threads...); for example, I try to
build for arm and i386with the "default" toolchain options then with a
"fat" toolchain (LFS, threads...)

If you find typoes, just reply to the patch, pointing the typoes.

If you find the change to be OK, you can reply to the patch with a mail
stating:

    Reviewed-by: Firstname NAME <your.name@example.net>

If you tested it, you can say something like (no need to be too verbose):

    [Firstname: build-tested for mips; run-tested on armel]
    Tested-by: Firstname NAME <your.name@example.net>

Also, you can have a look at our manual, where we have a full section
about how to contribute:
    http://buildroot.net/downloads/manual/manual.html#_contributing_to_buildroot

And again, each contribution counts! So thanks for yours! :-)

Regards,
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

[Buildroot] [PATCH] boot/at91bootstrap3: Add the option to download via git

[Arnout Vandecappelle]

On 07/03/15 12:21, Yann E. MORIN wrote:
>     Reviewed-by: Firstname NAME <your.name@example.net>

 Small correction: if you're not French, you are not required to shout your last
name :-)

 Regards,
 Arnout

-- 
Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F