Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH v2 2/2] wine: Add gettext dependency check for host-wine
@ 2015-03-07 16:23 André Hentschel
  2015-03-07 16:36 ` Thomas Petazzoni
  0 siblings, 1 reply; 2+ messages in thread
From: André Hentschel @ 2015-03-07 16:23 UTC (permalink / raw)
  To: buildroot

Signed-off-by: Andr? Hentschel <nerv@dawncrow.de>
---
v2: minor fixes

 package/wine/wine.mk | 9 +++++++--
 1 file changed, 7 insertions(+), 2 deletions(-)

diff --git a/package/wine/wine.mk b/package/wine/wine.mk
index e931c87..9c6e2aa 100644
--- a/package/wine/wine.mk
+++ b/package/wine/wine.mk
@@ -237,6 +237,13 @@ else
 WINE_CONF_OPTS += --without-zlib
 endif
 
+ifeq ($(BR2_PACKAGE_GETTEXT),y)
+HOST_WINE_CONF_OPTS += --with-gettext --with-gettextpo
+WINE_DEPENDENCIES += gettext
+else
+HOST_WINE_CONF_OPTS += --without-gettext --without-gettextpo
+endif
+
 # Wine needs to enable 64-bit build tools on 64-bit host
 ifeq ($(HOSTARCH),x86_64)
 HOST_WINE_CONF_OPTS += --enable-win64
@@ -274,8 +281,6 @@ HOST_WINE_CONF_OPTS += \
 	--without-curses \
 	--without-dbus \
 	--without-fontconfig \
-	--without-gettext \
-	--without-gettextpo \
 	--without-gphoto \
 	--without-glu \
 	--without-gnutls \

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* [Buildroot] [PATCH v2 2/2] wine: Add gettext dependency check for host-wine
  2015-03-07 16:23 [Buildroot] [PATCH v2 2/2] wine: Add gettext dependency check for host-wine André Hentschel
@ 2015-03-07 16:36 ` Thomas Petazzoni
  0 siblings, 0 replies; 2+ messages in thread
From: Thomas Petazzoni @ 2015-03-07 16:36 UTC (permalink / raw)
  To: buildroot

Dear Andr? Hentschel,

On Sat, 07 Mar 2015 17:23:37 +0100, Andr? Hentschel wrote:

> +ifeq ($(BR2_PACKAGE_GETTEXT),y)

This indicates that gettext is going to be built for the target.

> +HOST_WINE_CONF_OPTS += --with-gettext --with-gettextpo

This changes the configuration of a host package.

Conclusion: this doesn't make sense, unless a better explanation is
provided to explain why such a weird thing is needed.

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2015-03-07 16:36 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-03-07 16:23 [Buildroot] [PATCH v2 2/2] wine: Add gettext dependency check for host-wine André Hentschel
2015-03-07 16:36 ` Thomas Petazzoni

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox