Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Vicente Olivert Riera <Vincent.Riera@imgtec.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] lua-periphery: disable for MIPS architectures
Date: Tue, 17 Mar 2015 14:20:48 +0100	[thread overview]
Message-ID: <55082A30.9070809@imgtec.com> (raw)
In-Reply-To: <20150317130949.56e4d0c3@free-electrons.com>

Dear Thomas Petazzoni,

On 17/03/15 13:09, Thomas Petazzoni wrote:
> Dear Vicente Olivert Riera,
> 
> On Tue, 17 Mar 2015 11:47:39 +0000, Vicente Olivert Riera wrote:
>> c_ispeed and c_ospeed are not available for MIPS:
>>
>> src/serial.c:191:25: error: 'struct termios' has no member named 'c_ispeed'
>>          termios_settings.c_ispeed = baudrate;
>>
>> src/serial.c:192:25: error: 'struct termios' has no member named 'c_ospeed'
>>          termios_settings.c_ospeed = baudrate;
>>
>> Fixes:
>>
>>   http://autobuild.buildroot.net/results/ca7146661c8135568be90dd53b6ee569ebff270d/
>>
>> Signed-off-by: Vicente Olivert Riera <Vincent.Riera@imgtec.com>
> 
> I think disabling on MIPS is not the right fix. The right fix is to use
> the C library cfsetispeed() and cfsetospeed() instead of directly
> accessing the termios structure members, which are not guaranteed to
> exist.

thanks for the advice. I have sent a pull request after testing it fixes
the problem. Let's see what happens :-)

https://github.com/vsergeev/c-periphery/pull/1

Best regards,
--
Vincent

> Thomas
> 

      reply	other threads:[~2015-03-17 13:20 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-17 11:47 [Buildroot] [PATCH] lua-periphery: disable for MIPS architectures Vicente Olivert Riera
2015-03-17 12:09 ` Thomas Petazzoni
2015-03-17 13:20   ` Vicente Olivert Riera [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55082A30.9070809@imgtec.com \
    --to=vincent.riera@imgtec.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox