[Buildroot] [PATCH] lua-periphery: disable for MIPS architectures

[Buildroot] [PATCH] lua-periphery: disable for MIPS architectures

[Vicente Olivert Riera]

c_ispeed and c_ospeed are not available for MIPS:

src/serial.c:191:25: error: 'struct termios' has no member named 'c_ispeed'
         termios_settings.c_ispeed = baudrate;

src/serial.c:192:25: error: 'struct termios' has no member named 'c_ospeed'
         termios_settings.c_ospeed = baudrate;

Fixes:

  http://autobuild.buildroot.net/results/ca7146661c8135568be90dd53b6ee569ebff270d/

Signed-off-by: Vicente Olivert Riera <Vincent.Riera@imgtec.com>
---
 package/lua-periphery/Config.in |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/package/lua-periphery/Config.in b/package/lua-periphery/Config.in
index de5a716..0ccb05c 100644
--- a/package/lua-periphery/Config.in
+++ b/package/lua-periphery/Config.in
@@ -1,6 +1,8 @@
 config BR2_PACKAGE_LUA_PERIPHERY
 	bool "lua-periphery"
 	depends on BR2_PACKAGE_HAS_LUAINTERPRETER
+	# c_ispeed and c_ospeed are not available for MIPS
+	depends on !(BR2_mips || BR2_mipsel || BR2_mips64 || BR2_mips64el)
 	help
 	  A library for GPIO, SPI, I2C, MMIO, and Serial peripheral I/O
 	  interface access in userspace Linux with Lua.
-- 
1.7.1

[Buildroot] [PATCH] lua-periphery: disable for MIPS architectures

[Thomas Petazzoni]

Dear Vicente Olivert Riera,

On Tue, 17 Mar 2015 11:47:39 +0000, Vicente Olivert Riera wrote:
> c_ispeed and c_ospeed are not available for MIPS:
> 
> src/serial.c:191:25: error: 'struct termios' has no member named 'c_ispeed'
>          termios_settings.c_ispeed = baudrate;
> 
> src/serial.c:192:25: error: 'struct termios' has no member named 'c_ospeed'
>          termios_settings.c_ospeed = baudrate;
> 
> Fixes:
> 
>   http://autobuild.buildroot.net/results/ca7146661c8135568be90dd53b6ee569ebff270d/
> 
> Signed-off-by: Vicente Olivert Riera <Vincent.Riera@imgtec.com>

I think disabling on MIPS is not the right fix. The right fix is to use
the C library cfsetispeed() and cfsetospeed() instead of directly
accessing the termios structure members, which are not guaranteed to
exist.

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

[Buildroot] [PATCH] lua-periphery: disable for MIPS architectures

[Vicente Olivert Riera]

Dear Thomas Petazzoni,

On 17/03/15 13:09, Thomas Petazzoni wrote:
> Dear Vicente Olivert Riera,
> 
> On Tue, 17 Mar 2015 11:47:39 +0000, Vicente Olivert Riera wrote:
>> c_ispeed and c_ospeed are not available for MIPS:
>>
>> src/serial.c:191:25: error: 'struct termios' has no member named 'c_ispeed'
>>          termios_settings.c_ispeed = baudrate;
>>
>> src/serial.c:192:25: error: 'struct termios' has no member named 'c_ospeed'
>>          termios_settings.c_ospeed = baudrate;
>>
>> Fixes:
>>
>>   http://autobuild.buildroot.net/results/ca7146661c8135568be90dd53b6ee569ebff270d/
>>
>> Signed-off-by: Vicente Olivert Riera <Vincent.Riera@imgtec.com>
> 
> I think disabling on MIPS is not the right fix. The right fix is to use
> the C library cfsetispeed() and cfsetospeed() instead of directly
> accessing the termios structure members, which are not guaranteed to
> exist.

thanks for the advice. I have sent a pull request after testing it fixes
the problem. Let's see what happens :-)

https://github.com/vsergeev/c-periphery/pull/1

Best regards,
--
Vincent

> Thomas
>