[Buildroot] [PATCH] toolchain: disable internal for blackfin

[Buildroot] [PATCH] toolchain: disable internal for blackfin

[Gustavo Zacarias]

The internal toolchain was a "best effort" approach - we strived to make
it build properly and all but it's mostly untested.
Since it's got issues disable it until it's properly fixed and tested
and leave the official ADI toolchain instead.

Signed-off-by: Gustavo Zacarias <gustavo@zacarias.com.ar>
---
 toolchain/Config.in | 1 +
 1 file changed, 1 insertion(+)

diff --git a/toolchain/Config.in b/toolchain/Config.in
index 291db94..32a00a9 100644
--- a/toolchain/Config.in
+++ b/toolchain/Config.in
@@ -41,6 +41,7 @@ choice
 
 config BR2_TOOLCHAIN_BUILDROOT
 	bool "Buildroot toolchain"
+	depends on !BR2_bfin
 	select BR2_TOOLCHAIN_HAS_SHADOW_PASSWORDS
 
 config BR2_TOOLCHAIN_EXTERNAL
-- 
2.0.5

[Buildroot] [PATCH] toolchain: disable internal for blackfin

[Thomas Petazzoni]

Dear Gustavo Zacarias,

On Tue, 17 Mar 2015 13:41:00 -0300, Gustavo Zacarias wrote:
> The internal toolchain was a "best effort" approach - we strived to make
> it build properly and all but it's mostly untested.
> Since it's got issues disable it until it's properly fixed and tested
> and leave the official ADI toolchain instead.
> 
> Signed-off-by: Gustavo Zacarias <gustavo@zacarias.com.ar>

Applied, thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

[Buildroot] [PATCH] toolchain: disable internal for blackfin

[Thomas Petazzoni]

Dear Gustavo Zacarias,

On Tue, 17 Mar 2015 13:41:00 -0300, Gustavo Zacarias wrote:
> The internal toolchain was a "best effort" approach - we strived to make
> it build properly and all but it's mostly untested.
> Since it's got issues disable it until it's properly fixed and tested
> and leave the official ADI toolchain instead.
> 
> Signed-off-by: Gustavo Zacarias <gustavo@zacarias.com.ar>

Maybe some follow-up patches are possible, in binutils/Config.in.host
and gcc/Config.in.host in the selection of versions?

Thanks,

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

[Buildroot] [PATCH] toolchain: disable internal for blackfin

[Gustavo Zacarias]

On 03/17/2015 01:56 PM, Thomas Petazzoni wrote:

> Maybe some follow-up patches are possible, in binutils/Config.in.host
> and gcc/Config.in.host in the selection of versions?

Do we want to completely remove traces about it?
Regards.

[Buildroot] [PATCH] toolchain: disable internal for blackfin

[Thomas Petazzoni]

Dear Gustavo Zacarias,

On Tue, 17 Mar 2015 13:58:21 -0300, Gustavo Zacarias wrote:

> > Maybe some follow-up patches are possible, in binutils/Config.in.host
> > and gcc/Config.in.host in the selection of versions?
> 
> Do we want to completely remove traces about it?

Well to be honest, seeing how little contributions the Blackfin people
are doing to upstream projects, I am not really hoping a radical
improvement in the upstream support for Blackfin in the coming months
(years?). So I'd prefer to remove the traces of Blackfin support.

Another option of course, would be to introduce support for the ADI
specific gcc and binutils versions at
http://sourceforge.net/p/adi-toolchain/blackfin/ci/master/tree/. But
it's one Git repository with everything, so not easy to package.

Best regards,

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com