Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Arnout Vandecappelle <arnout@mind.be>
To: buildroot@busybox.net
Subject: [Buildroot] package/glog
Date: Fri, 27 Mar 2015 23:23:39 +0100	[thread overview]
Message-ID: <5515D86B.8080009@mind.be> (raw)
In-Reply-To: <CAGm1_kv3ArTGv2W9usiUdYOsVF1_kksZ7xjZ2GVAQtKYbczy3Q@mail.gmail.com>

On 27/03/15 22:20, Yegor Yefremov wrote:
> Hi Anthony,
> 
> thanks for your contribution. Below my comments.
> 
> On Tue, Mar 24, 2015 at 5:16 AM, Mr Anthony Arnold
> <anthony.arnold@uqconnect.edu.au> wrote:
>> Signed-off-by: Anthony Arnold <anthony.arnold@uqconnect.edu.au>
>> ---
>>  package/Config.in      |  1 +
>>  package/glog/Config.in | 11 +++++++++++
>>  package/glog/glog.mk   | 13 +++++++++++++
> 
> Please add a hash file
> (http://nightly.buildroot.org/manual.html#adding-packages-hash)

 Actually, no. It's missing in the manual, but hash files should not be added
for packages using the github helper. The problem is that the archive is created
on the fly, and will be different at different times (even for the same commit).

 Regards,
 Arnout


-- 
Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F

      reply	other threads:[~2015-03-27 22:23 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-24  1:49 [Buildroot] package/glog Mr Anthony Arnold
2015-03-24  4:16 ` Mr Anthony Arnold
2015-03-27 21:20   ` Yegor Yefremov
2015-03-27 22:23     ` Arnout Vandecappelle [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5515D86B.8080009@mind.be \
    --to=arnout@mind.be \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox