* [Buildroot] package/glog
@ 2015-03-24 1:49 Mr Anthony Arnold
2015-03-24 4:16 ` Mr Anthony Arnold
0 siblings, 1 reply; 4+ messages in thread
From: Mr Anthony Arnold @ 2015-03-24 1:49 UTC (permalink / raw)
To: buildroot
Signed-off-by: Anthony Arnold <anthony.arnold@uqconnect.edu.au>
---
package/Config.in | 1 +
package/glog/Config.in | 11 +++++++++++
package/glog/glog.mk | 13 +++++++++++++
3 files changed, 25 insertions(+)
create mode 100644 package/glog/Config.in
create mode 100644 package/glog/glog.mk
diff --git a/package/Config.in b/package/Config.in
index d6a5ad3..3128cc9 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -836,6 +836,7 @@ menu "Logging"
source "package/log4cplus/Config.in"
source "package/log4cxx/Config.in"
source "package/zlog/Config.in"
+ source "package/glog/Config.in"
endmenu
menu "Multimedia"
diff --git a/package/glog/Config.in b/package/glog/Config.in
new file mode 100644
index 0000000..ae528bd
--- /dev/null
+++ b/package/glog/Config.in
@@ -0,0 +1,11 @@
+config BR2_PACKAGE_GLOG
+ bool "glog"
+ depends on BR2_INSTALL_LIBSTDCPP
+ depends on BR2_TOOLCHAIN_HAS_THREADS
+ help
+ C++ implementation of the Google logging module
+
+ https://github.com/google/glog
+
+comment "glog needs a toolchain w/ C++, threads"
+ depends on !(BR2_INSTALL_LIBSTDCPP && BR2_TOOLCHAIN_HAS_THREADS)
\ No newline at end of file
diff --git a/package/glog/glog.mk b/package/glog/glog.mk
new file mode 100644
index 0000000..b955bbf
--- /dev/null
+++ b/package/glog/glog.mk
@@ -0,0 +1,13 @@
+################################################################################
+#
+# glog
+#
+################################################################################
+
+GLOG_VERSION = v0.3.4
+GLOG_LICENSE = New BSD License
+GLOG_LICENSE_FILES = COPYING
+GLOG_SITE = $(call github,google,glog,$(GLOG_VERSION))
+GLOG_SITE_METHOD = git
+
+$(eval $(autotools-package))
--
1.9.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [Buildroot] package/glog
2015-03-24 1:49 [Buildroot] package/glog Mr Anthony Arnold
@ 2015-03-24 4:16 ` Mr Anthony Arnold
2015-03-27 21:20 ` Yegor Yefremov
0 siblings, 1 reply; 4+ messages in thread
From: Mr Anthony Arnold @ 2015-03-24 4:16 UTC (permalink / raw)
To: buildroot
Signed-off-by: Anthony Arnold <anthony.arnold@uqconnect.edu.au>
---
package/Config.in | 1 +
package/glog/Config.in | 11 +++++++++++
package/glog/glog.mk | 13 +++++++++++++
3 files changed, 25 insertions(+)
create mode 100644 package/glog/Config.in
create mode 100644 package/glog/glog.mk
diff --git a/package/Config.in b/package/Config.in
index d6a5ad3..3128cc9 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -836,6 +836,7 @@ menu "Logging"
source "package/log4cplus/Config.in"
source "package/log4cxx/Config.in"
source "package/zlog/Config.in"
+ source "package/glog/Config.in"
endmenu
menu "Multimedia"
diff --git a/package/glog/Config.in b/package/glog/Config.in
new file mode 100644
index 0000000..ae528bd
--- /dev/null
+++ b/package/glog/Config.in
@@ -0,0 +1,11 @@
+config BR2_PACKAGE_GLOG
+ bool "glog"
+ depends on BR2_INSTALL_LIBSTDCPP
+ depends on BR2_TOOLCHAIN_HAS_THREADS
+ help
+ C++ implementation of the Google logging module
+
+ https://github.com/google/glog
+
+comment "glog needs a toolchain w/ C++, threads"
+ depends on !(BR2_INSTALL_LIBSTDCPP && BR2_TOOLCHAIN_HAS_THREADS)
\ No newline at end of file
diff --git a/package/glog/glog.mk b/package/glog/glog.mk
new file mode 100644
index 0000000..b955bbf
--- /dev/null
+++ b/package/glog/glog.mk
@@ -0,0 +1,13 @@
+################################################################################
+#
+# glog
+#
+################################################################################
+
+GLOG_VERSION = v0.3.4
+GLOG_LICENSE = New BSD License
+GLOG_LICENSE_FILES = COPYING
+GLOG_SITE = $(call github,google,glog,$(GLOG_VERSION))
+GLOG_SITE_METHOD = git
+
+$(eval $(autotools-package))
--
1.9.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* [Buildroot] package/glog
2015-03-24 4:16 ` Mr Anthony Arnold
@ 2015-03-27 21:20 ` Yegor Yefremov
2015-03-27 22:23 ` Arnout Vandecappelle
0 siblings, 1 reply; 4+ messages in thread
From: Yegor Yefremov @ 2015-03-27 21:20 UTC (permalink / raw)
To: buildroot
Hi Anthony,
thanks for your contribution. Below my comments.
On Tue, Mar 24, 2015 at 5:16 AM, Mr Anthony Arnold
<anthony.arnold@uqconnect.edu.au> wrote:
> Signed-off-by: Anthony Arnold <anthony.arnold@uqconnect.edu.au>
> ---
> package/Config.in | 1 +
> package/glog/Config.in | 11 +++++++++++
> package/glog/glog.mk | 13 +++++++++++++
Please add a hash file
(http://nightly.buildroot.org/manual.html#adding-packages-hash)
> 3 files changed, 25 insertions(+)
> create mode 100644 package/glog/Config.in
> create mode 100644 package/glog/glog.mk
>
> diff --git a/package/Config.in b/package/Config.in
> index d6a5ad3..3128cc9 100644
> --- a/package/Config.in
> +++ b/package/Config.in
> @@ -836,6 +836,7 @@ menu "Logging"
> source "package/log4cplus/Config.in"
> source "package/log4cxx/Config.in"
> source "package/zlog/Config.in"
> + source "package/glog/Config.in"
Entries should be sorted alphabetically
> endmenu
>
> menu "Multimedia"
> diff --git a/package/glog/Config.in b/package/glog/Config.in
> new file mode 100644
> index 0000000..ae528bd
> --- /dev/null
> +++ b/package/glog/Config.in
> @@ -0,0 +1,11 @@
> +config BR2_PACKAGE_GLOG
> + bool "glog"
> + depends on BR2_INSTALL_LIBSTDCPP
> + depends on BR2_TOOLCHAIN_HAS_THREADS
> + help
> + C++ implementation of the Google logging module
> +
> + https://github.com/google/glog
Help text should have one tab and two spaces as indentation
> +
> +comment "glog needs a toolchain w/ C++, threads"
> + depends on !(BR2_INSTALL_LIBSTDCPP && BR2_TOOLCHAIN_HAS_THREADS)
> \ No newline at end of file
> diff --git a/package/glog/glog.mk b/package/glog/glog.mk
> new file mode 100644
> index 0000000..b955bbf
> --- /dev/null
> +++ b/package/glog/glog.mk
> @@ -0,0 +1,13 @@
> +################################################################################
> +#
> +# glog
> +#
> +################################################################################
> +
> +GLOG_VERSION = v0.3.4
> +GLOG_LICENSE = New BSD License
> +GLOG_LICENSE_FILES = COPYING
> +GLOG_SITE = $(call github,google,glog,$(GLOG_VERSION))
> +GLOG_SITE_METHOD = git
No need for site method for github helper
As it is a library you need GLOG_INSTALL_STAGING = YES
Yegor
> +
> +$(eval $(autotools-package))
> --
> 1.9.1
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 4+ messages in thread
* [Buildroot] package/glog
2015-03-27 21:20 ` Yegor Yefremov
@ 2015-03-27 22:23 ` Arnout Vandecappelle
0 siblings, 0 replies; 4+ messages in thread
From: Arnout Vandecappelle @ 2015-03-27 22:23 UTC (permalink / raw)
To: buildroot
On 27/03/15 22:20, Yegor Yefremov wrote:
> Hi Anthony,
>
> thanks for your contribution. Below my comments.
>
> On Tue, Mar 24, 2015 at 5:16 AM, Mr Anthony Arnold
> <anthony.arnold@uqconnect.edu.au> wrote:
>> Signed-off-by: Anthony Arnold <anthony.arnold@uqconnect.edu.au>
>> ---
>> package/Config.in | 1 +
>> package/glog/Config.in | 11 +++++++++++
>> package/glog/glog.mk | 13 +++++++++++++
>
> Please add a hash file
> (http://nightly.buildroot.org/manual.html#adding-packages-hash)
Actually, no. It's missing in the manual, but hash files should not be added
for packages using the github helper. The problem is that the archive is created
on the fly, and will be different at different times (even for the same commit).
Regards,
Arnout
--
Arnout Vandecappelle arnout at mind be
Senior Embedded Software Architect +32-16-286500
Essensium/Mind http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint: 7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2015-03-27 22:23 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-03-24 1:49 [Buildroot] package/glog Mr Anthony Arnold
2015-03-24 4:16 ` Mr Anthony Arnold
2015-03-27 21:20 ` Yegor Yefremov
2015-03-27 22:23 ` Arnout Vandecappelle
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox