[Buildroot] [PATCH] mesa3d: specify llvm-prefix

[Buildroot] [PATCH] mesa3d: specify llvm-prefix

[Gustavo Zacarias]

When it's not defined an automatic search is triggered, which can find
/usr/bin/llvm-config on distributions that include all development files
(like gentoo) and have desktop packages installed.
So point it towards the staging dir which is where it should live
eventually if/when we've got it to avoid header/include path polution
that otherwise leads to build failures.

Signed-off-by: Gustavo Zacarias <gustavo@zacarias.com.ar>
---
 package/mesa3d/mesa3d.mk | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/package/mesa3d/mesa3d.mk b/package/mesa3d/mesa3d.mk
index fc82227..7473110 100644
--- a/package/mesa3d/mesa3d.mk
+++ b/package/mesa3d/mesa3d.mk
@@ -128,4 +128,7 @@ else
 MESA3D_CONF_OPTS += --disable-gles1 --disable-gles2
 endif
 
+# Avoid automatic search of llvm-config
+MESA3D_CONF_OPTS += --with-llvm-prefix=$(STAGING_DIR)/usr/bin
+
 $(eval $(autotools-package))
-- 
2.0.5

[Buildroot] [PATCH] mesa3d: specify llvm-prefix

[Thomas Petazzoni]

Dear Gustavo Zacarias,

On Mon, 30 Mar 2015 20:16:00 -0300, Gustavo Zacarias wrote:
> When it's not defined an automatic search is triggered, which can find
> /usr/bin/llvm-config on distributions that include all development files
> (like gentoo) and have desktop packages installed.
> So point it towards the staging dir which is where it should live
> eventually if/when we've got it to avoid header/include path polution
> that otherwise leads to build failures.
> 
> Signed-off-by: Gustavo Zacarias <gustavo@zacarias.com.ar>
> ---
>  package/mesa3d/mesa3d.mk | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/package/mesa3d/mesa3d.mk b/package/mesa3d/mesa3d.mk
> index fc82227..7473110 100644
> --- a/package/mesa3d/mesa3d.mk
> +++ b/package/mesa3d/mesa3d.mk
> @@ -128,4 +128,7 @@ else
>  MESA3D_CONF_OPTS += --disable-gles1 --disable-gles2
>  endif
>  
> +# Avoid automatic search of llvm-config
> +MESA3D_CONF_OPTS += --with-llvm-prefix=$(STAGING_DIR)/usr/bin

Shouldn't we instead test if LLVM is available, explicitly disable LLVM
support if not, and enable it if LLVM is available?

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

[Buildroot] [PATCH] mesa3d: specify llvm-prefix

[Gustavo Zacarias]

On 03/31/2015 06:25 AM, Thomas Petazzoni wrote:
>> +# Avoid automatic search of llvm-config
>> +MESA3D_CONF_OPTS += --with-llvm-prefix=$(STAGING_DIR)/usr/bin
> 
> Shouldn't we instead test if LLVM is available, explicitly disable LLVM
> support if not, and enable it if LLVM is available?

We don't have a llvm package in BR, so testing is a non-option.
There's no explicit option to disable llvm support, hence this is as
close as it gets without patching.
(--without-gallium-drivers comes close, but it takes down a whole bunch
of other stuff as well).
Regards.

[Buildroot] [PATCH] mesa3d: specify llvm-prefix

[Thomas Petazzoni]

Dear Gustavo Zacarias,

On Tue, 31 Mar 2015 07:54:30 -0300, Gustavo Zacarias wrote:
> On 03/31/2015 06:25 AM, Thomas Petazzoni wrote:
> >> +# Avoid automatic search of llvm-config
> >> +MESA3D_CONF_OPTS += --with-llvm-prefix=$(STAGING_DIR)/usr/bin
> > 
> > Shouldn't we instead test if LLVM is available, explicitly disable LLVM
> > support if not, and enable it if LLVM is available?
> 
> We don't have a llvm package in BR, so testing is a non-option.

Well what I meant is that since we don't have a LLVM option right now,
we should display LLVM support completely.

And we do have patches in patchwork to add LLVM.

> There's no explicit option to disable llvm support, hence this is as
> close as it gets without patching.
> (--without-gallium-drivers comes close, but it takes down a whole bunch
> of other stuff as well).

Ok. Applied then, thanks.

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

[Buildroot] [PATCH] mesa3d: specify llvm-prefix

[Gustavo Zacarias]

On 03/31/2015 08:55 AM, Thomas Petazzoni wrote:

> Well what I meant is that since we don't have a LLVM option right now,
> we should display LLVM support completely.
> 
> And we do have patches in patchwork to add LLVM.

Hi.
I missed that.
I'm just fighting some windmills in doing the webkit/midori revamp and
fixing accordingly ;)
Regards.