* [Buildroot] [PATCH] Makefile: add help for linux-update-defconfig target
@ 2015-04-02 19:34 Yegor Yefremov
2015-04-06 13:16 ` Arnout Vandecappelle
0 siblings, 1 reply; 5+ messages in thread
From: Yegor Yefremov @ 2015-04-02 19:34 UTC (permalink / raw)
To: buildroot
Signed-off-by: Yegor Yefremov <yegorslists@googlemail.com>
---
Makefile | 2 ++
1 file changed, 2 insertions(+)
diff --git a/Makefile b/Makefile
index edb122b..08b5c1e 100644
--- a/Makefile
+++ b/Makefile
@@ -878,6 +878,8 @@ endif
ifeq ($(BR2_LINUX_KERNEL),y)
@echo ' linux-menuconfig - Run Linux kernel menuconfig'
@echo ' linux-savedefconfig - Run Linux kernel savedefconfig'
+ @echo ' linux-update-defconfig - Save the Linux configuration to the path specified'
+ @echo ' by BR2_LINUX_KERNEL_CUSTOM_CONFIG_FILE'
endif
ifeq ($(BR2_TOOLCHAIN_BUILDROOT),y)
@echo ' uclibc-menuconfig - Run uClibc menuconfig'
--
2.1.0
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [Buildroot] [PATCH] Makefile: add help for linux-update-defconfig target
2015-04-02 19:34 [Buildroot] [PATCH] Makefile: add help for linux-update-defconfig target Yegor Yefremov
@ 2015-04-06 13:16 ` Arnout Vandecappelle
2015-04-06 13:18 ` Thomas Petazzoni
0 siblings, 1 reply; 5+ messages in thread
From: Arnout Vandecappelle @ 2015-04-06 13:16 UTC (permalink / raw)
To: buildroot
On 02/04/15 21:34, Yegor Yefremov wrote:
> Signed-off-by: Yegor Yefremov <yegorslists@googlemail.com>
Acked-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
Regards,
Arnout
> ---
> Makefile | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/Makefile b/Makefile
> index edb122b..08b5c1e 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -878,6 +878,8 @@ endif
> ifeq ($(BR2_LINUX_KERNEL),y)
> @echo ' linux-menuconfig - Run Linux kernel menuconfig'
> @echo ' linux-savedefconfig - Run Linux kernel savedefconfig'
> + @echo ' linux-update-defconfig - Save the Linux configuration to the path specified'
> + @echo ' by BR2_LINUX_KERNEL_CUSTOM_CONFIG_FILE'
> endif
> ifeq ($(BR2_TOOLCHAIN_BUILDROOT),y)
> @echo ' uclibc-menuconfig - Run uClibc menuconfig'
>
--
Arnout Vandecappelle arnout at mind be
Senior Embedded Software Architect +32-16-286500
Essensium/Mind http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint: 7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F
^ permalink raw reply [flat|nested] 5+ messages in thread
* [Buildroot] [PATCH] Makefile: add help for linux-update-defconfig target
2015-04-06 13:16 ` Arnout Vandecappelle
@ 2015-04-06 13:18 ` Thomas Petazzoni
2015-04-06 14:25 ` Arnout Vandecappelle
0 siblings, 1 reply; 5+ messages in thread
From: Thomas Petazzoni @ 2015-04-06 13:18 UTC (permalink / raw)
To: buildroot
Arnout, Yegor,
On Mon, 06 Apr 2015 15:16:11 +0200, Arnout Vandecappelle wrote:
> > Signed-off-by: Yegor Yefremov <yegorslists@googlemail.com>
>
> Acked-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
>
> > ---
> > Makefile | 2 ++
> > 1 file changed, 2 insertions(+)
> >
> > diff --git a/Makefile b/Makefile
> > index edb122b..08b5c1e 100644
> > --- a/Makefile
> > +++ b/Makefile
> > @@ -878,6 +878,8 @@ endif
> > ifeq ($(BR2_LINUX_KERNEL),y)
> > @echo ' linux-menuconfig - Run Linux kernel menuconfig'
> > @echo ' linux-savedefconfig - Run Linux kernel savedefconfig'
> > + @echo ' linux-update-defconfig - Save the Linux configuration to the path specified'
> > + @echo ' by BR2_LINUX_KERNEL_CUSTOM_CONFIG_FILE'
Why just for linux and not for all kconfig based packages ? Why
<foo>-update-defconfig and not <foo>-update-config ?
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 5+ messages in thread
* [Buildroot] [PATCH] Makefile: add help for linux-update-defconfig target
2015-04-06 13:18 ` Thomas Petazzoni
@ 2015-04-06 14:25 ` Arnout Vandecappelle
2015-04-06 21:34 ` Thomas Petazzoni
0 siblings, 1 reply; 5+ messages in thread
From: Arnout Vandecappelle @ 2015-04-06 14:25 UTC (permalink / raw)
To: buildroot
On 06/04/15 15:18, Thomas Petazzoni wrote:
> Arnout, Yegor,
>
> On Mon, 06 Apr 2015 15:16:11 +0200, Arnout Vandecappelle wrote:
>
>>> Signed-off-by: Yegor Yefremov <yegorslists@googlemail.com>
>>
>> Acked-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
>
>>
>>> ---
>>> Makefile | 2 ++
>>> 1 file changed, 2 insertions(+)
>>>
>>> diff --git a/Makefile b/Makefile
>>> index edb122b..08b5c1e 100644
>>> --- a/Makefile
>>> +++ b/Makefile
>>> @@ -878,6 +878,8 @@ endif
>>> ifeq ($(BR2_LINUX_KERNEL),y)
>>> @echo ' linux-menuconfig - Run Linux kernel menuconfig'
>>> @echo ' linux-savedefconfig - Run Linux kernel savedefconfig'
>>> + @echo ' linux-update-defconfig - Save the Linux configuration to the path specified'
>>> + @echo ' by BR2_LINUX_KERNEL_CUSTOM_CONFIG_FILE'
>
> Why just for linux and not for all kconfig based packages ? Why
> <foo>-update-defconfig and not <foo>-update-config ?
Here are the reasons:
- update-defconfig doesn't exist for all kconfig packages
- update-defconfig is preferred if it exists (for Linux I certainly see no
reason to ever use update-config)
- documenting foo-update-defconfig would perhaps be better, but that's part of a
bigger change that would completely remove all the specifics. When I did the
'make help' patches I started on that, but it turns out to be a bit more work so
I dropped it in the end.
Regards,
Arnout
>
> Thomas
>
--
Arnout Vandecappelle arnout at mind be
Senior Embedded Software Architect +32-16-286500
Essensium/Mind http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint: 7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F
^ permalink raw reply [flat|nested] 5+ messages in thread
* [Buildroot] [PATCH] Makefile: add help for linux-update-defconfig target
2015-04-06 14:25 ` Arnout Vandecappelle
@ 2015-04-06 21:34 ` Thomas Petazzoni
0 siblings, 0 replies; 5+ messages in thread
From: Thomas Petazzoni @ 2015-04-06 21:34 UTC (permalink / raw)
To: buildroot
Arnout,
On Mon, 06 Apr 2015 16:25:38 +0200, Arnout Vandecappelle wrote:
> Here are the reasons:
>
> - update-defconfig doesn't exist for all kconfig packages
>
> - update-defconfig is preferred if it exists (for Linux I certainly see no
> reason to ever use update-config)
>
> - documenting foo-update-defconfig would perhaps be better, but that's part of a
> bigger change that would completely remove all the specifics. When I did the
> 'make help' patches I started on that, but it turns out to be a bit more work so
> I dropped it in the end.
Hm, well, I'm still not highly convinced on how we handle this
per-package target help text. But anyway, applied, as it isn't that
worse than what we have today.
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2015-04-06 21:34 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-04-02 19:34 [Buildroot] [PATCH] Makefile: add help for linux-update-defconfig target Yegor Yefremov
2015-04-06 13:16 ` Arnout Vandecappelle
2015-04-06 13:18 ` Thomas Petazzoni
2015-04-06 14:25 ` Arnout Vandecappelle
2015-04-06 21:34 ` Thomas Petazzoni
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox