* [Buildroot] [PATCH 1/1] heimdal: needs host-flex and explicitly set -lpthread
@ 2015-04-19 17:53 Ryan Coe
2015-04-20 20:35 ` Thomas Petazzoni
0 siblings, 1 reply; 5+ messages in thread
From: Ryan Coe @ 2015-04-19 17:53 UTC (permalink / raw)
To: buildroot
Signed-off-by: Ryan Coe <bluemrp9@gmail.com>
---
package/heimdal/heimdal.mk | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/package/heimdal/heimdal.mk b/package/heimdal/heimdal.mk
index 972f15c..c4a1703 100644
--- a/package/heimdal/heimdal.mk
+++ b/package/heimdal/heimdal.mk
@@ -6,11 +6,11 @@
HEIMDAL_VERSION = 1.5.3
HEIMDAL_SITE = http://www.h5l.org/dist/src
-HEIMDAL_DEPENDENCIES = host-e2fsprogs host-pkgconf
+HEIMDAL_DEPENDENCIES = host-e2fsprogs host-pkgconf host-flex
HEIMDAL_INSTALL_STAGING = YES
# static because of -fPIC issues with e2fsprogs on x86_64 host
HOST_HEIMDAL_CONF_OPTS = --with-x=no --disable-shared --enable-static
-HOST_HEIMDAL_CONF_ENV = MAKEINFO=true
+HOST_HEIMDAL_CONF_ENV = MAKEINFO=true LIBS="-lpthread"
HEIMDAL_MAKE = $(MAKE1)
# For heimdal-0004-compile_et.patch
HEIMDAL_AUTORECONF = YES
--
2.3.5
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [Buildroot] [PATCH 1/1] heimdal: needs host-flex and explicitly set -lpthread
2015-04-19 17:53 [Buildroot] [PATCH 1/1] heimdal: needs host-flex and explicitly set -lpthread Ryan Coe
@ 2015-04-20 20:35 ` Thomas Petazzoni
2015-04-21 2:03 ` Ryan Coe
0 siblings, 1 reply; 5+ messages in thread
From: Thomas Petazzoni @ 2015-04-20 20:35 UTC (permalink / raw)
To: buildroot
Dear Ryan Coe,
On Sun, 19 Apr 2015 10:53:23 -0700, Ryan Coe wrote:
> Signed-off-by: Ryan Coe <bluemrp9@gmail.com>
> ---
> package/heimdal/heimdal.mk | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/package/heimdal/heimdal.mk b/package/heimdal/heimdal.mk
> index 972f15c..c4a1703 100644
> --- a/package/heimdal/heimdal.mk
> +++ b/package/heimdal/heimdal.mk
> @@ -6,11 +6,11 @@
>
> HEIMDAL_VERSION = 1.5.3
> HEIMDAL_SITE = http://www.h5l.org/dist/src
> -HEIMDAL_DEPENDENCIES = host-e2fsprogs host-pkgconf
> +HEIMDAL_DEPENDENCIES = host-e2fsprogs host-pkgconf host-flex
> HEIMDAL_INSTALL_STAGING = YES
> # static because of -fPIC issues with e2fsprogs on x86_64 host
> HOST_HEIMDAL_CONF_OPTS = --with-x=no --disable-shared --enable-static
> -HOST_HEIMDAL_CONF_ENV = MAKEINFO=true
> +HOST_HEIMDAL_CONF_ENV = MAKEINFO=true LIBS="-lpthread"
Could you give more details about the situations in which you are
seeing problems with host-flex and -lpthread being missing?
I indeed see that flex and bison are being tested at configure time,
but failing to detect them does not seem to affect the build (maybe
heimdal has a pre-generated versions of the files normally generated by
flex/bison?). And I see -lpthread being used properly when linking.
So, please include more details about the issues you're seeing your
commit log.
Thanks a lot!
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 5+ messages in thread
* [Buildroot] [PATCH 1/1] heimdal: needs host-flex and explicitly set -lpthread
2015-04-20 20:35 ` Thomas Petazzoni
@ 2015-04-21 2:03 ` Ryan Coe
2015-04-21 7:11 ` Thomas Petazzoni
0 siblings, 1 reply; 5+ messages in thread
From: Ryan Coe @ 2015-04-21 2:03 UTC (permalink / raw)
To: buildroot
On 04/20/2015 01:35 PM, Thomas Petazzoni wrote:
> Dear Ryan Coe,
>
> On Sun, 19 Apr 2015 10:53:23 -0700, Ryan Coe wrote:
>> Signed-off-by: Ryan Coe <bluemrp9@gmail.com>
>> ---
>> package/heimdal/heimdal.mk | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/package/heimdal/heimdal.mk b/package/heimdal/heimdal.mk
>> index 972f15c..c4a1703 100644
>> --- a/package/heimdal/heimdal.mk
>> +++ b/package/heimdal/heimdal.mk
>> @@ -6,11 +6,11 @@
>>
>> HEIMDAL_VERSION = 1.5.3
>> HEIMDAL_SITE = http://www.h5l.org/dist/src
>> -HEIMDAL_DEPENDENCIES = host-e2fsprogs host-pkgconf
>> +HEIMDAL_DEPENDENCIES = host-e2fsprogs host-pkgconf host-flex
>> HEIMDAL_INSTALL_STAGING = YES
>> # static because of -fPIC issues with e2fsprogs on x86_64 host
>> HOST_HEIMDAL_CONF_OPTS = --with-x=no --disable-shared --enable-static
>> -HOST_HEIMDAL_CONF_ENV = MAKEINFO=true
>> +HOST_HEIMDAL_CONF_ENV = MAKEINFO=true LIBS="-lpthread"
> Could you give more details about the situations in which you are
> seeing problems with host-flex and -lpthread being missing?
>
> I indeed see that flex and bison are being tested at configure time,
> but failing to detect them does not seem to affect the build (maybe
> heimdal has a pre-generated versions of the files normally generated by
> flex/bison?). And I see -lpthread being used properly when linking.
>
> So, please include more details about the issues you're seeing your
> commit log.
>
> Thanks a lot!
>
> Thomas
Thomas,
I found the addition of host-flex not to be necessary. The -lpthread
addition fixes a build error on my machine. I will submit a new version
of my patch.
Thanks,
Ryan
^ permalink raw reply [flat|nested] 5+ messages in thread
* [Buildroot] [PATCH 1/1] heimdal: needs host-flex and explicitly set -lpthread
2015-04-21 2:03 ` Ryan Coe
@ 2015-04-21 7:11 ` Thomas Petazzoni
[not found] ` <5537287A.9070505@gmail.com>
0 siblings, 1 reply; 5+ messages in thread
From: Thomas Petazzoni @ 2015-04-21 7:11 UTC (permalink / raw)
To: buildroot
Dear Ryan Coe,
On Mon, 20 Apr 2015 19:03:10 -0700, Ryan Coe wrote:
> I found the addition of host-flex not to be necessary. The -lpthread
> addition fixes a build error on my machine. I will submit a new version
> of my patch.
Could you give the full build log of host-heimdal on your machine, as
well as the contents of config.log, when the build fails due to
-lpthread being missing?
Thanks,
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2015-04-22 7:34 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-04-19 17:53 [Buildroot] [PATCH 1/1] heimdal: needs host-flex and explicitly set -lpthread Ryan Coe
2015-04-20 20:35 ` Thomas Petazzoni
2015-04-21 2:03 ` Ryan Coe
2015-04-21 7:11 ` Thomas Petazzoni
[not found] ` <5537287A.9070505@gmail.com>
2015-04-22 7:34 ` Thomas Petazzoni
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox