Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Arnout Vandecappelle <arnout@mind.be>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/2] package/libpthsem: remove argp-standalone dependency
Date: Sat, 02 May 2015 14:21:50 +0200	[thread overview]
Message-ID: <5544C15E.9060103@mind.be> (raw)
In-Reply-To: <1430562486-23625-1-git-send-email-romain.naour@openwide.fr>

On 02/05/15 12:28, Romain Naour wrote:
> argp-standalone provide libargp.a and argp.h which are
> never used in libpthsem.
> 
> Signed-off-by: Romain Naour <romain.naour@openwide.fr>

Acked-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
Tested-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
 Build-test with and without the _COMPAT option, and checked that there is no
reference to argp in the source.

 Adding the original submitter of this package in Cc for final verification.
Gregory, do you remember why you added the argp-standalone dependency?

 Regards,
 Arnout

> ---
>  package/libpthsem/Config.in    | 1 -
>  package/libpthsem/libpthsem.mk | 1 -
>  2 files changed, 2 deletions(-)
> 
> diff --git a/package/libpthsem/Config.in b/package/libpthsem/Config.in
> index 932acec..3219de1 100644
> --- a/package/libpthsem/Config.in
> +++ b/package/libpthsem/Config.in
> @@ -1,7 +1,6 @@
>  config BR2_PACKAGE_LIBPTHSEM
>  	bool "libpthsem"
>  	depends on BR2_USE_MMU # fork()
> -	select BR2_PACKAGE_ARGP_STANDALONE
>  	help
>  	  GNU pth is a user mode multi threading library. pthsem is an extend
>  	  version, with support for semaphores added.
> diff --git a/package/libpthsem/libpthsem.mk b/package/libpthsem/libpthsem.mk
> index 7c1de86..f9f6f71 100644
> --- a/package/libpthsem/libpthsem.mk
> +++ b/package/libpthsem/libpthsem.mk
> @@ -11,7 +11,6 @@ LIBPTHSEM_LICENSE = LGPLv2.1+
>  LIBPTHSEM_LICENSE_FILES = COPYING
>  LIBPTHSEM_AUTORECONF = YES
>  LIBPTHSEM_INSTALL_STAGING = YES
> -LIBPTHSEM_DEPENDENCIES = argp-standalone
>  LIBPTHSEM_CONFIG_SCRIPTS = pthsem-config
>  
>  ifeq ($(BR2_PACKAGE_LIBPTHSEM_COMPAT),y)
> 


-- 
Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F

  parent reply	other threads:[~2015-05-02 12:21 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-02 10:28 [Buildroot] [PATCH 1/2] package/libpthsem: remove argp-standalone dependency Romain Naour
2015-05-02 10:28 ` [Buildroot] [PATCH 2/2] package/argp-standalone: is useless for (e)glibc toolchains Romain Naour
2015-05-03 17:21   ` Peter Korsgaard
2015-05-02 12:21 ` Arnout Vandecappelle [this message]
2015-05-03 16:59   ` [Buildroot] [PATCH 1/2] package/libpthsem: remove argp-standalone dependency Romain Naour
2015-05-02 12:52 ` Thomas Petazzoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5544C15E.9060103@mind.be \
    --to=arnout@mind.be \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox