[Buildroot] [PATCH 1/2] package/libpthsem: remove argp-standalone dependency

[Buildroot] [PATCH 1/2] package/libpthsem: remove argp-standalone dependency

[Romain Naour]

argp-standalone provide libargp.a and argp.h which are
never used in libpthsem.

Signed-off-by: Romain Naour <romain.naour@openwide.fr>
---
 package/libpthsem/Config.in    | 1 -
 package/libpthsem/libpthsem.mk | 1 -
 2 files changed, 2 deletions(-)

diff --git a/package/libpthsem/Config.in b/package/libpthsem/Config.in
index 932acec..3219de1 100644
--- a/package/libpthsem/Config.in
+++ b/package/libpthsem/Config.in
@@ -1,7 +1,6 @@
 config BR2_PACKAGE_LIBPTHSEM
 	bool "libpthsem"
 	depends on BR2_USE_MMU # fork()
-	select BR2_PACKAGE_ARGP_STANDALONE
 	help
 	  GNU pth is a user mode multi threading library. pthsem is an extend
 	  version, with support for semaphores added.
diff --git a/package/libpthsem/libpthsem.mk b/package/libpthsem/libpthsem.mk
index 7c1de86..f9f6f71 100644
--- a/package/libpthsem/libpthsem.mk
+++ b/package/libpthsem/libpthsem.mk
@@ -11,7 +11,6 @@ LIBPTHSEM_LICENSE = LGPLv2.1+
 LIBPTHSEM_LICENSE_FILES = COPYING
 LIBPTHSEM_AUTORECONF = YES
 LIBPTHSEM_INSTALL_STAGING = YES
-LIBPTHSEM_DEPENDENCIES = argp-standalone
 LIBPTHSEM_CONFIG_SCRIPTS = pthsem-config
 
 ifeq ($(BR2_PACKAGE_LIBPTHSEM_COMPAT),y)
-- 
1.9.3

[Buildroot] [PATCH 2/2] package/argp-standalone: is useless for (e)glibc toolchains

[Romain Naour]

According to Thomas's remark [1], (e)glibc toolchains provide it's
own argp.h version.
Also, it appears that argp.h from glibc is more up to date should
be preferred to argp-standalone one.

[1] http://lists.busybox.net/pipermail/buildroot/2015-May/127511.html

Signed-off-by: Romain Naour <romain.naour@openwide.fr>
---
Note: I didn't add a comment in Config.in to tell that argp-standalone
      package is useless for (e)glibc toolchains.
---
 package/argp-standalone/Config.in | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/package/argp-standalone/Config.in b/package/argp-standalone/Config.in
index 5a0c051..3319dd9 100644
--- a/package/argp-standalone/Config.in
+++ b/package/argp-standalone/Config.in
@@ -1,5 +1,7 @@
 config BR2_PACKAGE_ARGP_STANDALONE
 	bool "argp-standalone"
+	# glibc provides its own argp implementation.
+	depends on !BR2_TOOLCHAIN_USES_GLIBC
 	help
 	  Glibc hierarchical argument parsing standalone library.
 
-- 
1.9.3

[Buildroot] [PATCH 2/2] package/argp-standalone: is useless for (e)glibc toolchains

[Peter Korsgaard]

>>>>> "Romain" == Romain Naour <romain.naour@openwide.fr> writes:

 > According to Thomas's remark [1], (e)glibc toolchains provide it's
 > own argp.h version.
 > Also, it appears that argp.h from glibc is more up to date should
 > be preferred to argp-standalone one.

 > [1] http://lists.busybox.net/pipermail/buildroot/2015-May/127511.html

 > Signed-off-by: Romain Naour <romain.naour@openwide.fr>
 > ---
 > Note: I didn't add a comment in Config.in to tell that argp-standalone
 >       package is useless for (e)glibc toolchains.

I think it is OK to not display anything as it doesn't make sense on
glibc.

Committed, thanks.

-- 
Bye, Peter Korsgaard

[Buildroot] [PATCH 1/2] package/libpthsem: remove argp-standalone dependency

[Arnout Vandecappelle]

On 02/05/15 12:28, Romain Naour wrote:
> argp-standalone provide libargp.a and argp.h which are
> never used in libpthsem.
> 
> Signed-off-by: Romain Naour <romain.naour@openwide.fr>

Acked-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
Tested-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
 Build-test with and without the _COMPAT option, and checked that there is no
reference to argp in the source.

 Adding the original submitter of this package in Cc for final verification.
Gregory, do you remember why you added the argp-standalone dependency?

 Regards,
 Arnout

> ---
>  package/libpthsem/Config.in    | 1 -
>  package/libpthsem/libpthsem.mk | 1 -
>  2 files changed, 2 deletions(-)
> 
> diff --git a/package/libpthsem/Config.in b/package/libpthsem/Config.in
> index 932acec..3219de1 100644
> --- a/package/libpthsem/Config.in
> +++ b/package/libpthsem/Config.in
> @@ -1,7 +1,6 @@
>  config BR2_PACKAGE_LIBPTHSEM
>  	bool "libpthsem"
>  	depends on BR2_USE_MMU # fork()
> -	select BR2_PACKAGE_ARGP_STANDALONE
>  	help
>  	  GNU pth is a user mode multi threading library. pthsem is an extend
>  	  version, with support for semaphores added.
> diff --git a/package/libpthsem/libpthsem.mk b/package/libpthsem/libpthsem.mk
> index 7c1de86..f9f6f71 100644
> --- a/package/libpthsem/libpthsem.mk
> +++ b/package/libpthsem/libpthsem.mk
> @@ -11,7 +11,6 @@ LIBPTHSEM_LICENSE = LGPLv2.1+
>  LIBPTHSEM_LICENSE_FILES = COPYING
>  LIBPTHSEM_AUTORECONF = YES
>  LIBPTHSEM_INSTALL_STAGING = YES
> -LIBPTHSEM_DEPENDENCIES = argp-standalone
>  LIBPTHSEM_CONFIG_SCRIPTS = pthsem-config
>  
>  ifeq ($(BR2_PACKAGE_LIBPTHSEM_COMPAT),y)
> 


-- 
Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F

[Buildroot] [PATCH 1/2] package/libpthsem: remove argp-standalone dependency

[Romain Naour]

Hi Arnout, All

Le 02/05/2015 14:21, Arnout Vandecappelle a ?crit :
> On 02/05/15 12:28, Romain Naour wrote:
>> argp-standalone provide libargp.a and argp.h which are
>> never used in libpthsem.
>>
>> Signed-off-by: Romain Naour <romain.naour@openwide.fr>
> 
> Acked-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
> Tested-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
>  Build-test with and without the _COMPAT option, and checked that there is no
> reference to argp in the source.
> 
>  Adding the original submitter of this package in Cc for final verification.
> Gregory, do you remember why you added the argp-standalone dependency?
> 
Peter find why argp-standalone was added to libpthsem:
http://git.buildroot.net/buildroot/commit/?id=25206d6e26dc4ce9c272e68876f31d0ca7d30e67

Gregory is also the original submitter of bcusdk package and it seems that he
added argp-standalone dependency to libpthsem instead of bcusdk.

Thank you Arnout for your review and test.

Best regards,
Romain

>  Regards,
>  Arnout
> 

[Buildroot] [PATCH 1/2] package/libpthsem: remove argp-standalone dependency

[Thomas Petazzoni]

Dear Romain Naour,

On Sat,  2 May 2015 12:28:05 +0200, Romain Naour wrote:
> argp-standalone provide libargp.a and argp.h which are
> never used in libpthsem.
> 
> Signed-off-by: Romain Naour <romain.naour@openwide.fr>
> ---
>  package/libpthsem/Config.in    | 1 -
>  package/libpthsem/libpthsem.mk | 1 -
>  2 files changed, 2 deletions(-)

Applied, thanks.

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com