[Buildroot] [PATCH 0/3] Caring at91bootstrap3

[Buildroot] [PATCH 0/3] Caring at91bootstrap3

[Angelo Compagnucci]

This patch series:
* Add license information to at91bootstrap
* Bumps to v3.7.2
* Add the option to download via git from custom url

Angelo Compagnucci (3):
  boot/at91bootstrap3: add license information
  boot/at91bootstrap3: bump to version 3.7.2
  boot/at91bootstrap3: download via cutom git url

 boot/at91bootstrap3/Config.in         | 34 ++++++++++++++++++++++++++++++++++
 boot/at91bootstrap3/at91bootstrap3.mk | 11 ++++++++++-
 2 files changed, 44 insertions(+), 1 deletion(-)

-- 
1.9.1

[Buildroot] [PATCH 1/3] boot/at91bootstrap3: add license information

[Angelo Compagnucci]

This patch adds licensing informations to at91bootstrap3

Signed-off-by: Angelo Compagnucci <angelo.compagnucci@gmail.com>
---
 boot/at91bootstrap3/at91bootstrap3.mk | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/boot/at91bootstrap3/at91bootstrap3.mk b/boot/at91bootstrap3/at91bootstrap3.mk
index ff49e14..2164a74 100644
--- a/boot/at91bootstrap3/at91bootstrap3.mk
+++ b/boot/at91bootstrap3/at91bootstrap3.mk
@@ -6,6 +6,8 @@
 
 AT91BOOTSTRAP3_VERSION = v3.7.1
 AT91BOOTSTRAP3_SITE = $(call github,linux4sam,at91bootstrap,$(AT91BOOTSTRAP3_VERSION))
+AT91BOOTSTRAP3_LICENSE = BSD-2c
+AT91BOOTSTRAP3_LICENSE_FILES = main.c
 
 AT91BOOTSTRAP3_INSTALL_IMAGES = YES
 AT91BOOTSTRAP3_INSTALL_TARGET = NO
-- 
1.9.1

[Buildroot] [PATCH 2/3] boot/at91bootstrap3: bump to version 3.7.2

[Angelo Compagnucci]

This patch bumps at91bootstrap3 version to 3.7.2

Signed-off-by: Angelo Compagnucci <angelo.compagnucci@gmail.com>
---
 boot/at91bootstrap3/at91bootstrap3.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/boot/at91bootstrap3/at91bootstrap3.mk b/boot/at91bootstrap3/at91bootstrap3.mk
index 2164a74..b73821e 100644
--- a/boot/at91bootstrap3/at91bootstrap3.mk
+++ b/boot/at91bootstrap3/at91bootstrap3.mk
@@ -4,7 +4,7 @@
 #
 ################################################################################
 
-AT91BOOTSTRAP3_VERSION = v3.7.1
+AT91BOOTSTRAP3_VERSION = v3.7.2
 AT91BOOTSTRAP3_SITE = $(call github,linux4sam,at91bootstrap,$(AT91BOOTSTRAP3_VERSION))
 AT91BOOTSTRAP3_LICENSE = BSD-2c
 AT91BOOTSTRAP3_LICENSE_FILES = main.c
-- 
1.9.1

[Buildroot] [PATCH 3/3] boot/at91bootstrap3: download via custom git url

[Angelo Compagnucci]

This patch adds the option to download at91bootstrap3 from
a custom git URL. This is a requirement for all that boards
that use a custom at91bootstrap3 version.

Signed-off-by: Angelo Compagnucci <angelo.compagnucci@gmail.com>
---
 boot/at91bootstrap3/Config.in         | 34 ++++++++++++++++++++++++++++++++++
 boot/at91bootstrap3/at91bootstrap3.mk |  9 ++++++++-
 2 files changed, 42 insertions(+), 1 deletion(-)

diff --git a/boot/at91bootstrap3/Config.in b/boot/at91bootstrap3/Config.in
index 8ac40ed..9f2f49b 100644
--- a/boot/at91bootstrap3/Config.in
+++ b/boot/at91bootstrap3/Config.in
@@ -10,6 +10,40 @@ config BR2_TARGET_AT91BOOTSTRAP3
 
 if BR2_TARGET_AT91BOOTSTRAP3
 
+choice
+
+	prompt "AT91 Bootstrap 3 version"
+
+config BR2_TARGET_AT91BOOTSTRAP3_LATEST_VERSION
+	bool "3.7.2"
+
+config BR2_TARGET_AT91BOOTSTRAP3_CUSTOM_GIT
+	bool "Custom Git repository"
+	help
+	  This option allows Buildroot to get the AT91 Bootstrap 3 source
+	  code from a Git repository.
+
+endchoice
+
+if BR2_TARGET_AT91BOOTSTRAP3_CUSTOM_GIT
+
+config BR2_TARGET_AT91BOOTSTRAP3_CUSTOM_REPO_URL
+	string "URL of custom repository"
+
+config BR2_TARGET_AT91BOOTSTRAP3_CUSTOM_REPO_VERSION
+	string "Custom repository version"
+	help
+	  Revision to use in the typical format used by Git
+	  E.G. a sha id, a tag, branch, ..
+
+endif
+
+config BR2_TARGET_AT91BOOTSTRAP3_VERSION
+	string
+	default "v3.7.2" if BR2_TARGET_AT91BOOTSTRAP3_LATEST_VERSION
+	default BR2_TARGET_AT91BOOTSTRAP3_CUSTOM_REPO_VERSION \
+		if BR2_TARGET_AT91BOOTSTRAP3_CUSTOM_GIT
+
 config BR2_TARGET_AT91BOOTSTRAP3_CUSTOM_PATCH_DIR
 	string "custom patch dir"
 	help
diff --git a/boot/at91bootstrap3/at91bootstrap3.mk b/boot/at91bootstrap3/at91bootstrap3.mk
index b73821e..fae2e8e 100644
--- a/boot/at91bootstrap3/at91bootstrap3.mk
+++ b/boot/at91bootstrap3/at91bootstrap3.mk
@@ -4,8 +4,15 @@
 #
 ################################################################################
 
-AT91BOOTSTRAP3_VERSION = v3.7.2
+AT91BOOTSTRAP3_VERSION = $(call qstrip,$(BR2_TARGET_AT91BOOTSTRAP3_VERSION))
+
+ifeq ($(BR2_TARGET_AT91BOOTSTRAP3_CUSTOM_GIT),y)
+AT91BOOTSTRAP3_SITE = $(call qstrip,$(BR2_TARGET_AT91BOOTSTRAP3_CUSTOM_REPO_URL))
+AT91BOOTSTRAP3_SITE_METHOD = git
+else
 AT91BOOTSTRAP3_SITE = $(call github,linux4sam,at91bootstrap,$(AT91BOOTSTRAP3_VERSION))
+endif
+
 AT91BOOTSTRAP3_LICENSE = BSD-2c
 AT91BOOTSTRAP3_LICENSE_FILES = main.c
 
-- 
1.9.1

[Buildroot] [PATCH 1/3] boot/at91bootstrap3: add license information

[Thomas Petazzoni]

Dear Angelo Compagnucci,

On Fri, 29 May 2015 11:38:44 +0200, Angelo Compagnucci wrote:
> This patch adds licensing informations to at91bootstrap3
> 
> Signed-off-by: Angelo Compagnucci <angelo.compagnucci@gmail.com>
> ---
>  boot/at91bootstrap3/at91bootstrap3.mk | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/boot/at91bootstrap3/at91bootstrap3.mk b/boot/at91bootstrap3/at91bootstrap3.mk
> index ff49e14..2164a74 100644
> --- a/boot/at91bootstrap3/at91bootstrap3.mk
> +++ b/boot/at91bootstrap3/at91bootstrap3.mk
> @@ -6,6 +6,8 @@
>  
>  AT91BOOTSTRAP3_VERSION = v3.7.1
>  AT91BOOTSTRAP3_SITE = $(call github,linux4sam,at91bootstrap,$(AT91BOOTSTRAP3_VERSION))
> +AT91BOOTSTRAP3_LICENSE = BSD-2c
> +AT91BOOTSTRAP3_LICENSE_FILES = main.c

I *think* it is actually closer to a BSD-3c, since it has the following
text:

 * Atmel's name may not be used to endorse or promote products derived from
 * this software without specific prior written permission.

However, the wording is not 100% the one of the BSD-3c, so I'm not sure
if we should call it BSD-3c or not.

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

[Buildroot] [PATCH 1/3] boot/at91bootstrap3: add license information

[Angelo Compagnucci]

Dear Thomas Petazzoni,

2015-05-31 10:43 GMT+02:00 Thomas Petazzoni
<thomas.petazzoni@free-electrons.com>:
> Dear Angelo Compagnucci,
>
> On Fri, 29 May 2015 11:38:44 +0200, Angelo Compagnucci wrote:
>> This patch adds licensing informations to at91bootstrap3
>>
>> Signed-off-by: Angelo Compagnucci <angelo.compagnucci@gmail.com>
>> ---
>>  boot/at91bootstrap3/at91bootstrap3.mk | 2 ++
>>  1 file changed, 2 insertions(+)
>>
>> diff --git a/boot/at91bootstrap3/at91bootstrap3.mk b/boot/at91bootstrap3/at91bootstrap3.mk
>> index ff49e14..2164a74 100644
>> --- a/boot/at91bootstrap3/at91bootstrap3.mk
>> +++ b/boot/at91bootstrap3/at91bootstrap3.mk
>> @@ -6,6 +6,8 @@
>>
>>  AT91BOOTSTRAP3_VERSION = v3.7.1
>>  AT91BOOTSTRAP3_SITE = $(call github,linux4sam,at91bootstrap,$(AT91BOOTSTRAP3_VERSION))
>> +AT91BOOTSTRAP3_LICENSE = BSD-2c
>> +AT91BOOTSTRAP3_LICENSE_FILES = main.c
>
> I *think* it is actually closer to a BSD-3c, since it has the following
> text:
>
>  * Atmel's name may not be used to endorse or promote products derived from
>  * this software without specific prior written permission.
>
> However, the wording is not 100% the one of the BSD-3c, so I'm not sure
> if we should call it BSD-3c or not.

Probably you are right, the wording is more similar to a BSD-3c
instead of a BSD-2c, but it's different. Can we use something like
BSD-custom or BSD-modified?

Sincerely, Angelo

>
> Thomas
> --
> Thomas Petazzoni, CTO, Free Electrons
> Embedded Linux, Kernel and Android engineering
> http://free-electrons.com



-- 
Profile: http://it.linkedin.com/in/compagnucciangelo

[Buildroot] [PATCH 1/3] boot/at91bootstrap3: add license information

[Arnout Vandecappelle]

On 06/01/15 18:03, Angelo Compagnucci wrote:
> Dear Thomas Petazzoni,
> 
> 2015-05-31 10:43 GMT+02:00 Thomas Petazzoni
> <thomas.petazzoni@free-electrons.com>:
>> Dear Angelo Compagnucci,
>>
>> On Fri, 29 May 2015 11:38:44 +0200, Angelo Compagnucci wrote:
>>> This patch adds licensing informations to at91bootstrap3
>>>
>>> Signed-off-by: Angelo Compagnucci <angelo.compagnucci@gmail.com>
>>> ---
>>>  boot/at91bootstrap3/at91bootstrap3.mk | 2 ++
>>>  1 file changed, 2 insertions(+)
>>>
>>> diff --git a/boot/at91bootstrap3/at91bootstrap3.mk b/boot/at91bootstrap3/at91bootstrap3.mk
>>> index ff49e14..2164a74 100644
>>> --- a/boot/at91bootstrap3/at91bootstrap3.mk
>>> +++ b/boot/at91bootstrap3/at91bootstrap3.mk
>>> @@ -6,6 +6,8 @@
>>>
>>>  AT91BOOTSTRAP3_VERSION = v3.7.1
>>>  AT91BOOTSTRAP3_SITE = $(call github,linux4sam,at91bootstrap,$(AT91BOOTSTRAP3_VERSION))
>>> +AT91BOOTSTRAP3_LICENSE = BSD-2c
>>> +AT91BOOTSTRAP3_LICENSE_FILES = main.c
>>
>> I *think* it is actually closer to a BSD-3c, since it has the following
>> text:
>>
>>  * Atmel's name may not be used to endorse or promote products derived from
>>  * this software without specific prior written permission.
>>
>> However, the wording is not 100% the one of the BSD-3c, so I'm not sure
>> if we should call it BSD-3c or not.
> 
> Probably you are right, the wording is more similar to a BSD-3c
> instead of a BSD-2c, but it's different. Can we use something like
> BSD-custom or BSD-modified?

 I would say

BSD-2c with endorsement clause

 That's still relatively short but also clear.

 Regards,
 Arnout


-- 
Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F

[Buildroot] [PATCH 3/3] boot/at91bootstrap3: download via custom git url

[Arnout Vandecappelle]

On 05/29/15 11:38, Angelo Compagnucci wrote:
> This patch adds the option to download at91bootstrap3 from
> a custom git URL. This is a requirement for all that boards
> that use a custom at91bootstrap3 version.
> 
> Signed-off-by: Angelo Compagnucci <angelo.compagnucci@gmail.com>
> ---
>  boot/at91bootstrap3/Config.in         | 34 ++++++++++++++++++++++++++++++++++
>  boot/at91bootstrap3/at91bootstrap3.mk |  9 ++++++++-
>  2 files changed, 42 insertions(+), 1 deletion(-)
> 
> diff --git a/boot/at91bootstrap3/Config.in b/boot/at91bootstrap3/Config.in
> index 8ac40ed..9f2f49b 100644
> --- a/boot/at91bootstrap3/Config.in
> +++ b/boot/at91bootstrap3/Config.in
> @@ -10,6 +10,40 @@ config BR2_TARGET_AT91BOOTSTRAP3
>  
>  if BR2_TARGET_AT91BOOTSTRAP3
>  
> +choice
> +
> +	prompt "AT91 Bootstrap 3 version"
> +
> +config BR2_TARGET_AT91BOOTSTRAP3_LATEST_VERSION
> +	bool "3.7.2"
> +
> +config BR2_TARGET_AT91BOOTSTRAP3_CUSTOM_GIT
> +	bool "Custom Git repository"
> +	help
> +	  This option allows Buildroot to get the AT91 Bootstrap 3 source
> +	  code from a Git repository.
> +
> +endchoice
> +
> +if BR2_TARGET_AT91BOOTSTRAP3_CUSTOM_GIT
> +
> +config BR2_TARGET_AT91BOOTSTRAP3_CUSTOM_REPO_URL
> +	string "URL of custom repository"
> +
> +config BR2_TARGET_AT91BOOTSTRAP3_CUSTOM_REPO_VERSION
> +	string "Custom repository version"
> +	help
> +	  Revision to use in the typical format used by Git
> +	  E.G. a sha id, a tag, branch, ..
> +
> +endif
> +
> +config BR2_TARGET_AT91BOOTSTRAP3_VERSION
> +	string
> +	default "v3.7.2" if BR2_TARGET_AT91BOOTSTRAP3_LATEST_VERSION
> +	default BR2_TARGET_AT91BOOTSTRAP3_CUSTOM_REPO_VERSION \
> +		if BR2_TARGET_AT91BOOTSTRAP3_CUSTOM_GIT
> +
>  config BR2_TARGET_AT91BOOTSTRAP3_CUSTOM_PATCH_DIR
>  	string "custom patch dir"
>  	help
> diff --git a/boot/at91bootstrap3/at91bootstrap3.mk b/boot/at91bootstrap3/at91bootstrap3.mk
> index b73821e..fae2e8e 100644
> --- a/boot/at91bootstrap3/at91bootstrap3.mk
> +++ b/boot/at91bootstrap3/at91bootstrap3.mk
> @@ -4,8 +4,15 @@
>  #
>  ################################################################################
>  
> -AT91BOOTSTRAP3_VERSION = v3.7.2
> +AT91BOOTSTRAP3_VERSION = $(call qstrip,$(BR2_TARGET_AT91BOOTSTRAP3_VERSION))
> +
> +ifeq ($(BR2_TARGET_AT91BOOTSTRAP3_CUSTOM_GIT),y)
> +AT91BOOTSTRAP3_SITE = $(call qstrip,$(BR2_TARGET_AT91BOOTSTRAP3_CUSTOM_REPO_URL))
> +AT91BOOTSTRAP3_SITE_METHOD = git
> +else
>  AT91BOOTSTRAP3_SITE = $(call github,linux4sam,at91bootstrap,$(AT91BOOTSTRAP3_VERSION))
> +endif
> +
>  AT91BOOTSTRAP3_LICENSE = BSD-2c
>  AT91BOOTSTRAP3_LICENSE_FILES = main.c

 There should be a check against an empty version in the custom repo case,
similar like it's done for uboot. Otherwise you get the cryptic:

>>> at91bootstrap3  Downloading
Doing full clone
fatal: The empty string is not a valid path
--2015-06-01 21:29:11--  http://sources.buildroot.net/at91bootstrap3-.tar.gz
Resolving sources.buildroot.net (sources.buildroot.net)... 176.9.16.109
Connecting to sources.buildroot.net (sources.buildroot.net)|176.9.16.109|:80...
connected.
HTTP request sent, awaiting response... 404 Not Found
2015-06-01 21:29:12 ERROR 404: Not Found.


 Otherwise, looks good to me.

 Regards,
 Arnout

-- 
Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F