[Buildroot] [PATCH 1/3] atf: new package

[Arnout Vandecappelle <arnout@mind.be>]

On 06/03/15 20:47, Sebastien Bourdelin wrote:
> ATF, or Automated Testing Framework, is a collection of libraries to
> write test programs in C, C++ and POSIX shell.
> 
> https://github.com/jmmv/atf
> 
> Signed-off-by: Sebastien Bourdelin <sebastien.bourdelin@savoirfairelinux.com>
> ---
>  package/Config.in     |  1 +
>  package/atf/Config.in | 11 +++++++++++
>  package/atf/atf.hash  |  2 ++
>  package/atf/atf.mk    | 21 +++++++++++++++++++++
>  4 files changed, 35 insertions(+)
>  create mode 100644 package/atf/Config.in
>  create mode 100644 package/atf/atf.hash
>  create mode 100644 package/atf/atf.mk
> 
> diff --git a/package/Config.in b/package/Config.in
> index e0c2e2a..78ed223 100644
> --- a/package/Config.in
> +++ b/package/Config.in
> @@ -57,6 +57,7 @@ endif
>  endmenu
>  
>  menu "Debugging, profiling and benchmark"
> +	source "package/atf/Config.in"
>  	source "package/blktrace/Config.in"
>  	source "package/bonnie/Config.in"
>  	source "package/cache-calibrator/Config.in"
> diff --git a/package/atf/Config.in b/package/atf/Config.in
> new file mode 100644
> index 0000000..59712ab
> --- /dev/null
> +++ b/package/atf/Config.in
> @@ -0,0 +1,11 @@
> +config BR2_PACKAGE_ATF
> +	bool "atf"
> +	depends on BR2_INSTALL_LIBSTDCPP
> +	help
> +	  ATF, or Automated Testing Framework, is a collection of
> +	  libraries to write test programs in C, C++ and POSIX shell.
> +
> +	  https://github.com/jmmv/atf
> +
> +comment "atf needs a toolchain w/ C++"
> +	depends on !BR2_INSTALL_LIBSTDCPP
> diff --git a/package/atf/atf.hash b/package/atf/atf.hash
> new file mode 100644
> index 0000000..cd929b8
> --- /dev/null
> +++ b/package/atf/atf.hash
> @@ -0,0 +1,2 @@
> +# Locally computed
> +sha256 3677cf957d7f574835b8bdd385984ba928d5695b3ff28f958e4227f810483ab7 atf-0.20.tar.gz
> diff --git a/package/atf/atf.mk b/package/atf/atf.mk
> new file mode 100644
> index 0000000..af691f5
> --- /dev/null
> +++ b/package/atf/atf.mk
> @@ -0,0 +1,21 @@
> +################################################################################
> +#
> +# atf
> +#
> +################################################################################
> +
> +ATF_VERSION = 0.20

 Why not use 0.21? Seems to be bugfixes only.

> +ATF_SOURCE = atf-$(ATF_VERSION).tar.gz
> +ATF_SITE = https://github.com/jmmv/atf/archive

 There's an uploaded archive at
https://github.com/jmmv/atf/releases/download/atf-0.21/atf-0.21.tar.gz
(same for 0.20). Then you don't need to AUTORECONF. Well, except that it has the
unreleased libtool beta which means that our patch doesn't apply so you need to
to autoreconf after all. But anyway, we prefer the uploaded archive.

 I you use the automatic archive (i.e. the URL you gave), then you can't have a
hash file. Also, you should use the github helper.


> +ATF_DEPENDENCIES = host-pkgconf

 As far as I can see, pkg-config is not used at build time, it's just some of
the tests that need it.

> +ATF_AUTORECONF = YES
> +ATF_INSTALL_STAGING = YES
> +ATF_LICENSE = BSD

 BSD-2c, BSD-3c

> +ATF_LICENSE_FILES = COPYING
> +ATF_CONF_ENV = \
> +	kyua_cv_getopt_plus=yes \
> +	kyua_cv_attribute_noreturn=yes \
> +	kyua_cv_getcwd_works=yes \
> +	ATF_SHELL=/bin/sh # default is /usr/bin/bash

 I think the default is actually the first shell it can find in the host path,
which in _your_ case happens to be /usr/bin/bash.

 Anyway, putting a comment at the end of the line is a bit dangerous, so I'd
rather put this above ATF_CONF_ENV:

# ATF_SHELL defaults to the host's bash
ATF_CONF_ENV = \
	...


 Regards,
 Arnout

> +
> +$(eval $(autotools-package))
> 


-- 
Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F