[Buildroot] [PATCH 1/1] openvmtools: add OPENVMTOOLS_VERSION_MAJOR variable

[Buildroot] [PATCH 1/1] openvmtools: add OPENVMTOOLS_VERSION_MAJOR variable

[Jerzy Grzegorek]

Signed-off-by: Jerzy Grzegorek <jerzy.grzegorek@trzebnica.net>
---
 package/openvmtools/openvmtools.mk | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/package/openvmtools/openvmtools.mk b/package/openvmtools/openvmtools.mk
index ef6544a..92ecd36 100644
--- a/package/openvmtools/openvmtools.mk
+++ b/package/openvmtools/openvmtools.mk
@@ -4,9 +4,10 @@
 #
 ################################################################################
 
-OPENVMTOOLS_VERSION = 9.10.0-2476743
+OPENVMTOOLS_VERSION_MAJOR = 9.10.0
+OPENVMTOOLS_VERSION = $(OPENVMTOOLS_VERSION_MAJOR)-2476743
 OPENVMTOOLS_SOURCE = open-vm-tools-$(OPENVMTOOLS_VERSION).tar.gz
-OPENVMTOOLS_SITE = http://downloads.sourceforge.net/project/open-vm-tools/open-vm-tools/stable-9.10.0
+OPENVMTOOLS_SITE = http://downloads.sourceforge.net/project/open-vm-tools/open-vm-tools/stable-$(OPENVMTOOLS_VERSION_MAJOR)
 OPENVMTOOLS_LICENSE = LGPLv2.1
 OPENVMTOOLS_LICENSE_FILES = COPYING
 # Autoreconf needed or config/missing will run configure again at buildtime
-- 
1.9.1

[Buildroot] [PATCH 1/1] openvmtools: add OPENVMTOOLS_VERSION_MAJOR variable

[Károly Kasza]

Hi,

the official openvmtools repo is also moving to GitHub, maybe we should
modify the whole download process?
I thought I'll wait for the next release before moving from sourceforge to
github, but we could also do it now.
The back draw it that hash files can not be used with Github currently
(AFAIK).

Regards,
Karoly
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20150610/237526b5/attachment.html>

[Buildroot] [PATCH 1/1] openvmtools: add OPENVMTOOLS_VERSION_MAJOR variable

[Jerzy Grzegorek]

Hi K?roly,

> Hi,
>
> the official openvmtools repo is also moving to GitHub, maybe we 
> should modify the whole download process?
> I thought I'll wait for the next release before moving from 
> sourceforge to github, but we could also do it now.

Thanks for the review.
Feel free to submit such a patch.

> The back draw it that hash files can not be used with Github currently 
> (AFAIK).

Let's wait and see what others think.

Regards,
Jerzy

>
> Regards,
> Karoly

[Buildroot] [PATCH 1/1] openvmtools: add OPENVMTOOLS_VERSION_MAJOR variable

[Arnout Vandecappelle]

On 06/10/15 08:44, Jerzy Grzegorek wrote:
> Signed-off-by: Jerzy Grzegorek <jerzy.grzegorek@trzebnica.net>

Reviewed-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>

 Note that the proposed move to github is a good idea, but a separate patch anyway.

 Regards,
 Arnout

> ---
>  package/openvmtools/openvmtools.mk | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/package/openvmtools/openvmtools.mk b/package/openvmtools/openvmtools.mk
> index ef6544a..92ecd36 100644
> --- a/package/openvmtools/openvmtools.mk
> +++ b/package/openvmtools/openvmtools.mk
> @@ -4,9 +4,10 @@
>  #
>  ################################################################################
>  
> -OPENVMTOOLS_VERSION = 9.10.0-2476743
> +OPENVMTOOLS_VERSION_MAJOR = 9.10.0
> +OPENVMTOOLS_VERSION = $(OPENVMTOOLS_VERSION_MAJOR)-2476743
>  OPENVMTOOLS_SOURCE = open-vm-tools-$(OPENVMTOOLS_VERSION).tar.gz
> -OPENVMTOOLS_SITE = http://downloads.sourceforge.net/project/open-vm-tools/open-vm-tools/stable-9.10.0
> +OPENVMTOOLS_SITE = http://downloads.sourceforge.net/project/open-vm-tools/open-vm-tools/stable-$(OPENVMTOOLS_VERSION_MAJOR)
>  OPENVMTOOLS_LICENSE = LGPLv2.1
>  OPENVMTOOLS_LICENSE_FILES = COPYING
>  # Autoreconf needed or config/missing will run configure again at buildtime
> 


-- 
Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F

[Buildroot] [PATCH 1/1] openvmtools: add OPENVMTOOLS_VERSION_MAJOR variable

[Thomas Petazzoni]

Dear Jerzy Grzegorek,

On Wed, 10 Jun 2015 08:44:30 +0200, Jerzy Grzegorek wrote:
> Signed-off-by: Jerzy Grzegorek <jerzy.grzegorek@trzebnica.net>
> ---
>  package/openvmtools/openvmtools.mk | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)

Applied, thanks.

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com