[Buildroot] [PATCH] directfb: add an option for debugging support

[Buildroot] [PATCH] directfb: add an option for debugging support

[Cédric Marie]

DirectFB debugging support is enabled by default. This new option makes
it possible to disable it (--disable-debug-support) and build the
library with no debug feature at all.

NB: When debugging support is disabled, the target installation path is
suffixed with -pure.

Signed-off-by: C?dric Marie <cedric.marie@openmailbox.org>
---
 package/directfb/Config.in   | 7 +++++++
 package/directfb/directfb.mk | 4 ++++
 2 files changed, 11 insertions(+)

diff --git a/package/directfb/Config.in b/package/directfb/Config.in
index 7759f8f..0015c0c 100644
--- a/package/directfb/Config.in
+++ b/package/directfb/Config.in
@@ -20,8 +20,15 @@ config BR2_PACKAGE_DIRECTFB_MULTI
 comment "directfb multi application needs a Linux kernel to be built"
 	depends on !BR2_LINUX_KERNEL
 
+config BR2_PACKAGE_DIRECTFB_DEBUG_SUPPORT
+	bool "directfb debugging support"
+	default y
+	help
+	  Compile DirectFB with debugging support
+
 config BR2_PACKAGE_DIRECTFB_DEBUG
 	bool "directfb debugging"
+	depends on BR2_PACKAGE_DIRECTFB_DEBUG_SUPPORT
 	help
 	  Compile DirectFB with lots of debug output
 
diff --git a/package/directfb/directfb.mk b/package/directfb/directfb.mk
index e3dc506..d8af56e 100644
--- a/package/directfb/directfb.mk
+++ b/package/directfb/directfb.mk
@@ -39,6 +39,10 @@ DIRECTFB_CONF_OPTS += --enable-multi --enable-fusion
 DIRECTFB_DEPENDENCIES += linux-fusion
 endif
 
+ifneq ($(BR2_PACKAGE_DIRECTFB_DEBUG_SUPPORT),y)
+DIRECTFB_CONF_OPTS += --disable-debug-support
+endif
+
 ifeq ($(BR2_PACKAGE_DIRECTFB_DEBUG),y)
 DIRECTFB_CONF_OPTS += --enable-debug
 endif
-- 
2.1.4

[Buildroot] [PATCH] directfb: add an option for debugging support

[Cédric Marie]

DirectFB debugging support is enabled by default. This new option makes
it possible to disable it (--disable-debug-support) and build the
library with no debug feature at all.

NB: When debugging support is disabled, the target installation path is
suffixed with -pure.

Signed-off-by: C?dric Marie <cedric.marie@openmailbox.org>
---
 package/directfb/Config.in   | 7 +++++++
 package/directfb/directfb.mk | 4 ++++
 2 files changed, 11 insertions(+)

diff --git a/package/directfb/Config.in b/package/directfb/Config.in
index 7759f8f..0015c0c 100644
--- a/package/directfb/Config.in
+++ b/package/directfb/Config.in
@@ -20,8 +20,15 @@ config BR2_PACKAGE_DIRECTFB_MULTI
 comment "directfb multi application needs a Linux kernel to be built"
 	depends on !BR2_LINUX_KERNEL
 
+config BR2_PACKAGE_DIRECTFB_DEBUG_SUPPORT
+	bool "directfb debugging support"
+	default y
+	help
+	  Compile DirectFB with debugging support
+
 config BR2_PACKAGE_DIRECTFB_DEBUG
 	bool "directfb debugging"
+	depends on BR2_PACKAGE_DIRECTFB_DEBUG_SUPPORT
 	help
 	  Compile DirectFB with lots of debug output
 
diff --git a/package/directfb/directfb.mk b/package/directfb/directfb.mk
index e3dc506..cf0609c 100644
--- a/package/directfb/directfb.mk
+++ b/package/directfb/directfb.mk
@@ -39,9 +39,13 @@ DIRECTFB_CONF_OPTS += --enable-multi --enable-fusion
 DIRECTFB_DEPENDENCIES += linux-fusion
 endif
 
+ifeq ($(BR2_PACKAGE_DIRECTFB_DEBUG_SUPPORT),y)
 ifeq ($(BR2_PACKAGE_DIRECTFB_DEBUG),y)
 DIRECTFB_CONF_OPTS += --enable-debug
 endif
+else
+DIRECTFB_CONF_OPTS += --disable-debug-support
+endif
 
 ifeq ($(BR2_PACKAGE_DIRECTFB_TRACE),y)
 DIRECTFB_CONF_OPTS += --enable-trace
-- 
2.1.4

[Buildroot] [PATCH] directfb: add an option for debugging support

[Cédric Marie]

Hi,

Sorry for the noise...
Please forget the first version of the patch. The second one looks 
better to me.

Thank you.

C?dric


Le 09/06/2015 22:32, C?dric Marie a ?crit :
> DirectFB debugging support is enabled by default. This new option makes
> it possible to disable it (--disable-debug-support) and build the
> library with no debug feature at all.
>
> NB: When debugging support is disabled, the target installation path is
> suffixed with -pure.
>
> Signed-off-by: C?dric Marie <cedric.marie@openmailbox.org>
> ---
>   package/directfb/Config.in   | 7 +++++++
>   package/directfb/directfb.mk | 4 ++++
>   2 files changed, 11 insertions(+)
>
> diff --git a/package/directfb/Config.in b/package/directfb/Config.in
> index 7759f8f..0015c0c 100644
> --- a/package/directfb/Config.in
> +++ b/package/directfb/Config.in
> @@ -20,8 +20,15 @@ config BR2_PACKAGE_DIRECTFB_MULTI
>   comment "directfb multi application needs a Linux kernel to be built"
>   	depends on !BR2_LINUX_KERNEL
>
> +config BR2_PACKAGE_DIRECTFB_DEBUG_SUPPORT
> +	bool "directfb debugging support"
> +	default y
> +	help
> +	  Compile DirectFB with debugging support
> +
>   config BR2_PACKAGE_DIRECTFB_DEBUG
>   	bool "directfb debugging"
> +	depends on BR2_PACKAGE_DIRECTFB_DEBUG_SUPPORT
>   	help
>   	  Compile DirectFB with lots of debug output
>
> diff --git a/package/directfb/directfb.mk b/package/directfb/directfb.mk
> index e3dc506..d8af56e 100644
> --- a/package/directfb/directfb.mk
> +++ b/package/directfb/directfb.mk
> @@ -39,6 +39,10 @@ DIRECTFB_CONF_OPTS += --enable-multi --enable-fusion
>   DIRECTFB_DEPENDENCIES += linux-fusion
>   endif
>
> +ifneq ($(BR2_PACKAGE_DIRECTFB_DEBUG_SUPPORT),y)
> +DIRECTFB_CONF_OPTS += --disable-debug-support
> +endif
> +
>   ifeq ($(BR2_PACKAGE_DIRECTFB_DEBUG),y)
>   DIRECTFB_CONF_OPTS += --enable-debug
>   endif
>

-- 
C?dric

[Buildroot] [PATCH] directfb: add an option for debugging support

[Arnout Vandecappelle]

On 06/09/15 22:43, C?dric Marie wrote:
> DirectFB debugging support is enabled by default. This new option makes
> it possible to disable it (--disable-debug-support) and build the
> library with no debug feature at all.
> 
> NB: When debugging support is disabled, the target installation path is
> suffixed with -pure.
> 
> Signed-off-by: C?dric Marie <cedric.marie@openmailbox.org>
> ---
>  package/directfb/Config.in   | 7 +++++++
>  package/directfb/directfb.mk | 4 ++++
>  2 files changed, 11 insertions(+)
> 
> diff --git a/package/directfb/Config.in b/package/directfb/Config.in
> index 7759f8f..0015c0c 100644
> --- a/package/directfb/Config.in
> +++ b/package/directfb/Config.in
> @@ -20,8 +20,15 @@ config BR2_PACKAGE_DIRECTFB_MULTI
>  comment "directfb multi application needs a Linux kernel to be built"
>  	depends on !BR2_LINUX_KERNEL
>  
> +config BR2_PACKAGE_DIRECTFB_DEBUG_SUPPORT
> +	bool "directfb debugging support"
> +	default y
> +	help
> +	  Compile DirectFB with debugging support

 I think the explanation you gave in your first mail would be valuable here.
Certainly, the fact that the target installation path is suffixed with -pure
should be clarified.

 Do all the packages that depend on directfb still build correctly with this
-pure suffix?

 Regards,
 Arnout

> +
>  config BR2_PACKAGE_DIRECTFB_DEBUG
>  	bool "directfb debugging"
> +	depends on BR2_PACKAGE_DIRECTFB_DEBUG_SUPPORT
>  	help
>  	  Compile DirectFB with lots of debug output
>  
> diff --git a/package/directfb/directfb.mk b/package/directfb/directfb.mk
> index e3dc506..cf0609c 100644
> --- a/package/directfb/directfb.mk
> +++ b/package/directfb/directfb.mk
> @@ -39,9 +39,13 @@ DIRECTFB_CONF_OPTS += --enable-multi --enable-fusion
>  DIRECTFB_DEPENDENCIES += linux-fusion
>  endif
>  
> +ifeq ($(BR2_PACKAGE_DIRECTFB_DEBUG_SUPPORT),y)
>  ifeq ($(BR2_PACKAGE_DIRECTFB_DEBUG),y)
>  DIRECTFB_CONF_OPTS += --enable-debug
>  endif
> +else
> +DIRECTFB_CONF_OPTS += --disable-debug-support
> +endif
>  
>  ifeq ($(BR2_PACKAGE_DIRECTFB_TRACE),y)
>  DIRECTFB_CONF_OPTS += --enable-trace
> 


-- 
Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F

[Buildroot] [PATCH] directfb: add an option for debugging support

[Cédric Marie]

Hi,

Le 2015-06-10 23:45, Arnout Vandecappelle a ?crit?:
>  I think the explanation you gave in your first mail would be valuable 
> here.

OK. I didn't want to give too much details in the end, but you're right.


> Certainly, the fact that the target installation path is suffixed with 
> -pure
> should be clarified.
> 
>  Do all the packages that depend on directfb still build correctly with 
> this
> -pure suffix?

The public library is not moved: /usr/lib/libdirectfb.so
Only internal libraries are placed in a different directory: 
/usr/lib/directfb-x.y.z-pure/
It contains following directories: gfxdrivers, inputdrivers, interfaces, 
systems, wm.
It makes no difference for applications using DFB.


Would you be satisfied with that description below, as a commit message?


DirectFB provides two options for debug:
* --enable-debug-support (default is yes)
* --enable-debug (default is no)
The first one provides the functions to print debug information. These
functions can be called inside DirectFB, or by an external DirectFB
driver in another package.
The second one enables verbose mode in DirectFB, using these functions.

Buildroot currently provides an option for the second one only. The
first one - which is necessary for the second one - is always enabled,
because this is the default value.

The new option (BR2_PACKAGE_DIRECTFB_DEBUG_SUPPORT) makes it possible
to disable debugging support (--disable-debug-support) in order to
build the library with no debug feature at all.

When debugging support is disabled, the target installation path of
internal libraries (/usr/lib/directfb-<version>) is suffixed with
-pure. The public library (/usr/lib/libdirectfb.so) remains unchanged.

Some external DirectFB drivers will install in
/usr/lib/directfb-<version>-pure in release mode. For that reason, it
is important that DirectFB can be configured to use this directory.



-- 
C?dric

[Buildroot] [PATCH] directfb: add an option for debugging support

[Arnout Vandecappelle]

On 06/11/15 14:58, C?dric Marie wrote:
> Hi,
> 
> Le 2015-06-10 23:45, Arnout Vandecappelle a ?crit :
>>  I think the explanation you gave in your first mail would be valuable here.
> 
> OK. I didn't want to give too much details in the end, but you're right.
> 
> 
>> Certainly, the fact that the target installation path is suffixed with -pure
>> should be clarified.
>>
>>  Do all the packages that depend on directfb still build correctly with this
>> -pure suffix?
> 
> The public library is not moved: /usr/lib/libdirectfb.so
> Only internal libraries are placed in a different directory:
> /usr/lib/directfb-x.y.z-pure/
> It contains following directories: gfxdrivers, inputdrivers, interfaces,
> systems, wm.
> It makes no difference for applications using DFB.
> 
> 
> Would you be satisfied with that description below, as a commit message?

 Yes, but I was in fact mainly talking about the help text of the new option.

 Regards,
 Arnout

> 
> 
> DirectFB provides two options for debug:
> * --enable-debug-support (default is yes)
> * --enable-debug (default is no)
> The first one provides the functions to print debug information. These
> functions can be called inside DirectFB, or by an external DirectFB
> driver in another package.
> The second one enables verbose mode in DirectFB, using these functions.
> 
> Buildroot currently provides an option for the second one only. The
> first one - which is necessary for the second one - is always enabled,
> because this is the default value.
> 
> The new option (BR2_PACKAGE_DIRECTFB_DEBUG_SUPPORT) makes it possible
> to disable debugging support (--disable-debug-support) in order to
> build the library with no debug feature at all.
> 
> When debugging support is disabled, the target installation path of
> internal libraries (/usr/lib/directfb-<version>) is suffixed with
> -pure. The public library (/usr/lib/libdirectfb.so) remains unchanged.
> 
> Some external DirectFB drivers will install in
> /usr/lib/directfb-<version>-pure in release mode. For that reason, it
> is important that DirectFB can be configured to use this directory.
> 
> 
> 


-- 
Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F

[Buildroot] [PATCH] directfb: add an option for debugging support

[Cédric Marie]

Hi,

Le 11/06/2015 22:32, Arnout Vandecappelle a ?crit :
>   Yes, but I was in fact mainly talking about the help text of the new option.

Oops, sorry.
But I suppose I shouldn't give so much details in the help text, as in 
the commit message.
What do you think is important to mention?

Here is a proposal, feel free to comment/modify:

Compile DirectFB with debugging support. It provides functions to print 
debug information, for DirectFB as well as external DirectFB drivers.
When disabled, DirectFB has got no debug feature at all, and the 
directory that contains the internal libraries is suffixed with -pure
(/usr/lib/directfb-<version>-pure/).


NB: I'm not really satisfied with "internal libraries", but I can't find 
the right expression for that. It contains gfx drivers, but not only...


-- 
C?dric

[Buildroot] [PATCH] directfb: add an option for debugging support

[Arnout Vandecappelle]

On 06/11/15 23:20, C?dric Marie wrote:
> Hi,
> 
> Le 11/06/2015 22:32, Arnout Vandecappelle a ?crit :
>>   Yes, but I was in fact mainly talking about the help text of the new option.
> 
> Oops, sorry.
> But I suppose I shouldn't give so much details in the help text, as in the
> commit message.
> What do you think is important to mention?
> 
> Here is a proposal, feel free to comment/modify:
> 
> Compile DirectFB with debugging support. It provides functions to print debug
> information, for DirectFB as well as external DirectFB drivers.
> When disabled, DirectFB has got no debug feature at all, and the directory that

When disabled, DirectFB does not print any debug information. The drivers will
be installed to and loaded from /usr/lib/directfb-<version>-pure instead of
/usr/lib/directfb-<version>-.

> contains the internal libraries is suffixed with -pure
> (/usr/lib/directfb-<version>-pure/).
> 
> 
> NB: I'm not really satisfied with "internal libraries", but I can't find the
> right expression for that. It contains gfx drivers, but not only...

 gfx drivers, input drivers, window systems drivers, ... I think it's drivers
:-) Only interfaces doesn't fit.


 Regards,
 Arnout



-- 
Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F

[Buildroot] [PATCH] directfb: add an option for debugging support

[Cédric Marie]

Le 2015-06-12 00:24, Arnout Vandecappelle a ?crit?:
> When disabled, DirectFB does not print any debug information. The 
> drivers will
> be installed to and loaded from /usr/lib/directfb-<version>-pure 
> instead of
> /usr/lib/directfb-<version>.

OK. Sounds better like this :)


>  gfx drivers, input drivers, window systems drivers, ... I think it's 
> drivers
> :-) Only interfaces doesn't fit.

hmmm... I guess you're right :)
Thank you, I will "git format" a nice brand new patch. Coming "soon"...


Regards,

-- 
C?dric

[Buildroot] [PATCH] directfb: add an option for debugging support

[Cédric Marie]

DirectFB provides two options for debug:
* --enable-debug-support (default is yes)
* --enable-debug (default is no)
The first one provides the functions to print debug information. These
functions can be called inside DirectFB, or by an external DirectFB
driver in another package.
The second one enables verbose mode in DirectFB, using these functions.

Buildroot currently provides an option for the second one only. The
first one - which is necessary for the second one - is always enabled,
because this is the default value.

The new option (BR2_PACKAGE_DIRECTFB_DEBUG_SUPPORT) makes it possible
to disable debugging support (--disable-debug-support) in order to
build the library with no debug feature at all.

When debugging support is disabled, the target installation path of
drivers (/usr/lib/directfb-<version>) is suffixed with -pure. The
public library (/usr/lib/libdirectfb.so) remains unchanged.

Some external DirectFB drivers will install into
/usr/lib/directfb-<version>-pure in release mode. For that reason, it
is important that DirectFB can be configured to use this directory.

Signed-off-by: C?dric Marie <cedric.marie@openmailbox.org>
---
 package/directfb/Config.in   | 14 ++++++++++++++
 package/directfb/directfb.mk |  4 ++++
 2 files changed, 18 insertions(+)

diff --git a/package/directfb/Config.in b/package/directfb/Config.in
index 7759f8f..2b0d5c7 100644
--- a/package/directfb/Config.in
+++ b/package/directfb/Config.in
@@ -20,8 +20,22 @@ config BR2_PACKAGE_DIRECTFB_MULTI
 comment "directfb multi application needs a Linux kernel to be built"
 	depends on !BR2_LINUX_KERNEL
 
+config BR2_PACKAGE_DIRECTFB_DEBUG_SUPPORT
+	bool "directfb debugging support"
+	default y
+	help
+	  Compile DirectFB with debugging support. It provides
+	  functions to print debug information, for DirectFB as well as
+	  external DirectFB drivers.
+
+	  When disabled, DirectFB does not print any debug information.
+	  The drivers will be installed to and loaded from
+	  /usr/lib/directfb-<version>-pure instead of
+	  /usr/lib/directfb-<version>.
+
 config BR2_PACKAGE_DIRECTFB_DEBUG
 	bool "directfb debugging"
+	depends on BR2_PACKAGE_DIRECTFB_DEBUG_SUPPORT
 	help
 	  Compile DirectFB with lots of debug output
 
diff --git a/package/directfb/directfb.mk b/package/directfb/directfb.mk
index e3dc506..cf0609c 100644
--- a/package/directfb/directfb.mk
+++ b/package/directfb/directfb.mk
@@ -39,9 +39,13 @@ DIRECTFB_CONF_OPTS += --enable-multi --enable-fusion
 DIRECTFB_DEPENDENCIES += linux-fusion
 endif
 
+ifeq ($(BR2_PACKAGE_DIRECTFB_DEBUG_SUPPORT),y)
 ifeq ($(BR2_PACKAGE_DIRECTFB_DEBUG),y)
 DIRECTFB_CONF_OPTS += --enable-debug
 endif
+else
+DIRECTFB_CONF_OPTS += --disable-debug-support
+endif
 
 ifeq ($(BR2_PACKAGE_DIRECTFB_TRACE),y)
 DIRECTFB_CONF_OPTS += --enable-trace
-- 
2.1.4

[Buildroot] [PATCH] directfb: add an option for debugging support

[Arnout Vandecappelle]

On 06/14/15 22:51, C?dric Marie wrote:
> DirectFB provides two options for debug:
> * --enable-debug-support (default is yes)
> * --enable-debug (default is no)
> The first one provides the functions to print debug information. These
> functions can be called inside DirectFB, or by an external DirectFB
> driver in another package.
> The second one enables verbose mode in DirectFB, using these functions.
> 
> Buildroot currently provides an option for the second one only. The
> first one - which is necessary for the second one - is always enabled,
> because this is the default value.
> 
> The new option (BR2_PACKAGE_DIRECTFB_DEBUG_SUPPORT) makes it possible
> to disable debugging support (--disable-debug-support) in order to
> build the library with no debug feature at all.
> 
> When debugging support is disabled, the target installation path of
> drivers (/usr/lib/directfb-<version>) is suffixed with -pure. The
> public library (/usr/lib/libdirectfb.so) remains unchanged.
> 
> Some external DirectFB drivers will install into
> /usr/lib/directfb-<version>-pure in release mode. For that reason, it
> is important that DirectFB can be configured to use this directory.
> 
> Signed-off-by: C?dric Marie <cedric.marie@openmailbox.org>
[snip]
> +ifeq ($(BR2_PACKAGE_DIRECTFB_DEBUG_SUPPORT),y)
>  ifeq ($(BR2_PACKAGE_DIRECTFB_DEBUG),y)
>  DIRECTFB_CONF_OPTS += --enable-debug
>  endif

 There should be a --enable-debug-support somewhere around here,

 Regards,
 Arnout


> +else
> +DIRECTFB_CONF_OPTS += --disable-debug-support
> +endif
>  
>  ifeq ($(BR2_PACKAGE_DIRECTFB_TRACE),y)
>  DIRECTFB_CONF_OPTS += --enable-trace
> 


-- 
Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F

[Buildroot] [PATCH] directfb: add an option for debugging support

[Cédric Marie]

Le 2015-06-15 00:07, Arnout Vandecappelle a ?crit?:
>  There should be a --enable-debug-support somewhere around here,

You're right, that would be safer. In case they change the default 
value.
I will add it.

But I can't see any clear rule for that...
--enable-multi, --enable-fusion, --enable-debug, --enable-trace have no 
disable counterpart.
--enable-x11, --enable-unique, --enable-gif do have a --disable 
counterpart.

Moreover, there is a --disable-multi for host-directfb, while it is 
assumed to be the default for directfb (--enable-multi with no 
counterpart).


-- 
C?dric

[Buildroot] [PATCH] directfb: add an option for debugging support

[Cédric Marie]

DirectFB provides two options for debug:
* --enable-debug-support (default is yes)
* --enable-debug (default is no)
The first one provides the functions to print debug information. These
functions can be called inside DirectFB, or by an external DirectFB
driver in another package.
The second one enables verbose mode in DirectFB, using these functions.

Buildroot currently provides an option for the second one only. The
first one - which is necessary for the second one - is always enabled,
because this is the default value.

The new option (BR2_PACKAGE_DIRECTFB_DEBUG_SUPPORT) makes it possible
to disable debugging support (--disable-debug-support) in order to
build the library with no debug feature at all.

When debugging support is disabled, the target installation path of
drivers (/usr/lib/directfb-<version>) is suffixed with -pure. The
public library (/usr/lib/libdirectfb.so) remains unchanged.

Some external DirectFB drivers will install into
/usr/lib/directfb-<version>-pure in release mode. For that reason, it
is important that DirectFB can be configured to use this directory.

Signed-off-by: C?dric Marie <cedric.marie@openmailbox.org>
---
 package/directfb/Config.in   | 14 ++++++++++++++
 package/directfb/directfb.mk |  5 +++++
 2 files changed, 19 insertions(+)

diff --git a/package/directfb/Config.in b/package/directfb/Config.in
index 7759f8f..2b0d5c7 100644
--- a/package/directfb/Config.in
+++ b/package/directfb/Config.in
@@ -20,8 +20,22 @@ config BR2_PACKAGE_DIRECTFB_MULTI
 comment "directfb multi application needs a Linux kernel to be built"
 	depends on !BR2_LINUX_KERNEL
 
+config BR2_PACKAGE_DIRECTFB_DEBUG_SUPPORT
+	bool "directfb debugging support"
+	default y
+	help
+	  Compile DirectFB with debugging support. It provides
+	  functions to print debug information, for DirectFB as well as
+	  external DirectFB drivers.
+
+	  When disabled, DirectFB does not print any debug information.
+	  The drivers will be installed to and loaded from
+	  /usr/lib/directfb-<version>-pure instead of
+	  /usr/lib/directfb-<version>.
+
 config BR2_PACKAGE_DIRECTFB_DEBUG
 	bool "directfb debugging"
+	depends on BR2_PACKAGE_DIRECTFB_DEBUG_SUPPORT
 	help
 	  Compile DirectFB with lots of debug output
 
diff --git a/package/directfb/directfb.mk b/package/directfb/directfb.mk
index e3dc506..ad1dd18 100644
--- a/package/directfb/directfb.mk
+++ b/package/directfb/directfb.mk
@@ -39,9 +39,14 @@ DIRECTFB_CONF_OPTS += --enable-multi --enable-fusion
 DIRECTFB_DEPENDENCIES += linux-fusion
 endif
 
+ifeq ($(BR2_PACKAGE_DIRECTFB_DEBUG_SUPPORT),y)
+DIRECTFB_CONF_OPTS += --enable-debug-support
 ifeq ($(BR2_PACKAGE_DIRECTFB_DEBUG),y)
 DIRECTFB_CONF_OPTS += --enable-debug
 endif
+else
+DIRECTFB_CONF_OPTS += --disable-debug-support
+endif
 
 ifeq ($(BR2_PACKAGE_DIRECTFB_TRACE),y)
 DIRECTFB_CONF_OPTS += --enable-trace
-- 
2.1.4

[Buildroot] [PATCH] directfb: add an option for debugging support

[Arnout Vandecappelle]

On 06/15/15 08:33, C?dric Marie wrote:
> Le 2015-06-15 00:07, Arnout Vandecappelle a ?crit :
>>  There should be a --enable-debug-support somewhere around here,
> 
> You're right, that would be safer. In case they change the default value.
> I will add it.
> 
> But I can't see any clear rule for that...
> --enable-multi, --enable-fusion, --enable-debug, --enable-trace have no disable
> counterpart.
> --enable-x11, --enable-unique, --enable-gif do have a --disable counterpart.
> 
> Moreover, there is a --disable-multi for host-directfb, while it is assumed to
> be the default for directfb (--enable-multi with no counterpart).


 Historical accident. Nowadays we try to enforce enable/disable pairs during review.


 Regards,
 Arnout


-- 
Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F

[Buildroot] [PATCH] directfb: add an option for debugging support

[Arnout Vandecappelle]

On 06/15/15 22:02, C?dric Marie wrote:
> DirectFB provides two options for debug:
> * --enable-debug-support (default is yes)
> * --enable-debug (default is no)
> The first one provides the functions to print debug information. These
> functions can be called inside DirectFB, or by an external DirectFB
> driver in another package.
> The second one enables verbose mode in DirectFB, using these functions.
> 
> Buildroot currently provides an option for the second one only. The
> first one - which is necessary for the second one - is always enabled,
> because this is the default value.
> 
> The new option (BR2_PACKAGE_DIRECTFB_DEBUG_SUPPORT) makes it possible
> to disable debugging support (--disable-debug-support) in order to
> build the library with no debug feature at all.
> 
> When debugging support is disabled, the target installation path of
> drivers (/usr/lib/directfb-<version>) is suffixed with -pure. The
> public library (/usr/lib/libdirectfb.so) remains unchanged.
> 
> Some external DirectFB drivers will install into
> /usr/lib/directfb-<version>-pure in release mode. For that reason, it
> is important that DirectFB can be configured to use this directory.
> 
> Signed-off-by: C?dric Marie <cedric.marie@openmailbox.org>

Reviewed-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>


 In the future, please give your patches a version number (using git
format-patch -v2 or --subject-prefix='PATCH v2') and include a changelog in the
commit message, e.g.:

---
v2: add explicit --disable-debug-support (Arnout)


The lines below --- will be automatically stripped from the commit message when
it is applied.

 Regards,
 Arnout

> ---
>  package/directfb/Config.in   | 14 ++++++++++++++
>  package/directfb/directfb.mk |  5 +++++
>  2 files changed, 19 insertions(+)
> 
> diff --git a/package/directfb/Config.in b/package/directfb/Config.in
> index 7759f8f..2b0d5c7 100644
> --- a/package/directfb/Config.in
> +++ b/package/directfb/Config.in
> @@ -20,8 +20,22 @@ config BR2_PACKAGE_DIRECTFB_MULTI
>  comment "directfb multi application needs a Linux kernel to be built"
>  	depends on !BR2_LINUX_KERNEL
>  
> +config BR2_PACKAGE_DIRECTFB_DEBUG_SUPPORT
> +	bool "directfb debugging support"
> +	default y
> +	help
> +	  Compile DirectFB with debugging support. It provides
> +	  functions to print debug information, for DirectFB as well as
> +	  external DirectFB drivers.
> +
> +	  When disabled, DirectFB does not print any debug information.
> +	  The drivers will be installed to and loaded from
> +	  /usr/lib/directfb-<version>-pure instead of
> +	  /usr/lib/directfb-<version>.
> +
>  config BR2_PACKAGE_DIRECTFB_DEBUG
>  	bool "directfb debugging"
> +	depends on BR2_PACKAGE_DIRECTFB_DEBUG_SUPPORT
>  	help
>  	  Compile DirectFB with lots of debug output
>  
> diff --git a/package/directfb/directfb.mk b/package/directfb/directfb.mk
> index e3dc506..ad1dd18 100644
> --- a/package/directfb/directfb.mk
> +++ b/package/directfb/directfb.mk
> @@ -39,9 +39,14 @@ DIRECTFB_CONF_OPTS += --enable-multi --enable-fusion
>  DIRECTFB_DEPENDENCIES += linux-fusion
>  endif
>  
> +ifeq ($(BR2_PACKAGE_DIRECTFB_DEBUG_SUPPORT),y)
> +DIRECTFB_CONF_OPTS += --enable-debug-support
>  ifeq ($(BR2_PACKAGE_DIRECTFB_DEBUG),y)
>  DIRECTFB_CONF_OPTS += --enable-debug
>  endif
> +else
> +DIRECTFB_CONF_OPTS += --disable-debug-support
> +endif
>  
>  ifeq ($(BR2_PACKAGE_DIRECTFB_TRACE),y)
>  DIRECTFB_CONF_OPTS += --enable-trace
> 


-- 
Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F

[Buildroot] [PATCH] directfb: add an option for debugging support

[Thomas Petazzoni]

Dear C?dric Marie,

On Mon, 15 Jun 2015 22:02:45 +0200, C?dric Marie wrote:
> DirectFB provides two options for debug:
> * --enable-debug-support (default is yes)
> * --enable-debug (default is no)
> The first one provides the functions to print debug information. These
> functions can be called inside DirectFB, or by an external DirectFB
> driver in another package.
> The second one enables verbose mode in DirectFB, using these functions.
> 
> Buildroot currently provides an option for the second one only. The
> first one - which is necessary for the second one - is always enabled,
> because this is the default value.
> 
> The new option (BR2_PACKAGE_DIRECTFB_DEBUG_SUPPORT) makes it possible
> to disable debugging support (--disable-debug-support) in order to
> build the library with no debug feature at all.
> 
> When debugging support is disabled, the target installation path of
> drivers (/usr/lib/directfb-<version>) is suffixed with -pure. The
> public library (/usr/lib/libdirectfb.so) remains unchanged.
> 
> Some external DirectFB drivers will install into
> /usr/lib/directfb-<version>-pure in release mode. For that reason, it
> is important that DirectFB can be configured to use this directory.
> 
> Signed-off-by: C?dric Marie <cedric.marie@openmailbox.org>
> ---
>  package/directfb/Config.in   | 14 ++++++++++++++
>  package/directfb/directfb.mk |  5 +++++
>  2 files changed, 19 insertions(+)

Applied, thanks.

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com