* [Buildroot] [PATCH v4 1/3] atf: new package
2015-06-11 21:00 [Buildroot] [PATCH v4 0/3] kyua: new package and dependencies Sebastien Bourdelin
@ 2015-06-11 21:00 ` Sebastien Bourdelin
2015-06-11 21:00 ` [Buildroot] [PATCH v4 2/3] lutok: " Sebastien Bourdelin
2015-06-11 21:00 ` [Buildroot] [PATCH v4 3/3] kyua: " Sebastien Bourdelin
2 siblings, 0 replies; 7+ messages in thread
From: Sebastien Bourdelin @ 2015-06-11 21:00 UTC (permalink / raw)
To: buildroot
ATF, or Automated Testing Framework, is a collection of libraries to
write test programs in C, C++ and POSIX shell.
https://github.com/jmmv/atf
Signed-off-by: Sebastien Bourdelin <sebastien.bourdelin@savoirfairelinux.com>
---
Changes v3 -> v4:
- rebase
suggested by Arnout Vandecapelle <arnout@mind.be>:
- changes the license to BSD-2c, BSD-3c
suggested by Thomas Petazzoni <thomas.petazzoni@free-electrons.com>:
- moves the package to Librairies/Other
Changes v2 -> v3:
- rebase
suggested by Arnout Vandecapelle <arnout@mind.be>:
- adds comment to explain the need to use AUTORECONF
Changes v1 -> v2:
suggested by Arnout Vandecapelle <arnout@mind.be>:
- bump the version
- uses the release archive instead of the github automatic one
- updates the hash
- removes host-pkgconf from dependencies
- changes the license
- reworks the comment around CONF_ENV to avoid error
---
package/Config.in | 1 +
package/atf/Config.in | 11 +++++++++++
package/atf/atf.hash | 2 ++
package/atf/atf.mk | 23 +++++++++++++++++++++++
4 files changed, 37 insertions(+)
create mode 100644 package/atf/Config.in
create mode 100644 package/atf/atf.hash
create mode 100644 package/atf/atf.mk
diff --git a/package/Config.in b/package/Config.in
index a17901f..d111a82 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -1005,6 +1005,7 @@ menu "Other"
source "package/apr-util/Config.in"
source "package/argp-standalone/Config.in"
source "package/armadillo/Config.in"
+ source "package/atf/Config.in"
source "package/bdwgc/Config.in"
source "package/boost/Config.in"
source "package/clapack/Config.in"
diff --git a/package/atf/Config.in b/package/atf/Config.in
new file mode 100644
index 0000000..59712ab
--- /dev/null
+++ b/package/atf/Config.in
@@ -0,0 +1,11 @@
+config BR2_PACKAGE_ATF
+ bool "atf"
+ depends on BR2_INSTALL_LIBSTDCPP
+ help
+ ATF, or Automated Testing Framework, is a collection of
+ libraries to write test programs in C, C++ and POSIX shell.
+
+ https://github.com/jmmv/atf
+
+comment "atf needs a toolchain w/ C++"
+ depends on !BR2_INSTALL_LIBSTDCPP
diff --git a/package/atf/atf.hash b/package/atf/atf.hash
new file mode 100644
index 0000000..78cd3c6
--- /dev/null
+++ b/package/atf/atf.hash
@@ -0,0 +1,2 @@
+# Locally computed
+sha256 92bc64180135eea8fe84c91c9f894e678767764f6dbc8482021d4dde09857505 atf-0.21.tar.gz
diff --git a/package/atf/atf.mk b/package/atf/atf.mk
new file mode 100644
index 0000000..0873685
--- /dev/null
+++ b/package/atf/atf.mk
@@ -0,0 +1,23 @@
+################################################################################
+#
+# atf
+#
+################################################################################
+
+ATF_VERSION = 0.21
+ATF_SITE = https://github.com/jmmv/atf/releases/download/atf-$(ATF_VERSION)
+ATF_INSTALL_STAGING = YES
+ATF_LICENSE = BSD-2c, BSD-3c
+ATF_LICENSE_FILES = COPYING
+# Ships a beta libtool version hence our patch doesn't apply.
+ATF_AUTORECONF = YES
+
+
+# ATF_SHELL defaults to the host's bash
+ATF_CONF_ENV = \
+ kyua_cv_getopt_plus=yes \
+ kyua_cv_attribute_noreturn=yes \
+ kyua_cv_getcwd_works=yes \
+ ATF_SHELL=/bin/sh
+
+$(eval $(autotools-package))
--
2.4.0
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [Buildroot] [PATCH v4 2/3] lutok: new package
2015-06-11 21:00 [Buildroot] [PATCH v4 0/3] kyua: new package and dependencies Sebastien Bourdelin
2015-06-11 21:00 ` [Buildroot] [PATCH v4 1/3] atf: new package Sebastien Bourdelin
@ 2015-06-11 21:00 ` Sebastien Bourdelin
2015-06-11 21:56 ` Arnout Vandecappelle
2015-06-11 21:00 ` [Buildroot] [PATCH v4 3/3] kyua: " Sebastien Bourdelin
2 siblings, 1 reply; 7+ messages in thread
From: Sebastien Bourdelin @ 2015-06-11 21:00 UTC (permalink / raw)
To: buildroot
Lutok is a lightweight C++ API library for Lua.
https://github.com/jmmv/lutok
Signed-off-by: Sebastien Bourdelin <sebastien.bourdelin@savoirfairelinux.com>
---
Changes v3 -> v4:
- rebase
Changes v2 -> v3:
- rebase
suggested by Arnout Vandecapelle <arnout@mind.be>:
- reworks comment in the Config.in for the required lua dependencies
Changes v1 -> v2:
suggested by Arnout Vandecapelle <arnout@mind.be>:
- reworks lua dependencies, doesn't work with luajit
- adds comment in the Config.in for the required lua dependencies
- uses the release archive instead of the github automatic one
- updates the hash
- removes the useless AUTORECONF option
- adds optional dependency on atf
- don't generate the doxygen doc
- changes the license
---
package/Config.in | 1 +
package/lutok/Config.in | 13 +++++++++++++
package/lutok/lutok.hash | 2 ++
package/lutok/lutok.mk | 26 ++++++++++++++++++++++++++
4 files changed, 42 insertions(+)
create mode 100644 package/lutok/Config.in
create mode 100644 package/lutok/lutok.hash
create mode 100644 package/lutok/lutok.mk
diff --git a/package/Config.in b/package/Config.in
index d111a82..b006211 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -456,6 +456,7 @@ endif
source "package/lua/Config.in"
source "package/luainterpreter/Config.in"
source "package/luajit/Config.in"
+ source "package/lutok/Config.in"
if BR2_PACKAGE_HAS_LUAINTERPRETER && !BR2_STATIC_LIBS
# lua modules are dynamically loaded, so not available on static builds
menu "Lua libraries/modules"
diff --git a/package/lutok/Config.in b/package/lutok/Config.in
new file mode 100644
index 0000000..ef885c8
--- /dev/null
+++ b/package/lutok/Config.in
@@ -0,0 +1,13 @@
+config BR2_PACKAGE_LUTOK
+ bool "lutok"
+ depends on BR2_INSTALL_LIBSTDCPP
+ depends on BR2_PACKAGE_HAS_LUAINTERPRETER \
+ && !BR2_PACKAGE_LUAJIT
+ help
+ Lutok is a lightweight C++ API library for Lua.
+
+ https://github.com/jmmv/lutok
+
+comment "lutok needs a toolchain w/ C++ and full Lua"
+ depends on !BR2_INSTALL_LIBSTDCPP || BR2_PACKAGE_LUAJIT
+ depends on BR2_PACKAGE_HAS_LUAINTERPRETER
diff --git a/package/lutok/lutok.hash b/package/lutok/lutok.hash
new file mode 100644
index 0000000..0ec8988
--- /dev/null
+++ b/package/lutok/lutok.hash
@@ -0,0 +1,2 @@
+# Locally computed
+sha256 2cec51efa0c8d65ace8b21eaa08384b77abc5087b46e785f78de1c21fb754cd5 lutok-0.4.tar.gz
diff --git a/package/lutok/lutok.mk b/package/lutok/lutok.mk
new file mode 100644
index 0000000..0c78daa
--- /dev/null
+++ b/package/lutok/lutok.mk
@@ -0,0 +1,26 @@
+################################################################################
+#
+# lutok
+#
+################################################################################
+
+LUTOK_VERSION = 0.4
+LUTOK_SITE = https://github.com/jmmv/lutok/releases/download/lutok-$(LUTOK_VERSION)
+LUTOK_INSTALL_STAGING = YES
+LUTOK_DEPENDENCIES = host-pkgconf lua
+LUTOK_CONF_OPTS = --without-doxygen
+LUTOK_LICENSE = BSD-3c
+LUTOK_LICENSE_FILES = COPYING
+
+ifeq ($(BR2_PACKAGE_ATF),y)
+LUTOK_DEPENDENCIES += atf
+LUTOK_CONF_OPTS += --with-atf
+else
+LUTOK_CONF_OPTS += --without-atf
+endif
+
+ifneq ($(BR2_STATIC_LIBS),y)
+LUTOK_MAKE_OPTS = LIBS=-ldl
+endif
+
+$(eval $(autotools-package))
--
2.4.0
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [Buildroot] [PATCH v4 2/3] lutok: new package
2015-06-11 21:00 ` [Buildroot] [PATCH v4 2/3] lutok: " Sebastien Bourdelin
@ 2015-06-11 21:56 ` Arnout Vandecappelle
0 siblings, 0 replies; 7+ messages in thread
From: Arnout Vandecappelle @ 2015-06-11 21:56 UTC (permalink / raw)
To: buildroot
On 06/11/15 23:00, Sebastien Bourdelin wrote:
> Lutok is a lightweight C++ API library for Lua.
>
> https://github.com/jmmv/lutok
>
> Signed-off-by: Sebastien Bourdelin <sebastien.bourdelin@savoirfairelinux.com>
[snip]
> diff --git a/package/lutok/Config.in b/package/lutok/Config.in
> new file mode 100644
> index 0000000..ef885c8
> --- /dev/null
> +++ b/package/lutok/Config.in
> @@ -0,0 +1,13 @@
> +config BR2_PACKAGE_LUTOK
> + bool "lutok"
> + depends on BR2_INSTALL_LIBSTDCPP
> + depends on BR2_PACKAGE_HAS_LUAINTERPRETER \
> + && !BR2_PACKAGE_LUAJIT
We only put several depends on one line if they're ||-ed. So make this
depends on BR2_PACKAGE_HAS_LUAINTERPRETER
depends on BR2_PACKAGE_LUAJIT
> + help
> + Lutok is a lightweight C++ API library for Lua.
> +
> + https://github.com/jmmv/lutok
> +
> +comment "lutok needs a toolchain w/ C++ and full Lua"
> + depends on !BR2_INSTALL_LIBSTDCPP || BR2_PACKAGE_LUAJIT
> + depends on BR2_PACKAGE_HAS_LUAINTERPRETER
[snip]
> +ifneq ($(BR2_STATIC_LIBS),y)
> +LUTOK_MAKE_OPTS = LIBS=-ldl
> +endif
This is actually not needed for this package, it is needed for liblua. So add a
comment like in haserl:
# liblua uses dlopen when dynamically linked
> +
> +$(eval $(autotools-package))
>
Like atf, this package installs a bunch of tests in /usr/tests.
Short term, get rid of them, either with a POST_INSTALL_TARGET_HOOK or by using
install-exec.
Long term, we should consider adding a global option BR2_INSTALL_TESTS that
installs various tests. There are a bunch of packages that have a local option
for installing tests, but that's not sustainable. If we ever get around to doing
runtime tests, we'll need something like that. In the meantime, it could already
be useful for others.
Regards,
Arnout
--
Arnout Vandecappelle arnout at mind be
Senior Embedded Software Architect +32-16-286500
Essensium/Mind http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint: 7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F
^ permalink raw reply [flat|nested] 7+ messages in thread
* [Buildroot] [PATCH v4 3/3] kyua: new package
2015-06-11 21:00 [Buildroot] [PATCH v4 0/3] kyua: new package and dependencies Sebastien Bourdelin
2015-06-11 21:00 ` [Buildroot] [PATCH v4 1/3] atf: new package Sebastien Bourdelin
2015-06-11 21:00 ` [Buildroot] [PATCH v4 2/3] lutok: " Sebastien Bourdelin
@ 2015-06-11 21:00 ` Sebastien Bourdelin
2015-06-11 22:13 ` Arnout Vandecappelle
2 siblings, 1 reply; 7+ messages in thread
From: Sebastien Bourdelin @ 2015-06-11 21:00 UTC (permalink / raw)
To: buildroot
Kyua is a testing framework for infrastructure software, originally
designed to equip BSD-based operating systems with a test suite. This
means that Kyua is lightweight and simple, and that Kyua integrates
well with various build systems and continuous integration frameworks.
https://github.com/jmmv/kyua
Signed-off-by: Sebastien Bourdelin <sebastien.bourdelin@savoirfairelinux.com>
---
Changes v3 -> v4:
- rebase
Changes v2 -> v3:
- rebase
Changes v1 -> v2:
- don't generate the doxygen doc
suggested by Arnout Vandecapelle <arnout@mind.be>:
- reworks dependencies in Config.in
- uses the uploaded archive instead of the github automatic one
- changes the hash
- removes the useless AUTORECONF
- changes the license
- fixes a mistake with POST_INSTALL_HOOK
---
package/Config.in | 1 +
package/kyua/Config.in | 23 +++++++++++++++++++++++
package/kyua/kyua.hash | 2 ++
package/kyua/kyua.mk | 27 +++++++++++++++++++++++++++
4 files changed, 53 insertions(+)
create mode 100644 package/kyua/Config.in
create mode 100644 package/kyua/kyua.hash
create mode 100644 package/kyua/kyua.mk
diff --git a/package/Config.in b/package/Config.in
index b006211..1d7b7bc 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -72,6 +72,7 @@ menu "Debugging, profiling and benchmark"
source "package/kexec/Config.in"
source "package/kexec-lite/Config.in"
source "package/ktap/Config.in"
+ source "package/kyua/Config.in"
source "package/latencytop/Config.in"
source "package/lmbench/Config.in"
if BR2_PACKAGE_BUSYBOX_SHOW_OTHERS
diff --git a/package/kyua/Config.in b/package/kyua/Config.in
new file mode 100644
index 0000000..7489782
--- /dev/null
+++ b/package/kyua/Config.in
@@ -0,0 +1,23 @@
+config BR2_PACKAGE_KYUA
+ bool "kyua"
+ depends on BR2_INSTALL_LIBSTDCPP
+ depends on BR2_PACKAGE_HAS_LUAINTERPRETER \
+ && !BR2_PACKAGE_LUAJIT # lutok
+ select BR2_PACKAGE_ATF
+ select BR2_PACKAGE_LUTOK
+ select BR2_PACKAGE_SQLITE
+ help
+ Kyua is a testing framework for infrastructure software,
+ originally designed to equip BSD-based operating systems
+ with a test suite. This means that Kyua is lightweight
+ and simple, and that Kyua integrates well with various build
+ systems and continuous integration frameworks.
+
+ https://github.com/jmmv/kyua
+
+comment "kyua needs a toolchain w/ C++"
+ depends on !BR2_INSTALL_LIBSTDCPP
+
+comment "kyua needs a Lua 5.1 interpreter or above"
+ depends on BR2_INSTALL_LIBSTDCPP && \
+ (!BR2_PACKAGE_HAS_LUAINTERPRETER || BR2_PACKAGE_LUAJIT)
diff --git a/package/kyua/kyua.hash b/package/kyua/kyua.hash
new file mode 100644
index 0000000..938e556
--- /dev/null
+++ b/package/kyua/kyua.hash
@@ -0,0 +1,2 @@
+# Locally Calculted
+sha256 2b8b64a458b642df75086eeb73e8073d105b8d9cff04c9b1a905b68bc8502560 kyua-0.11.tar.gz
diff --git a/package/kyua/kyua.mk b/package/kyua/kyua.mk
new file mode 100644
index 0000000..783d3db
--- /dev/null
+++ b/package/kyua/kyua.mk
@@ -0,0 +1,27 @@
+################################################################################
+#
+# kyua
+#
+################################################################################
+
+KYUA_VERSION = 0.11
+KYUA_SITE = https://github.com/jmmv/kyua/releases/download/kyua-$(KYUA_VERSION)
+KYUA_DEPENDENCIES = host-pkgconf atf lutok sqlite
+KYUA_CONF_OPTS = --without-doxygen
+KYUA_LICENSE = BSD-3c
+KYUA_LICENSE_FILES = COPYING
+KYUA_CONF_ENV = \
+ kyua_cv_attribute_noreturn=yes \
+ kyua_cv_getcwd_dyn=yes \
+ kyua_cv_lchmod_works=no \
+ kyua_cv_getopt_gnu=yes \
+ kyua_cv_getopt_optind_reset_value=0 \
+ kyua_cv_signals_lastno=15
+
+define KYUA_INSTALL_CONFIG
+ $(INSTALL) -D -m 644 $(@D)/examples/kyua.conf $(TARGET_DIR)/etc/kyua/kyua.conf
+endef
+
+KYUA_POST_INSTALL_HOOKS += KYUA_INSTALL_CONFIG
+
+$(eval $(autotools-package))
--
2.4.0
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [Buildroot] [PATCH v4 3/3] kyua: new package
2015-06-11 21:00 ` [Buildroot] [PATCH v4 3/3] kyua: " Sebastien Bourdelin
@ 2015-06-11 22:13 ` Arnout Vandecappelle
2015-06-11 22:48 ` Sebastien Bourdelin
0 siblings, 1 reply; 7+ messages in thread
From: Arnout Vandecappelle @ 2015-06-11 22:13 UTC (permalink / raw)
To: buildroot
On 06/11/15 23:00, Sebastien Bourdelin wrote:
> Kyua is a testing framework for infrastructure software, originally
> designed to equip BSD-based operating systems with a test suite. This
> means that Kyua is lightweight and simple, and that Kyua integrates
> well with various build systems and continuous integration frameworks.
>
> https://github.com/jmmv/kyua
>
> Signed-off-by: Sebastien Bourdelin <sebastien.bourdelin@savoirfairelinux.com>
[snip]
> diff --git a/package/Config.in b/package/Config.in
> index b006211..1d7b7bc 100644
> --- a/package/Config.in
> +++ b/package/Config.in
> @@ -72,6 +72,7 @@ menu "Debugging, profiling and benchmark"
Before someone makes the remark: unlike atf, this one should _not_ move to
Libs->Other, because kyua is not a library.
> source "package/kexec/Config.in"
> source "package/kexec-lite/Config.in"
> source "package/ktap/Config.in"
> + source "package/kyua/Config.in"
> source "package/latencytop/Config.in"
> source "package/lmbench/Config.in"
> if BR2_PACKAGE_BUSYBOX_SHOW_OTHERS
> diff --git a/package/kyua/Config.in b/package/kyua/Config.in
> new file mode 100644
> index 0000000..7489782
> --- /dev/null
> +++ b/package/kyua/Config.in
> @@ -0,0 +1,23 @@
> +config BR2_PACKAGE_KYUA
> + bool "kyua"
> + depends on BR2_INSTALL_LIBSTDCPP
> + depends on BR2_PACKAGE_HAS_LUAINTERPRETER \
> + && !BR2_PACKAGE_LUAJIT # lutok
Same comment as for lutok. Repeat the # lutok on both lines.
> + select BR2_PACKAGE_ATF
> + select BR2_PACKAGE_LUTOK
> + select BR2_PACKAGE_SQLITE
> + help
> + Kyua is a testing framework for infrastructure software,
> + originally designed to equip BSD-based operating systems
> + with a test suite. This means that Kyua is lightweight
> + and simple, and that Kyua integrates well with various build
> + systems and continuous integration frameworks.
> +
> + https://github.com/jmmv/kyua
> +
> +comment "kyua needs a toolchain w/ C++"
> + depends on !BR2_INSTALL_LIBSTDCPP
> +
> +comment "kyua needs a Lua 5.1 interpreter or above"
> + depends on BR2_INSTALL_LIBSTDCPP && \
> + (!BR2_PACKAGE_HAS_LUAINTERPRETER || BR2_PACKAGE_LUAJIT)
This comment should be exactly the same as for lutok:
comment "kyua needs a toolchain w/ C++ and full Lua"
depends on !BR2_INSTALL_LIBSTDCPP || BR2_PACKAGE_LUAJIT
depends on BR2_PACKAGE_HAS_LUAINTERPRETER
[snip]
> diff --git a/package/kyua/kyua.mk b/package/kyua/kyua.mk
> new file mode 100644
> index 0000000..783d3db
> --- /dev/null
> +++ b/package/kyua/kyua.mk
> @@ -0,0 +1,27 @@
> +################################################################################
> +#
> +# kyua
> +#
> +################################################################################
> +
> +KYUA_VERSION = 0.11
> +KYUA_SITE = https://github.com/jmmv/kyua/releases/download/kyua-$(KYUA_VERSION)
> +KYUA_DEPENDENCIES = host-pkgconf atf lutok sqlite
> +KYUA_CONF_OPTS = --without-doxygen
> +KYUA_LICENSE = BSD-3c
> +KYUA_LICENSE_FILES = COPYING
> +KYUA_CONF_ENV = \
> + kyua_cv_attribute_noreturn=yes \
> + kyua_cv_getcwd_dyn=yes \
> + kyua_cv_lchmod_works=no \
> + kyua_cv_getopt_gnu=yes \
> + kyua_cv_getopt_optind_reset_value=0 \
> + kyua_cv_signals_lastno=15
> +
> +define KYUA_INSTALL_CONFIG
> + $(INSTALL) -D -m 644 $(@D)/examples/kyua.conf $(TARGET_DIR)/etc/kyua/kyua.conf
> +endef
> +
> +KYUA_POST_INSTALL_HOOKS += KYUA_INSTALL_CONFIG
> +
> +$(eval $(autotools-package))
>
Again, kyua installs a bunch of tests.
But in fact, you don't even need atf to build kyua. Just specifying
--without-atf is enough to avoid installing the self-tests.
And the same goes for lutok: you don't need atf to build or run either of them...
So, I'm in favour of configuring lutok and kyua with --without-atf as a way to
avoid installing the tests. For atf itself, you still need the install-exec
workaround.
Regards,
Arnout
--
Arnout Vandecappelle arnout at mind be
Senior Embedded Software Architect +32-16-286500
Essensium/Mind http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint: 7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F
^ permalink raw reply [flat|nested] 7+ messages in thread
* [Buildroot] [PATCH v4 3/3] kyua: new package
2015-06-11 22:13 ` Arnout Vandecappelle
@ 2015-06-11 22:48 ` Sebastien Bourdelin
0 siblings, 0 replies; 7+ messages in thread
From: Sebastien Bourdelin @ 2015-06-11 22:48 UTC (permalink / raw)
To: buildroot
Hi Arnout,
Thanks for your review, it's really appreciate.
I will send a new patchset soon.
Sebastien.
On 06/11/2015 06:13 PM, Arnout Vandecappelle wrote:
> On 06/11/15 23:00, Sebastien Bourdelin wrote:
>> Kyua is a testing framework for infrastructure software, originally
>> designed to equip BSD-based operating systems with a test suite. This
>> means that Kyua is lightweight and simple, and that Kyua integrates
>> well with various build systems and continuous integration frameworks.
>>
>> https://github.com/jmmv/kyua
>>
>> Signed-off-by: Sebastien Bourdelin <sebastien.bourdelin@savoirfairelinux.com>
> [snip]
>> diff --git a/package/Config.in b/package/Config.in
>> index b006211..1d7b7bc 100644
>> --- a/package/Config.in
>> +++ b/package/Config.in
>> @@ -72,6 +72,7 @@ menu "Debugging, profiling and benchmark"
> Before someone makes the remark: unlike atf, this one should _not_ move to
> Libs->Other, because kyua is not a library.
>
>> source "package/kexec/Config.in"
>> source "package/kexec-lite/Config.in"
>> source "package/ktap/Config.in"
>> + source "package/kyua/Config.in"
>> source "package/latencytop/Config.in"
>> source "package/lmbench/Config.in"
>> if BR2_PACKAGE_BUSYBOX_SHOW_OTHERS
>> diff --git a/package/kyua/Config.in b/package/kyua/Config.in
>> new file mode 100644
>> index 0000000..7489782
>> --- /dev/null
>> +++ b/package/kyua/Config.in
>> @@ -0,0 +1,23 @@
>> +config BR2_PACKAGE_KYUA
>> + bool "kyua"
>> + depends on BR2_INSTALL_LIBSTDCPP
>> + depends on BR2_PACKAGE_HAS_LUAINTERPRETER \
>> + && !BR2_PACKAGE_LUAJIT # lutok
> Same comment as for lutok. Repeat the # lutok on both lines.
>
>> + select BR2_PACKAGE_ATF
>> + select BR2_PACKAGE_LUTOK
>> + select BR2_PACKAGE_SQLITE
>> + help
>> + Kyua is a testing framework for infrastructure software,
>> + originally designed to equip BSD-based operating systems
>> + with a test suite. This means that Kyua is lightweight
>> + and simple, and that Kyua integrates well with various build
>> + systems and continuous integration frameworks.
>> +
>> + https://github.com/jmmv/kyua
>> +
>> +comment "kyua needs a toolchain w/ C++"
>> + depends on !BR2_INSTALL_LIBSTDCPP
>> +
>> +comment "kyua needs a Lua 5.1 interpreter or above"
>> + depends on BR2_INSTALL_LIBSTDCPP && \
>> + (!BR2_PACKAGE_HAS_LUAINTERPRETER || BR2_PACKAGE_LUAJIT)
> This comment should be exactly the same as for lutok:
>
> comment "kyua needs a toolchain w/ C++ and full Lua"
> depends on !BR2_INSTALL_LIBSTDCPP || BR2_PACKAGE_LUAJIT
> depends on BR2_PACKAGE_HAS_LUAINTERPRETER
>
> [snip]
>> diff --git a/package/kyua/kyua.mk b/package/kyua/kyua.mk
>> new file mode 100644
>> index 0000000..783d3db
>> --- /dev/null
>> +++ b/package/kyua/kyua.mk
>> @@ -0,0 +1,27 @@
>> +################################################################################
>> +#
>> +# kyua
>> +#
>> +################################################################################
>> +
>> +KYUA_VERSION = 0.11
>> +KYUA_SITE = https://github.com/jmmv/kyua/releases/download/kyua-$(KYUA_VERSION)
>> +KYUA_DEPENDENCIES = host-pkgconf atf lutok sqlite
>> +KYUA_CONF_OPTS = --without-doxygen
>> +KYUA_LICENSE = BSD-3c
>> +KYUA_LICENSE_FILES = COPYING
>> +KYUA_CONF_ENV = \
>> + kyua_cv_attribute_noreturn=yes \
>> + kyua_cv_getcwd_dyn=yes \
>> + kyua_cv_lchmod_works=no \
>> + kyua_cv_getopt_gnu=yes \
>> + kyua_cv_getopt_optind_reset_value=0 \
>> + kyua_cv_signals_lastno=15
>> +
>> +define KYUA_INSTALL_CONFIG
>> + $(INSTALL) -D -m 644 $(@D)/examples/kyua.conf $(TARGET_DIR)/etc/kyua/kyua.conf
>> +endef
>> +
>> +KYUA_POST_INSTALL_HOOKS += KYUA_INSTALL_CONFIG
>> +
>> +$(eval $(autotools-package))
>>
> Again, kyua installs a bunch of tests.
>
> But in fact, you don't even need atf to build kyua. Just specifying
> --without-atf is enough to avoid installing the self-tests.
>
> And the same goes for lutok: you don't need atf to build or run either of them...
>
> So, I'm in favour of configuring lutok and kyua with --without-atf as a way to
> avoid installing the tests. For atf itself, you still need the install-exec
> workaround.
>
>
> Regards,
> Arnout
>
^ permalink raw reply [flat|nested] 7+ messages in thread