Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Viallard Anthony <viallard@syscom-instruments.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] Force rebuild of local site packages and theirs local dependencies
Date: Mon, 22 Jun 2015 12:15:14 +0200	[thread overview]
Message-ID: <5587E032.8030506@syscom-instruments.com> (raw)
In-Reply-To: <20150616215022.6eb61f22@free-electrons.com>

On 06/16/2015 09:50 PM, Thomas Petazzoni wrote:
> Dear Anthony Viallard,
>
> On Tue, 16 Jun 2015 15:21:28 +0200, Anthony Viallard wrote:
>
>> diff --git a/package/pkg-generic.mk b/package/pkg-generic.mk
>> index d5b29f0..929a31c 100644
>> --- a/package/pkg-generic.mk
>> +++ b/package/pkg-generic.mk
>> @@ -509,6 +509,10 @@ ifeq ($$(filter $(1),$$(DEPENDENCIES_HOST_PREREQ)),)
>>   $$($(2)_TARGET_SOURCE) $$($(2)_TARGET_RSYNC): | dependencies
>>   endif
>>
>> +ifeq ($$($(2)_SITE_METHOD),local)
>> +$$($(2)_TARGET_RSYNC): $(1)-clean-for-rebuild
>> +endif
>
> Why don't you use "make <pkg>-rebuild" or "make <pkg>-reconfigure" ?
>
> The problem with your proposal is that you have arbitrarily decided to
> make it always restart from the build step. What if some people want to
> restart from the install step, or the configure step ?
>
> Thanks,
>
> Thomas
>

Hi Thomas,

The main thing is this not convenient. I have about 30 packages and we 
are a team. I don't want to check after each git pull the packages which 
have been modified and call make <pkg>-rebuild for each of them (and be 
aware about dependencies, for example calling libraries rebuild before 
because the <pkg>-rebuild target doesn't rebuild the dependencies).

My patch is a quick workaround to do my needs. Moreover, like doug 
claims, the patch doesn't work. There is an issue. I will try to find why.

If there was a "make rebuild" target and if the "make <pkg>-rebuild" was 
able to rebuild all the dependencies too, it will satisfy my needs.

Regards,
Anthony.

  reply	other threads:[~2015-06-22 10:15 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-16 13:21 [Buildroot] [PATCH 1/1] Force rebuild of local site packages and theirs local dependencies Anthony Viallard
2015-06-16 16:30 ` rdkehn at yahoo.com
2015-06-22 10:01   ` Viallard Anthony
2015-06-16 19:50 ` Thomas Petazzoni
2015-06-22 10:15   ` Viallard Anthony [this message]
2015-06-22 12:07     ` Viallard Anthony
2015-06-22 16:13     ` rdkehn at yahoo.com
2015-07-02  8:56       ` Viallard Anthony
2015-06-23  7:56     ` Jérôme Pouiller
2015-07-02  9:01       ` Viallard Anthony
2015-07-02 15:32         ` Jérôme Pouiller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5587E032.8030506@syscom-instruments.com \
    --to=viallard@syscom-instruments.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox