[Buildroot] [PATCH 1/2] heimdal: needs host-ncurses

[Buildroot] [PATCH 1/2] heimdal: needs host-ncurses

[Vicente Olivert Riera]

Otherwise it will fail with an error like this one:

checking for tgetent in -lcurses... no
checking for tgetent in -lncurses... no
configure: error: libcurses or libncurses are required!

Signed-off-by: Vicente Olivert Riera <Vincent.Riera@imgtec.com>
---
 package/heimdal/heimdal.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/package/heimdal/heimdal.mk b/package/heimdal/heimdal.mk
index 6260f8c..19bca5e 100644
--- a/package/heimdal/heimdal.mk
+++ b/package/heimdal/heimdal.mk
@@ -6,7 +6,7 @@
 
 HEIMDAL_VERSION = 1.6rc2
 HEIMDAL_SITE = http://www.h5l.org/dist/src
-HEIMDAL_DEPENDENCIES = host-e2fsprogs host-pkgconf
+HEIMDAL_DEPENDENCIES = host-e2fsprogs host-ncurses host-pkgconf
 HEIMDAL_INSTALL_STAGING = YES
 # static because of -fPIC issues with e2fsprogs on x86_64 host
 HOST_HEIMDAL_CONF_OPTS = \
-- 
2.3.6

[Buildroot] [PATCH 2/2] heimdal: disable parallel build

[Vicente Olivert Riera]

The commit 2fc8be39edd610623d322c71e42a06b535cbadb7 enabled parallel
build, but this is causing build failures like this one:

Making all in kadm5
make[3]: Entering directory
`/home/test/autobuild/instance-0/output/build/host-heimdal-1.6rc2/lib/kadm5'
compile_et kadm5_err.et
compile_et kadm5_err.et
  CC       ad.lo
    CC       chpass_c.lo
    In file included from chpass_c.c:34:
    kadm5_locl.h:78:23: error: kadm5_err.h: No such file or directory

The file 'kadm5_err.h' is a generated header which is being requested
before being generated.

Fixes:

  http://autobuild.buildroot.net/results/3a4/3a42c5b294a9a8602844ed1127ec5eadb60a6bed/

Signed-off-by: Vicente Olivert Riera <Vincent.Riera@imgtec.com>
---
 package/heimdal/heimdal.mk | 1 +
 1 file changed, 1 insertion(+)

diff --git a/package/heimdal/heimdal.mk b/package/heimdal/heimdal.mk
index 19bca5e..8c2aa2b 100644
--- a/package/heimdal/heimdal.mk
+++ b/package/heimdal/heimdal.mk
@@ -24,6 +24,7 @@ HOST_HEIMDAL_CONF_OPTS = \
 	--without-x \
 	--disable-heimdal-documentation
 HOST_HEIMDAL_CONF_ENV = MAKEINFO=true
+HEIMDAL_MAKE = $(MAKE1)
 HEIMDAL_LICENSE = BSD-3c
 HEIMDAL_LICENSE_FILES = LICENSE
 
-- 
2.3.6

[Buildroot] [PATCH 2/2] heimdal: disable parallel build

[Gustavo Zacarias]

On 10/07/15 13:05, Vicente Olivert Riera wrote:

> The commit 2fc8be39edd610623d322c71e42a06b535cbadb7 enabled parallel
> build, but this is causing build failures like this one:
>
> Making all in kadm5
> make[3]: Entering directory
> `/home/test/autobuild/instance-0/output/build/host-heimdal-1.6rc2/lib/kadm5'
> compile_et kadm5_err.et
> compile_et kadm5_err.et
>    CC       ad.lo
>      CC       chpass_c.lo
>      In file included from chpass_c.c:34:
>      kadm5_locl.h:78:23: error: kadm5_err.h: No such file or directory
>
> The file 'kadm5_err.h' is a generated header which is being requested
> before being generated.
>
> Fixes:
>
>    http://autobuild.buildroot.net/results/3a4/3a42c5b294a9a8602844ed1127ec5eadb60a6bed/
>
> Signed-off-by: Vicente Olivert Riera <Vincent.Riera@imgtec.com>

Hi Vicente.
That's harsh, specially since it seems to be a tiny breakage that's 
already fixed upstream via:
http://repo.or.cz/w/heimdal.git/commitdiff/6affa4c
Care to redo it in a "fixing" way? :)
Regards.

[Buildroot] [PATCH 2/2] heimdal: disable parallel build

[Vicente Olivert Riera]

Sure, no problem.

On 10/07/15 18:19, Gustavo Zacarias wrote:
>
>
> On 10/07/15 13:05, Vicente Olivert Riera wrote:
>
>> The commit 2fc8be39edd610623d322c71e42a06b535cbadb7 enabled parallel
>> build, but this is causing build failures like this one:
>>
>> Making all in kadm5
>> make[3]: Entering directory
>> `/home/test/autobuild/instance-0/output/build/host-heimdal-1.6rc2/lib/kadm5'
>>
>> compile_et kadm5_err.et
>> compile_et kadm5_err.et
>>    CC       ad.lo
>>      CC       chpass_c.lo
>>      In file included from chpass_c.c:34:
>>      kadm5_locl.h:78:23: error: kadm5_err.h: No such file or directory
>>
>> The file 'kadm5_err.h' is a generated header which is being requested
>> before being generated.
>>
>> Fixes:
>>
>>
>> http://autobuild.buildroot.net/results/3a4/3a42c5b294a9a8602844ed1127ec5eadb60a6bed/
>>
>>
>> Signed-off-by: Vicente Olivert Riera <Vincent.Riera@imgtec.com>
>
> Hi Vicente.
> That's harsh, specially since it seems to be a tiny breakage that's
> already fixed upstream via:
> http://repo.or.cz/w/heimdal.git/commitdiff/6affa4c
> Care to redo it in a "fixing" way? :)
> Regards.
>

[Buildroot] [PATCH 2/2] heimdal: disable parallel build

[Thomas Petazzoni]

Dear Vicente Olivert Riera,

On Fri, 10 Jul 2015 18:05:08 +0200, Vicente Olivert Riera wrote:
> The commit 2fc8be39edd610623d322c71e42a06b535cbadb7 enabled parallel
> build, but this is causing build failures like this one:
> 
> Making all in kadm5
> make[3]: Entering directory
> `/home/test/autobuild/instance-0/output/build/host-heimdal-1.6rc2/lib/kadm5'
> compile_et kadm5_err.et
> compile_et kadm5_err.et
>   CC       ad.lo
>     CC       chpass_c.lo
>     In file included from chpass_c.c:34:
>     kadm5_locl.h:78:23: error: kadm5_err.h: No such file or directory
> 
> The file 'kadm5_err.h' is a generated header which is being requested
> before being generated.
> 
> Fixes:
> 
>   http://autobuild.buildroot.net/results/3a4/3a42c5b294a9a8602844ed1127ec5eadb60a6bed/
> 
> Signed-off-by: Vicente Olivert Riera <Vincent.Riera@imgtec.com>
> ---
>  package/heimdal/heimdal.mk | 1 +
>  1 file changed, 1 insertion(+)

I've marked this patch as Rejected and instead committed a patch that
backports the upstream commit pointed by Gustavo and that should fix
the parallel build issue.

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

[Buildroot] [PATCH 1/2] heimdal: needs host-ncurses

[Thomas Petazzoni]

Dear Vicente Olivert Riera,

On Fri, 10 Jul 2015 18:05:07 +0200, Vicente Olivert Riera wrote:
> Otherwise it will fail with an error like this one:
> 
> checking for tgetent in -lcurses... no
> checking for tgetent in -lncurses... no
> configure: error: libcurses or libncurses are required!
> 
> Signed-off-by: Vicente Olivert Riera <Vincent.Riera@imgtec.com>
> ---
>  package/heimdal/heimdal.mk | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Applied, thanks.

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com