[Buildroot] [PATCH 1/2] package/qpid-proton: disable for static build only

[Buildroot] [PATCH 1/2] package/qpid-proton: disable for static build only

[Romain Naour]

qpid-proton always build a shared library "libqpid-proton.so"

Fixes:
http://autobuild.buildroot.net/results/bf6/bf6b9bcc0cead87c8fb12ec4c7f5ff73e6d61d3f/

Signed-off-by: Romain Naour <romain.naour@openwide.fr>
---
 package/qpid-proton/Config.in | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/package/qpid-proton/Config.in b/package/qpid-proton/Config.in
index b6a1aa9..f8aaf39 100644
--- a/package/qpid-proton/Config.in
+++ b/package/qpid-proton/Config.in
@@ -1,5 +1,6 @@
 config BR2_PACKAGE_QPID_PROTON
 	bool "qpid-proton"
+	depends on !BR2_STATIC_LIBS # build a shared library
 	depends on BR2_USE_WCHAR # util-linux
 	select BR2_PACKAGE_UTIL_LINUX
 	select BR2_PACKAGE_UTIL_LINUX_LIBUUID
@@ -13,5 +14,5 @@ config BR2_PACKAGE_QPID_PROTON
 
 	  https://qpid.apache.org/proton/
 
-comment "qpid-proton needs a toolchain w/ wchar"
-	depends on !BR2_USE_WCHAR
+comment "qpid-proton needs a toolchain w/ dynamic library, wchar"
+	depends on BR2_STATIC_LIBS || !BR2_USE_WCHAR
-- 
2.4.3

[Buildroot] [PATCH 2/2] package/qpid-proton: disable languages bindings

[Romain Naour]

Fixes (workaround):
http://autobuild.buildroot.net/results/eff48f8a827f8b4dbbdb7cb648a6c4a3ab4ac8a5/

Signed-off-by: Romain Naour <romain.naour@openwide.fr>
Cc: Luca Ceresoli <luca@lucaceresoli.net>
---

Hi Luca,

The dependency on host-swig is missing in qpid-proton package.
Therefore languages bindings are enabled when the swig tool is found, but
for each languages bindings the target package dependency is missing.

The build failure [1] occurs only when host-swig is available *and* python
target package is build before qpid-proton.

Is it ok for you to disable all bindings ?

Best regards,
Romain

[1] http://autobuild.buildroot.net/results/eff/eff48f8a827f8b4dbbdb7cb648a6c4a3ab4ac8a5/
---
 package/qpid-proton/qpid-proton.mk | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/package/qpid-proton/qpid-proton.mk b/package/qpid-proton/qpid-proton.mk
index 12fddb4..2e8c1d0 100644
--- a/package/qpid-proton/qpid-proton.mk
+++ b/package/qpid-proton/qpid-proton.mk
@@ -15,8 +15,15 @@ QPID_PROTON_DEPENDENCIES = \
 	util-linux \
 	$(if $(BR2_PACKAGE_OPENSSL),openssl)
 
+# Language bindings are enabled when host-swig tool is present in HOST_DIR.
+# For now, disable all of them.
 QPID_PROTON_CONF_OPTS = \
 	-DBUILD_JAVA=OFF \
+	-DBUILD_JAVASCRIPT=OFF \
+	-DBUILD_PERL=OFF \
+	-DBUILD_PHP=OFF \
+	-DBUILD_PYTHON=OFF \
+	-DBUILD_RUBY=OFF \
 	-DENABLE_VALGRIND=OFF \
 	-DENABLE_WARNING_ERROR=OFF \
 	-DPYTHON_EXECUTABLE=$(HOST_DIR)/usr/bin/python2
-- 
2.4.3

[Buildroot] [PATCH 1/2] package/qpid-proton: disable for static build only

[Thomas Petazzoni]

Dear Romain Naour,

On Wed, 22 Jul 2015 16:13:09 +0200, Romain Naour wrote:
> qpid-proton always build a shared library "libqpid-proton.so"
> 
> Fixes:
> http://autobuild.buildroot.net/results/bf6/bf6b9bcc0cead87c8fb12ec4c7f5ff73e6d61d3f/
> 
> Signed-off-by: Romain Naour <romain.naour@openwide.fr>
> ---
>  package/qpid-proton/Config.in | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)

Both applied, thanks.

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

[Buildroot] [PATCH 2/2] package/qpid-proton: disable languages bindings

[Luca Ceresoli]

Dear Romain,

Romain Naour wrote:
> Fixes (workaround):
> http://autobuild.buildroot.net/results/eff48f8a827f8b4dbbdb7cb648a6c4a3ab4ac8a5/
>
> Signed-off-by: Romain Naour <romain.naour@openwide.fr>
> Cc: Luca Ceresoli <luca@lucaceresoli.net>
> ---
>
> Hi Luca,
>
> The dependency on host-swig is missing in qpid-proton package.
> Therefore languages bindings are enabled when the swig tool is found, but
> for each languages bindings the target package dependency is missing.
>
> The build failure [1] occurs only when host-swig is available *and* python
> target package is build before qpid-proton.
>
> Is it ok for you to disable all bindings ?

No objections. I only care about the C APIs.

Of course anybody interested can add (and fix) bindings as needed.

Thanks for having fixed this issue.

-- 
Luca