[Buildroot] Bug in package tftp

[Buildroot] Bug in package tftp

[universe II]

Dear all,
when adding the tftp server to my target system image I found out that 
the tftp server is not started by the corresponding init script. Reason 
for that is a typo in the init script. The tftp binary is installed with 
the filename "tftpd" but the init script tries to call "in.tftpd". Just 
fixing the name in the script solves the problem. Please find below the 
patch for correcting the bug.

Regards,
Andreas


diff -Naur a/tftpd/S80tftpd-hpa b/tftpd/S80tftpd-hpa
--- a/tftpd/S80tftpd-hpa        2015-08-07 11:38:37.572148556 +0200
+++ b/tftpd/S80tftpd-hpa        2015-08-07 14:44:19.394469103 +0200
@@ -6,7 +6,7 @@

  PATH=/usr/local/sbin:/usr/local/bin:/sbin:/bin:/usr/sbin:/usr/bin
  DESC="HPA's tftpd"
-NAME=in.tftpd
+NAME=tftpd
  DAEMON=/usr/sbin/$NAME
  PIDFILE=/var/run/$NAME.pid
  SCRIPTNAME=/etc/init.d/S80tftpd-hpa
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20150821/e21e33fe/attachment.html>

[Buildroot] Bug in package tftp

[Vicente Olivert Riera]

Dear Andreas,

On 08/21/2015 12:26 PM, universe II wrote:
> diff -Naur a/tftpd/S80tftpd-hpa b/tftpd/S80tftpd-hpa

that's not correct. You made the patch manually using "diff" from the
package directory, so the paths are not relative to $(TOPDIR). Anyway,
why you didn't make the patch using git?
You make the changes to the package/tftpd/S80tftpd-hpa file. Add that
file. Commit. And then use "git send-email --to=buildroot at buildroot.org
-1" (-1 to send only one patch starting from the HEAD).

Regards,

Vincent.

[Buildroot] Bug in package tftp

[Peter Korsgaard]

>>>>> "universe" == universe  <universeii@gmx.de> writes:

 > Dear all,
 > when adding the tftp server to my target system image I found out that
 > the tftp server is not started by the corresponding init
 > script. Reason for that is a typo in the init script. The tftp binary
 > is installed with the filename "tftpd" but the init script tries to
 > call "in.tftpd". Just fixing the name in the script solves the
 > problem. Please find below the patch for correcting the bug.

 > Regards,
 > Andreas

Fixed, thanks. In the future, please provide git formatted patches and
use your real name in From: and your Signed-off-by lines.

-- 
Bye, Peter Korsgaard