Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH] apitrace: bump to version 7.0
@ 2015-08-24  8:54 Vicente Olivert Riera
  2015-08-24 15:21 ` Peter Korsgaard
  0 siblings, 1 reply; 4+ messages in thread
From: Vicente Olivert Riera @ 2015-08-24  8:54 UTC (permalink / raw)
  To: buildroot

Our current apitrace version can't detect the host-python version
correctly, so if both host-python and host-python3 where installed, it
will take the last one and it will fail with an "invalid syntax" error.
The latest apitrace version has this problem solved and it detects the
host-python version correctly.

Fixes:

  http://autobuild.buildroot.net/results/22a/22a73b4ba0adcc874ecc153917ae6edcfd4d37af/

Signed-off-by: Vicente Olivert Riera <Vincent.Riera@imgtec.com>
---
 package/apitrace/apitrace.mk |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/package/apitrace/apitrace.mk b/package/apitrace/apitrace.mk
index b164367..28a40e4 100644
--- a/package/apitrace/apitrace.mk
+++ b/package/apitrace/apitrace.mk
@@ -4,7 +4,7 @@
 #
 ################################################################################
 
-APITRACE_VERSION = c181b7fbf4b1c3912424761fec8ac7124640543a
+APITRACE_VERSION = 7.0
 APITRACE_SITE = $(call github,apitrace,apitrace,$(APITRACE_VERSION))
 APITRACE_LICENSE = MIT
 APITRACE_LICENSE_FILES = LICENSE
-- 
1.7.1

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [Buildroot] [PATCH] apitrace: bump to version 7.0
  2015-08-24  8:54 [Buildroot] [PATCH] apitrace: bump to version 7.0 Vicente Olivert Riera
@ 2015-08-24 15:21 ` Peter Korsgaard
  2015-08-24 15:42   ` Vicente Olivert Riera
  0 siblings, 1 reply; 4+ messages in thread
From: Peter Korsgaard @ 2015-08-24 15:21 UTC (permalink / raw)
  To: buildroot

>>>>> "Vicente" == Vicente Olivert Riera <Vincent.Riera@imgtec.com> writes:

 > Our current apitrace version can't detect the host-python version
 > correctly, so if both host-python and host-python3 where installed, it
 > will take the last one and it will fail with an "invalid syntax" error.
 > The latest apitrace version has this problem solved and it detects the
 > host-python version correctly.

 > Fixes:

 >   http://autobuild.buildroot.net/results/22a/22a73b4ba0adcc874ecc153917ae6edcfd4d37af/

 > Signed-off-by: Vicente Olivert Riera <Vincent.Riera@imgtec.com>

So then perhaps we shouldn't force people to build host-python if they
already have host-python3 built?

E.G. something like:

APITRACE_DEPENDENCIES = xlib_libX11 $(if $(BR2_PACKAGE_PYTHON3),host-python3,host-python)

But that can be added later - Committed, thanks.

-- 
Bye, Peter Korsgaard

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [Buildroot] [PATCH] apitrace: bump to version 7.0
  2015-08-24 15:21 ` Peter Korsgaard
@ 2015-08-24 15:42   ` Vicente Olivert Riera
  2015-08-24 15:55     ` Peter Korsgaard
  0 siblings, 1 reply; 4+ messages in thread
From: Vicente Olivert Riera @ 2015-08-24 15:42 UTC (permalink / raw)
  To: buildroot

Dear Peter Korsgaard,

On 08/24/2015 04:21 PM, Peter Korsgaard wrote:
>>>>>> "Vicente" == Vicente Olivert Riera <Vincent.Riera@imgtec.com> writes:
> 
>  > Our current apitrace version can't detect the host-python version
>  > correctly, so if both host-python and host-python3 where installed, it
>  > will take the last one and it will fail with an "invalid syntax" error.
>  > The latest apitrace version has this problem solved and it detects the
>  > host-python version correctly.
> 
>  > Fixes:
> 
>  >   http://autobuild.buildroot.net/results/22a/22a73b4ba0adcc874ecc153917ae6edcfd4d37af/
> 
>  > Signed-off-by: Vicente Olivert Riera <Vincent.Riera@imgtec.com>
> 
> So then perhaps we shouldn't force people to build host-python if they
> already have host-python3 built?
> 
> E.G. something like:
> 
> APITRACE_DEPENDENCIES = xlib_libX11 $(if $(BR2_PACKAGE_PYTHON3),host-python3,host-python)
> 
> But that can be added later - Committed, thanks.
> 

No, no. I think you misunderstood me, or perhaps I didn't explain myself
very well.

What the new version of apitrace does is using python2 even if you have
python3 installed. The old one was using python3 although both python2
and python3 were installed. It was just choosing the wrong python. Does
it make sense now?

Regards,

Vincent.

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [Buildroot] [PATCH] apitrace: bump to version 7.0
  2015-08-24 15:42   ` Vicente Olivert Riera
@ 2015-08-24 15:55     ` Peter Korsgaard
  0 siblings, 0 replies; 4+ messages in thread
From: Peter Korsgaard @ 2015-08-24 15:55 UTC (permalink / raw)
  To: buildroot

>>>>> "Vicente" == Vicente Olivert Riera <Vincent.Riera@imgtec.com> writes:

Hi,

> No, no. I think you misunderstood me, or perhaps I didn't explain myself
 > very well.

 > What the new version of apitrace does is using python2 even if you have
 > python3 installed. The old one was using python3 although both python2
 > and python3 were installed. It was just choosing the wrong python. Does
 > it make sense now?

Ahh, ok. I don't see any references to 'python2' in the apitrace sources
though.

-- 
Venlig hilsen,
Peter Korsgaard 

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2015-08-24 15:55 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-08-24  8:54 [Buildroot] [PATCH] apitrace: bump to version 7.0 Vicente Olivert Riera
2015-08-24 15:21 ` Peter Korsgaard
2015-08-24 15:42   ` Vicente Olivert Riera
2015-08-24 15:55     ` Peter Korsgaard

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox