Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Vicente Olivert Riera <Vincent.Riera@imgtec.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] Move tar package location to 'system-tools'
Date: Tue, 1 Sep 2015 13:51:40 +0100	[thread overview]
Message-ID: <55E59F5C.5020806@imgtec.com> (raw)
In-Reply-To: <12995385.iRNRCdloQv@deathstar>

Dear Francesco Nwokeka,

could you please send the patch in-line using "git send-email" instead
of attaching the patch to the email?

Also, one comment regarding your patch:

> @@ -1509,6 +1506,9 @@ endif
>  if BR2_PACKAGE_BUSYBOX_SHOW_OTHERS
>  	source "package/sysvinit/Config.in"
>  endif
> +if BR2_PACKAGE_BUSYBOX_SHOW_OTHERS
> +	source "package/tar/Config.in"
> +endif
>  	source "package/util-linux/Config.in"
>  endmenu

Since there are two packages in a row which are inside an "if
BR2_PACKAGE_BUSYBOX_SHOW_OTHERS", it would be better if you put them
together into the same if clause. Something like this:

> @@ -1509,6 +1506,9 @@ endif
>  if BR2_PACKAGE_BUSYBOX_SHOW_OTHERS
>  	source "package/sysvinit/Config.in"
> +	source "package/tar/Config.in"
>  endif
>  	source "package/util-linux/Config.in"
> endmenu

Please label your next patch as v2 ([PATCHv2]) when you send it :-)

Regards,

Vincent.

On 09/01/2015 01:44 PM, Francesco Nwokeka wrote:
> 
> 
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
> 

  reply	other threads:[~2015-09-01 12:51 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-01 12:44 [Buildroot] [PATCH 1/1] Move tar package location to 'system-tools' Francesco Nwokeka
2015-09-01 12:51 ` Vicente Olivert Riera [this message]
2015-09-01 13:14   ` Thomas Petazzoni
2015-09-01 15:38 ` [Buildroot] [PATCHv2 1/1] tar: Move tar package to 'system-tools' menu Francesco Nwokeka

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55E59F5C.5020806@imgtec.com \
    --to=vincent.riera@imgtec.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox