[Buildroot] [PATCH 1/1] Move tar package location to 'system-tools'

[Buildroot] [PATCH 1/1] Move tar package location to 'system-tools'

[Francesco Nwokeka]

A non-text attachment was scrubbed...
Name: 0001-Move-tar-package-location-to-system-tools.patch
Type: text/x-patch
Size: 1126 bytes
Desc: not available
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20150901/e4e1b829/attachment.bin>

[Buildroot] [PATCH 1/1] Move tar package location to 'system-tools'

[Vicente Olivert Riera]

Dear Francesco Nwokeka,

could you please send the patch in-line using "git send-email" instead
of attaching the patch to the email?

Also, one comment regarding your patch:

> @@ -1509,6 +1506,9 @@ endif
>  if BR2_PACKAGE_BUSYBOX_SHOW_OTHERS
>  	source "package/sysvinit/Config.in"
>  endif
> +if BR2_PACKAGE_BUSYBOX_SHOW_OTHERS
> +	source "package/tar/Config.in"
> +endif
>  	source "package/util-linux/Config.in"
>  endmenu

Since there are two packages in a row which are inside an "if
BR2_PACKAGE_BUSYBOX_SHOW_OTHERS", it would be better if you put them
together into the same if clause. Something like this:

> @@ -1509,6 +1506,9 @@ endif
>  if BR2_PACKAGE_BUSYBOX_SHOW_OTHERS
>  	source "package/sysvinit/Config.in"
> +	source "package/tar/Config.in"
>  endif
>  	source "package/util-linux/Config.in"
> endmenu

Please label your next patch as v2 ([PATCHv2]) when you send it :-)

Regards,

Vincent.

On 09/01/2015 01:44 PM, Francesco Nwokeka wrote:
> 
> 
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
> 

[Buildroot] [PATCH 1/1] Move tar package location to 'system-tools'

[Thomas Petazzoni]

Hello,

On Tue, 1 Sep 2015 13:51:40 +0100, Vicente Olivert Riera wrote:

> Please label your next patch as v2 ([PATCHv2]) when you send it :-)

And also use the usual convention for the commit title:

	<package>: <description>

so, something like:

	tar: move to the "System tools" menu

Thanks,

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

[Buildroot] [PATCHv2 1/1] tar: Move tar package to 'system-tools' menu

[Francesco Nwokeka]

Signed-off-by: Francesco Nwokeka <francesco.nwokeka@gmail.com>
---
 package/Config.in | 2 --
 1 file changed, 2 deletions(-)

diff --git a/package/Config.in b/package/Config.in
index 521deb4..58b7380 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -1505,8 +1505,6 @@ endif
        source "package/systemd/Config.in"
 if BR2_PACKAGE_BUSYBOX_SHOW_OTHERS
        source "package/sysvinit/Config.in"
-endif
-if BR2_PACKAGE_BUSYBOX_SHOW_OTHERS
        source "package/tar/Config.in"
 endif
        source "package/util-linux/Config.in"
-- 
2.5.0