Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH 1/2] udisks: bump to version 1.0.5
@ 2015-09-02  9:31 Vicente Olivert Riera
  2015-09-02  9:31 ` [Buildroot] [PATCH 2/2] udisks: fix build with newer glibc versions Vicente Olivert Riera
  2015-09-02  9:33 ` [Buildroot] [PATCH 1/2] udisks: bump to version 1.0.5 Thomas Petazzoni
  0 siblings, 2 replies; 4+ messages in thread
From: Vicente Olivert Riera @ 2015-09-02  9:31 UTC (permalink / raw)
  To: buildroot

This version depends on libgudev, otherwise it fails with an error like
this one:

checking for GUDEV... no
configure: error: Package requirements (gudev-1.0 >= 147) were not met:

Signed-off-by: Vicente Olivert Riera <Vincent.Riera@imgtec.com>
---
 package/udisks/Config.in   |    1 +
 package/udisks/udisks.hash |    2 +-
 package/udisks/udisks.mk   |    5 +++--
 3 files changed, 5 insertions(+), 3 deletions(-)

diff --git a/package/udisks/Config.in b/package/udisks/Config.in
index a5da2bf..8b8fd28 100644
--- a/package/udisks/Config.in
+++ b/package/udisks/Config.in
@@ -12,6 +12,7 @@ config BR2_PACKAGE_UDISKS
 	select BR2_PACKAGE_PARTED
 	select BR2_PACKAGE_LVM2
 	select BR2_PACKAGE_LIBATASMART
+	select BR2_PACKAGE_LIBGUDEV
 	help
 	  The udisks project provides
 
diff --git a/package/udisks/udisks.hash b/package/udisks/udisks.hash
index 5debfd5..7ad4326 100644
--- a/package/udisks/udisks.hash
+++ b/package/udisks/udisks.hash
@@ -1,2 +1,2 @@
 # Locally calculated
-sha256	854b89368733b9c3a577101b761ad5397ae75a05110c8698ac5b29de9a8bf8f5	udisks-1.0.4.tar.gz
+sha256 f2ec82eb0ea7e01dc299b5b29b3c18cdf861236ec43dcff66b3552b4b31c6f71  udisks-1.0.5.tar.gz
diff --git a/package/udisks/udisks.mk b/package/udisks/udisks.mk
index 7a24106..0770a27 100644
--- a/package/udisks/udisks.mk
+++ b/package/udisks/udisks.mk
@@ -4,7 +4,7 @@
 #
 ################################################################################
 
-UDISKS_VERSION = 1.0.4
+UDISKS_VERSION = 1.0.5
 UDISKS_SITE = http://hal.freedesktop.org/releases
 UDISKS_LICENSE = GPLv2+
 UDISKS_LICENSE_FILES = COPYING
@@ -18,7 +18,8 @@ UDISKS_DEPENDENCIES = 	\
 	polkit		\
 	parted		\
 	lvm2		\
-	libatasmart
+	libatasmart \
+	libgudev
 
 UDISKS_CONF_OPTS = --disable-remote-access --disable-man-pages
 
-- 
1.7.1

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [Buildroot] [PATCH 2/2] udisks: fix build with newer glibc versions
  2015-09-02  9:31 [Buildroot] [PATCH 1/2] udisks: bump to version 1.0.5 Vicente Olivert Riera
@ 2015-09-02  9:31 ` Vicente Olivert Riera
  2015-09-02  9:33 ` [Buildroot] [PATCH 1/2] udisks: bump to version 1.0.5 Thomas Petazzoni
  1 sibling, 0 replies; 4+ messages in thread
From: Vicente Olivert Riera @ 2015-09-02  9:31 UTC (permalink / raw)
  To: buildroot

Backport an upstream patch to fix the build with newer glibc versions.
This is how the failure looks like:

job-drive-detach.c: In function 'sysfs_exists':
job-drive-detach.c:44:15: error: storage size of 'statbuf' isn't known
   struct stat statbuf;

Fixes:

  http://autobuild.buildroot.net/results/ab3/ab36c2a1d2ca41a4d9ec6bab7d8d45678dbc5dcd/

Signed-off-by: Vicente Olivert Riera <Vincent.Riera@imgtec.com>
---
 .../0001-fix-build-with-newer-glibc-versions.patch |   29 ++++++++++++++++++++
 1 files changed, 29 insertions(+), 0 deletions(-)
 create mode 100644 package/udisks/0001-fix-build-with-newer-glibc-versions.patch

diff --git a/package/udisks/0001-fix-build-with-newer-glibc-versions.patch b/package/udisks/0001-fix-build-with-newer-glibc-versions.patch
new file mode 100644
index 0000000..336fc44
--- /dev/null
+++ b/package/udisks/0001-fix-build-with-newer-glibc-versions.patch
@@ -0,0 +1,29 @@
+Fix build with newer glibc versions
+
+This patch has been backported from upstream:
+
+http://cgit.freedesktop.org/udisks/commit/?h=udisks1&id=9829152b12a8924d2e091a00133ed1a3a7ba75c0
+
+Signed-off-by: Vicente Olivert Riera <Vincent.Riera@imgtec.com>
+
+From 9829152b12a8924d2e091a00133ed1a3a7ba75c0 Mon Sep 17 00:00:00 2001
+From: Alexandre Rostovtsev <tetromino@gentoo.org>
+Date: Fri, 29 May 2015 21:09:39 -0400
+Subject: fix build with newer glibc versions
+
+https://bugs.freedesktop.org/show_bug.cgi?id=90778
+
+diff --git a/src/helpers/job-drive-detach.c b/src/helpers/job-drive-detach.c
+index eeafcab..d122a1f 100644
+--- a/src/helpers/job-drive-detach.c
++++ b/src/helpers/job-drive-detach.c
+@@ -18,6 +18,7 @@
+  *
+  */
+ 
++#include <sys/stat.h>
+ #include <stdio.h>
+ #include <string.h>
+ #include <errno.h>
+-- 
+cgit v0.10.2
-- 
1.7.1

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [Buildroot] [PATCH 1/2] udisks: bump to version 1.0.5
  2015-09-02  9:31 [Buildroot] [PATCH 1/2] udisks: bump to version 1.0.5 Vicente Olivert Riera
  2015-09-02  9:31 ` [Buildroot] [PATCH 2/2] udisks: fix build with newer glibc versions Vicente Olivert Riera
@ 2015-09-02  9:33 ` Thomas Petazzoni
  2015-09-02  9:55   ` Vicente Olivert Riera
  1 sibling, 1 reply; 4+ messages in thread
From: Thomas Petazzoni @ 2015-09-02  9:33 UTC (permalink / raw)
  To: buildroot

Dear Vicente Olivert Riera,

On Wed, 2 Sep 2015 10:31:23 +0100, Vicente Olivert Riera wrote:
> This version depends on libgudev, otherwise it fails with an error like
> this one:
> 
> checking for GUDEV... no
> configure: error: Package requirements (gudev-1.0 >= 147) were not met:
> 
> Signed-off-by: Vicente Olivert Riera <Vincent.Riera@imgtec.com>
> ---
>  package/udisks/Config.in   |    1 +
>  package/udisks/udisks.hash |    2 +-
>  package/udisks/udisks.mk   |    5 +++--
>  3 files changed, 5 insertions(+), 3 deletions(-)
> 
> diff --git a/package/udisks/Config.in b/package/udisks/Config.in
> index a5da2bf..8b8fd28 100644
> --- a/package/udisks/Config.in
> +++ b/package/udisks/Config.in
> @@ -12,6 +12,7 @@ config BR2_PACKAGE_UDISKS
>  	select BR2_PACKAGE_PARTED
>  	select BR2_PACKAGE_LVM2
>  	select BR2_PACKAGE_LIBATASMART
> +	select BR2_PACKAGE_LIBGUDEV

No: libgudev should only be used when systemd is used. Otherwise, it's
provided by eudev.

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [Buildroot] [PATCH 1/2] udisks: bump to version 1.0.5
  2015-09-02  9:33 ` [Buildroot] [PATCH 1/2] udisks: bump to version 1.0.5 Thomas Petazzoni
@ 2015-09-02  9:55   ` Vicente Olivert Riera
  0 siblings, 0 replies; 4+ messages in thread
From: Vicente Olivert Riera @ 2015-09-02  9:55 UTC (permalink / raw)
  To: buildroot


Dear Thomas Petazzoni,

On 09/02/2015 10:33 AM, Thomas Petazzoni wrote:
> Dear Vicente Olivert Riera,
> 
> On Wed, 2 Sep 2015 10:31:23 +0100, Vicente Olivert Riera wrote:
>> This version depends on libgudev, otherwise it fails with an error like
>> this one:
>>
>> checking for GUDEV... no
>> configure: error: Package requirements (gudev-1.0 >= 147) were not met:
>>
>> Signed-off-by: Vicente Olivert Riera <Vincent.Riera@imgtec.com>
>> ---
>>  package/udisks/Config.in   |    1 +
>>  package/udisks/udisks.hash |    2 +-
>>  package/udisks/udisks.mk   |    5 +++--
>>  3 files changed, 5 insertions(+), 3 deletions(-)
>>
>> diff --git a/package/udisks/Config.in b/package/udisks/Config.in
>> index a5da2bf..8b8fd28 100644
>> --- a/package/udisks/Config.in
>> +++ b/package/udisks/Config.in
>> @@ -12,6 +12,7 @@ config BR2_PACKAGE_UDISKS
>>  	select BR2_PACKAGE_PARTED
>>  	select BR2_PACKAGE_LVM2
>>  	select BR2_PACKAGE_LIBATASMART
>> +	select BR2_PACKAGE_LIBGUDEV
> 
> No: libgudev should only be used when systemd is used. Otherwise, it's
> provided by eudev.

Ahh, ok, I was testing this package having systemd as well. I'll change
it. Thanks!

Regards,

Vincent.

> 
> Thomas
> 

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2015-09-02  9:55 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-09-02  9:31 [Buildroot] [PATCH 1/2] udisks: bump to version 1.0.5 Vicente Olivert Riera
2015-09-02  9:31 ` [Buildroot] [PATCH 2/2] udisks: fix build with newer glibc versions Vicente Olivert Riera
2015-09-02  9:33 ` [Buildroot] [PATCH 1/2] udisks: bump to version 1.0.5 Thomas Petazzoni
2015-09-02  9:55   ` Vicente Olivert Riera

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox