[Buildroot] [PATCH v2] Buildroot' patch to add support for aarch64 in mplayer configure script

[Buildroot] [PATCH v2] Buildroot' patch to add support for aarch64 in mplayer configure script

[jpinto]

Signed-off-by: jpinto <jpinto@synopsys.com>
---
 package/mplayer/0007-enable-aarch64.patch | 13 +++++++++++++
 1 file changed, 13 insertions(+)
 create mode 100644 package/mplayer/0007-enable-aarch64.patch

diff --git a/package/mplayer/0007-enable-aarch64.patch b/package/mplayer/0007-enable-aarch64.patch
new file mode 100644
index 0000000..7f75756
--- /dev/null
+++ b/package/mplayer/0007-enable-aarch64.patch
@@ -0,0 +1,13 @@
+--- b/configure	2015-09-15 17:30:46.187307557 +0100
++++ a/configure	2015-09-15 17:31:11.729307537 +0100
+@@ -2496,6 +2496,10 @@
+     arch='arc'
+     iproc='arc'
+     ;;
++  aarch64)
++    arch='arm64'
++    iproc='arm64'
++    ;;
+ 
+   *)
+     echo "The architecture of your CPU ($host_arch) is not supported by this configure script"

---
 package/mplayer/Config.in | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/package/mplayer/Config.in b/package/mplayer/Config.in
index 79ff3b1..7a8b03f 100644
--- a/package/mplayer/Config.in
+++ b/package/mplayer/Config.in
@@ -3,7 +3,7 @@ config BR2_PACKAGE_MPLAYER_ARCH_SUPPORTS
 	default y
 	# Those architectures are not supported by MPlayer
 	depends on !(BR2_bfin || BR2_sh2a || BR2_sh4a || BR2_sh4aeb \
-		|| BR2_microblaze || BR2_aarch64 || BR2_nios2)
+		|| BR2_microblaze || BR2_nios2)
 	# Broken support for <ARMv5
 	depends on !BR2_ARM_CPU_ARMV4
 
-- 
1.8.1.5

[Buildroot] [PATCH v3] Buildroot' patch to add support for aarch64 in mplayer configure script

[Thomas Petazzoni]

Hello Joao,

Your e-mail is two patches concataned to each other. Can you make that
a single patch instead?

Also, the title should be adjusted, as I explained in a previous
message. See some more comments below.

On Tue, 15 Sep 2015 18:00:48 +0100, jpinto wrote:
> 
> Signed-off-by: Joao Pinto <jpinto@synopsys.com>
> Tested-by: Joao Pinto <jpinto@synopsys.com>
> ---
>  package/mplayer/0007-enable-aarch64.patch | 13 +++++++++++++
>  1 file changed, 13 insertions(+)
>  create mode 100644 package/mplayer/0007-enable-aarch64.patch
> 
> diff --git a/package/mplayer/0007-enable-aarch64.patch b/package/mplayer/0007-enable-aarch64.patch
> new file mode 100644
> index 0000000..7f75756
> --- /dev/null
> +++ b/package/mplayer/0007-enable-aarch64.patch
> @@ -0,0 +1,13 @@

All patches in Buildroot should have a description and a Signed-off-by
line. See
http://buildroot.org/downloads/manual/manual.html#_format_and_licensing_of_the_package_patches
for details.

Thanks,

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

[Buildroot] [PATCH v3] Buildroot' patch to add support for aarch64 in mplayer configure script

[Arnout Vandecappelle]

On 15-09-15 23:18, Thomas Petazzoni wrote:
> Hello Joao,
> 
> Your e-mail is two patches concataned to each other. Can you make that
> a single patch instead?
> 
> Also, the title should be adjusted, as I explained in a previous
> message. See some more comments below.
> 
> On Tue, 15 Sep 2015 18:00:48 +0100, jpinto wrote:
>>
>> Signed-off-by: Joao Pinto <jpinto@synopsys.com>
>> Tested-by: Joao Pinto <jpinto@synopsys.com>
>> ---
>>  package/mplayer/0007-enable-aarch64.patch | 13 +++++++++++++
>>  1 file changed, 13 insertions(+)
>>  create mode 100644 package/mplayer/0007-enable-aarch64.patch
>>
>> diff --git a/package/mplayer/0007-enable-aarch64.patch b/package/mplayer/0007-enable-aarch64.patch
>> new file mode 100644
>> index 0000000..7f75756
>> --- /dev/null
>> +++ b/package/mplayer/0007-enable-aarch64.patch
>> @@ -0,0 +1,13 @@
> 
> All patches in Buildroot should have a description and a Signed-off-by
> line. See
> http://buildroot.org/downloads/manual/manual.html#_format_and_licensing_of_the_package_patches
> for details.

 Once that is done, could you also send the patch upstream?

 Regards,
 Arnout


-- 
Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF

[Buildroot] [PATCH v3] Buildroot' patch to add support for aarch64 in mplayer configure script

[Joao Pinto]

Hi Arnout!

On 9/15/2015 10:22 PM, Arnout Vandecappelle wrote:
> On 15-09-15 23:18, Thomas Petazzoni wrote:
>> Hello Joao,
>>
>> Your e-mail is two patches concataned to each other. Can you make that
>> a single patch instead?
>>
>> Also, the title should be adjusted, as I explained in a previous
>> message. See some more comments below.
>>
>> On Tue, 15 Sep 2015 18:00:48 +0100, jpinto wrote:
>>>
>>> Signed-off-by: Joao Pinto <jpinto@synopsys.com>
>>> Tested-by: Joao Pinto <jpinto@synopsys.com>
>>> ---
>>>  package/mplayer/0007-enable-aarch64.patch | 13 +++++++++++++
>>>  1 file changed, 13 insertions(+)
>>>  create mode 100644 package/mplayer/0007-enable-aarch64.patch
>>>
>>> diff --git a/package/mplayer/0007-enable-aarch64.patch b/package/mplayer/0007-enable-aarch64.patch
>>> new file mode 100644
>>> index 0000000..7f75756
>>> --- /dev/null
>>> +++ b/package/mplayer/0007-enable-aarch64.patch
>>> @@ -0,0 +1,13 @@
>>
>> All patches in Buildroot should have a description and a Signed-off-by
>> line. See
>> http://buildroot.org/downloads/manual/manual.html#_format_and_licensing_of_the_package_patches
>> for details.
> 
>  Once that is done, could you also send the patch upstream?

When you say upstream, you mean send it to mplayer authors?

> 
>  Regards,
>  Arnout
> 
> 

Regards,
Joao

[Buildroot] [PATCH v3] Buildroot' patch to add support for aarch64 in mplayer configure script

[Thomas Petazzoni]

Dear Joao Pinto,

On Wed, 16 Sep 2015 09:28:44 +0100, Joao Pinto wrote:

> >> All patches in Buildroot should have a description and a Signed-off-by
> >> line. See
> >> http://buildroot.org/downloads/manual/manual.html#_format_and_licensing_of_the_package_patches
> >> for details.
> > 
> >  Once that is done, could you also send the patch upstream?
> 
> When you say upstream, you mean send it to mplayer authors?

Yes, exactly. We don't really like to keep patches on packages forever,
so when they can be sent upstream, it's better.

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com