Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH v2 1/1] squeezelite: new package
@ 2015-09-20  1:16 kei-k at ca2.so-net.ne.jp
  2015-09-20  7:29 ` Vincent Olivert Riera
  0 siblings, 1 reply; 4+ messages in thread
From: kei-k at ca2.so-net.ne.jp @ 2015-09-20  1:16 UTC (permalink / raw)
  To: buildroot

I'm sending patch again as suggested Vincent.

Thank you,
Kawashima

Signed-off-by: Hiroshi Kawashima <kei-k@ca2.so-net.ne.jp>
---
 package/Config.in                  |    5 +----
 package/squeezelite/Config.in      |   32 ++++++++++++++++++++++++++++++++
 package/squeezelite/squeezelite.mk |   30 ++++++++++++++++++++++++++++++
 3 files changed, 63 insertions(+), 4 deletions(-)
 create mode 100644 package/squeezelite/Config.in
 create mode 100644 package/squeezelite/squeezelite.mk

diff --git a/package/Config.in b/package/Config.in
index 22aef52..57f4498 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -33,6 +33,7 @@ menu "Audio and video applications"
 	source "package/opus-tools/Config.in"
 	source "package/pulseaudio/Config.in"
 	source "package/sox/Config.in"
+	source "package/squeezelite/Config.in"
 	source "package/tidsp-binaries/Config.in"
 	source "package/tovid/Config.in"
 	source "package/tstools/Config.in"
@@ -111,7 +112,6 @@ menu "Development tools"
 	source "package/binutils/Config.in"
 	source "package/bsdiff/Config.in"
 	source "package/bustle/Config.in"
-	source "package/check/Config.in"
 	source "package/cmake/Config.in"
 	source "package/cppunit/Config.in"
 	source "package/cvs/Config.in"
@@ -697,7 +697,6 @@ menu "Audio/Sound"
 	source "package/libao/Config.in"
 	source "package/libbroadvoice/Config.in"
 	source "package/libcdaudio/Config.in"
-	source "package/libcddb/Config.in"
 	source "package/libcdio/Config.in"
 	source "package/libcodec2/Config.in"
 	source "package/libcue/Config.in"
@@ -769,7 +768,6 @@ menu "Database"
 	source "package/berkeleydb/Config.in"
 	source "package/cppdb/Config.in"
 	source "package/gdbm/Config.in"
-	source "package/kompexsqlite/Config.in"
 	source "package/leveldb/Config.in"
 	source "package/mysql/Config.in"
 	source "package/postgresql/Config.in"
@@ -1458,7 +1456,6 @@ if BR2_PACKAGE_BUSYBOX_SHOW_OTHERS
 	source "package/which/Config.in"
 endif
 	source "package/xmlstarlet/Config.in"
-	source "package/xxhash/Config.in"
 endmenu
 
 menu "System tools"
diff --git a/package/squeezelite/Config.in b/package/squeezelite/Config.in
new file mode 100644
index 0000000..c27dac2
--- /dev/null
+++ b/package/squeezelite/Config.in
@@ -0,0 +1,32 @@
+config BR2_PACKAGE_SQUEEZELITE
+	bool "squeezelite"
+	depends on BR2_USE_WCHAR # flac
+	depends on BR2_TOOLCHAIN_HAS_THREADS # alsa-lib
+	depends on BR2_USE_MMU # mpg123
+	select BR2_PACKAGE_ALSA_LIB
+	select BR2_PACKAGE_FLAC
+	select BR2_PACKAGE_LIBMAD
+	select BR2_PACKAGE_LIBVORBIS
+	select BR2_PACKAGE_FAAD2
+	select BR2_PACKAGE_MPG123
+	select BR2_PACKAGE_LIBSOXR
+	help
+	  Logitech Media Server client
+	  https://code.google.com/p/squeezelite/
+
+config BR2_PACKAGE_SQUEEZELITE_ENABLE_RESAMPLE
+	bool "Enable resampling function"
+	default y
+	depends on BR2_PACKAGE_SQUEEZELITE
+	help
+	  Enable resampling function
+
+config BR2_PACKAGE_SQUEEZELITE_WITH_RESAMPLE_MP
+	bool "Use OpenMP for resampling"
+	default y
+	depends on BR2_PACKAGE_SQUEEZELITE_ENABLE_RESAMPLE
+	help
+	  Enable OpenMP support for resampling
+
+comment "squeezelite needs a toolchain w/ wchar, threads, mmu
+	depends on !BR2_USE_WCHAR || !BR2_TOOLCHAIN_HAS_THREADS || !BR2_USE_MMU
diff --git a/package/squeezelite/squeezelite.mk b/package/squeezelite/squeezelite.mk
new file mode 100644
index 0000000..681bb46
--- /dev/null
+++ b/package/squeezelite/squeezelite.mk
@@ -0,0 +1,30 @@
+################################################################################
+#
+# squeezelite
+#
+################################################################################
+
+SQUEEZELITE_VERSION = v1.8
+SQUEEZELITE_SITE = https://code.google.com/p/squeezelite
+SQUEEZELITE_SITE_METHOD = git
+SQUEEZELITE_LICENSE = GPLv3
+SQUEEZELITE_LICENSE_FILE = LICENSE.txt
+SQUEEZELITE_DEPENDENCIES = alsa-lib flac libmad libvorbis faad2 mpg123 libsoxr
+
+ifeq ($(BR2_PACKAGE_SQUEEZELITE_ENABLE_RESAMPLE),y)
+	SQUEEZELITE_MAKE_OPTS += -DRESAMPLE
+	ifeq ($(BR2_PACKAGE_SQUEEZELITE_WITH_RESAMPLE_MP),y)
+		SQUEEZELITE_MAKE_OPTS += -DRESAMPLE_MP
+	endif
+endif
+
+define SQUEEZELITE_BUILD_CMDS
+    $(TARGET_MAKE_ENV) $(MAKE) OPTS="$(SQUEEZELITE_MAKE_OPTS)" \
+	CC="$(TARGET_CC)" LD="$(TARGET_LD)" -C $(@D) all
+endef
+
+define SQUEEZELITE_INSTALL_TARGET_CMDS
+    $(INSTALL) -D -m 0755 $(@D)/squeezelite $(TARGET_DIR)/usr/bin
+endef
+
+$(eval $(generic-package))
-- 
1.7.1

============================================================
    Hiroshi Kawashima

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [Buildroot] [PATCH v2 1/1] squeezelite: new package
  2015-09-20  1:16 kei-k at ca2.so-net.ne.jp
@ 2015-09-20  7:29 ` Vincent Olivert Riera
  0 siblings, 0 replies; 4+ messages in thread
From: Vincent Olivert Riera @ 2015-09-20  7:29 UTC (permalink / raw)
  To: buildroot

Dear Hiroshi Kawashima,

On 20/09/15 02:16, kei-k at ca2.so-net.ne.jp wrote:
> I'm sending patch again as suggested Vincent.
>
> Thank you,
> Kawashima

that commit log doesn't explain what your patch does.

> Signed-off-by: Hiroshi Kawashima <kei-k@ca2.so-net.ne.jp>
> ---

The changelog between version should be here.

> package/Config.in | 5 +----
> package/squeezelite/Config.in | 32 ++++++++++++++++++++++++++++++++
> package/squeezelite/squeezelite.mk | 30 ++++++++++++++++++++++++++++++
> 3 files changed, 63 insertions(+), 4 deletions(-)
> create mode 100644 package/squeezelite/Config.in
> create mode 100644 package/squeezelite/squeezelite.mk
>
> diff --git a/package/Config.in b/package/Config.in
> index 22aef52..57f4498 100644
> --- a/package/Config.in
> +++ b/package/Config.in
> @@ -33,6 +33,7 @@ menu "Audio and video applications"
> source "package/opus-tools/Config.in"
> source "package/pulseaudio/Config.in"
> source "package/sox/Config.in"
> + source "package/squeezelite/Config.in"
> source "package/tidsp-binaries/Config.in"
> source "package/tovid/Config.in"
> source "package/tstools/Config.in"
> @@ -111,7 +112,6 @@ menu "Development tools"
> source "package/binutils/Config.in"
> source "package/bsdiff/Config.in"
> source "package/bustle/Config.in"
> - source "package/check/Config.in"

Why do you remove this package from the menu?

> source "package/cmake/Config.in"
> source "package/cppunit/Config.in"
> source "package/cvs/Config.in"
> @@ -697,7 +697,6 @@ menu "Audio/Sound"
> source "package/libao/Config.in"
> source "package/libbroadvoice/Config.in"
> source "package/libcdaudio/Config.in"
> - source "package/libcddb/Config.in"

And this one.

> source "package/libcdio/Config.in"
> source "package/libcodec2/Config.in"
> source "package/libcue/Config.in"
> @@ -769,7 +768,6 @@ menu "Database"
> source "package/berkeleydb/Config.in"
> source "package/cppdb/Config.in"
> source "package/gdbm/Config.in"
> - source "package/kompexsqlite/Config.in"

And this one.

> source "package/leveldb/Config.in"
> source "package/mysql/Config.in"
> source "package/postgresql/Config.in"
> @@ -1458,7 +1456,6 @@ if BR2_PACKAGE_BUSYBOX_SHOW_OTHERS
> source "package/which/Config.in"
> endif
> source "package/xmlstarlet/Config.in"
> - source "package/xxhash/Config.in"

And this one.

> endmenu
>
> menu "System tools"
> diff --git a/package/squeezelite/Config.in b/package/squeezelite/Config.in
> new file mode 100644
> index 0000000..c27dac2
> --- /dev/null
> +++ b/package/squeezelite/Config.in
> @@ -0,0 +1,32 @@
> +config BR2_PACKAGE_SQUEEZELITE
> + bool "squeezelite"
> + depends on BR2_USE_WCHAR # flac
> + depends on BR2_TOOLCHAIN_HAS_THREADS # alsa-lib
> + depends on BR2_USE_MMU # mpg123
> + select BR2_PACKAGE_ALSA_LIB
> + select BR2_PACKAGE_FLAC
> + select BR2_PACKAGE_LIBMAD
> + select BR2_PACKAGE_LIBVORBIS
> + select BR2_PACKAGE_FAAD2
> + select BR2_PACKAGE_MPG123
> + select BR2_PACKAGE_LIBSOXR
> + help
> + Logitech Media Server client
> + https://code.google.com/p/squeezelite/
> +
> +config BR2_PACKAGE_SQUEEZELITE_ENABLE_RESAMPLE
> + bool "Enable resampling function"
> + default y
> + depends on BR2_PACKAGE_SQUEEZELITE
> + help
> + Enable resampling function
> +
> +config BR2_PACKAGE_SQUEEZELITE_WITH_RESAMPLE_MP
> + bool "Use OpenMP for resampling"
> + default y
> + depends on BR2_PACKAGE_SQUEEZELITE_ENABLE_RESAMPLE
> + help
> + Enable OpenMP support for resampling
> +
> +comment "squeezelite needs a toolchain w/ wchar, threads, mmu
> + depends on !BR2_USE_WCHAR || !BR2_TOOLCHAIN_HAS_THREADS || !BR2_USE_MMU

No, it should be exactly as I said (have a look to other packages to find examples):

comment "squeezelite needs a toolchain w/ wchar, threads
 depends BR2_USE_MMU
 depends on !BR2_USE_WCHAR || !BR2_TOOLCHAIN_HAS_THREADS

Regards,

Vincent.

> diff --git a/package/squeezelite/squeezelite.mk b/package/squeezelite/squeezelite.mk
> new file mode 100644
> index 0000000..681bb46
> --- /dev/null
> +++ b/package/squeezelite/squeezelite.mk
> @@ -0,0 +1,30 @@
> +################################################################################
> +#
> +# squeezelite
> +#
> +################################################################################
> +
> +SQUEEZELITE_VERSION = v1.8
> +SQUEEZELITE_SITE = https://code.google.com/p/squeezelite
> +SQUEEZELITE_SITE_METHOD = git
> +SQUEEZELITE_LICENSE = GPLv3
> +SQUEEZELITE_LICENSE_FILE = LICENSE.txt
> +SQUEEZELITE_DEPENDENCIES = alsa-lib flac libmad libvorbis faad2 mpg123 libsoxr
> +
> +ifeq ($(BR2_PACKAGE_SQUEEZELITE_ENABLE_RESAMPLE),y)
> + SQUEEZELITE_MAKE_OPTS += -DRESAMPLE
> + ifeq ($(BR2_PACKAGE_SQUEEZELITE_WITH_RESAMPLE_MP),y)
> + SQUEEZELITE_MAKE_OPTS += -DRESAMPLE_MP
> + endif
> +endif
> +
> +define SQUEEZELITE_BUILD_CMDS
> + $(TARGET_MAKE_ENV) $(MAKE) OPTS="$(SQUEEZELITE_MAKE_OPTS)" \
> + CC="$(TARGET_CC)" LD="$(TARGET_LD)" -C $(@D) all
> +endef
> +
> +define SQUEEZELITE_INSTALL_TARGET_CMDS
> + $(INSTALL) -D -m 0755 $(@D)/squeezelite $(TARGET_DIR)/usr/bin
> +endef
> +
> +$(eval $(generic-package))
> 

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [Buildroot]  [PATCH v2 1/1] squeezelite: new package
@ 2015-09-20  8:52 kei-k at ca2.so-net.ne.jp
  2015-09-20  9:05 ` Vicente Olivert Riera
  0 siblings, 1 reply; 4+ messages in thread
From: kei-k at ca2.so-net.ne.jp @ 2015-09-20  8:52 UTC (permalink / raw)
  To: buildroot

Signed-off-by: Hiroshi Kawashima <kei-k@ca2.so-net.ne.jp>
---
 package/Config.in                  |    1 +
 package/squeezelite/Config.in      |   32 ++++++++++++++++++++++++++++++++
 package/squeezelite/squeezelite.mk |   30 ++++++++++++++++++++++++++++++
 1 files changed, 63 insertions(+)
 create mode 100644 package/squeezelite/Config.in
 create mode 100644 package/squeezelite/squeezelite.mk

diff --git a/package/Config.in b/package/Config.in
index 22aef52..57f4498 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -33,6 +33,7 @@ menu "Audio and video applications"
 	source "package/opus-tools/Config.in"
 	source "package/pulseaudio/Config.in"
 	source "package/sox/Config.in"
+	source "package/squeezelite/Config.in"
 	source "package/tidsp-binaries/Config.in"
 	source "package/tovid/Config.in"
 	source "package/tstools/Config.in"
 menu "System tools"
diff --git a/package/squeezelite/Config.in b/package/squeezelite/Config.in
new file mode 100644
index 0000000..c27dac2
--- /dev/null
+++ b/package/squeezelite/Config.in
@@ -0,0 +1,32 @@
+config BR2_PACKAGE_SQUEEZELITE
+	bool "squeezelite"
+	depends on BR2_USE_WCHAR # flac
+	depends on BR2_TOOLCHAIN_HAS_THREADS # alsa-lib
+	depends on BR2_USE_MMU # mpg123
+	select BR2_PACKAGE_ALSA_LIB
+	select BR2_PACKAGE_FLAC
+	select BR2_PACKAGE_LIBMAD
+	select BR2_PACKAGE_LIBVORBIS
+	select BR2_PACKAGE_FAAD2
+	select BR2_PACKAGE_MPG123
+	select BR2_PACKAGE_LIBSOXR
+	help
+	  Logitech Media Server client
+	  https://code.google.com/p/squeezelite/
+
+config BR2_PACKAGE_SQUEEZELITE_ENABLE_RESAMPLE
+	bool "Enable resampling function"
+	default y
+	depends on BR2_PACKAGE_SQUEEZELITE
+	help
+	  Enable resampling function
+
+config BR2_PACKAGE_SQUEEZELITE_WITH_RESAMPLE_MP
+	bool "Use OpenMP for resampling"
+	default y
+	depends on BR2_PACKAGE_SQUEEZELITE_ENABLE_RESAMPLE
+	help
+	  Enable OpenMP support for resampling
+
+comment "squeezelite needs a toolchain w/ wchar, threads, mmu
+	depends on !BR2_USE_WCHAR || !BR2_TOOLCHAIN_HAS_THREADS || !BR2_USE_MMU
diff --git a/package/squeezelite/squeezelite.mk b/package/squeezelite/squeezelite.mk
new file mode 100644
index 0000000..681bb46
--- /dev/null
+++ b/package/squeezelite/squeezelite.mk
@@ -0,0 +1,30 @@
+################################################################################
+#
+# squeezelite
+#
+################################################################################
+
+SQUEEZELITE_VERSION = v1.8
+SQUEEZELITE_SITE = https://code.google.com/p/squeezelite
+SQUEEZELITE_SITE_METHOD = git
+SQUEEZELITE_LICENSE = GPLv3
+SQUEEZELITE_LICENSE_FILE = LICENSE.txt
+SQUEEZELITE_DEPENDENCIES = alsa-lib flac libmad libvorbis faad2 mpg123 libsoxr
+
+ifeq ($(BR2_PACKAGE_SQUEEZELITE_ENABLE_RESAMPLE),y)
+	SQUEEZELITE_MAKE_OPTS += -DRESAMPLE
+	ifeq ($(BR2_PACKAGE_SQUEEZELITE_WITH_RESAMPLE_MP),y)
+		SQUEEZELITE_MAKE_OPTS += -DRESAMPLE_MP
+	endif
+endif
+
+define SQUEEZELITE_BUILD_CMDS
+    $(TARGET_MAKE_ENV) $(MAKE) OPTS="$(SQUEEZELITE_MAKE_OPTS)" \
+	CC="$(TARGET_CC)" LD="$(TARGET_LD)" -C $(@D) all
+endef
+
+define SQUEEZELITE_INSTALL_TARGET_CMDS
+    $(INSTALL) -D -m 0755 $(@D)/squeezelite $(TARGET_DIR)/usr/bin
+endef
+
+$(eval $(generic-package))
-- 
1.7.1
============================================================
    Hiroshi Kawashima

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [Buildroot] [PATCH v2 1/1] squeezelite: new package
  2015-09-20  8:52 [Buildroot] [PATCH v2 1/1] squeezelite: new package kei-k at ca2.so-net.ne.jp
@ 2015-09-20  9:05 ` Vicente Olivert Riera
  0 siblings, 0 replies; 4+ messages in thread
From: Vicente Olivert Riera @ 2015-09-20  9:05 UTC (permalink / raw)
  To: buildroot

Dear Hiroshi Kawashima,

This patch should be v3 because the previous one was v2.

On 20/09/15 09:52, kei-k at ca2.so-net.ne.jp wrote:
[snip]

> +comment "squeezelite needs a toolchain w/ wchar, threads, mmu
> +	depends on !BR2_USE_WCHAR || !BR2_TOOLCHAIN_HAS_THREADS || !BR2_USE_MMU

It seems you missed part of my comments in the previous email. This 
should look like this:


comment "squeezelite needs a toolchain w/ wchar, threads"
	depends on BR2_USE_MMU
	depends on !BR2_USE_WCHAR || !BR2_TOOLCHAIN_HAS_THREADS

Regards,

Vincent.

[snip]

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2015-09-20  9:05 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-09-20  8:52 [Buildroot] [PATCH v2 1/1] squeezelite: new package kei-k at ca2.so-net.ne.jp
2015-09-20  9:05 ` Vicente Olivert Riera
  -- strict thread matches above, loose matches on Subject: below --
2015-09-20  1:16 kei-k at ca2.so-net.ne.jp
2015-09-20  7:29 ` Vincent Olivert Riera

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox