[Buildroot] [PATCH] rtptools: needs RPC support

[Buildroot] [PATCH] rtptools: needs RPC support

[Vicente Olivert Riera]

rtptools needs a toolchain with RPC support, otherwise it will fail with
an error message like this one:

host2ip.c:13:38: fatal error: rpcsvc/ypclnt.h: No such file or directory
 #include <rpcsvc/ypclnt.h>   /* YP */

Signed-off-by: Vicente Olivert Riera <Vincent.Riera@imgtec.com>
---
 package/rtptools/Config.in |    4 ++++
 1 files changed, 4 insertions(+), 0 deletions(-)

diff --git a/package/rtptools/Config.in b/package/rtptools/Config.in
index 80bbb7a..a798960 100644
--- a/package/rtptools/Config.in
+++ b/package/rtptools/Config.in
@@ -1,5 +1,9 @@
+comment "rtptools needs a toolchain w/ RPC"
+	depends on !BR2_TOOLCHAIN_HAS_NATIVE_RPC
+
 config BR2_PACKAGE_RTPTOOLS
 	bool "rtptools"
+	depends on BR2_TOOLCHAIN_HAS_NATIVE_RPC
 	help
 	  The rtptools distribution consists of a number of small
 	  applications that can be used for processing RTP data.
-- 
1.7.1

[Buildroot] [PATCH] rtptools: needs RPC support

[Thomas Petazzoni]

Dear Vicente Olivert Riera,

On Wed, 23 Sep 2015 12:57:59 +0100, Vicente Olivert Riera wrote:
> rtptools needs a toolchain with RPC support, otherwise it will fail with
> an error message like this one:
> 
> host2ip.c:13:38: fatal error: rpcsvc/ypclnt.h: No such file or directory
>  #include <rpcsvc/ypclnt.h>   /* YP */
> 
> Signed-off-by: Vicente Olivert Riera <Vincent.Riera@imgtec.com>

I'm surprised we have not seen autobuilder failures. Or did you forget
to include a reference to an autobuilder error?

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

[Buildroot] [PATCH] rtptools: needs RPC support

[Vicente Olivert Riera]

Dear Thomas Petazzoni,

On 09/23/2015 02:03 PM, Thomas Petazzoni wrote:
> Dear Vicente Olivert Riera,
> 
> On Wed, 23 Sep 2015 12:57:59 +0100, Vicente Olivert Riera wrote:
>> rtptools needs a toolchain with RPC support, otherwise it will fail with
>> an error message like this one:
>>
>> host2ip.c:13:38: fatal error: rpcsvc/ypclnt.h: No such file or directory
>>  #include <rpcsvc/ypclnt.h>   /* YP */
>>
>> Signed-off-by: Vicente Olivert Riera <Vincent.Riera@imgtec.com>
> 
> I'm surprised we have not seen autobuilder failures. Or did you forget
> to include a reference to an autobuilder error?

No, I didn't forget that. I have catch this issue with one local
autobuilder I have. If you wonder why I have a local autobuilder instead
of submitting the results to the ML, it's because that autobuilder uses
toolchains that are not yet included in our Buildroot tree.

Regards,

Vincent.

> 
> Thanks!
> 
> Thomas
> 

[Buildroot] [PATCH] rtptools: needs RPC support

[Thomas Petazzoni]

Hello,

On Wed, 23 Sep 2015 14:07:03 +0100, Vicente Olivert Riera wrote:

> > I'm surprised we have not seen autobuilder failures. Or did you forget
> > to include a reference to an autobuilder error?
> 
> No, I didn't forget that. I have catch this issue with one local
> autobuilder I have. If you wonder why I have a local autobuilder instead
> of submitting the results to the ML, it's because that autobuilder uses
> toolchains that are not yet included in our Buildroot tree.

That's perfectly OK. However, I wonder why we haven't seen this problem
with toolchains already tested in the autobuilders. rtptools does not
have any other dependencies, and we have a "basic" toolchain with no
special options enabled.

Also, I think your patch should instead be:

	select BR2_PACKAGE_LIBTIRPC if !BR2_TOOLCHAIN_HAS_NATIVE_RPC

and add libtirpc to the dependencies.

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

[Buildroot] [PATCH] rtptools: needs RPC support

[Vicente Olivert Riera]

Hi Thomas,

On 09/23/2015 02:12 PM, Thomas Petazzoni wrote:
> Hello,
> 
> On Wed, 23 Sep 2015 14:07:03 +0100, Vicente Olivert Riera wrote:
> 
>>> I'm surprised we have not seen autobuilder failures. Or did you forget
>>> to include a reference to an autobuilder error?
>>
>> No, I didn't forget that. I have catch this issue with one local
>> autobuilder I have. If you wonder why I have a local autobuilder instead
>> of submitting the results to the ML, it's because that autobuilder uses
>> toolchains that are not yet included in our Buildroot tree.
> 
> That's perfectly OK. However, I wonder why we haven't seen this problem
> with toolchains already tested in the autobuilders. rtptools does not
> have any other dependencies, and we have a "basic" toolchain with no
> special options enabled.
> 
> Also, I think your patch should instead be:
> 
> 	select BR2_PACKAGE_LIBTIRPC if !BR2_TOOLCHAIN_HAS_NATIVE_RPC

I already tried that and it didn't fix the problem. Also added to the
.mk file the following:

ifeq ($(BR2_TOOLCHAIN_HAS_NATIVE_RPC),y)
RTPTOOLS_DEPENDENCIES += libtirpc
endif

After checking that libtirpc was installed, then I ran this command:

find output/staging/ -type f -name "ypclnt.h"

And that file doesn't exist either, so libtirpc can't fix the problem.

Regards,

Vincent.

> and add libtirpc to the dependencies.
> 
> Thomas
> 

[Buildroot] [PATCH] rtptools: needs RPC support

[Vicente Olivert Riera]

Hi again Thomas,

On 09/23/2015 02:16 PM, Vicente Olivert Riera wrote:
> Hi Thomas,
> 
> On 09/23/2015 02:12 PM, Thomas Petazzoni wrote:
>> Hello,
>>
>> On Wed, 23 Sep 2015 14:07:03 +0100, Vicente Olivert Riera wrote:
>>
>>>> I'm surprised we have not seen autobuilder failures. Or did you forget
>>>> to include a reference to an autobuilder error?
>>>
>>> No, I didn't forget that. I have catch this issue with one local
>>> autobuilder I have. If you wonder why I have a local autobuilder instead
>>> of submitting the results to the ML, it's because that autobuilder uses
>>> toolchains that are not yet included in our Buildroot tree.
>>
>> That's perfectly OK. However, I wonder why we haven't seen this problem
>> with toolchains already tested in the autobuilders. rtptools does not
>> have any other dependencies, and we have a "basic" toolchain with no
>> special options enabled.
>>
>> Also, I think your patch should instead be:
>>
>> 	select BR2_PACKAGE_LIBTIRPC if !BR2_TOOLCHAIN_HAS_NATIVE_RPC
> 
> I already tried that and it didn't fix the problem. Also added to the
> .mk file the following:
> 
> ifeq ($(BR2_TOOLCHAIN_HAS_NATIVE_RPC),y)

Sorry, I didn't put the "y" when I tried it. It was just a type while
writing the email.

Regards,

Vincent.

> RTPTOOLS_DEPENDENCIES += libtirpc
> endif
> 
> After checking that libtirpc was installed, then I ran this command:
> 
> find output/staging/ -type f -name "ypclnt.h"
> 
> And that file doesn't exist either, so libtirpc can't fix the problem.
> 
> Regards,
> 
> Vincent.
> 
>> and add libtirpc to the dependencies.
>>
>> Thomas
>>
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
> 

[Buildroot] [PATCH] rtptools: needs RPC support

[Peter Korsgaard]

>>>>> "Vicente" == Vicente Olivert Riera <Vincent.Riera@imgtec.com> writes:

 > rtptools needs a toolchain with RPC support, otherwise it will fail with
 > an error message like this one:

 > host2ip.c:13:38: fatal error: rpcsvc/ypclnt.h: No such file or directory
 >  #include <rpcsvc/ypclnt.h>   /* YP */

Hmm, are you sure?

I just did a test build here with a toolchain without RPC support:

find output/staging/usr -name ypclnt.h

But it still built. I do see that rpctools itself contain that header
file:

find output/build/rtptools-1.20 -name ypclnt.h
output/build/rtptools-1.20/nt/include/ypclnt.h
output/build/rtptools-1.20/nt/include/rpcsvc/ypclnt.h

-- 
Bye, Peter Korsgaard

[Buildroot] [PATCH] rtptools: needs RPC support

[Vicente Olivert Riera]

Dear Peter Korsgaard,

On 23/09/15 22:25, Peter Korsgaard wrote:
>>>>>> "Vicente" == Vicente Olivert Riera <Vincent.Riera@imgtec.com> writes:
>
>   > rtptools needs a toolchain with RPC support, otherwise it will fail with
>   > an error message like this one:
>
>   > host2ip.c:13:38: fatal error: rpcsvc/ypclnt.h: No such file or directory
>   >  #include <rpcsvc/ypclnt.h>   /* YP */
>
> Hmm, are you sure?
>
> I just did a test build here with a toolchain without RPC support:
>
> find output/staging/usr -name ypclnt.h
>
> But it still built. I do see that rpctools itself contain that header
> file:
>
> find output/build/rtptools-1.20 -name ypclnt.h
> output/build/rtptools-1.20/nt/include/ypclnt.h
> output/build/rtptools-1.20/nt/include/rpcsvc/ypclnt.h
>

We were discussing about this in the IRC during this afternoon, and 
checked that it actually builds with toolchains without RPC. I 
highlighted the issue using a toolchain which is a bit special.
I then marked my patch as deferred few hours ago, but now I'm going to 
mark it as rejected. I will keep investigating about this because is 
very weird that the rtptools itself has the headers but my toolchain is 
not able to find them.

Regards,

Vincent.