From: Vicente Olivert Riera <Vincent.Riera@imgtec.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] libwebsockets: add option to enable/disable ipv6 support
Date: Wed, 23 Sep 2015 15:51:09 +0100 [thread overview]
Message-ID: <5602BC5D.40101@imgtec.com> (raw)
In-Reply-To: <816992ffccd84eb3bdfaa89a699d1610@LysExc01.nanotronic.local>
Dear Wetzel Andreas,
thanks for fixing the issue.
On 09/23/2015 03:43 PM, Wetzel Andreas wrote:
> Hi Vincente,
>
> Please find the corrected (with tabs) patch in the attachment.
why don't you send the v2 of your patch using git send-email? The
Buildroot project strongly prefers patches to be sent using git
send-email. It easier for everyone to review them and also for the
maintainer to apply them.
Regards,
Vincent.
>
> Regards,
> Andi
>
> ________________________________________
> From: Vicente Olivert Riera <Vincent.Riera@imgtec.com>
> Sent: Wednesday, September 23, 2015 16:08
> To: Wetzel Andreas
> Cc: buildroot
> Subject: Re: [Buildroot] [PATCH 1/1] libwebsockets: add option to enable/disable ipv6 support
>
> Dear Andreas Wetzel,
>
> On 09/23/2015 02:16 PM, Andreas Wetzel wrote:
>> Added configuration option BR2_PACKAGE_LIBWEBSOCKETS_IPV6 that
>> adds -DLWS_IPV6=ON/OFF to LIBWEBSOCKETS_CONF_OPTS.
>>
>> Signed-off-by: Andreas Wetzel <andreas.wetzel@nanotronic.ch>
>> ---
>> package/libwebsockets/Config.in | 7 +++++++
>> package/libwebsockets/libwebsockets.mk | 8 +++++++-
>> 2 files changed, 14 insertions(+), 1 deletion(-)
>>
>> diff --git a/package/libwebsockets/Config.in b/package/libwebsockets/Config.in
>> index 2b350bf..e3c7eea 100644
>> --- a/package/libwebsockets/Config.in
>> +++ b/package/libwebsockets/Config.in
>> @@ -8,3 +8,10 @@ config BR2_PACKAGE_LIBWEBSOCKETS
>> in both directions.
>>
>> http://libwebsockets.org/
>> +
>> +if BR2_PACKAGE_LIBWEBSOCKETS
>> +
>> +config BR2_PACKAGE_LIBWEBSOCKETS_IPV6
>> + bool "Compile with support for ipv6"
>
> please use tabs for indentation, not spaces.
>
> Regards,
>
> Vincent.
>
>> +
>> +endif
>> diff --git a/package/libwebsockets/libwebsockets.mk b/package/libwebsockets/libwebsockets.mk
>> index 2f83748..f4a3db2 100644
>> --- a/package/libwebsockets/libwebsockets.mk
>> +++ b/package/libwebsockets/libwebsockets.mk
>> @@ -11,7 +11,7 @@ LIBWEBSOCKETS_LICENSE = LGPLv2.1 with exceptions
>> LIBWEBSOCKETS_LICENSE_FILES = LICENSE
>> LIBWEBSOCKETS_DEPENDENCIES = zlib
>> LIBWEBSOCKETS_INSTALL_STAGING = YES
>> -LIBWEBSOCKETS_CONF_OPTS = -DLWS_WITHOUT_TESTAPPS=ON -DLWS_IPV6=ON
>> +LIBWEBSOCKETS_CONF_OPTS = -DLWS_WITHOUT_TESTAPPS=ON
>>
>> ifeq ($(BR2_PACKAGE_OPENSSL),y)
>> LIBWEBSOCKETS_DEPENDENCIES += openssl host-openssl
>> @@ -20,4 +20,10 @@ else
>> LIBWEBSOCKETS_CONF_OPTS += -DLWS_WITH_SSL=OFF
>> endif
>>
>> +ifeq ($(BR2_PACKAGE_LIBWEBSOCKETS_IPV6),y)
>> +LIBWEBSOCKETS_CONF_OPTS += -DLWS_IPV6=ON
>> +else
>> +LIBWEBSOCKETS_CONF_OPTS += -DLWS_IPV6=OFF
>> +endif
>> +
>> $(eval $(cmake-package))
>>
>
>
next prev parent reply other threads:[~2015-09-23 14:51 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-23 13:16 [Buildroot] [PATCH 1/1] libwebsockets: add option to enable/disable ipv6 support Andreas Wetzel
2015-09-23 14:08 ` Vicente Olivert Riera
2015-09-23 14:43 ` Wetzel Andreas
2015-09-23 14:51 ` Vicente Olivert Riera [this message]
2015-09-23 15:12 ` Wetzel Andreas
2015-09-23 15:42 ` Vicente Olivert Riera
2015-09-23 21:02 ` Thomas Petazzoni
2015-09-25 11:12 ` Wetzel Andreas
2015-09-25 12:06 ` Thomas Petazzoni
2015-09-25 12:27 ` Gustavo Zacarias
2015-09-25 12:33 ` Thomas Petazzoni
2015-10-03 18:57 ` Peter Korsgaard
2015-10-05 8:18 ` Wetzel Andreas
2015-10-10 17:24 ` Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5602BC5D.40101@imgtec.com \
--to=vincent.riera@imgtec.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox