[Buildroot] [PATCH 1/1] libwebsockets: add option to enable/disable ipv6 support

[Buildroot] [PATCH 1/1] libwebsockets: add option to enable/disable ipv6 support

[Andreas Wetzel]

Added configuration option BR2_PACKAGE_LIBWEBSOCKETS_IPV6 that
adds -DLWS_IPV6=ON/OFF to LIBWEBSOCKETS_CONF_OPTS.

Signed-off-by: Andreas Wetzel <andreas.wetzel@nanotronic.ch>
---
 package/libwebsockets/Config.in        | 7 +++++++
 package/libwebsockets/libwebsockets.mk | 8 +++++++-
 2 files changed, 14 insertions(+), 1 deletion(-)

diff --git a/package/libwebsockets/Config.in b/package/libwebsockets/Config.in
index 2b350bf..e3c7eea 100644
--- a/package/libwebsockets/Config.in
+++ b/package/libwebsockets/Config.in
@@ -8,3 +8,10 @@ config BR2_PACKAGE_LIBWEBSOCKETS
 	  in both directions.
 
 	  http://libwebsockets.org/
+
+if BR2_PACKAGE_LIBWEBSOCKETS
+
+config BR2_PACKAGE_LIBWEBSOCKETS_IPV6
+    bool "Compile with support for ipv6"
+
+endif
diff --git a/package/libwebsockets/libwebsockets.mk b/package/libwebsockets/libwebsockets.mk
index 2f83748..f4a3db2 100644
--- a/package/libwebsockets/libwebsockets.mk
+++ b/package/libwebsockets/libwebsockets.mk
@@ -11,7 +11,7 @@ LIBWEBSOCKETS_LICENSE = LGPLv2.1 with exceptions
 LIBWEBSOCKETS_LICENSE_FILES = LICENSE
 LIBWEBSOCKETS_DEPENDENCIES = zlib
 LIBWEBSOCKETS_INSTALL_STAGING = YES
-LIBWEBSOCKETS_CONF_OPTS = -DLWS_WITHOUT_TESTAPPS=ON -DLWS_IPV6=ON
+LIBWEBSOCKETS_CONF_OPTS = -DLWS_WITHOUT_TESTAPPS=ON
 
 ifeq ($(BR2_PACKAGE_OPENSSL),y)
 LIBWEBSOCKETS_DEPENDENCIES += openssl host-openssl
@@ -20,4 +20,10 @@ else
 LIBWEBSOCKETS_CONF_OPTS += -DLWS_WITH_SSL=OFF
 endif
 
+ifeq ($(BR2_PACKAGE_LIBWEBSOCKETS_IPV6),y)
+LIBWEBSOCKETS_CONF_OPTS += -DLWS_IPV6=ON
+else
+LIBWEBSOCKETS_CONF_OPTS += -DLWS_IPV6=OFF
+endif
+
 $(eval $(cmake-package))
-- 
2.1.4

[Buildroot] [PATCH 1/1] libwebsockets: add option to enable/disable ipv6 support

[Vicente Olivert Riera]

Dear Andreas Wetzel,

On 09/23/2015 02:16 PM, Andreas Wetzel wrote:
> Added configuration option BR2_PACKAGE_LIBWEBSOCKETS_IPV6 that
> adds -DLWS_IPV6=ON/OFF to LIBWEBSOCKETS_CONF_OPTS.
> 
> Signed-off-by: Andreas Wetzel <andreas.wetzel@nanotronic.ch>
> ---
>  package/libwebsockets/Config.in        | 7 +++++++
>  package/libwebsockets/libwebsockets.mk | 8 +++++++-
>  2 files changed, 14 insertions(+), 1 deletion(-)
> 
> diff --git a/package/libwebsockets/Config.in b/package/libwebsockets/Config.in
> index 2b350bf..e3c7eea 100644
> --- a/package/libwebsockets/Config.in
> +++ b/package/libwebsockets/Config.in
> @@ -8,3 +8,10 @@ config BR2_PACKAGE_LIBWEBSOCKETS
>  	  in both directions.
>  
>  	  http://libwebsockets.org/
> +
> +if BR2_PACKAGE_LIBWEBSOCKETS
> +
> +config BR2_PACKAGE_LIBWEBSOCKETS_IPV6
> +    bool "Compile with support for ipv6"

please use tabs for indentation, not spaces.

Regards,

Vincent.

> +
> +endif
> diff --git a/package/libwebsockets/libwebsockets.mk b/package/libwebsockets/libwebsockets.mk
> index 2f83748..f4a3db2 100644
> --- a/package/libwebsockets/libwebsockets.mk
> +++ b/package/libwebsockets/libwebsockets.mk
> @@ -11,7 +11,7 @@ LIBWEBSOCKETS_LICENSE = LGPLv2.1 with exceptions
>  LIBWEBSOCKETS_LICENSE_FILES = LICENSE
>  LIBWEBSOCKETS_DEPENDENCIES = zlib
>  LIBWEBSOCKETS_INSTALL_STAGING = YES
> -LIBWEBSOCKETS_CONF_OPTS = -DLWS_WITHOUT_TESTAPPS=ON -DLWS_IPV6=ON
> +LIBWEBSOCKETS_CONF_OPTS = -DLWS_WITHOUT_TESTAPPS=ON
>  
>  ifeq ($(BR2_PACKAGE_OPENSSL),y)
>  LIBWEBSOCKETS_DEPENDENCIES += openssl host-openssl
> @@ -20,4 +20,10 @@ else
>  LIBWEBSOCKETS_CONF_OPTS += -DLWS_WITH_SSL=OFF
>  endif
>  
> +ifeq ($(BR2_PACKAGE_LIBWEBSOCKETS_IPV6),y)
> +LIBWEBSOCKETS_CONF_OPTS += -DLWS_IPV6=ON
> +else
> +LIBWEBSOCKETS_CONF_OPTS += -DLWS_IPV6=OFF
> +endif
> +
>  $(eval $(cmake-package))
> 

[Buildroot] [PATCH 1/1] libwebsockets: add option to enable/disable ipv6 support

[Wetzel Andreas]

Hi Vincente,

Please find the corrected (with tabs) patch in the attachment.

Regards,
Andi

________________________________________
From: Vicente Olivert Riera <Vincent.Riera@imgtec.com>
Sent: Wednesday, September 23, 2015 16:08
To: Wetzel Andreas
Cc: buildroot
Subject: Re: [Buildroot] [PATCH 1/1] libwebsockets: add option to enable/disable ipv6 support

Dear Andreas Wetzel,

On 09/23/2015 02:16 PM, Andreas Wetzel wrote:
> Added configuration option BR2_PACKAGE_LIBWEBSOCKETS_IPV6 that
> adds -DLWS_IPV6=ON/OFF to LIBWEBSOCKETS_CONF_OPTS.
>
> Signed-off-by: Andreas Wetzel <andreas.wetzel@nanotronic.ch>
> ---
>  package/libwebsockets/Config.in        | 7 +++++++
>  package/libwebsockets/libwebsockets.mk | 8 +++++++-
>  2 files changed, 14 insertions(+), 1 deletion(-)
>
> diff --git a/package/libwebsockets/Config.in b/package/libwebsockets/Config.in
> index 2b350bf..e3c7eea 100644
> --- a/package/libwebsockets/Config.in
> +++ b/package/libwebsockets/Config.in
> @@ -8,3 +8,10 @@ config BR2_PACKAGE_LIBWEBSOCKETS
>         in both directions.
>
>         http://libwebsockets.org/
> +
> +if BR2_PACKAGE_LIBWEBSOCKETS
> +
> +config BR2_PACKAGE_LIBWEBSOCKETS_IPV6
> +    bool "Compile with support for ipv6"

please use tabs for indentation, not spaces.

Regards,

Vincent.

> +
> +endif
> diff --git a/package/libwebsockets/libwebsockets.mk b/package/libwebsockets/libwebsockets.mk
> index 2f83748..f4a3db2 100644
> --- a/package/libwebsockets/libwebsockets.mk
> +++ b/package/libwebsockets/libwebsockets.mk
> @@ -11,7 +11,7 @@ LIBWEBSOCKETS_LICENSE = LGPLv2.1 with exceptions
>  LIBWEBSOCKETS_LICENSE_FILES = LICENSE
>  LIBWEBSOCKETS_DEPENDENCIES = zlib
>  LIBWEBSOCKETS_INSTALL_STAGING = YES
> -LIBWEBSOCKETS_CONF_OPTS = -DLWS_WITHOUT_TESTAPPS=ON -DLWS_IPV6=ON
> +LIBWEBSOCKETS_CONF_OPTS = -DLWS_WITHOUT_TESTAPPS=ON
>
>  ifeq ($(BR2_PACKAGE_OPENSSL),y)
>  LIBWEBSOCKETS_DEPENDENCIES += openssl host-openssl
> @@ -20,4 +20,10 @@ else
>  LIBWEBSOCKETS_CONF_OPTS += -DLWS_WITH_SSL=OFF
>  endif
>
> +ifeq ($(BR2_PACKAGE_LIBWEBSOCKETS_IPV6),y)
> +LIBWEBSOCKETS_CONF_OPTS += -DLWS_IPV6=ON
> +else
> +LIBWEBSOCKETS_CONF_OPTS += -DLWS_IPV6=OFF
> +endif
> +
>  $(eval $(cmake-package))
>


-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-libwebsockets-add-option-to-enable-disable-ipv6-supp_v2.patch
Type: text/x-patch
Size: 1847 bytes
Desc: 0001-libwebsockets-add-option-to-enable-disable-ipv6-supp_v2.patch
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20150923/f5ae5df2/attachment.bin>

[Buildroot] [PATCH 1/1] libwebsockets: add option to enable/disable ipv6 support

[Vicente Olivert Riera]

Dear Wetzel Andreas,

thanks for fixing the issue.

On 09/23/2015 03:43 PM, Wetzel Andreas wrote:
> Hi Vincente,
> 
> Please find the corrected (with tabs) patch in the attachment.

why don't you send the v2 of your patch using git send-email? The
Buildroot project strongly prefers patches to be sent using git
send-email. It easier for everyone to review them and also for the
maintainer to apply them.

Regards,

Vincent.

> 
> Regards,
> Andi
> 
> ________________________________________
> From: Vicente Olivert Riera <Vincent.Riera@imgtec.com>
> Sent: Wednesday, September 23, 2015 16:08
> To: Wetzel Andreas
> Cc: buildroot
> Subject: Re: [Buildroot] [PATCH 1/1] libwebsockets: add option to enable/disable ipv6 support
> 
> Dear Andreas Wetzel,
> 
> On 09/23/2015 02:16 PM, Andreas Wetzel wrote:
>> Added configuration option BR2_PACKAGE_LIBWEBSOCKETS_IPV6 that
>> adds -DLWS_IPV6=ON/OFF to LIBWEBSOCKETS_CONF_OPTS.
>>
>> Signed-off-by: Andreas Wetzel <andreas.wetzel@nanotronic.ch>
>> ---
>>  package/libwebsockets/Config.in        | 7 +++++++
>>  package/libwebsockets/libwebsockets.mk | 8 +++++++-
>>  2 files changed, 14 insertions(+), 1 deletion(-)
>>
>> diff --git a/package/libwebsockets/Config.in b/package/libwebsockets/Config.in
>> index 2b350bf..e3c7eea 100644
>> --- a/package/libwebsockets/Config.in
>> +++ b/package/libwebsockets/Config.in
>> @@ -8,3 +8,10 @@ config BR2_PACKAGE_LIBWEBSOCKETS
>>         in both directions.
>>
>>         http://libwebsockets.org/
>> +
>> +if BR2_PACKAGE_LIBWEBSOCKETS
>> +
>> +config BR2_PACKAGE_LIBWEBSOCKETS_IPV6
>> +    bool "Compile with support for ipv6"
> 
> please use tabs for indentation, not spaces.
> 
> Regards,
> 
> Vincent.
> 
>> +
>> +endif
>> diff --git a/package/libwebsockets/libwebsockets.mk b/package/libwebsockets/libwebsockets.mk
>> index 2f83748..f4a3db2 100644
>> --- a/package/libwebsockets/libwebsockets.mk
>> +++ b/package/libwebsockets/libwebsockets.mk
>> @@ -11,7 +11,7 @@ LIBWEBSOCKETS_LICENSE = LGPLv2.1 with exceptions
>>  LIBWEBSOCKETS_LICENSE_FILES = LICENSE
>>  LIBWEBSOCKETS_DEPENDENCIES = zlib
>>  LIBWEBSOCKETS_INSTALL_STAGING = YES
>> -LIBWEBSOCKETS_CONF_OPTS = -DLWS_WITHOUT_TESTAPPS=ON -DLWS_IPV6=ON
>> +LIBWEBSOCKETS_CONF_OPTS = -DLWS_WITHOUT_TESTAPPS=ON
>>
>>  ifeq ($(BR2_PACKAGE_OPENSSL),y)
>>  LIBWEBSOCKETS_DEPENDENCIES += openssl host-openssl
>> @@ -20,4 +20,10 @@ else
>>  LIBWEBSOCKETS_CONF_OPTS += -DLWS_WITH_SSL=OFF
>>  endif
>>
>> +ifeq ($(BR2_PACKAGE_LIBWEBSOCKETS_IPV6),y)
>> +LIBWEBSOCKETS_CONF_OPTS += -DLWS_IPV6=ON
>> +else
>> +LIBWEBSOCKETS_CONF_OPTS += -DLWS_IPV6=OFF
>> +endif
>> +
>>  $(eval $(cmake-package))
>>
> 
> 

[Buildroot] [PATCH 1/1] libwebsockets: add option to enable/disable ipv6 support

[Wetzel Andreas]

Hi Vincente,

I thought about using git send-email again. But then favoured a reply to have the history included in the mail body. Sorry for that.

Next time I will use git send-email again. I don't like our outlook webmail anyway :)

Regards,
Andi

________________________________________
From: Vicente Olivert Riera <Vincent.Riera@imgtec.com>
Sent: Wednesday, September 23, 2015 16:51
To: Wetzel Andreas
Cc: buildroot
Subject: Re: [Buildroot] [PATCH 1/1] libwebsockets: add option to enable/disable ipv6 support

Dear Wetzel Andreas,

thanks for fixing the issue.

On 09/23/2015 03:43 PM, Wetzel Andreas wrote:
> Hi Vincente,
>
> Please find the corrected (with tabs) patch in the attachment.

why don't you send the v2 of your patch using git send-email? The
Buildroot project strongly prefers patches to be sent using git
send-email. It easier for everyone to review them and also for the
maintainer to apply them.

Regards,

Vincent.

>
> Regards,
> Andi
>
> ________________________________________
> From: Vicente Olivert Riera <Vincent.Riera@imgtec.com>
> Sent: Wednesday, September 23, 2015 16:08
> To: Wetzel Andreas
> Cc: buildroot
> Subject: Re: [Buildroot] [PATCH 1/1] libwebsockets: add option to enable/disable ipv6 support
>
> Dear Andreas Wetzel,
>
> On 09/23/2015 02:16 PM, Andreas Wetzel wrote:
>> Added configuration option BR2_PACKAGE_LIBWEBSOCKETS_IPV6 that
>> adds -DLWS_IPV6=ON/OFF to LIBWEBSOCKETS_CONF_OPTS.
>>
>> Signed-off-by: Andreas Wetzel <andreas.wetzel@nanotronic.ch>
>> ---
>>  package/libwebsockets/Config.in        | 7 +++++++
>>  package/libwebsockets/libwebsockets.mk | 8 +++++++-
>>  2 files changed, 14 insertions(+), 1 deletion(-)
>>
>> diff --git a/package/libwebsockets/Config.in b/package/libwebsockets/Config.in
>> index 2b350bf..e3c7eea 100644
>> --- a/package/libwebsockets/Config.in
>> +++ b/package/libwebsockets/Config.in
>> @@ -8,3 +8,10 @@ config BR2_PACKAGE_LIBWEBSOCKETS
>>         in both directions.
>>
>>         http://libwebsockets.org/
>> +
>> +if BR2_PACKAGE_LIBWEBSOCKETS
>> +
>> +config BR2_PACKAGE_LIBWEBSOCKETS_IPV6
>> +    bool "Compile with support for ipv6"
>
> please use tabs for indentation, not spaces.
>
> Regards,
>
> Vincent.
>
>> +
>> +endif
>> diff --git a/package/libwebsockets/libwebsockets.mk b/package/libwebsockets/libwebsockets.mk
>> index 2f83748..f4a3db2 100644
>> --- a/package/libwebsockets/libwebsockets.mk
>> +++ b/package/libwebsockets/libwebsockets.mk
>> @@ -11,7 +11,7 @@ LIBWEBSOCKETS_LICENSE = LGPLv2.1 with exceptions
>>  LIBWEBSOCKETS_LICENSE_FILES = LICENSE
>>  LIBWEBSOCKETS_DEPENDENCIES = zlib
>>  LIBWEBSOCKETS_INSTALL_STAGING = YES
>> -LIBWEBSOCKETS_CONF_OPTS = -DLWS_WITHOUT_TESTAPPS=ON -DLWS_IPV6=ON
>> +LIBWEBSOCKETS_CONF_OPTS = -DLWS_WITHOUT_TESTAPPS=ON
>>
>>  ifeq ($(BR2_PACKAGE_OPENSSL),y)
>>  LIBWEBSOCKETS_DEPENDENCIES += openssl host-openssl
>> @@ -20,4 +20,10 @@ else
>>  LIBWEBSOCKETS_CONF_OPTS += -DLWS_WITH_SSL=OFF
>>  endif
>>
>> +ifeq ($(BR2_PACKAGE_LIBWEBSOCKETS_IPV6),y)
>> +LIBWEBSOCKETS_CONF_OPTS += -DLWS_IPV6=ON
>> +else
>> +LIBWEBSOCKETS_CONF_OPTS += -DLWS_IPV6=OFF
>> +endif
>> +
>>  $(eval $(cmake-package))
>>
>
>

[Buildroot] [PATCH 1/1] libwebsockets: add option to enable/disable ipv6 support

[Vicente Olivert Riera]

Dear Wetzel Andreas,

On 09/23/2015 04:12 PM, Wetzel Andreas wrote:
> Hi Vincente,
> 
> I thought about using git send-email again. But then favoured a reply to have the history included in the mail body. Sorry for that.
> 
> Next time I will use git send-email again. I don't like our outlook webmail anyway :)

Nobody will do it for you, so I suggest you to send the v2 using send
email. That's what I would do if I were you :P

Regards,

Vincent.

> 
> Regards,
> Andi
> 
> ________________________________________
> From: Vicente Olivert Riera <Vincent.Riera@imgtec.com>
> Sent: Wednesday, September 23, 2015 16:51
> To: Wetzel Andreas
> Cc: buildroot
> Subject: Re: [Buildroot] [PATCH 1/1] libwebsockets: add option to enable/disable ipv6 support
> 
> Dear Wetzel Andreas,
> 
> thanks for fixing the issue.
> 
> On 09/23/2015 03:43 PM, Wetzel Andreas wrote:
>> Hi Vincente,
>>
>> Please find the corrected (with tabs) patch in the attachment.
> 
> why don't you send the v2 of your patch using git send-email? The
> Buildroot project strongly prefers patches to be sent using git
> send-email. It easier for everyone to review them and also for the
> maintainer to apply them.
> 
> Regards,
> 
> Vincent.
> 
>>
>> Regards,
>> Andi
>>
>> ________________________________________
>> From: Vicente Olivert Riera <Vincent.Riera@imgtec.com>
>> Sent: Wednesday, September 23, 2015 16:08
>> To: Wetzel Andreas
>> Cc: buildroot
>> Subject: Re: [Buildroot] [PATCH 1/1] libwebsockets: add option to enable/disable ipv6 support
>>
>> Dear Andreas Wetzel,
>>
>> On 09/23/2015 02:16 PM, Andreas Wetzel wrote:
>>> Added configuration option BR2_PACKAGE_LIBWEBSOCKETS_IPV6 that
>>> adds -DLWS_IPV6=ON/OFF to LIBWEBSOCKETS_CONF_OPTS.
>>>
>>> Signed-off-by: Andreas Wetzel <andreas.wetzel@nanotronic.ch>
>>> ---
>>>  package/libwebsockets/Config.in        | 7 +++++++
>>>  package/libwebsockets/libwebsockets.mk | 8 +++++++-
>>>  2 files changed, 14 insertions(+), 1 deletion(-)
>>>
>>> diff --git a/package/libwebsockets/Config.in b/package/libwebsockets/Config.in
>>> index 2b350bf..e3c7eea 100644
>>> --- a/package/libwebsockets/Config.in
>>> +++ b/package/libwebsockets/Config.in
>>> @@ -8,3 +8,10 @@ config BR2_PACKAGE_LIBWEBSOCKETS
>>>         in both directions.
>>>
>>>         http://libwebsockets.org/
>>> +
>>> +if BR2_PACKAGE_LIBWEBSOCKETS
>>> +
>>> +config BR2_PACKAGE_LIBWEBSOCKETS_IPV6
>>> +    bool "Compile with support for ipv6"
>>
>> please use tabs for indentation, not spaces.
>>
>> Regards,
>>
>> Vincent.
>>
>>> +
>>> +endif
>>> diff --git a/package/libwebsockets/libwebsockets.mk b/package/libwebsockets/libwebsockets.mk
>>> index 2f83748..f4a3db2 100644
>>> --- a/package/libwebsockets/libwebsockets.mk
>>> +++ b/package/libwebsockets/libwebsockets.mk
>>> @@ -11,7 +11,7 @@ LIBWEBSOCKETS_LICENSE = LGPLv2.1 with exceptions
>>>  LIBWEBSOCKETS_LICENSE_FILES = LICENSE
>>>  LIBWEBSOCKETS_DEPENDENCIES = zlib
>>>  LIBWEBSOCKETS_INSTALL_STAGING = YES
>>> -LIBWEBSOCKETS_CONF_OPTS = -DLWS_WITHOUT_TESTAPPS=ON -DLWS_IPV6=ON
>>> +LIBWEBSOCKETS_CONF_OPTS = -DLWS_WITHOUT_TESTAPPS=ON
>>>
>>>  ifeq ($(BR2_PACKAGE_OPENSSL),y)
>>>  LIBWEBSOCKETS_DEPENDENCIES += openssl host-openssl
>>> @@ -20,4 +20,10 @@ else
>>>  LIBWEBSOCKETS_CONF_OPTS += -DLWS_WITH_SSL=OFF
>>>  endif
>>>
>>> +ifeq ($(BR2_PACKAGE_LIBWEBSOCKETS_IPV6),y)
>>> +LIBWEBSOCKETS_CONF_OPTS += -DLWS_IPV6=ON
>>> +else
>>> +LIBWEBSOCKETS_CONF_OPTS += -DLWS_IPV6=OFF
>>> +endif
>>> +
>>>  $(eval $(cmake-package))
>>>
>>
>>
> 
> 

[Buildroot] [PATCH 1/1] libwebsockets: add option to enable/disable ipv6 support

[Thomas Petazzoni]

Dear Andreas Wetzel,

On Wed, 23 Sep 2015 15:16:34 +0200, Andreas Wetzel wrote:
> Added configuration option BR2_PACKAGE_LIBWEBSOCKETS_IPV6 that
> adds -DLWS_IPV6=ON/OFF to LIBWEBSOCKETS_CONF_OPTS.
> 
> Signed-off-by: Andreas Wetzel <andreas.wetzel@nanotronic.ch>

We stopped supporting IPv6 as an optional feature in the toolchain, and
made it mandatory. So, to go in the same direction, I would suggest to
simply always enable IPv6 in libwebsockets.

What is the size overhead of enabling IPv6 ? If it's reasonable, then
we want IPv6 to be unconditionally enabled.

Best regards,

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

[Buildroot] [PATCH 1/1] libwebsockets: add option to enable/disable ipv6 support

[Wetzel Andreas]

Hi Thomas,

Ok, I was not aware that you made IPv6 mandantory. Sorry for that.

Currently, IPv6 is always enabled for libwebsockets.
In a project we used a kernel without support for IPv6. libwebsockets (with ipv6 support) seem to cause problems if the kernel does not support IPv6 at all. That's why I thought such configuration option would make sense.

Size is no reason. Including IPv6 support is a matter of a few kilobytes.

So my resolution is to add IPv6 support to the linux kernel we use to.

Thank you,
Andi
________________________________________
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
Sent: Wednesday, September 23, 2015 23:02
To: Wetzel Andreas
Cc: buildroot at busybox.net; Gustavo Zacarias
Subject: Re: [Buildroot] [PATCH 1/1] libwebsockets: add option to enable/disable ipv6 support

Dear Andreas Wetzel,

On Wed, 23 Sep 2015 15:16:34 +0200, Andreas Wetzel wrote:
> Added configuration option BR2_PACKAGE_LIBWEBSOCKETS_IPV6 that
> adds -DLWS_IPV6=ON/OFF to LIBWEBSOCKETS_CONF_OPTS.
>
> Signed-off-by: Andreas Wetzel <andreas.wetzel@nanotronic.ch>

We stopped supporting IPv6 as an optional feature in the toolchain, and
made it mandatory. So, to go in the same direction, I would suggest to
simply always enable IPv6 in libwebsockets.

What is the size overhead of enabling IPv6 ? If it's reasonable, then
we want IPv6 to be unconditionally enabled.

Best regards,

Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

[Buildroot] [PATCH 1/1] libwebsockets: add option to enable/disable ipv6 support

[Thomas Petazzoni]

Hello Andreas,

On Fri, 25 Sep 2015 11:12:00 +0000, Wetzel Andreas wrote:

> Ok, I was not aware that you made IPv6 mandantory. Sorry for that.
> 
> Currently, IPv6 is always enabled for libwebsockets.
> In a project we used a kernel without support for IPv6. libwebsockets (with ipv6 support) seem to cause problems if the kernel does not support IPv6 at all. That's why I thought such configuration option would make sense.
> 
> Size is no reason. Including IPv6 support is a matter of a few kilobytes.
> 
> So my resolution is to add IPv6 support to the linux kernel we use to.

What is the size difference of the kernel with/without IPv6 enabled? If
it's very significant, then maybe we need to revisit this? Gustavo?

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

[Buildroot] [PATCH 1/1] libwebsockets: add option to enable/disable ipv6 support

[Gustavo Zacarias]

On 25/09/15 09:06, Thomas Petazzoni wrote:

>> Size is no reason. Including IPv6 support is a matter of a few kilobytes.
>>
>> So my resolution is to add IPv6 support to the linux kernel we use to.
>
> What is the size difference of the kernel with/without IPv6 enabled? If
> it's very significant, then maybe we need to revisit this? Gustavo?
>
> Thomas

Hi Thomas.
Size delta kernel 4.2.1 x86_64_defconfig:
System is 5879 kB vs 5704 kB
Not much.

Keep in mind that even if we introduce the ipv6 option back this will be 
an issue anyway with glibc and musl-based systems since the kernel might 
lack ipv6 as well, sounds more like a bug than anything else.

Regards.

[Buildroot] [PATCH 1/1] libwebsockets: add option to enable/disable ipv6 support

[Thomas Petazzoni]

Hello,

On Fri, 25 Sep 2015 09:27:08 -0300, Gustavo Zacarias wrote:

> Hi Thomas.
> Size delta kernel 4.2.1 x86_64_defconfig:
> System is 5879 kB vs 5704 kB
> Not much.

Still quite a bit, but not huge either.

> Keep in mind that even if we introduce the ipv6 option back this will be 
> an issue anyway with glibc and musl-based systems since the kernel might 
> lack ipv6 as well, sounds more like a bug than anything else.

Yes, probably libwebsockets should be able to work with IPv6 enabled
even if IPv6 support is disabled in the kernel, no?

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

[Buildroot] [PATCH 1/1] libwebsockets: add option to enable/disable ipv6 support

[Peter Korsgaard]

>>>>> "Andreas" == Andreas Wetzel <andreas.wetzel@nanotronic.ch> writes:

 > Added configuration option BR2_PACKAGE_LIBWEBSOCKETS_IPV6 that
 > adds -DLWS_IPV6=ON/OFF to LIBWEBSOCKETS_CONF_OPTS.

So apparently this is a bug in libwebsockets? Have you brought up the
issue with the libwebsockets developers?

-- 
Bye, Peter Korsgaard

[Buildroot] [PATCH 1/1] libwebsockets: add option to enable/disable ipv6 support

[Wetzel Andreas]

>>>>>> "Andreas" == Andreas Wetzel <andreas.wetzel@nanotronic.ch> writes:

>> Added configuration option BR2_PACKAGE_LIBWEBSOCKETS_IPV6 that
>> adds -DLWS_IPV6=ON/OFF to LIBWEBSOCKETS_CONF_OPTS.

> So apparently this is a bug in libwebsockets? Have you brought up the
> issue with the libwebsockets developers?

I have not yet done that, but I'll for sure ask for comments in the libwebsockets list.

Regards,
Andi

[Buildroot] [PATCH 1/1] libwebsockets: add option to enable/disable ipv6 support

[Thomas Petazzoni]

Dear Andreas Wetzel,

On Wed, 23 Sep 2015 15:16:34 +0200, Andreas Wetzel wrote:
> Added configuration option BR2_PACKAGE_LIBWEBSOCKETS_IPV6 that
> adds -DLWS_IPV6=ON/OFF to LIBWEBSOCKETS_CONF_OPTS.
> 
> Signed-off-by: Andreas Wetzel <andreas.wetzel@nanotronic.ch>

Have you received some news from the upstream developers to explain why
an IPv6-enabled libwebsocket breaks with a non-IPv6 capable kernel?

In the mean time, I'll mark your patch as Changes Requested in our
patch tracking system, since you have received some comments. So please
make sure you repost a new version once you receive more feedback from
upstream (hopefully a patch for libwebsockets that makes it work
correctly even if the kernel doesn't have IPv6 support).

Thanks,

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com