[Buildroot] [PATCH 1/1] drbd-utils: bump version to 8.9.4

[Buildroot] [PATCH 1/1] drbd-utils: bump version to 8.9.4

[Christophe Vu-Brugier]

Version 8.9.4 of drbd-utils contains fixes for the musl C library.

Fixes http://autobuild.buildroot.net/results/4e0/4e0ed65b2e06f4ccadcad5b4302e6334667ecbdb

Moreover, this commit removes the hook used to disable the
documentation which is no longer necessary.

Signed-off-by: Christophe Vu-Brugier <cvubrugier@fastmail.fm>
---
 package/drbd-utils/drbd-utils.hash | 2 +-
 package/drbd-utils/drbd-utils.mk   | 8 +-------
 2 files changed, 2 insertions(+), 8 deletions(-)

diff --git a/package/drbd-utils/drbd-utils.hash b/package/drbd-utils/drbd-utils.hash
index c9894cd..731526e 100644
--- a/package/drbd-utils/drbd-utils.hash
+++ b/package/drbd-utils/drbd-utils.hash
@@ -1,2 +1,2 @@
 # Locally calculated
-sha256	2c531655d0d198a6af055edbc90f232538c2a3d2ce3fe137d03d06de4c1166d7	drbd-utils-8.9.1.tar.gz
+sha256	01a8924f8bc1370fc91e0495989d69b65c3b08346006d614d4b1dbdcd1caade5	drbd-utils-8.9.4.tar.gz
diff --git a/package/drbd-utils/drbd-utils.mk b/package/drbd-utils/drbd-utils.mk
index 5df5b81..627b9a4 100644
--- a/package/drbd-utils/drbd-utils.mk
+++ b/package/drbd-utils/drbd-utils.mk
@@ -4,7 +4,7 @@
 #
 ################################################################################
 
-DRBD_UTILS_VERSION = 8.9.1
+DRBD_UTILS_VERSION = 8.9.4
 DRBD_UTILS_SITE = http://oss.linbit.com/drbd/
 DRBD_UTILS_LICENSE = GPLv2+
 DRBD_UTILS_LICENSE_FILES = COPYING
@@ -26,10 +26,4 @@ else
 DRBD_UTILS_CONF_OPTS += --with-udev=no
 endif
 
-# Do not build the documentation because it requires docbook
-define DRBD_UTILS_DISABLE_DOCS
-	$(SED) 's/user scripts documentation/user scripts/' $(@D)/Makefile.in
-endef
-DRBD_UTILS_POST_PATCH_HOOKS += DRBD_UTILS_DISABLE_DOCS
-
 $(eval $(autotools-package))
-- 
2.5.1

[Buildroot] [PATCH 1/1] drbd-utils: bump version to 8.9.4

[Vicente Olivert Riera]

Dear Christophe Vu-Brugier,

On 09/21/2015 09:48 AM, Christophe Vu-Brugier wrote:
> Version 8.9.4 of drbd-utils contains fixes for the musl C library.
> 
> Fixes http://autobuild.buildroot.net/results/4e0/4e0ed65b2e06f4ccadcad5b4302e6334667ecbdb

There is a comment below that will require you to send a v2 of your
patch. When you do it, could you please add the autobuild URL in this way?

-------------
Fixes:

<space><space><here the autobuil url>
-------------

That's the most common way to point to an autobuild URL in the commit
log. See an example:

http://git.buildroot.net/buildroot/commit/?id=9119c1e6586d0719cec0f39488c22f136da318f1

> Moreover, this commit removes the hook used to disable the
> documentation which is no longer necessary.
> 
> Signed-off-by: Christophe Vu-Brugier <cvubrugier@fastmail.fm>
> ---
>  package/drbd-utils/drbd-utils.hash | 2 +-
>  package/drbd-utils/drbd-utils.mk   | 8 +-------
>  2 files changed, 2 insertions(+), 8 deletions(-)
> 
> diff --git a/package/drbd-utils/drbd-utils.hash b/package/drbd-utils/drbd-utils.hash
> index c9894cd..731526e 100644
> --- a/package/drbd-utils/drbd-utils.hash
> +++ b/package/drbd-utils/drbd-utils.hash
> @@ -1,2 +1,2 @@
>  # Locally calculated
> -sha256	2c531655d0d198a6af055edbc90f232538c2a3d2ce3fe137d03d06de4c1166d7	drbd-utils-8.9.1.tar.gz
> +sha256	01a8924f8bc1370fc91e0495989d69b65c3b08346006d614d4b1dbdcd1caade5	drbd-utils-8.9.4.tar.gz

That hash value is wrong:

ERROR: drbd-utils-8.9.4.tar.gz has wrong sha256 hash:
ERROR: expected:
01a8924f8bc1370fc91e0495989d69b65c3b08346006d614d4b1dbdcd1caade5
ERROR: got     :
38929279d1bf549fd1ade4ce6773a6fe209db51bbb0efe7bf6d2b7871ba0afbc

Please send an v2 with the right hash value.

Regards,

Vincent.

> diff --git a/package/drbd-utils/drbd-utils.mk b/package/drbd-utils/drbd-utils.mk
> index 5df5b81..627b9a4 100644
> --- a/package/drbd-utils/drbd-utils.mk
> +++ b/package/drbd-utils/drbd-utils.mk
> @@ -4,7 +4,7 @@
>  #
>  ################################################################################
>  
> -DRBD_UTILS_VERSION = 8.9.1
> +DRBD_UTILS_VERSION = 8.9.4
>  DRBD_UTILS_SITE = http://oss.linbit.com/drbd/
>  DRBD_UTILS_LICENSE = GPLv2+
>  DRBD_UTILS_LICENSE_FILES = COPYING
> @@ -26,10 +26,4 @@ else
>  DRBD_UTILS_CONF_OPTS += --with-udev=no
>  endif
>  
> -# Do not build the documentation because it requires docbook
> -define DRBD_UTILS_DISABLE_DOCS
> -	$(SED) 's/user scripts documentation/user scripts/' $(@D)/Makefile.in
> -endef
> -DRBD_UTILS_POST_PATCH_HOOKS += DRBD_UTILS_DISABLE_DOCS
> -
>  $(eval $(autotools-package))
> 

[Buildroot] [PATCH 1/1] drbd-utils: bump version to 8.9.4

[Christophe Vu-Brugier]

Hi Vicente,

Thank you for your review!

On Thu, 24 Sep 2015 11:54:36 +0100, Vicente Olivert Riera wrote :
> That hash value is wrong:
> 
> ERROR: drbd-utils-8.9.4.tar.gz has wrong sha256 hash:
> ERROR: expected:
> 01a8924f8bc1370fc91e0495989d69b65c3b08346006d614d4b1dbdcd1caade5
> ERROR: got     :
> 38929279d1bf549fd1ade4ce6773a6fe209db51bbb0efe7bf6d2b7871ba0afbc
> 
> Please send an v2 with the right hash value.

That's very surprising, but you are right. The content of the tarball
has changed since I last downloaded it (on Monday 21st). It seems a new
tarball with the same name was released on Tuesday. It contains a set
of fixes committed two days ago:

  http://git.drbd.org/gitweb.cgi?p=drbd-utils.git;a=shortlog

I will respin my patch to fix the checksum and modify the commit
message for Autobuild as you suggested.

Thanks again!

-- 
Christophe Vu-Brugier

[Buildroot] [PATCH 1/1] drbd-utils: bump version to 8.9.4

[Vicente Olivert Riera]

Hi Christophe,

On 09/24/2015 02:00 PM, Christophe Vu-Brugier wrote:
> Hi Vicente,
> 
> Thank you for your review!
> 
> On Thu, 24 Sep 2015 11:54:36 +0100, Vicente Olivert Riera wrote :
>> That hash value is wrong:
>>
>> ERROR: drbd-utils-8.9.4.tar.gz has wrong sha256 hash:
>> ERROR: expected:
>> 01a8924f8bc1370fc91e0495989d69b65c3b08346006d614d4b1dbdcd1caade5
>> ERROR: got     :
>> 38929279d1bf549fd1ade4ce6773a6fe209db51bbb0efe7bf6d2b7871ba0afbc
>>
>> Please send an v2 with the right hash value.
> 
> That's very surprising, but you are right. The content of the tarball
> has changed since I last downloaded it (on Monday 21st). It seems a new
> tarball with the same name was released on Tuesday. It contains a set
> of fixes committed two days ago:
> 
>   http://git.drbd.org/gitweb.cgi?p=drbd-utils.git;a=shortlog

Then it wasn't your fault. They should have released a new tarball with
a different name. What they did is not a good practice. Anyway...

> I will respin my patch to fix the checksum and modify the commit
> message for Autobuild as you suggested.

Great! Don't forget to add the right subject prefix "PATCH v2", append
the Changelog below "---" and mark this patch as superseded in Patchwork :-)

http://buildroot.org/downloads/manual/manual.html#submitting-patches

Scroll down until "21.5.2. Patch revision changelog".

Regards,

Vincent.

> Thanks again!
>