From: Vicente Olivert Riera <Vincent.Riera@imgtec.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/2] Revert "setools: fix race condition"
Date: Wed, 30 Sep 2015 08:52:14 +0100 [thread overview]
Message-ID: <560B94AE.3020009@imgtec.com> (raw)
In-Reply-To: <20150929173206.11f589b7@free-electrons.com>
Hello Thomas,
On 29/09/15 16:32, Thomas Petazzoni wrote:
> Dear Vicente Olivert Riera,
>
> On Tue, 29 Sep 2015 16:08:29 +0100, Vicente Olivert Riera wrote:
>> This reverts commit 1ac68fe2c9b4cea91c7a30429ebf75279ede8e70.
>>
>> Further investigations revealed that the problem wasn't a race condition
>> but the lack of flex package in the host machine:
>>
>> https://github.com/TresysTechnology/setools3/issues/5#issuecomment-144048612
>
> Missing SoB line here :-)
Shame on me :-( I should have passed the '-s' option to 'git revert'.
I have sent a v2.
Thanks,
Vincent.
>
>> ---
>> package/setools/setools.mk | 4 ----
>> 1 files changed, 0 insertions(+), 4 deletions(-)
>>
>> diff --git a/package/setools/setools.mk b/package/setools/setools.mk
>> index 71301c7..a2bfd42 100644
>> --- a/package/setools/setools.mk
>> +++ b/package/setools/setools.mk
>> @@ -12,10 +12,6 @@ SETOOLS_INSTALL_STAGING = YES
>> SETOOLS_LICENSE = GPLv2+ LGPLv2.1+
>> SETOOLS_LICENSE_FILES = COPYING COPYING.GPL COPYING.LGPL
>>
>> -# Race condition reported upstream:
>> -# https://github.com/TresysTechnology/setools3/issues/5
>> -SETOOLS_MAKE = $(MAKE1)
>> -
>> # configure.ac is patched by the cross compile patch,
>> # so autoreconf is necessary
>> SETOOLS_AUTORECONF = YES
>
> Thomas
>
prev parent reply other threads:[~2015-09-30 7:52 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-29 15:08 [Buildroot] [PATCH 1/2] Revert "setools: fix race condition" Vicente Olivert Riera
2015-09-29 15:08 ` [Buildroot] [PATCH 2/2] setools: depends on host-flex Vicente Olivert Riera
2015-09-29 15:32 ` [Buildroot] [PATCH 1/2] Revert "setools: fix race condition" Thomas Petazzoni
2015-09-30 7:52 ` Vicente Olivert Riera [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=560B94AE.3020009@imgtec.com \
--to=vincent.riera@imgtec.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox