[Buildroot] [PATCH 1/2] Revert "setools: fix race condition"

[Buildroot] [PATCH 1/2] Revert "setools: fix race condition"

[Vicente Olivert Riera]

This reverts commit 1ac68fe2c9b4cea91c7a30429ebf75279ede8e70.

Further investigations revealed that the problem wasn't a race condition
but the lack of flex package in the host machine:

  https://github.com/TresysTechnology/setools3/issues/5#issuecomment-144048612
---
 package/setools/setools.mk |    4 ----
 1 files changed, 0 insertions(+), 4 deletions(-)

diff --git a/package/setools/setools.mk b/package/setools/setools.mk
index 71301c7..a2bfd42 100644
--- a/package/setools/setools.mk
+++ b/package/setools/setools.mk
@@ -12,10 +12,6 @@ SETOOLS_INSTALL_STAGING = YES
 SETOOLS_LICENSE = GPLv2+ LGPLv2.1+
 SETOOLS_LICENSE_FILES = COPYING COPYING.GPL COPYING.LGPL
 
-# Race condition reported upstream:
-# https://github.com/TresysTechnology/setools3/issues/5
-SETOOLS_MAKE = $(MAKE1)
-
 # configure.ac is patched by the cross compile patch,
 # so autoreconf is necessary
 SETOOLS_AUTORECONF = YES
-- 
1.7.1

[Buildroot] [PATCH 2/2] setools: depends on host-flex

[Vicente Olivert Riera]

setools needs host-flex in order to generate some source files during
build time, otherwise it will fail with an error like this one:

error: policy_scan.c: No such file or directory

Issue reported here as a race condition problem, but it turned out that
it the actual problem was the lack of host-flex:

  https://github.com/TresysTechnology/setools3/issues/5#issuecomment-144048612

Fixes:

  http://autobuild.buildroot.net/results/dad/dad9d79c10722b203536540141a6defc79937e4e/

Signed-off-by: Vicente Olivert Riera <Vincent.Riera@imgtec.com>
---
 package/setools/setools.mk |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/package/setools/setools.mk b/package/setools/setools.mk
index a2bfd42..612ab89 100644
--- a/package/setools/setools.mk
+++ b/package/setools/setools.mk
@@ -7,7 +7,7 @@
 SETOOLS_VERSION = 3.3.8
 SETOOLS_SOURCE = setools-$(SETOOLS_VERSION).tar.bz2
 SETOOLS_SITE = https://raw.githubusercontent.com/wiki/TresysTechnology/setools3/files/dists/setools-$(SETOOLS_VERSION)/
-SETOOLS_DEPENDENCIES = libselinux libsepol sqlite libxml2 bzip2 host-bison
+SETOOLS_DEPENDENCIES = libselinux libsepol sqlite libxml2 bzip2 host-bison host-flex
 SETOOLS_INSTALL_STAGING = YES
 SETOOLS_LICENSE = GPLv2+ LGPLv2.1+
 SETOOLS_LICENSE_FILES = COPYING COPYING.GPL COPYING.LGPL
-- 
1.7.1

[Buildroot] [PATCH 1/2] Revert "setools: fix race condition"

[Thomas Petazzoni]

Dear Vicente Olivert Riera,

On Tue, 29 Sep 2015 16:08:29 +0100, Vicente Olivert Riera wrote:
> This reverts commit 1ac68fe2c9b4cea91c7a30429ebf75279ede8e70.
> 
> Further investigations revealed that the problem wasn't a race condition
> but the lack of flex package in the host machine:
> 
>   https://github.com/TresysTechnology/setools3/issues/5#issuecomment-144048612

Missing SoB line here :-)

> ---
>  package/setools/setools.mk |    4 ----
>  1 files changed, 0 insertions(+), 4 deletions(-)
> 
> diff --git a/package/setools/setools.mk b/package/setools/setools.mk
> index 71301c7..a2bfd42 100644
> --- a/package/setools/setools.mk
> +++ b/package/setools/setools.mk
> @@ -12,10 +12,6 @@ SETOOLS_INSTALL_STAGING = YES
>  SETOOLS_LICENSE = GPLv2+ LGPLv2.1+
>  SETOOLS_LICENSE_FILES = COPYING COPYING.GPL COPYING.LGPL
>  
> -# Race condition reported upstream:
> -# https://github.com/TresysTechnology/setools3/issues/5
> -SETOOLS_MAKE = $(MAKE1)
> -
>  # configure.ac is patched by the cross compile patch,
>  # so autoreconf is necessary
>  SETOOLS_AUTORECONF = YES

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

[Buildroot] [PATCH 1/2] Revert "setools: fix race condition"

[Vicente Olivert Riera]

Hello Thomas,

On 29/09/15 16:32, Thomas Petazzoni wrote:
> Dear Vicente Olivert Riera,
>
> On Tue, 29 Sep 2015 16:08:29 +0100, Vicente Olivert Riera wrote:
>> This reverts commit 1ac68fe2c9b4cea91c7a30429ebf75279ede8e70.
>>
>> Further investigations revealed that the problem wasn't a race condition
>> but the lack of flex package in the host machine:
>>
>>    https://github.com/TresysTechnology/setools3/issues/5#issuecomment-144048612
>
> Missing SoB line here :-)

Shame on me :-( I should have passed the '-s' option to 'git revert'.

I have sent a v2.

Thanks,

Vincent.

>
>> ---
>>   package/setools/setools.mk |    4 ----
>>   1 files changed, 0 insertions(+), 4 deletions(-)
>>
>> diff --git a/package/setools/setools.mk b/package/setools/setools.mk
>> index 71301c7..a2bfd42 100644
>> --- a/package/setools/setools.mk
>> +++ b/package/setools/setools.mk
>> @@ -12,10 +12,6 @@ SETOOLS_INSTALL_STAGING = YES
>>   SETOOLS_LICENSE = GPLv2+ LGPLv2.1+
>>   SETOOLS_LICENSE_FILES = COPYING COPYING.GPL COPYING.LGPL
>>
>> -# Race condition reported upstream:
>> -# https://github.com/TresysTechnology/setools3/issues/5
>> -SETOOLS_MAKE = $(MAKE1)
>> -
>>   # configure.ac is patched by the cross compile patch,
>>   # so autoreconf is necessary
>>   SETOOLS_AUTORECONF = YES
>
> Thomas
>