* [Buildroot] [PATCH v3 1/3] skeleton: Clean up profile file
@ 2015-10-03 14:14 Maxime Hadjinlian
2015-10-03 14:14 ` [Buildroot] [PATCH v3 2/3] skeleton: Remove bash specific files Maxime Hadjinlian
` (2 more replies)
0 siblings, 3 replies; 7+ messages in thread
From: Maxime Hadjinlian @ 2015-10-03 14:14 UTC (permalink / raw)
To: buildroot
There's a lot of code in /etc/profile, which doesn't really belong in a
minimal default skeleton.
If the user has a specific needs, it needs to be added in
/etc/profile.d/ by a post-build script.
Signed-off-by Maxime Hadjinlian <maxime.hadjinlian@gmail.com>
---
v1 -> v2:
- Don't change indent and don't fix 'pretty' stuff
- Keep PS1 , PAGER and EDITOR setted.
- At the end of the for loop, add unset i
---
system/skeleton/etc/profile | 60 +++++--------------------------------
system/skeleton/etc/profile.d/umask | 1 +
2 files changed, 9 insertions(+), 52 deletions(-)
create mode 100644 system/skeleton/etc/profile.d/umask
diff --git a/system/skeleton/etc/profile b/system/skeleton/etc/profile
index c7438fe..c40a311 100644
--- a/system/skeleton/etc/profile
+++ b/system/skeleton/etc/profile
@@ -1,66 +1,22 @@
-# ~/.bashrc: executed by bash(1) for non-login interactive shells.
-
export PATH=\
/bin:\
/sbin:\
/usr/bin:\
-/usr/sbin:\
-/usr/local/bin
-
-# If running interactively, then:
-if [ "$PS1" ]; then
-
- if [ "$BASH" ]; then
- export PS1="[\u@\h \W]\\$ "
- alias ll='/bin/ls --color=tty -laFh'
- alias ls='/bin/ls --color=tty -F'
- export LS_COLORS='no=00:fi=00:di=01;34:ln=01;36:pi=40;33:so=01;35:do=01;35:bd=40;33;01:cd=40;33;01:or=40;31;01:ex=01;32:*.tar=01;31:*.tgz=01;31:*.arj=01;31:*.taz=01;31:*.lzh=01;31:*.zip=01;31:*.z=01;31:*.Z=01;31:*.gz=01;31:*.bz2=01;31:*.deb=01;31:*.rpm=01;31:*.jar=01;31:*.jpg=01;35:*.jpeg=01;35:*.png=01;35:*.gif=01;35:*.bmp=01;35:*.pbm=01;35:*.pgm=01;35:*.ppm=01;35:*.tga=01;35:*.xbm=01;35:*.xpm=01;35:*.tif=01;35:*.tiff=01;35:*.mpg=01;35:*.mpeg=01;35:*.avi=01;35:*.fli=01;35:*.gl=01;35:*.dl=01;35:*.xcf=01;35:*.xwd=01;35:';
- else
- if [ "`id -u`" -eq 0 ]; then
- export PS1='# '
- else
- export PS1='$ '
- fi
- fi
-
- export USER=`id -un`
- export LOGNAME=$USER
- export HOSTNAME=`/bin/hostname`
- export HISTSIZE=1000
- export HISTFILESIZE=1000
- export PAGER='/bin/more '
- export EDITOR='/bin/vi'
- export INPUTRC=/etc/inputrc
- export DMALLOC_OPTIONS=debug=0x34f47d83,inter=100,log=logfile
-
-fi;
+/usr/sbin
-if [ -z "$LANG" ]; then
- if [ -n $HOME ] && [ -r $HOME/.config/locale.conf ]; then
- . "$HOME/.config/locale.conf"
- elif [ -r /etc/locale.conf ]; then
- . /etc/locale.conf
- fi
+if [ "`id -u`" -eq 0 ]; then
+ export PS1='# '
+else
+ export PS1='$ '
fi
-LANG=${LANG:-C}
-export LANG
-[ -n "$LC_CTYPE" ] && export LC_CTYPE
-[ -n "$LC_NUMERIC" ] && export LC_NUMERIC
-[ -n "$LC_TIME" ] && export LC_TIME
-[ -n "$LC_COLLATE" ] && export LC_COLLATE
-[ -n "$LC_MONETARY" ] && export LC_MONETARY
-[ -n "$LC_MESSAGES" ] && export LC_MESSAGES
-[ -n "$LC_PAPER" ] && export LC_PAPER
-[ -n "$LC_NAME" ] && export LC_NAME
-[ -n "$LC_ADDRESS" ] && export LC_ADDRESS
-[ -n "$LC_TELEPHONE" ] && export LC_TELEPHONE
-[ -n "$LC_MEASUREMENT" ] && export LC_MEASUREMENT
-[ -n "$LC_IDENTIFICATION" ] && export LC_IDENTIFICATION
+export PAGER='/bin/more '
+export EDITOR='/bin/vi'
# Source configuration files from /etc/profile.d
for i in /etc/profile.d/*.sh ; do
if [ -r "$i" ]; then
. $i
fi
+ unset i
done
diff --git a/system/skeleton/etc/profile.d/umask b/system/skeleton/etc/profile.d/umask
new file mode 100644
index 0000000..8e71ad5
--- /dev/null
+++ b/system/skeleton/etc/profile.d/umask
@@ -0,0 +1 @@
+umask 022
--
2.5.3
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [Buildroot] [PATCH v3 2/3] skeleton: Remove bash specific files
2015-10-03 14:14 [Buildroot] [PATCH v3 1/3] skeleton: Clean up profile file Maxime Hadjinlian
@ 2015-10-03 14:14 ` Maxime Hadjinlian
2015-10-03 14:27 ` Arnout Vandecappelle
2015-10-03 14:14 ` [Buildroot] [PATCH v3 3/3] skeleton: Pretty fixes for /etc/profile Maxime Hadjinlian
2015-10-03 14:27 ` [Buildroot] [PATCH v3 1/3] skeleton: Clean up profile file Arnout Vandecappelle
2 siblings, 1 reply; 7+ messages in thread
From: Maxime Hadjinlian @ 2015-10-03 14:14 UTC (permalink / raw)
To: buildroot
Signed-off-by Maxime Hadjinlian <maxime.hadjinlian@gmail.com>
---
system/skeleton/root/.bash_history | 0
system/skeleton/root/.bash_logout | 7 -------
system/skeleton/root/.bash_profile | 7 -------
3 files changed, 14 deletions(-)
delete mode 100644 system/skeleton/root/.bash_history
delete mode 100644 system/skeleton/root/.bash_logout
delete mode 100644 system/skeleton/root/.bash_profile
diff --git a/system/skeleton/root/.bash_history b/system/skeleton/root/.bash_history
deleted file mode 100644
index e69de29..0000000
diff --git a/system/skeleton/root/.bash_logout b/system/skeleton/root/.bash_logout
deleted file mode 100644
index 77ef1f9..0000000
--- a/system/skeleton/root/.bash_logout
+++ /dev/null
@@ -1,7 +0,0 @@
-# ~/.bash_logout: executed by bash(1) when login shell exits.
-
-# when leaving the console clear the screen to increase privacy
-
-case "`tty`" in
- /dev/tty[0-9]*) clear
-esac
diff --git a/system/skeleton/root/.bash_profile b/system/skeleton/root/.bash_profile
deleted file mode 100644
index 0ee04a3..0000000
--- a/system/skeleton/root/.bash_profile
+++ /dev/null
@@ -1,7 +0,0 @@
-# .bash_profile
-
-umask 022
-
-if [ -f ~/.bashrc ]; then
- source ~/.bashrc
-fi
--
2.5.3
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [Buildroot] [PATCH v3 3/3] skeleton: Pretty fixes for /etc/profile
2015-10-03 14:14 [Buildroot] [PATCH v3 1/3] skeleton: Clean up profile file Maxime Hadjinlian
2015-10-03 14:14 ` [Buildroot] [PATCH v3 2/3] skeleton: Remove bash specific files Maxime Hadjinlian
@ 2015-10-03 14:14 ` Maxime Hadjinlian
2015-10-03 14:31 ` Arnout Vandecappelle
2015-10-03 14:27 ` [Buildroot] [PATCH v3 1/3] skeleton: Clean up profile file Arnout Vandecappelle
2 siblings, 1 reply; 7+ messages in thread
From: Maxime Hadjinlian @ 2015-10-03 14:14 UTC (permalink / raw)
To: buildroot
Fix indent and put PATH on a single line.
Signed-off-by: Maxime Hadjinlian <maxime.hadjinlian@gmail.com>
---
system/skeleton/etc/profile | 18 +++++++-----------
1 file changed, 7 insertions(+), 11 deletions(-)
diff --git a/system/skeleton/etc/profile b/system/skeleton/etc/profile
index c40a311..df0be7f 100644
--- a/system/skeleton/etc/profile
+++ b/system/skeleton/etc/profile
@@ -1,13 +1,9 @@
-export PATH=\
-/bin:\
-/sbin:\
-/usr/bin:\
-/usr/sbin
+export PATH=/bin:/sbin:/usr/bin:/usr/sbin
if [ "`id -u`" -eq 0 ]; then
- export PS1='# '
+ export PS1='# '
else
- export PS1='$ '
+ export PS1='$ '
fi
export PAGER='/bin/more '
@@ -15,8 +11,8 @@ export EDITOR='/bin/vi'
# Source configuration files from /etc/profile.d
for i in /etc/profile.d/*.sh ; do
- if [ -r "$i" ]; then
- . $i
- fi
- unset i
+ if [ -r "$i" ]; then
+ . $i
+ fi
+ unset i
done
--
2.5.3
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [Buildroot] [PATCH v3 1/3] skeleton: Clean up profile file
2015-10-03 14:14 [Buildroot] [PATCH v3 1/3] skeleton: Clean up profile file Maxime Hadjinlian
2015-10-03 14:14 ` [Buildroot] [PATCH v3 2/3] skeleton: Remove bash specific files Maxime Hadjinlian
2015-10-03 14:14 ` [Buildroot] [PATCH v3 3/3] skeleton: Pretty fixes for /etc/profile Maxime Hadjinlian
@ 2015-10-03 14:27 ` Arnout Vandecappelle
2015-10-03 14:34 ` Arnout Vandecappelle
2 siblings, 1 reply; 7+ messages in thread
From: Arnout Vandecappelle @ 2015-10-03 14:27 UTC (permalink / raw)
To: buildroot
On 03-10-15 15:14, Maxime Hadjinlian wrote:
> There's a lot of code in /etc/profile, which doesn't really belong in a
> minimal default skeleton.
>
> If the user has a specific needs, it needs to be added in
> /etc/profile.d/ by a post-build script.
>
> Signed-off-by Maxime Hadjinlian <maxime.hadjinlian@gmail.com>
> ---
> v1 -> v2:
> - Don't change indent and don't fix 'pretty' stuff
> - Keep PS1 , PAGER and EDITOR setted.
> - At the end of the for loop, add unset i
> ---
> system/skeleton/etc/profile | 60 +++++--------------------------------
> system/skeleton/etc/profile.d/umask | 1 +
> 2 files changed, 9 insertions(+), 52 deletions(-)
> create mode 100644 system/skeleton/etc/profile.d/umask
>
> diff --git a/system/skeleton/etc/profile b/system/skeleton/etc/profile
> index c7438fe..c40a311 100644
> --- a/system/skeleton/etc/profile
> +++ b/system/skeleton/etc/profile
> @@ -1,66 +1,22 @@
> -# ~/.bashrc: executed by bash(1) for non-login interactive shells.
> -
> export PATH=\
> /bin:\
> /sbin:\
> /usr/bin:\
> -/usr/sbin:\
> -/usr/local/bin
> -
> -# If running interactively, then:
> -if [ "$PS1" ]; then
> -
> - if [ "$BASH" ]; then
> - export PS1="[\u@\h \W]\\$ "
> - alias ll='/bin/ls --color=tty -laFh'
> - alias ls='/bin/ls --color=tty -F'
> - export LS_COLORS='no=00:fi=00:di=01;34:ln=01;36:pi=40;33:so=01;35:do=01;35:bd=40;33;01:cd=40;33;01:or=40;31;01:ex=01;32:*.tar=01;31:*.tgz=01;31:*.arj=01;31:*.taz=01;31:*.lzh=01;31:*.zip=01;31:*.z=01;31:*.Z=01;31:*.gz=01;31:*.bz2=01;31:*.deb=01;31:*.rpm=01;31:*.jar=01;31:*.jpg=01;35:*.jpeg=01;35:*.png=01;35:*.gif=01;35:*.bmp=01;35:*.pbm=01;35:*.pgm=01;35:*.ppm=01;35:*.tga=01;35:*.xbm=01;35:*.xpm=01;35:*.tif=01;35:*.tiff=01;35:*.mpg=01;35:*.mpeg=01;35:*.avi=01;35:*.fli=01;35:*.gl=01;35:*.dl=01;35:*.xcf=01;35:*.xwd=01;35:';
> - else
> - if [ "`id -u`" -eq 0 ]; then
> - export PS1='# '
> - else
> - export PS1='$ '
> - fi
> - fi
[snip]
> +if [ "`id -u`" -eq 0 ]; then
> + export PS1='# '
> +else
> + export PS1='$ '
Previously, this was inside an if [ "$PS1" ]; i.e. only set for interactive
shells. Perhaps that should be kept. Not really essential, though.
> fi
>
> -LANG=${LANG:-C}
> -export LANG
> -[ -n "$LC_CTYPE" ] && export LC_CTYPE
> -[ -n "$LC_NUMERIC" ] && export LC_NUMERIC
> -[ -n "$LC_TIME" ] && export LC_TIME
> -[ -n "$LC_COLLATE" ] && export LC_COLLATE
> -[ -n "$LC_MONETARY" ] && export LC_MONETARY
> -[ -n "$LC_MESSAGES" ] && export LC_MESSAGES
> -[ -n "$LC_PAPER" ] && export LC_PAPER
> -[ -n "$LC_NAME" ] && export LC_NAME
> -[ -n "$LC_ADDRESS" ] && export LC_ADDRESS
> -[ -n "$LC_TELEPHONE" ] && export LC_TELEPHONE
> -[ -n "$LC_MEASUREMENT" ] && export LC_MEASUREMENT
> -[ -n "$LC_IDENTIFICATION" ] && export LC_IDENTIFICATION
> +export PAGER='/bin/more '
> +export EDITOR='/bin/vi'
>
> # Source configuration files from /etc/profile.d
> for i in /etc/profile.d/*.sh ; do
> if [ -r "$i" ]; then
> . $i
> fi
> + unset i
You forgot to mention this in the commit message :-P
Regards,
Arnout
> done
> diff --git a/system/skeleton/etc/profile.d/umask b/system/skeleton/etc/profile.d/umask
> new file mode 100644
> index 0000000..8e71ad5
> --- /dev/null
> +++ b/system/skeleton/etc/profile.d/umask
> @@ -0,0 +1 @@
> +umask 022
>
--
Arnout Vandecappelle arnout at mind be
Senior Embedded Software Architect +32-16-286500
Essensium/Mind http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint: 7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF
^ permalink raw reply [flat|nested] 7+ messages in thread
* [Buildroot] [PATCH v3 2/3] skeleton: Remove bash specific files
2015-10-03 14:14 ` [Buildroot] [PATCH v3 2/3] skeleton: Remove bash specific files Maxime Hadjinlian
@ 2015-10-03 14:27 ` Arnout Vandecappelle
0 siblings, 0 replies; 7+ messages in thread
From: Arnout Vandecappelle @ 2015-10-03 14:27 UTC (permalink / raw)
To: buildroot
On 03-10-15 15:14, Maxime Hadjinlian wrote:
> Signed-off-by Maxime Hadjinlian <maxime.hadjinlian@gmail.com>
Reviewed-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
> ---
> system/skeleton/root/.bash_history | 0
> system/skeleton/root/.bash_logout | 7 -------
> system/skeleton/root/.bash_profile | 7 -------
> 3 files changed, 14 deletions(-)
> delete mode 100644 system/skeleton/root/.bash_history
> delete mode 100644 system/skeleton/root/.bash_logout
> delete mode 100644 system/skeleton/root/.bash_profile
>
> diff --git a/system/skeleton/root/.bash_history b/system/skeleton/root/.bash_history
> deleted file mode 100644
> index e69de29..0000000
> diff --git a/system/skeleton/root/.bash_logout b/system/skeleton/root/.bash_logout
> deleted file mode 100644
> index 77ef1f9..0000000
> --- a/system/skeleton/root/.bash_logout
> +++ /dev/null
> @@ -1,7 +0,0 @@
> -# ~/.bash_logout: executed by bash(1) when login shell exits.
> -
> -# when leaving the console clear the screen to increase privacy
> -
> -case "`tty`" in
> - /dev/tty[0-9]*) clear
> -esac
> diff --git a/system/skeleton/root/.bash_profile b/system/skeleton/root/.bash_profile
> deleted file mode 100644
> index 0ee04a3..0000000
> --- a/system/skeleton/root/.bash_profile
> +++ /dev/null
> @@ -1,7 +0,0 @@
> -# .bash_profile
> -
> -umask 022
> -
> -if [ -f ~/.bashrc ]; then
> - source ~/.bashrc
> -fi
>
--
Arnout Vandecappelle arnout at mind be
Senior Embedded Software Architect +32-16-286500
Essensium/Mind http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint: 7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF
^ permalink raw reply [flat|nested] 7+ messages in thread
* [Buildroot] [PATCH v3 3/3] skeleton: Pretty fixes for /etc/profile
2015-10-03 14:14 ` [Buildroot] [PATCH v3 3/3] skeleton: Pretty fixes for /etc/profile Maxime Hadjinlian
@ 2015-10-03 14:31 ` Arnout Vandecappelle
0 siblings, 0 replies; 7+ messages in thread
From: Arnout Vandecappelle @ 2015-10-03 14:31 UTC (permalink / raw)
To: buildroot
On 03-10-15 15:14, Maxime Hadjinlian wrote:
> Fix indent and put PATH on a single line.
>
> Signed-off-by: Maxime Hadjinlian <maxime.hadjinlian@gmail.com>
Acked-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
Verified that patch is whitespace-only except for the removed \.
Regards,
Arnout
> ---
> system/skeleton/etc/profile | 18 +++++++-----------
> 1 file changed, 7 insertions(+), 11 deletions(-)
>
> diff --git a/system/skeleton/etc/profile b/system/skeleton/etc/profile
> index c40a311..df0be7f 100644
> --- a/system/skeleton/etc/profile
> +++ b/system/skeleton/etc/profile
> @@ -1,13 +1,9 @@
> -export PATH=\
> -/bin:\
> -/sbin:\
> -/usr/bin:\
> -/usr/sbin
> +export PATH=/bin:/sbin:/usr/bin:/usr/sbin
>
> if [ "`id -u`" -eq 0 ]; then
> - export PS1='# '
> + export PS1='# '
> else
> - export PS1='$ '
> + export PS1='$ '
> fi
>
> export PAGER='/bin/more '
> @@ -15,8 +11,8 @@ export EDITOR='/bin/vi'
>
> # Source configuration files from /etc/profile.d
> for i in /etc/profile.d/*.sh ; do
> - if [ -r "$i" ]; then
> - . $i
> - fi
> - unset i
> + if [ -r "$i" ]; then
> + . $i
> + fi
> + unset i
> done
>
--
Arnout Vandecappelle arnout at mind be
Senior Embedded Software Architect +32-16-286500
Essensium/Mind http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint: 7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF
^ permalink raw reply [flat|nested] 7+ messages in thread
* [Buildroot] [PATCH v3 1/3] skeleton: Clean up profile file
2015-10-03 14:27 ` [Buildroot] [PATCH v3 1/3] skeleton: Clean up profile file Arnout Vandecappelle
@ 2015-10-03 14:34 ` Arnout Vandecappelle
0 siblings, 0 replies; 7+ messages in thread
From: Arnout Vandecappelle @ 2015-10-03 14:34 UTC (permalink / raw)
To: buildroot
On 03-10-15 15:27, Arnout Vandecappelle wrote:
> On 03-10-15 15:14, Maxime Hadjinlian wrote:
>> There's a lot of code in /etc/profile, which doesn't really belong in a
>> minimal default skeleton.
>>
>> If the user has a specific needs, it needs to be added in
>> /etc/profile.d/ by a post-build script.
>>
>> Signed-off-by Maxime Hadjinlian <maxime.hadjinlian@gmail.com>
My comments were just nit-picking, so:
Reviewed-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
Regards,
Arnout
>> ---
>> v1 -> v2:
>> - Don't change indent and don't fix 'pretty' stuff
>> - Keep PS1 , PAGER and EDITOR setted.
>> - At the end of the for loop, add unset i
>> ---
>> system/skeleton/etc/profile | 60 +++++--------------------------------
>> system/skeleton/etc/profile.d/umask | 1 +
>> 2 files changed, 9 insertions(+), 52 deletions(-)
>> create mode 100644 system/skeleton/etc/profile.d/umask
>>
>> diff --git a/system/skeleton/etc/profile b/system/skeleton/etc/profile
>> index c7438fe..c40a311 100644
>> --- a/system/skeleton/etc/profile
>> +++ b/system/skeleton/etc/profile
>> @@ -1,66 +1,22 @@
>> -# ~/.bashrc: executed by bash(1) for non-login interactive shells.
>> -
>> export PATH=\
>> /bin:\
>> /sbin:\
>> /usr/bin:\
>> -/usr/sbin:\
>> -/usr/local/bin
>> -
>> -# If running interactively, then:
>> -if [ "$PS1" ]; then
>> -
>> - if [ "$BASH" ]; then
>> - export PS1="[\u@\h \W]\\$ "
>> - alias ll='/bin/ls --color=tty -laFh'
>> - alias ls='/bin/ls --color=tty -F'
>> - export LS_COLORS='no=00:fi=00:di=01;34:ln=01;36:pi=40;33:so=01;35:do=01;35:bd=40;33;01:cd=40;33;01:or=40;31;01:ex=01;32:*.tar=01;31:*.tgz=01;31:*.arj=01;31:*.taz=01;31:*.lzh=01;31:*.zip=01;31:*.z=01;31:*.Z=01;31:*.gz=01;31:*.bz2=01;31:*.deb=01;31:*.rpm=01;31:*.jar=01;31:*.jpg=01;35:*.jpeg=01;35:*.png=01;35:*.gif=01;35:*.bmp=01;35:*.pbm=01;35:*.pgm=01;35:*.ppm=01;35:*.tga=01;35:*.xbm=01;35:*.xpm=01;35:*.tif=01;35:*.tiff=01;35:*.mpg=01;35:*.mpeg=01;35:*.avi=01;35:*.fli=01;35:*.gl=01;35:*.dl=01;35:*.xcf=01;35:*.xwd=01;35:';
>> - else
>> - if [ "`id -u`" -eq 0 ]; then
>> - export PS1='# '
>> - else
>> - export PS1='$ '
>> - fi
>> - fi
> [snip]
>> +if [ "`id -u`" -eq 0 ]; then
>> + export PS1='# '
>> +else
>> + export PS1='$ '
>
> Previously, this was inside an if [ "$PS1" ]; i.e. only set for interactive
> shells. Perhaps that should be kept. Not really essential, though.
>
>> fi
>>
>> -LANG=${LANG:-C}
>> -export LANG
>> -[ -n "$LC_CTYPE" ] && export LC_CTYPE
>> -[ -n "$LC_NUMERIC" ] && export LC_NUMERIC
>> -[ -n "$LC_TIME" ] && export LC_TIME
>> -[ -n "$LC_COLLATE" ] && export LC_COLLATE
>> -[ -n "$LC_MONETARY" ] && export LC_MONETARY
>> -[ -n "$LC_MESSAGES" ] && export LC_MESSAGES
>> -[ -n "$LC_PAPER" ] && export LC_PAPER
>> -[ -n "$LC_NAME" ] && export LC_NAME
>> -[ -n "$LC_ADDRESS" ] && export LC_ADDRESS
>> -[ -n "$LC_TELEPHONE" ] && export LC_TELEPHONE
>> -[ -n "$LC_MEASUREMENT" ] && export LC_MEASUREMENT
>> -[ -n "$LC_IDENTIFICATION" ] && export LC_IDENTIFICATION
>> +export PAGER='/bin/more '
>> +export EDITOR='/bin/vi'
>>
>> # Source configuration files from /etc/profile.d
>> for i in /etc/profile.d/*.sh ; do
>> if [ -r "$i" ]; then
>> . $i
>> fi
>> + unset i
>
> You forgot to mention this in the commit message :-P
>
>
> Regards,
> Arnout
>
>
>> done
>> diff --git a/system/skeleton/etc/profile.d/umask b/system/skeleton/etc/profile.d/umask
>> new file mode 100644
>> index 0000000..8e71ad5
>> --- /dev/null
>> +++ b/system/skeleton/etc/profile.d/umask
>> @@ -0,0 +1 @@
>> +umask 022
>>
>
>
--
Arnout Vandecappelle arnout at mind be
Senior Embedded Software Architect +32-16-286500
Essensium/Mind http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint: 7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2015-10-03 14:34 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-10-03 14:14 [Buildroot] [PATCH v3 1/3] skeleton: Clean up profile file Maxime Hadjinlian
2015-10-03 14:14 ` [Buildroot] [PATCH v3 2/3] skeleton: Remove bash specific files Maxime Hadjinlian
2015-10-03 14:27 ` Arnout Vandecappelle
2015-10-03 14:14 ` [Buildroot] [PATCH v3 3/3] skeleton: Pretty fixes for /etc/profile Maxime Hadjinlian
2015-10-03 14:31 ` Arnout Vandecappelle
2015-10-03 14:27 ` [Buildroot] [PATCH v3 1/3] skeleton: Clean up profile file Arnout Vandecappelle
2015-10-03 14:34 ` Arnout Vandecappelle
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox