Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Alexander Lukichev <alexander.lukichev@gmail.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] qt: fix build for arm with BR2_STATIC_LIBS
Date: Wed, 07 Oct 2015 07:55:52 +0300	[thread overview]
Message-ID: <5614A5D8.40804@gmail.com> (raw)
In-Reply-To: <56144247.7050604@mind.be>

Hi, Arnout!

  Thanks for taking a look!

On 10/07/2015 12:51 AM, Arnout Vandecappelle wrote:
>> --- /dev/null
>> +++ b/package/qt/0009-no-dynamic-library-plugins.patch
>> @@ -0,0 +1,27 @@
>> +Do not define QT_NO_DYNAMIC_LIBRARY if it is already defined
[...]
>> ++#ifndef QT_NO_DYNAMIC_LIBRARY
>> + #if (defined(Q_OS_VXWORKS) && !defined(VXWORKS_RTP)) || defined (Q_OS_NACL)
>> + #define QT_NO_DYNAMIC_LIBRARY
>> + #endif
>> ++#endif

>  I'm sorry, but I fail to understand how there can be a compilation error...
> We're not building for VxWorks or NaCl, so why should there be a problem?

Indeed. I will remove unnecessary Qt patch and send a new version. Thanks again!

--
Best regards,
  Alexander Lukichev

  reply	other threads:[~2015-10-07  4:55 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-06 10:56 [Buildroot] [PATCH 1/1] qt: fix build for arm with BR2_STATIC_LIBS Alexander Lukichev
2015-10-06 21:51 ` Arnout Vandecappelle
2015-10-07  4:55   ` Alexander Lukichev [this message]
2015-10-07  7:02 ` [Buildroot] [PATCH v2] " Alexander Lukichev
2015-10-10 10:03   ` Thomas Petazzoni
2015-10-12 20:38   ` Peter Korsgaard
2015-10-13  5:14     ` Alexander Lukichev

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5614A5D8.40804@gmail.com \
    --to=alexander.lukichev@gmail.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox