Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Korsgaard <peter@korsgaard.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v2] qt: fix build for arm with BR2_STATIC_LIBS
Date: Mon, 12 Oct 2015 22:38:16 +0200	[thread overview]
Message-ID: <87io6baklj.fsf@dell.be.48ers.dk> (raw)
In-Reply-To: <1444201366-354-1-git-send-email-alexander.lukichev@gmail.com> (Alexander Lukichev's message of "Wed, 7 Oct 2015 10:02:46 +0300")

>>>>> "Alexander" == Alexander Lukichev <alexander.lukichev@gmail.com> writes:

 > Some Buildroot-generated static toolchains for ARM do not have
 > dlfcn.h header, which breaks builds of qt-4.8.7 because its
 > QtCore's plugin loader expects this header to be present (and
 > dynamic libraries to be supported). For certain platforms without
 > dynamic libraries, there is a QT_NO_DYNAMIC_LIBRARY constant
 > defined in plugin loader's source. This patch puts that constant
 > into Qt's build environment if Buildroot is configured without
 > shared library support.

 > Fixes:
 > - http://autobuild.buildroot.net/results/11a4c19638ca211bd2a424fd92602166235c9433
 > - http://autobuild.buildroot.net/results/c056e8781558267f6971a5f017f47e90dcf24e07
 > - http://autobuild.buildroot.net/results/b8f34afa8686e890a1a3882a52081bb6a3b9c13b
 > and several others.

 > Signed-off-by: Alexander Lukichev <alexander.lukichev@gmail.com>
 > ---
 > Changes
 > v2: unnecessary Qt patch removed (Arnout).
 > ---
 >  package/qt/qt.mk | 4 ++++
 >  1 file changed, 4 insertions(+)

 > diff --git a/package/qt/qt.mk b/package/qt/qt.mk
 > index e0e5d22..a64d32f 100644
 > --- a/package/qt/qt.mk
 > +++ b/package/qt/qt.mk
 > @@ -203,6 +203,10 @@ else
 >  QT_CONFIGURE_OPTS += -static
 >  endif
 
 > +ifeq ($(BR2_STATIC_LIBS),y)
 > +QT_CONFIGURE_OPTS += -D QT_NO_DYNAMIC_LIBRARY

Hmm, shouldn't this be checking BR2_PACKAGE_QT_STATIC instead?

-- 
Bye, Peter Korsgaard

  parent reply	other threads:[~2015-10-12 20:38 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-06 10:56 [Buildroot] [PATCH 1/1] qt: fix build for arm with BR2_STATIC_LIBS Alexander Lukichev
2015-10-06 21:51 ` Arnout Vandecappelle
2015-10-07  4:55   ` Alexander Lukichev
2015-10-07  7:02 ` [Buildroot] [PATCH v2] " Alexander Lukichev
2015-10-10 10:03   ` Thomas Petazzoni
2015-10-12 20:38   ` Peter Korsgaard [this message]
2015-10-13  5:14     ` Alexander Lukichev

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87io6baklj.fsf@dell.be.48ers.dk \
    --to=peter@korsgaard.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox